Author: jingham
Date: Mon Dec 4 18:34:05 2017
New Revision: 319730
URL: http://llvm.org/viewvc/llvm-project?rev=319730&view=rev
Log:
Clean up stop hook output in case a hook restarts.
I was warning about the fact that this will abort
further stop hooks, but didn't check that there WAS
a further
Author: jingham
Date: Mon Dec 4 18:50:45 2017
New Revision: 319731
URL: http://llvm.org/viewvc/llvm-project?rev=319731&view=rev
Log:
Add target.process.stop-on-exec setting, and obey it.
Also add a test. There should also be control for this
in ProcessLaunchInfo and a "target launch" flag, but
Author: jingham
Date: Thu Dec 7 11:44:09 2017
New Revision: 320077
URL: http://llvm.org/viewvc/llvm-project?rev=320077&view=rev
Log:
These tests don't depend on debug info format.
Mark them as such.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
Modifi
This is a trivial thing, but you can use:
lldbutil.run_break_set_by_source_regexp
rather than having to capture the line number matching the regex and setting a
line breakpoint from that. You are setting them in different source files, so
you'll have to pass:
extra_options = "-f 'One/One.c
IIUA, this code is negotiating the best compression to use for communication
between lldb & the remote stub. Since there's no guarantee that the remote
stub has anything to do with llvm, you can't just use whatever llvm uses.
Jim
> On Jan 7, 2018, at 2:11 AM, Michał Górny via Phabricator via
Author: jingham
Date: Mon Jan 8 19:03:20 2018
New Revision: 322054
URL: http://llvm.org/viewvc/llvm-project?rev=322054&view=rev
Log:
Cut and paste error - I wasn't actually running both tests...
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
Modified:
> On Jan 9, 2018, at 9:31 PM, Nelson Elhage via Phabricator
> wrote:
>
> nelhage added a comment.
>
> Hey -- Is there anything I can do to move this patch forward? Would it help
> to do something like only setting the attribute if the mangled name that
> *would* be generated doesn't match t
Tim added it to the Xcode project, but added it to the wrong target. All
lldb_private implementation files need to be added to the lldb-core target. We
also add all the .h files to the project alongside their .cpp files, but the .h
files for don't get added to any target (to keep Xcode's heade
The only hard part of writing any kind of test for this is actually getting a
legitimate .app into the testsuite. Doesn't seem fair to ask Pavel to do that,
since he doesn't work on macOS...
Jim
> On Jan 10, 2018, at 1:59 PM, Davide Italiano via Phabricator
> wrote:
>
> davide added a comm
App bundles are "just directories" but they are actually different on iOS & OS
X. The most interesting part of them is a plist that gives some information
about the bundle. lldb reads that plist to figure out what the real executable
is (it is usually the bundle name minus the .app, but it doe
Author: jingham
Date: Wed Jan 10 14:52:42 2018
New Revision: 322232
URL: http://llvm.org/viewvc/llvm-project?rev=322232&view=rev
Log:
Add a test for finding a binary in an app package.
Added:
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/
lldb/trunk/packages/Python/l
Author: jingham
Date: Wed Jan 10 15:06:34 2018
New Revision: 322235
URL: http://llvm.org/viewvc/llvm-project?rev=322235&view=rev
Log:
Runs the part of the test that just finds the binary on all systems.
That should work everywhere. Then only try actually running on macosx.
Modified:
lldb/tru
I added a simple test: macosx/find-app-in-bundle. On non-Darwin systems it
just ensures we find the app in the
app bundle and can set a breakpoint in it. On Darwin, it also ensures we can
launch the app and hit our breakpoint.
When I get a chance I'll add an iOS app bundle and make a tricky on
Author: jingham
Date: Wed Jan 10 15:32:43 2018
New Revision: 322239
URL: http://llvm.org/viewvc/llvm-project?rev=322239&view=rev
Log:
Running this on other systems won't work because I don't
know how to specifically build a MachO binary on other systems.
Modified:
lldb/trunk/packages/Python/
Eh, no, that wasn't right. I don't know how to build and link a mach-o binary
on some random other system. So I made this a Darwin only test till I can
figure out how to do that.
Jim
> On Jan 10, 2018, at 3:09 PM, Jim Ingham wrote:
>
> I added a simple test: macosx/find-app-in-bundle. On
Author: jingham
Date: Thu Jan 11 15:31:29 2018
New Revision: 322328
URL: http://llvm.org/viewvc/llvm-project?rev=322328&view=rev
Log:
Fix a tiny thinko in this test and re-add.
target.IsValid() not target...
Added:
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile
Author: jingham
Date: Thu Jan 11 15:52:50 2018
New Revision: 322329
URL: http://llvm.org/viewvc/llvm-project?rev=322329&view=rev
Log:
Fix the same thinko in another place...
Thanks Jason.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py
Mo
Author: jingham
Date: Thu Jan 11 17:12:45 2018
New Revision: 322338
URL: http://llvm.org/viewvc/llvm-project?rev=322338&view=rev
Log:
Print the SBDebugger.CreateTarget error message.
This is failing on the bot but not locally. Maybe
the error message will tell us why.
Modified:
lldb/trunk/
Author: jingham
Date: Thu Jan 11 17:30:33 2018
New Revision: 322341
URL: http://llvm.org/viewvc/llvm-project?rev=322341&view=rev
Log:
Fix the Makefile - this version should work on the bot
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile
Modified:
lldb/
Author: jingham
Date: Thu Jan 11 19:03:23 2018
New Revision: 322348
URL: http://llvm.org/viewvc/llvm-project?rev=322348&view=rev
Log:
Fix Breakpoint::RemoveInvalidLocations to fix the exec testcase.
RemoveInvalidLocations was clearing out the m_locations in the
breakpoint by hand, and it wasn't a
That sounds like a great idea. It should make a nice half-way between the
regular SB tests and the inline tests. The latter are super easy to write,
which is nice, but hard to debug - particularly when you have to insert some
more error output because the test only fails on a bot or some syste
> On Jan 22, 2018, at 3:10 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added subscribers: krytarowski, jingham, davide.
> labath added a comment.
>
> In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote:
>
>> - Added yaml2obj dependency. It it okay to be an unconditional dep
In the xcode build, yaml2obj is built as part of the llvm build stage and so
gets put in the same bin directory clang builds into. It looks like this patch
expects to find yaml2obj next to the lldb executable:
def yaml2obj_executable():
"""
Get the path to the yaml2obj executable, which
It seems to me better to remove breakpoint sites under any memory that you are
going to overwrite. The old breakpoints aren't guaranteed to make any sense
and, for instance, on x86 could do harm (they could end up in the middle of an
instruction in the new TEXT.)
If you want to do this regular
So far, all the "flakey" tests I've analyzed - of which there have been not a
few over the years - have either been:
1) Why was pexpect so hard to get right when expect has been rock solid for
decades...
2) Tests whose setup conditions are hard to get right, or hard to have happen
on whatever m
I guess I don't see how having a test dive into lldb-test and do a bunch of
work opaque work that I can't really annotate makes for an easier debugging
scenario than a test were I can trivially insert code to query the state of the
test as it goes along. In the current testsuite, the progress o
That doesn't seem to me a strong enough argument to me to justify devising a
parallel mechanism to the one we have to use for our more complex tests when it
also happens to serve this purpose perfectly well. Every time we make folks
learn to diagnose a different mode of failure we are putting a
Author: jingham
Date: Tue Jan 30 10:43:31 2018
New Revision: 323805
URL: http://llvm.org/viewvc/llvm-project?rev=323805&view=rev
Log:
Rewrite this test not to use pexpect.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py
Modified:
lldb/trunk/
Now that we aren't mixing variants, would it be possible to have a test class
claim that all the tests use the same binary file? At present to get
self-contained tests you often need to do roughly the same thing many times, on
the same binary. You only need to build it once per variant in that
Yeah, no reason to pile on this patch, mostly I was making sure I understood
what we could do...
Jim
> On Feb 1, 2018, at 11:24 AM, Adrian Prantl via Phabricator
> wrote:
>
> aprantl added a comment.
>
> @jingham wrote:
>
>> Now that we aren't mixing variants, would it be possible to have
Author: jingham
Date: Thu Feb 1 13:31:14 2018
New Revision: 324008
URL: http://llvm.org/viewvc/llvm-project?rev=324008&view=rev
Log:
Remove unused Args variable, and #include of Args.h. NFC.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/s
Author: jingham
Date: Thu Feb 1 13:35:50 2018
New Revision: 324010
URL: http://llvm.org/viewvc/llvm-project?rev=324010&view=rev
Log:
Added lldbutil.run_to_name_breakpoint and use it in one test.
Using the "run_to_{source,name}_breakpoint will allow us to remove
a lot of boiler-plate from the tes
Might try adding this patch to the test case:
Index:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
===
---
packages/Python/lldbsuite/test/functionalities/break
Author: jingham
Date: Fri Feb 2 10:39:25 2018
New Revision: 324119
URL: http://llvm.org/viewvc/llvm-project?rev=324119&view=rev
Log:
Add the ability to restrict the breakpoint to a module
for run_to_{source,name}_breakpoint.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
Mo
Author: jingham
Date: Wed Feb 7 12:09:13 2018
New Revision: 324509
URL: http://llvm.org/viewvc/llvm-project?rev=324509&view=rev
Log:
Remove an errant ^S
(still can't get over those Emacs habits...)
Modified:
lldb/trunk/scripts/interface/SBThread.i
Modified: lldb/trunk/scripts/interface/SB
Thanks for laying this out. I don't think any of us have a brief for getopt,
it was the tool at hand. Getting some fuzzy match suggestions would be nice.
Your comment about getopts reminds me, a more fundamental problem with lldb's
command interpreter is that the CommandObject is stateful. So
Author: jingham
Date: Mon Feb 12 12:25:37 2018
New Revision: 324930
URL: http://llvm.org/viewvc/llvm-project?rev=324930&view=rev
Log:
Remove the pubnames support from the Xcode project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
UR
We don’t parse libraries beyond getting sections until we look for symbols,
this doesn’t seem to slow startup noticeably, and since I find it super useful
especially for a program like lldb, where the driver has very little code in it
and most of the functionality is in libraries, I’m happy with
To be fair, you could probably have made the dotest.py version of the test
close to as fast by not running a process. The old test was testing that we
got a location for the breakpoint AND hit it. The latter was probably
overkill. But the two tests aren't testing the same thing.
> On Feb 23,
Author: jingham
Date: Fri Feb 23 13:10:42 2018
New Revision: 325958
URL: http://llvm.org/viewvc/llvm-project?rev=325958&view=rev
Log:
Fix breakpoint thread name conditionals after breakpoint options refactor.
PR36435
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread
Sure, as long as we aren't turning the output of the "break set" or other
commands into test API - which your version of this lit test does not - then
this sort of test seems fine to me.
When we were starting out and building up the set of tests available I at least
tended to err on the side of
Author: jingham
Date: Wed Feb 28 14:41:11 2018
New Revision: 326378
URL: http://llvm.org/viewvc/llvm-project?rev=326378&view=rev
Log:
Fix up the gtest targets for changes in the UnwindAssembly tests.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/proj
Author: jingham
Date: Wed Feb 28 18:44:34 2018
New Revision: 326412
URL: http://llvm.org/viewvc/llvm-project?rev=326412&view=rev
Log:
We were getting the wrong dynamic type if there were two classes with the same
basename.
There's a bug in FindTypes, it ignores the exact flag if you pass a name
I have no general objections to macros, and reducing boiler-plate is good.
They do get in the way of debugging because of the weird C rule that a macro
has to pretend that it is all one source line, so if they contain code you are
interested in stopping at, there needs to be some other way to d
Thanks!
Jim
> On Mar 1, 2018, at 8:56 AM, Pavel Labath via lldb-commits
> wrote:
>
> Author: labath
> Date: Thu Mar 1 08:56:28 2018
> New Revision: 326449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326449&view=rev
> Log:
> Make TestDynamicValueSameBase gcc-compatible
>
> gcc will say
The hashing algorithm gives different values - at least for foobár - between
the two implementations. So if you build with an older clang, and test with a
new lldb, the type lookup fails.
Were the two algorithms supposed to be identical? It will mean that type
lookups in the output of older c
> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote:
>
>
>
>
> On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote:
> On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote:
> > The hashing algorithm gives different values - at least for foobár -
> > between the two implementations. So if you buil
Author: jingham
Date: Mon Mar 12 12:21:59 2018
New Revision: 327318
URL: http://llvm.org/viewvc/llvm-project?rev=327318&view=rev
Log:
Improve prologue handling to support functions with multiple entry points.
https://reviews.llvm.org/D42582
Patch from Leandro Lupori.
Modified:
lldb/trunk/in
Author: jingham
Date: Mon Mar 12 14:17:04 2018
New Revision: 327331
URL: http://llvm.org/viewvc/llvm-project?rev=327331&view=rev
Log:
Re-add change for https://reviews.llvm.org/D42582 with added directories.
Added:
lldb/trunk/lit/Breakpoint/Inputs/ppc64-localentry.s
lldb/trunk/lit/Breakpo
Author: jingham
Date: Tue Mar 13 14:06:05 2018
New Revision: 327448
URL: http://llvm.org/viewvc/llvm-project?rev=327448&view=rev
Log:
Add a missing return in SBPlatform::IsConnected and test
for the behavior - using the fact that the Host platform
is always present & connected.
Modified:
lld
Author: jingham
Date: Mon Mar 19 16:15:06 2018
New Revision: 327924
URL: http://llvm.org/viewvc/llvm-project?rev=327924&view=rev
Log:
Modernize a test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py
Modified:
lldb/trunk/packages/Pyth
would you have looked to find
this?
Jim
> On Mar 19, 2018, at 6:31 PM, Davide Italiano wrote:
>
> On Mon, Mar 19, 2018 at 4:15 PM, Jim Ingham via lldb-commits
> wrote:
>> Author: jingham
>> Date: Mon Mar 19 16:15:06 2018
>> New Revision: 327924
>>
>>
So that file you are looking for is
"packages/Python/lldbsuite/test/README-testsuite. It would be great to have a
fresh pair of eyes look this over and add whatever you would have found
useful...
Jim
> On Mar 19, 2018, at 6:44 PM, Davide Italiano wrote:
>
> On Mon, Mar 19, 2018 at 6:38 PM,
Author: jingham
Date: Mon Mar 19 19:15:23 2018
New Revision: 327941
URL: http://llvm.org/viewvc/llvm-project?rev=327941&view=rev
Log:
Add a suggestion to convert dotest tests to use run_to_source_breakpoint.
Modified:
lldb/trunk/www/projects.html
Modified: lldb/trunk/www/projects.html
URL:
> On Mar 20, 2018, at 4:55 AM, Pavel Labath via lldb-commits
> wrote:
>
> Deleting the test build dir is fairly easy. I can whip up a patch for that,
> but I'm not sure if that's the part that is bothering you the most here.
> Dealing with the log files is a bot more complicated and there do
Author: jingham
Date: Fri Mar 23 16:44:52 2018
New Revision: 328389
URL: http://llvm.org/viewvc/llvm-project?rev=328389&view=rev
Log:
Add support for __attribute__(trivial_abi).
,
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/
lldb/trunk/packages/Python/lldbsuite
Author: jingham
Date: Wed Mar 28 10:06:23 2018
New Revision: 328715
URL: http://llvm.org/viewvc/llvm-project?rev=328715&view=rev
Log:
Explicitly import subprocess
For some reason on one of our bots subprocess wasn't already
imported. Do so explicitly.
Modified:
lldb/trunk/packages/Python/ll
Author: jingham
Date: Wed Mar 28 11:05:43 2018
New Revision: 328721
URL: http://llvm.org/viewvc/llvm-project?rev=328721&view=rev
Log:
Revert r328715. Wasn't wrong, just not the issue.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
Modified:
lldb
Author: jingham
Date: Tue Apr 10 10:20:27 2018
New Revision: 329722
URL: http://llvm.org/viewvc/llvm-project?rev=329722&view=rev
Log:
Fix the Xcode build for the addition of OptionArgsParser.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/lldb.xcworkspace/contents.xcworksp
Author: jingham
Date: Tue Apr 10 10:49:56 2018
New Revision: 329727
URL: http://llvm.org/viewvc/llvm-project?rev=329727&view=rev
Log:
Fix a typo in the gtest build target for Debug configuration.
I usually run DebugClang...
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/l
Author: jingham
Date: Tue Apr 10 12:29:37 2018
New Revision: 329745
URL: http://llvm.org/viewvc/llvm-project?rev=329745&view=rev
Log:
Convert an absolute to a group relative reference for TestOptionArgParser.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.x
Author: jingham
Date: Wed Apr 11 12:27:03 2018
New Revision: 329844
URL: http://llvm.org/viewvc/llvm-project?rev=329844&view=rev
Log:
Fix a thinko in CommandObjectMemoryRegion.
Don't try to read the first argument till you've checked
that there is one.
Modified:
lldb/trunk/source/Commands/Co
Author: jingham
Date: Tue Apr 17 13:35:00 2018
New Revision: 330211
URL: http://llvm.org/viewvc/llvm-project?rev=330211&view=rev
Log:
Fix the xcode project for the Args -> Utility move.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
UR
Author: jingham
Date: Tue Apr 17 13:44:47 2018
New Revision: 330214
URL: http://llvm.org/viewvc/llvm-project?rev=330214&view=rev
Log:
Change PlatformPosix::DoLoadImage to use a UtilityFunction.
That way we won't have to compile a new expression every time we want
dlopen a library.
Differentia
Author: jingham
Date: Fri Apr 20 11:30:31 2018
New Revision: 330460
URL: http://llvm.org/viewvc/llvm-project?rev=330460&view=rev
Log:
Fix the Xcode gtest target for the move of FileSpecTest.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.p
Author: jingham
Date: Thu Apr 26 18:57:40 2018
New Revision: 331012
URL: http://llvm.org/viewvc/llvm-project?rev=331012&view=rev
Log:
Fix a thinko in the iteration over StructuredDataPlugin Create functions.
The code was grabbing the first plugin, and then never getting
another one.
Modified:
Greg,
Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.:
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/6271/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671
Can you figure out what's up with this?
Jim
BTW, the "reply to" for lldb-commits mails f
Author: jingham
Date: Thu May 3 18:31:47 2018
New Revision: 331501
URL: http://llvm.org/viewvc/llvm-project?rev=331501&view=rev
Log:
Add children and child[N] properties to SBValue.i.
Also fixed some bad formatting in SBValue.i.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api
Author: jingham
Date: Mon Mar 20 14:19:03 2017
New Revision: 298289
URL: http://llvm.org/viewvc/llvm-project?rev=298289&view=rev
Log:
Fix a problem with line tables & .o files that start with code with no line
table entries.
If you have code before the first line table entry when debugging with
Author: jingham
Date: Mon Mar 20 14:21:31 2017
New Revision: 298290
URL: http://llvm.org/viewvc/llvm-project?rev=298290&view=rev
Log:
Get ObjectFileMachO to handle @executable_path
Only do this when we are debugging an executable, since we
don't have a good way to trace from an ObjectFile back to
Author: jingham
Date: Mon Mar 20 21:13:50 2017
New Revision: 298331
URL: http://llvm.org/viewvc/llvm-project?rev=298331&view=rev
Log:
FindTypes should find "struct TypeName" as well as "TypeName".
This fixes a bug introduced by r291559. The Module's FindType was
passing the original name not th
Author: jingham
Date: Mon Mar 27 14:03:11 2017
New Revision: 298874
URL: http://llvm.org/viewvc/llvm-project?rev=298874&view=rev
Log:
Fix the Xcode project for OpenBSD additions.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
htt
Author: jingham
Date: Mon Mar 27 14:12:25 2017
New Revision: 298876
URL: http://llvm.org/viewvc/llvm-project?rev=298876&view=rev
Log:
In FileSpec::Equal, short-cut GetNormalizedPath.
GetNormalizedPath seems to be slow, so it's worth
shortcutting it if possible. This change does so
when the filen
Author: jingham
Date: Tue Mar 28 18:25:34 2017
New Revision: 298958
URL: http://llvm.org/viewvc/llvm-project?rev=298958&view=rev
Log:
Print the error if dsymForUUID sometimes produces bad plists.
Not much we can do about it but at least we can print the bad
plist and the error.
Modified:
lld
> On Mar 29, 2017, at 2:06 AM, Tamas Berghammer via Phabricator
> wrote:
>
> tberghammer added a comment.
>
> SBValue::SetName is not part of the SB API (what is the right decision IMO as
> an SBValue should be mostly immutable) so this issue doesn't effect it. I
> looked through the code in
I see. Might be worth filing an enhancement request to expose Clone so you can
do this in a Python synthetic child provider. But there's no reason that lack
should block this change.
Jim
> On Mar 30, 2017, at 12:51 PM, Tamas Berghammer wrote:
>
> It is possible to vend one of the actual bac
Thanks.
Jim
> On Mar 30, 2017, at 1:16 PM, Tamas Berghammer wrote:
>
> Created bug for exposing ValueObject::Clone as SB API:
> http://bugs.llvm.org/show_bug.cgi?id=32477
>
> On Thu, Mar 30, 2017 at 1:04 PM Jim Ingham via Phabricator
> wrote:
> jingham accepted this revision.
> jingham added
Author: jingham
Date: Thu Mar 30 20:32:57 2017
New Revision: 299147
URL: http://llvm.org/viewvc/llvm-project?rev=299147&view=rev
Log:
Don't add a newline if the object description already has one.
Modified:
lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp
Modified: lldb/trunk/source
Author: jingham
Date: Fri Mar 31 17:39:55 2017
New Revision: 299276
URL: http://llvm.org/viewvc/llvm-project?rev=299276&view=rev
Log:
DisassembleRange can return an empty DisassemblerSP
check for it.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/Stack
Author: jingham
Date: Tue Apr 4 12:48:21 2017
New Revision: 299451
URL: http://llvm.org/viewvc/llvm-project?rev=299451&view=rev
Log:
Tone down the "lldb types" log a bit.
Change the get shared class info function to only
dump its results to the inferior stdout when the
log is verbose. This matc
Author: jingham
Date: Tue Apr 4 19:08:21 2017
New Revision: 299489
URL: http://llvm.org/viewvc/llvm-project?rev=299489&view=rev
Log:
Reverting r299374 & r299402 due to testsuite failure.
This caused a failure in the test case:
functionalities/breakpoint/objc/TestObjCBreakpoints.py
When we ar
This patch is causing a testsuite failure in ObjC breakpoint setting:
functionalities/breakpoint/objc/TestObjCBreakpoints.py
You must be grabbing ObjC names and somehow treating them as C++ names.
I reverted the patch till the test gets fixed. If you can't get your hands on
an ObjC binary to t
No problem. You can't test on all platforms, so changes like this are bound to
sometimes introduce regressions. If you can remember to watch the bots for
systems you don't run or test on that makes the turnaround smoother.
Otherwise, if it's a MacOS problem the QE folks here are sure to tell
Author: jingham
Date: Wed Apr 5 20:33:38 2017
New Revision: 299609
URL: http://llvm.org/viewvc/llvm-project?rev=299609&view=rev
Log:
getAsInteger is not a equivalent replacement for strtol
work around that fact for CommandObjectMemoryWrite.
Modified:
lldb/trunk/source/Commands/CommandObje
Author: jingham
Date: Tue Apr 11 19:19:54 2017
New Revision: 300012
URL: http://llvm.org/viewvc/llvm-project?rev=300012&view=rev
Log:
Teach SBFrame how to guess its language.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-language/
lldb/trunk/packages/Python/lld
> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits
> wrote:
>
> zturner added a comment.
>
> How much would it complicate things to move the hand maintained files out of
> tree? If the Xcode build isn't really a thing we're officially supporting,
> perhaps we can
> On Apr 12, 2017, at 9:51 AM, Jim Ingham via lldb-commits
> wrote:
>
>>
>> On Apr 11, 2017, at 7:01 PM, Zachary Turner via Phabricator via lldb-commits
>> wrote:
>>
>> zturner added a comment.
>>
>> How much would it complicate thing
Author: jingham
Date: Mon Apr 17 19:20:59 2017
New Revision: 300517
URL: http://llvm.org/viewvc/llvm-project?rev=300517&view=rev
Log:
This test is succeeding on macOS with clang.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py
Modified:
lldb
Author: jingham
Date: Mon Apr 17 19:44:14 2017
New Revision: 300519
URL: http://llvm.org/viewvc/llvm-project?rev=300519&view=rev
Log:
TestStaticVariables still fails on Linux.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py
Modified:
lldb/tr
Author: jingham
Date: Tue Apr 18 11:52:16 2017
New Revision: 300564
URL: http://llvm.org/viewvc/llvm-project?rev=300564&view=rev
Log:
Add back code to implement "frame var -a,-l,-g" filters.
r285226 dropped the code that did these checks. I am pretty
sure that was inadvertent, so I added that ba
We've had a couple of cases of "dead" code which turned out to be the llvm.org
side of generic behavior for which Swift was the only current specific
implementation. So while I agree, little single functions that aren't used
anywhere are fine to cull, anything that looks like it might be the fo
Author: jingham
Date: Wed Apr 19 13:56:44 2017
New Revision: 300733
URL: http://llvm.org/viewvc/llvm-project?rev=300733&view=rev
Log:
Add CopyDiagnostic to the DiagnosticManager.
From Gregor Milos (gmi...@apple.com), for:
https://reviews.llvm.org/D32078
Modified:
lldb/trunk/include/lldb/Exp
Author: jingham
Date: Wed Apr 19 18:21:04 2017
New Revision: 300785
URL: http://llvm.org/viewvc/llvm-project?rev=300785&view=rev
Log:
Fix !N and !-N commands and add a test case.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/history/
lldb/trunk/packages/Python/lldbsu
Author: jingham
Date: Thu Apr 20 16:51:27 2017
New Revision: 300902
URL: http://llvm.org/viewvc/llvm-project?rev=300902&view=rev
Log:
Add an example command to toggle between disassembly-only and source mode.
Sometimes you are debugging in source, but you really only want to see
the disassembly.
it more difficult to figure
out how to do ordinary things.
Jim
> On Apr 21, 2017, at 1:32 AM, Pavel Labath wrote:
>
> This is cool, I just did some assembly debugging yesterday, and wished it was
> easier :)
>
> On 20 April 2017 at 22:51, Jim Ingham via lldb-commits
> wrote
Author: jingham
Date: Thu Apr 27 19:44:07 2017
New Revision: 301608
URL: http://llvm.org/viewvc/llvm-project?rev=301608&view=rev
Log:
Add a newline to suppress compiler warnings.
Modified:
lldb/trunk/include/lldb/Core/TraceOptions.h
Modified: lldb/trunk/include/lldb/Core/TraceOptions.h
URL:
Author: jingham
Date: Thu Apr 27 19:51:06 2017
New Revision: 301609
URL: http://llvm.org/viewvc/llvm-project?rev=301609&view=rev
Log:
Provide a mechanism to do some pre-loading of symbols up front.
Loading a shared library can require a large amount of work; rather than do
that serially for each
It isn't uncommon for folks to debug programs with all the debug information
for the whole system available. In those cases, what looks to the user like a
normal sized application is actually a very large one as far as lldb's global
string pool is concerned. My experience is that whenever you
I'd vote for keeping the timers if possible. Their job is to tell you "of the
time spent in some operation, how much was spent in say DWARF parsing", etc.
That has been useful on occasion.
Jim
> On May 4, 2017, at 2:12 PM, Scott Smith via Phabricator via lldb-commits
> wrote:
>
> scott.smi
Author: jingham
Date: Fri May 5 18:38:26 2017
New Revision: 302323
URL: http://llvm.org/viewvc/llvm-project?rev=302323&view=rev
Log:
Added "info threads", "thread 1" and "apropos".
Modified:
lldb/trunk/www/lldb-gdb.html
Modified: lldb/trunk/www/lldb-gdb.html
URL:
http://llvm.org/viewvc/llv
101 - 200 of 1210 matches
Mail list logo
