> On Jan 9, 2018, at 9:31 PM, Nelson Elhage via Phabricator 
> <revi...@reviews.llvm.org> wrote:
> 
> nelhage added a comment.
> 
> Hey -- Is there anything I can do to move this patch forward? Would it help 
> to do something like only setting the attribute if the mangled name that 
> *would* be generated doesn't match the one from the DWARF? Any such symbol is 
> already broken for lldb, so such a patch feels perhaps safer and more 
> conservative, at the cost of a bit of added complexity.

That sounds fine from a complexity standpoint, but I worry about the 
performance impact of doing more work than we already do on all mangled names 
we look at.

Jim

> 
> 
> https://reviews.llvm.org/D40283
> 
> 
> 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to