[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Yeah I didn't realise it generated them randomly, though I don't know what else it was going to do :) Do you need a CMake variable for this too? I wonder how you are getting the argument to dotest. For example https://lab.llvm.org/buildbot/#/builde

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Split test to avoid timeout (PR #129614)

2025-03-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: If this PR is approved, and `TestGdbRemoteFork.py` gives you trouble, splitting it sounds good. I suspect folks will be on board with splitting these extremely long tests, but I will hold off approving for a few days in case that's not the case. https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/129614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Return optional from json utils (PR #129919)

2025-03-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: I read through this and all the usages look correct. I suppose there are some places that could use the optional without doing value_or, but changing those now would complicate the patch. I'll leave it to @JDevlieghere to review fully since they did the previous part. htt

[Lldb-commits] [lldb] [lldb] Adapt llgs tests for RISC-V (PR #130034)

2025-03-06 Thread David Spickett via lldb-commits
@@ -195,8 +195,17 @@ def test_qRegisterInfo_contains_required_generics_debugserver(self): # Ensure we have a stack pointer register. self.assertIn("sp", generic_regs) -# Ensure we have a flags register. -self.assertIn("flags", generic_regs) +

[Lldb-commits] [lldb] [lldb] Adapt llgs tests for RISC-V (PR #130034)

2025-03-06 Thread David Spickett via lldb-commits
@@ -1393,6 +1393,11 @@ def isLoongArchLSX(self): def isLoongArchLASX(self): return self.isLoongArch() and "lasx" in self.getCPUInfo() +def isRISCV(self): +"""Returns true if the architecture is RISCV64 or RISCV32.""" +arch = self.getArchitecture

[Lldb-commits] [lldb] [lldb][lldb-dap] Return optional from json utils (PR #129919)

2025-03-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/129919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support expectedFlakey decorator in dotest (PR #129817)

2025-03-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Do you have any suggestions on how we should handle the "expected" flakiness > because of how we test the debugger? Do you think this is something we should > try to solve as part of the lldb testing framework? Super basic tip, in case you didn't notice already, Linaro's

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2025-03-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes, that fixed it. https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: You could make the test binary a cmake dependency, see `lldb/test/CMakeLists.txt`. Perhaps in: ``` if(TARGET lldb-server) add_lldb_test_dependency(lldb-server) endif() ``` This means if you ran the test directly without `ninja check-lldb`, it would fail, but this would ap

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/130453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Add more ARM checks in TestLldbGdbServer.py (PR #130277)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/130277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Been a bit since I looked at this series, so I think "base files" means enough to get a build and you'll come back and implement the specifics later. In that context, mostly small comments other than, I think some of these methods should return failu

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// DavidSpickett wrote: This needs a couple more `-` to make it match with the other line below. https://github.com/llvm/llvm-project/pull/118160 _

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/130453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add terminfo dependency for ncurses support (PR #126810)

2025-02-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: If this and the follow up are working well, consider backporting them to 20.x. https://github.com/llvm/llvm-project/pull/126810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2025-02-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/94034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2025-02-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/129038 >From 67e0bd38889c1a62c9f457432f9e9d46c6ece8dc Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 26 Feb 2025 10:01:39 + Subject: [PATCH] [lldb] Restore register state if PrepareTrivialCall fails

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-28 Thread David Spickett via lldb-commits
@@ -102,12 +102,7 @@ static Status PushToLinuxGuardedControlStack(addr_t return_addr, size_t wrote = thread.GetProcess()->WriteMemory(gcspr_el0, &return_addr, sizeof(return_addr), error); if ((wrote != sizeof(return_addr) |

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/129038 >From 67e0bd38889c1a62c9f457432f9e9d46c6ece8dc Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 26 Feb 2025 10:01:39 + Subject: [PATCH 1/2] [lldb] Restore register state if PrepareTrivialCall f

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/129038 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: @ita-sc is this still any use to you? If not I will close this. (sorry this fell through the cracks, I am currently looking for a solution to stop this happening) https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: @dlav-sc do you still have an interest in this? If not, I will close this PR. https://github.com/llvm/llvm-project/pull/112555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: I forgot about this, apologies. If you have the time to fix the conflicts, I'll take another look. https://github.com/llvm/llvm-project/pull/94034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC handling in lldb-server (PR #127505)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please update the title/description to mention that this is within atomic sequences. I thought this was some kind of fused instruction pair/delay slot type deal but it's not that. Looks fine at a high level, but I always like to get an architecture expert in just in case.

[Lldb-commits] [lldb] [lldb][lldb-dap]Return optional from json utils (PR #129919)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/129919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support discontinuous functions in another Disasembler overload (PR #130987)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/130987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support discontinuous functions in another Disasembler overload (PR #130987)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/130987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Function::GetAddressRange*s* in "frame diagnose" (PR #130949)

2025-03-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Updating the API, not trying to add anything new to frame diagnose, sounds good to me. https://github.com/llvm/llvm-project/pull/130949 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb] Split test to avoid timeout (PR #129614)

2025-03-05 Thread David Spickett via lldb-commits
@@ -5,9 +5,9 @@ lldb-server tests run where the lldb-server exe is available. -This class will be broken into smaller test case classes by -gdb remote packet functional areas. For now it contains -the initial set of tests implemented. +The tests are split between the LldbGdbS

[Lldb-commits] [lldb] [lldb] Split test to avoid timeout (PR #129614)

2025-03-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: Even for a debug build, timeouts aren't a good experience. The sleeps as you say are a minority of the time, and I would rather not disturb them anyway. So I agree with splitting this. How many others are close to the limit that you've found, just this one? https://github

[Lldb-commits] [lldb] [LLDB][Telemetry]Defind telemetry::CommandInfo (PR #129354)

2025-03-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Defind telemetry... Define? https://github.com/llvm/llvm-project/pull/129354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-13 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb][debugserver] Synchronize interrupt and resume signals (PR #131073)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/131073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Split some lldb-server tests to avoid timeout (PR #129614)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/129614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support discontinuous functions in another Disasembler overload (PR #130987)

2025-03-13 Thread David Spickett via lldb-commits
@@ -552,28 +552,35 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, bool Disassembler::Disassemble(Debugger &debugger, const ArchSpec &arch, StackFrame &frame, Stream &strm) { - AddressRange range; SymbolCont

[Lldb-commits] [lldb] [lldb] Support discontinuous functions in another Disasembler overload (PR #130987)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Split some lldb-server tests to avoid timeout (PR #129614)

2025-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM with the folder name changed as suggested. It'll be easier to find everything this way as well. https://github.com/llvm/llvm-project/pull/129614 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb] Fix build problem in llgs tests for RISC-V (PR #127091)

2025-02-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/127091 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d2b3912 - [lldb] Remove commented out declaration in DWARFExpressionList

2025-02-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-02-21T14:56:30Z New Revision: d2b3912002693008141ed8a15c0f2fdb6e861f84 URL: https://github.com/llvm/llvm-project/commit/d2b3912002693008141ed8a15c0f2fdb6e861f84 DIFF: https://github.com/llvm/llvm-project/commit/d2b3912002693008141ed8a15c0f2fdb6e861f84.diff LOG

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self): ) self.match("register read s31", ["s31 = 128"]) +@skipIfXmlSupportMissing +@skipIfRemote +@skipIfLLVMTargetMissing("RISCV") +def test_riscv64_regs(self): +"""Test grabbing various riscv64 regi

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Address the two new comments and this'll be good to go. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,37 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux (PR #128512)

2025-02-24 Thread David Spickett via lldb-commits
@@ -10,7 +10,7 @@ class TestDiagnoseDereferenceFunctionReturn(TestBase): -@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples())) +@expectedFailureAll(oslist=["windows"]) @skipIf( archs=no_match(["x86_64"]) ) # frame diagnose d

[Lldb-commits] [lldb] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux (PR #128512)

2025-02-24 Thread David Spickett via lldb-commits
@@ -1670,13 +1670,14 @@ lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame, ConstString reg, break; case Instruction::Operand::Type::Immediate: { DavidSpickett wrote: What exactly is an immediate here? It's not a literal value, if it were we w

[Lldb-commits] [lldb] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux (PR #128512)

2025-02-24 Thread David Spickett via lldb-commits
@@ -1670,13 +1670,14 @@ lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame, ConstString reg, break; case Instruction::Operand::Type::Immediate: { DavidSpickett wrote: It makes enough sense yes :) https://github.com/llvm/llvm-project/pull/12851

[Lldb-commits] [lldb] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux (PR #128512)

2025-02-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. As usual with Windows, I am a bit curious whether this works there, but not enough to check myself or demand that you do :) https://github.com/llvm/llvm-project/pull/128512 ___ lldb-c

[Lldb-commits] [lldb] [lldb] Fix TestDiagnoseDereferenceFunctionReturn on linux (PR #128512)

2025-02-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also we have no Windows x86 bot right now so you'd never know if it was right outside your own machine. https://github.com/llvm/llvm-project/pull/128512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,141 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM thanks for fixing this and doing all the leg work to verify it. I will merge once the CI passes, or anyone else can if they have the rights to. https://github.com/llvm/llvm-project/pull/124475

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Well, those BOLT failures are unrelated. So if Windows shows the same ones, this can be merged. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Np. Strangely no BOLT failures on Windows perhaps it doesn't run there, one other lld test but unrelated to this. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,141 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-26 Thread David Spickett via lldb-commits
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -// The port number may be up to "65535\0". -char port_cstr[6] =

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: All my questions answered, I leave it to @ashgti as the relative expert to be the approver. https://github.com/llvm/llvm-project/pull/128719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-25 Thread David Spickett via lldb-commits
@@ -55,8 +55,6 @@ TEST_F(PipeTest, OpenAsReader) { } #endif -// This test is flaky on Windows on Arm. DavidSpickett wrote: Likely me that disabled it, but I doubt I had tested it on x86 Windows since we don't run a buildbot for it. Hopefully it'll be fine on

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-25 Thread David Spickett via lldb-commits
@@ -93,15 +93,13 @@ Status SharedSocket::CompleteSending(lldb::pid_t child_pid) { "WSADuplicateSocket() failed, error: %d", last_error); } - size_t num_bytes; - Status error = - m_socket_pipe.WriteWithTimeout(&protocol_info, sizeof(protocol_info), -

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-25 Thread David Spickett via lldb-commits
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -// The port number may be up to "65535\0". -char port_cstr[6] =

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-25 Thread David Spickett via lldb-commits
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -// The port number may be up to "65535\0". -char port_cstr[6] =

[Lldb-commits] [lldb] [lldb] Assorted improvements to the Pipe class (PR #128719)

2025-02-25 Thread David Spickett via lldb-commits
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -// The port number may be up to "65535\0". -char port_cstr[6] =

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Existing GCS test case is here - https://github.com/llvm/llvm-project/blob/f6262fa035d8b942bf76e084fa875409bc8ff83a/lldb/test/API/linux/aarch64/gcs/TestAArch64LinuxGCS.py#L286 These don't run on bots yet, only Arm's simulator. https://github.com/llvm/llvm-project/pull/1290

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/129038 Fixes #124269 PrepareTrivalCall always had the possibility of failing, but given that it only wrote to general purpose registers, if it did, you had bigger problems. When it failed, we did not mark the t

[Lldb-commits] [lldb] [lldb] Restore register state if PrepareTrivialCall fails (PR #129038)

2025-02-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Our policy for the GCS registers is documented here - https://lldb.llvm.org/use/aarch64-linux.html#id3 - but for the GCS enable bit, we restore all of them after an expression. https://github.com/llvm/llvm-project/pull/129038 ___

[Lldb-commits] [lldb] d4002b4 - [lldb] Skip Expression NonZeroFrame test on Windows

2025-04-04 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-04T14:32:48Z New Revision: d4002b43f517fea0292bf71dccaa3d0f6dd798b9 URL: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9 DIFF: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9.diff LOG

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: This fails to compile on Windows: https://lab.llvm.org/buildbot/#/builders/141/builds/7573 ``` lld-link: error: undefined symbol: printf >>> referenced by main.o:(func) c

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: Skipped for now: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9 It could be another case where we link with link.exe which can't hand

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: Sorry yes it is building now but failing: ``` FAIL: test (TestExprFromNonZeroFrame.ExprFromNonZeroFrame.test) Tests that we can use SBFrame::EvaluateExpression on a fram

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal number of SIGBUS on mips (PR #132688)

2025-03-25 Thread David Spickett via lldb-commits
@@ -61,10 +61,17 @@ void LinuxSignals::Reset() { AddSignal(5, "SIGTRAP", true, true, true, "trace trap (not reset when caught)"); AddSignal(6, "SIGABRT", false,true, true, "abort()/IOT trap", "SIGIOT"); - AddSignal(7, "SIGBUS",

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal number of SIGBUS on mips (PR #132688)

2025-03-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > MIPS changed the SIGBUS signal number to be the same as other architectures. But your change appears to use different numbers for MIPS, which looks like the opposite. Also please cite in the PR description the changes in the Linux Kernel that did this. Also I'm pretty

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: /cherry-pick 39e7efe1e4304544289d8d1b45f4d04d11b4a791 https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: Given how fiddly this all is, I would duplicate the test (meaning, add another test case to that file). Even if there is overlap, it's worth it for the added clarity. https://github.com/llvm/llvm-project/pull/131609 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: > if I start lldb with no arguments: https://github.com/llvm/llvm-project/issues/134064 > Does not happen if I have a program file, but this is also strange: This part appears to have been fixed. https://github.com/llvm/llvm-project/pull/121860 ___

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: /cherry-pick 945c494e2c3c078e26ff521ef3e9455e0ff764ac https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: `test_platform_process_launch_gdb_server` is worth looking into. https://github.com/llvm/llvm-project/pull/131609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,94 @@ +LLDB RPC Upstreaming Design Doc +=== + +This document aims to explain the general structure of the upstreaming patches for adding LLDB RPC. The 2 primary concepts explained here will be: + +* How LLDB RPC is used +* How the ``lldb-rpc

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: >From what I've seen, this is a decent start but there are further issues to be >dealt with. Details on https://github.com/llvm/llvm-project/issues/138717. I have to work on some other SME changes first, so it will be a few weeks until I can do anything for this. @laverdet

[Lldb-commits] [lldb] 47c7e73 - Revert "[lldb-dap] Change the launch sequence (#138219)"

2025-05-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-07T09:11:09Z New Revision: 47c7e73e5763f81f218cc4e1eae306d0427aa42d URL: https://github.com/llvm/llvm-project/commit/47c7e73e5763f81f218cc4e1eae306d0427aa42d DIFF: https://github.com/llvm/llvm-project/commit/47c7e73e5763f81f218cc4e1eae306d0427aa42d.diff LOG

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yep, called from AddThreadList: ``` #0 0xedfbe37c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/david.spickett/build-llvm-arm/local/lib/python3.10/dist-packages/lldb/_lldb.cpython-310-arm-linux-gnueabihf.so+0xdbe37c) #1 0xedfbca00 llvm::sys::RunS

[Lldb-commits] [lldb] [lldb][lldb-dap] Disable more tests on Windows (PR #139251)

2025-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/139251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    23   24   25   26   27   28   29   >