DavidSpickett wrote: I read through this and all the usages look correct. I suppose there are some places that could use the optional without doing value_or, but changing those now would complicate the patch.
I'll leave it to @JDevlieghere to review fully since they did the previous part. https://github.com/llvm/llvm-project/pull/129919 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits