https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/109764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8)
set(LLDB_IS_64_BITS 1)
endif()
+set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests
execution")
DavidSpickett wrote:
Ok and that means you can still use a single `ninja check-l
https://github.com/DavidSpickett approved this pull request.
LGTM
In theory we could test this but it'd be platform specific and error injection
is always tricky, the change is straightforward, so let's not worry about it.
https://github.com/llvm/llvm-project/pull/106950
__
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Feels like we diverted you from your original problem though, which was the
remote taking the informative errno and changing it to some meaningless value.
If you've solved your problem then no obligation to do any more but if you do
want to look into the other reporting me
DavidSpickett wrote:
We're almost there for the save all / restore all anyway. We'll need special
cases for SME of course but SME is weird enough to justify that.
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-comm
DavidSpickett wrote:
> There will be more features in future meaning more read/ write routines doing
> almost similar stuff.
IMO We may later consider refactoring the code to provide a top level interface
for feature registers read and write.
Yes I would like a "data driven" model for it. I go
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-25T10:08:10+01:00
New Revision: 706821ba8ff9db829252581dd12d8c5ee2e7b3f0
URL:
https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0
DIFF:
https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0.diff
Author: David Spickett
Date: 2024-09-26T12:06:23Z
New Revision: 3eaaf7c4d062976901c79b523e9f3cc606943119
URL:
https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119
DIFF:
https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119.diff
LOG
@@ -60,7 +60,8 @@ something like ``target.BreakpointCreateByName`` [#]_.
A good rule of thumb is to prefer shell tests when what is being tested is
relatively simple. Expressivity is limited compared to the API tests, which
means that you have to have a well-defined test scenar
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8)
set(LLDB_IS_64_BITS 1)
endif()
+set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests
execution")
DavidSpickett wrote:
Remind me again what this does (probably the third time I'v
DavidSpickett wrote:
So does this not need new testing or did you not add that yet?
I'm not clear on what fully decode means because at least for certain signals
like a tag check fault we do have a description for live processes and core
files. Perhaps that's because I added those as special c
DavidSpickett wrote:
> Perhaps that's because I added those as special cases I don't remember the
> specifics.
I only added part of the description -
https://github.com/llvm/llvm-project/commit/85bc498826d4dac4b64f7b02659f6ec52f11c223.
Didn't add the fault address.
Happy to see improvements
https://github.com/DavidSpickett approved this pull request.
LGTM.
Maybe @labath would like to take a last look at it before it lands.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
Author: David Spickett
Date: 2024-09-27T13:31:58+01:00
New Revision: f6e771cfeda5527b817c80e86d2352cf1f3e5e37
URL:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37
DIFF:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37.diff
https://github.com/DavidSpickett approved this pull request.
Assuming all read memory requests are generated from variables, this makes
sense. They wouldn't be split across regions.
https://github.com/llvm/llvm-project/pull/109057
___
lldb-commits mai
https://github.com/DavidSpickett approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/108996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -269,21 +274,7 @@ void
*lldb_private::python::SWIGBridge::LLDBSWIGPython_GetDynamicSetting(
}
python::PythonObject
-lldb_private::python::SWIGBridge::LLDBSwigPythonCreateScriptedStopHook(
-lldb::TargetSP target_sp, const char *python_class_name,
-const char *sessio
Author: David Spickett
Date: 2024-09-20T09:41:07Z
New Revision: 76b827bb4d5b4cc4d3229c4c6de2529e8b156810
URL:
https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810
DIFF:
https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810.diff
LOG
DavidSpickett wrote:
Found by @tschuett on https://github.com/llvm/llvm-project/issues/109119.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/109427
This got deleted in e078c9507c3abb4d9bb2265c366b26557880a3e3, I presume
accidentally, because it didn't have a corresponding rst file for it.
So I've brought it back and converted it into Markdown. The co
Author: David Spickett
Date: 2024-09-20T15:18:45+01:00
New Revision: 1553714b0093a8ef907faf3b3145c224caa7364a
URL:
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a
DIFF:
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a.diff
DavidSpickett wrote:
I've reverted this
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a.
I feel like the solution isn't that complicated but it's close to end of the
work day for me and I'd like to see the bot green again.
If you have a suggestion on how t
DavidSpickett wrote:
Output from the 2 failures:
```
FAIL: test_file_fail
(TestGDBRemotePlatformFile.TestGDBRemotePlatformFile.test_file_fail)
Test mocked failures of remote operations
--
Traceback (most recent call last)
DavidSpickett wrote:
Mostly RST yes, but we have a few recent documents in Markdown which I enabled
support for in https://github.com/llvm/llvm-project/pull/89716.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-com
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
Author: David Spickett
Date: 2024-09-20T09:57:07Z
New Revision: 801046e3303eed43bffebb84e9e505cc19cad5c0
URL:
https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0
DIFF:
https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0.diff
LOG
DavidSpickett wrote:
I've reverted this
(https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0)
because it broke a stop hook test:
https://lab.llvm.org/buildbot/#/builders/162/builds/6735
It seems to add the stop hook but there's no output when it should have bee
DavidSpickett wrote:
This is failing on Windows because we use an error code that means there was no
error in one of the tests in `lldb/unittests/Utility/StatusTest.cpp`:
```
auto success = Status(NO_ERROR, ErrorType::eErrorTypeWin32);
EXPECT_STREQ(NULL, success.AsCString());
EXPECT_FALSE(
DavidSpickett wrote:
Reminder to update the PR description now that the large code model has been
implemented over in llvm.
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/109934
The FP8 formats have a "_" in the name so that they are:
1. Easier to read.
2. Possible to use in register expressions if/when they are supported.
Some other bits do have defined meanings but they are not
DavidSpickett wrote:
Core files will be the next PR and a test will be added to ensure fields show
up when using a core file too.
https://github.com/llvm/llvm-project/pull/109934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
Ok fair enough, maybe it's
https://github.com/DavidSpickett approved this pull request.
Decide what to do with the remote test change but otherwise this LGTM.
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
Author: David Spickett
Date: 2024-09-25T14:31:57Z
New Revision: 26e0b5077236064d9ab0548e049dffce4d476c06
URL:
https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06
DIFF:
https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06.diff
LOG
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -161,6 +165,11 @@ def getToolchainUtil(util_name):
}
utils = []
+# Required by API TestBSDArchives.py tests.
+# TODO don't forget to fix the test's Makefile when porting to mainline
DavidSpickett wrote:
TODO left in
https:/
@@ -149,9 +153,9 @@ def getToolchainSpec(self, compiler):
cc_dir = cc_path.parent
def getToolchainUtil(util_name):
-return cc_dir / (cc_prefix + util_name + cc_ext)
+return os.path.join(configuration.llvm_tools_dir, util_name +
exe_ext)
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
And this works now because.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
My only question here is, is there some tool that every bot is going to have to
add an override for because it's not something in `/bin`?
If there is such a tool, that doesn't make this change bad, but we may want to
delay while that's accounted for.
DavidSpickett wrote:
A better version of my question, do you have a list of tools this effects, is
it just the ones where you have modified lines in this PR?
If so we probably have nothing to worry about.
https://github.com/llvm/llvm-project/pull/109961
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
Just need a basic explanati
DavidSpickett wrote:
Np. I also realised I have been missing review requests on llvm-zorg for weeks
too, including yours.
https://github.com/llvm/llvm-project/pull/110104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/110104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/115288
Technically you can manually set `LUA_LIBRARIES` and others to use a different
version, and I don't see any version checks in the C++ code. However, I'm not
sure that is intentional, it looks more like a
Author: David Spickett
Date: 2024-11-07T15:27:12Z
New Revision: 85eec89600085a054650585d3a3287a6e0a93a50
URL:
https://github.com/llvm/llvm-project/commit/85eec89600085a054650585d3a3287a6e0a93a50
DIFF:
https://github.com/llvm/llvm-project/commit/85eec89600085a054650585d3a3287a6e0a93a50.diff
LOG
DavidSpickett wrote:
I've disabled the new tests on Windows but can't look into the reason for the
failures until next week.
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
DavidSpickett wrote:
Test was fixed by https://github.com/llvm/llvm-project/pull/114628.
https://github.com/llvm/llvm-project/pull/114295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
Author: David Spickett
Date: 2024-11-25T09:53:15Z
New Revision: 84fec7757ea330bbaf82b46ed081ccc45b120e45
URL:
https://github.com/llvm/llvm-project/commit/84fec7757ea330bbaf82b46ed081ccc45b120e45
DIFF:
https://github.com/llvm/llvm-project/commit/84fec7757ea330bbaf82b46ed081ccc45b120e45.diff
LOG
https://github.com/DavidSpickett approved this pull request.
This is what I would have assumed reading
https://en.cppreference.com/w/cpp/chrono, so LGTM. Thank you for the proactive
fix!
Given that this has built on other platforms without issue, is it worth
checking if libcxx also has this q
DavidSpickett wrote:
On what platform are you seeing this problem? None of Linaro's bots have an
issue with the test.
Is it because you're using remote debugging and only in that case it prompts
for this?
https://github.com/llvm/llvm-project/pull/118095
___
DavidSpickett wrote:
Seems fine but please expand on `Currently SyntheticCappingTestCase fails with`
to say where it fails. Linaro's bots don't have a problem with this test, so I
assume you are using a different kind of setup.
https://github.com/llvm/llvm-project/pull/118094
_
DavidSpickett wrote:
It leaks the fds if `dumpSessionInfo` is never called, do I understand
correctly? If so please add that information to the PR description.
https://github.com/llvm/llvm-project/pull/118093
___
lldb-commits mailing list
lldb-commits
https://github.com/DavidSpickett approved this pull request.
Happy for it to be fixed and removed in another PR if it's unused.
Saves us resurrecting a broken function if we do want it back in future.
https://github.com/llvm/llvm-project/pull/118093
_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118093
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DavidSpickett wrote:
Will keep this in review until the code changes land. I might not reflect
reality if changes are made along the way.
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/DavidSpickett approved this pull request.
Thanks! LGTM.
Probably for the best since the interface will have changed since the older
videos, I hope they are preserved somewhere inside Apple though.
https://github.com/llvm/llvm-project/pull/116838
_
https://github.com/DavidSpickett approved this pull request.
LGTM
For an expert this wording can imply that the previous wording might be the
case, and for the non-experts it's less misleading.
https://github.com/llvm/llvm-project/pull/116827
___
lld
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/116838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -224,7 +224,7 @@ Status ProcessElfCore::DoLoadCore() {
ArchSpec core_arch(m_core_module_sp->GetArchitecture());
target_arch.MergeFrom(core_arch);
GetTarget().SetArchitecture(target_arch);
-
+
DavidSpickett wrote:
I would push these whitespace changes
https://github.com/DavidSpickett commented:
I'm a bit confused as to how we have a core file but also things are moved in
memory.
Can you give an explanation of how this occurs? Please add it to the PR
description.
Also, tests? (which is partly why I ask how this occurs)
https://github.com/l
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -223,6 +220,61 @@ TEST_F(MainLoopTest, ManyPendingCallbacks) {
ASSERT_TRUE(loop.Run().Success());
}
+TEST_F(MainLoopTest, CallbackWithTimeout) {
+ MainLoop loop;
+ loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
+ std::chrono::s
@@ -223,6 +220,61 @@ TEST_F(MainLoopTest, ManyPendingCallbacks) {
ASSERT_TRUE(loop.Run().Success());
}
+TEST_F(MainLoopTest, CallbackWithTimeout) {
+ MainLoop loop;
+ loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
+ std::chrono::s
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/117860
The meat of this is how we execute expressions and deal with the aftermath. For
most users this will never be a concern, so it functions more as a design doc
than anything else.
>From 4838ed0ef8a62041981
DavidSpickett wrote:
This is actually one of the last patches for GCS, but I'm putting it up first
so you have something to refer to for the actual code changes.
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commi
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/117861
This is intended for use with Arm's Guarded Control Stack extension (GCS).
Which reuses some existing shadow stack support in Linux. It should also work
with the x86 equivalent.
A "ss" flag is added to t
DavidSpickett wrote:
RFC here:
https://discourse.llvm.org/t/rfc-aarch64-guarded-control-stack-support-for-lldb/83364
Should help you understand the test case.
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-commits
DavidSpickett wrote:
RFC here:
https://discourse.llvm.org/t/rfc-aarch64-guarded-control-stack-support-for-lldb/83364
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
DavidSpickett wrote:
> Also the wording is "shadow stack: yes" because the shadow stack region is
> just where it's stored. It's enabled for the whole process or it isn't. As
> opposed to memory tagging which can be enabled per region, so "memory
> tagging: enabled" fits better for that.
Thou
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I don't have any objections to this.
Please update the PR description before landing, it will be used as the commit
message.
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks.
I'll keep an eye on the buildbot.
https://github.com/llvm/llvm-project/pull/117756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I started to comment on some style issues here then realised that this code is
adapted from
`lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp` and
I think about 90% of it is the same.
I would prefer that you extract the gener
DavidSpickett wrote:
We could move all this back into NativeRegisterContextLinux too but A: let's
take one step at a time and B: it may be that some architecture does not fit
the pattern that AArch64 and LoongArch do.
So in the interests of you getting this done and us having less churn, stick
DavidSpickett wrote:
Please dig into why it's failing, remotely or locally whatever you can
reproduce. I doubt the reason is anything sinister but I'd like to know what it
is before approving anything.
https://github.com/llvm/llvm-project/pull/118095
___
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/116194
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I'm a bit skeptical about saying "X related tests" given that it will include
things like core files that can be run anywhere, but we also can't say "tests
that run on X" because we'd have to label everything individually.
How are you going to use th
@@ -39,6 +41,7 @@
"std-module": "Tests related to importing the std module",
"stresstest": "Tests related to stressing lldb limits",
"watchpoint": "Watchpoint-related tests",
+"windows": "Windows-related tests",
DavidSpickett wrote:
What's goin
https://github.com/DavidSpickett approved this pull request.
So it was unsupported so it never ran on that bot. Then it was changed to xfail
for remote, so it passed on one bot but was broken on another.
This change narrows the xfail to the one configuration that fails.
In that case, LGTM.
ht
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -399,11 +392,9 @@ size_t Block::MemorySize() const {
return mem_size;
}
-void Block::AddChild(const BlockSP &child_block_sp) {
- if (child_block_sp) {
-child_block_sp->SetParentScope(this);
-m_children.push_back(child_block_sp);
- }
+BlockSP Block::CreateChild(u
https://github.com/DavidSpickett approved this pull request.
Some small things you can address if you want but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/117683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -43,11 +43,13 @@ class Block : public UserID, public SymbolContextScope {
typedef RangeVector RangeList;
typedef RangeList::Entry Range;
- /// Construct with a User ID \a uid, \a depth.
- ///
- /// Initialize this block with the specified UID \a uid. The \a depth in
@@ -57,7 +57,17 @@ add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses
support in LLDB" Curse
add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in
LLDB" LibLZMA LIBLZMA_FOUND)
add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support i
@@ -57,7 +57,17 @@ add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses
support in LLDB" Curse
add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in
LLDB" LibLZMA LIBLZMA_FOUND)
add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support i
@@ -399,11 +392,9 @@ size_t Block::MemorySize() const {
return mem_size;
}
-void Block::AddChild(const BlockSP &child_block_sp) {
- if (child_block_sp) {
-child_block_sp->SetParentScope(this);
-m_children.push_back(child_block_sp);
- }
+BlockSP Block::CreateChild(u
2001 - 2100 of 2869 matches
Mail list logo
