[Lldb-commits] [lldb] 21030b9 - [lldb][Docs] Add section on using QEMU without bridge networking

Author: David Spickett Date: 2023-10-06T15:28:10+01:00 New Revision: 21030b9ab4487d845e29792063f5666d8c4b8e09 URL: https://github.com/llvm/llvm-project/commit/21030b9ab4487d845e29792063f5666d8c4b8e09 DIFF: https://github.com/llvm/llvm-project/commit/21030b9ab4487d845e29792063f5666d8c4b8e09.diff

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/66768 >From 8b292d573710e1c37227d6f80b9770220abd658e Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 22 Aug 2023 14:42:35 +0100 Subject: [PATCH 1/2] [lldb][AArch64] Invalidate SVG prior to reconfiguring

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() { std::optional svg_reg_value; const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg"); if (svg_reg_info) { +// When vg is written it is automatically made invalid. Writing vg wi

[Lldb-commits] [lldb] cf5639d - [lldb][Docs] Fix typo in debugging lldb doc

Author: David Spickett Date: 2023-10-09T08:18:13+01:00 New Revision: cf5639dd2df406b0ef32031182f2ea5daf2e5fbb URL: https://github.com/llvm/llvm-project/commit/cf5639dd2df406b0ef32031182f2ea5daf2e5fbb DIFF: https://github.com/llvm/llvm-project/commit/cf5639dd2df406b0ef32031182f2ea5daf2e5fbb.diff

[Lldb-commits] [lldb] f47914a - [lldb][Docs] Use RST link format in IntelPT doc

Author: David Spickett Date: 2023-10-09T08:21:21+01:00 New Revision: f47914a7cd733751d6ae4dcb9c240520c34ec492 URL: https://github.com/llvm/llvm-project/commit/f47914a7cd733751d6ae4dcb9c240520c34ec492 DIFF: https://github.com/llvm/llvm-project/commit/f47914a7cd733751d6ae4dcb9c240520c34ec492.diff

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

DavidSpickett wrote: Thanks for working on this! It's going to save me a lot of "b main" in the future. https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a rem… (PR #68866)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/68866 …ote gdbserver This can be used to have VS Code debug various emulators, remote systems, hardware probes, etc. In my case I was doing this for the Gameboy Advance, https://github.com/stuij/gba-llvm-devki

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/68866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/68866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/68866 >From a7c0c715f8c355e548e27e7c538fb9fccaf0ce89 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 12 Oct 2023 10:04:52 +0100 Subject: [PATCH 1/2] [lldb][lldb-vscode] Add example configuration for con

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Remote Debug Server + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is +debugging the program `/tmp/a.out` and listening locally o

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/68866 >From a7c0c715f8c355e548e27e7c538fb9fccaf0ce89 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 12 Oct 2023 10:04:52 +0100 Subject: [PATCH 1/3] [lldb][lldb-vscode] Add example configuration for con

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] 17fce28 - [lldb][DYLD][NFC] Dedupe calls to CreateBreakpoint

Author: David Spickett Date: 2023-10-16T10:15:46Z New Revision: 17fce286834344a5379288b68068224af74d51f0 URL: https://github.com/llvm/llvm-project/commit/17fce286834344a5379288b68068224af74d51f0 DIFF: https://github.com/llvm/llvm-project/commit/17fce286834344a5379288b68068224af74d51f0.diff LOG

[Lldb-commits] [lldb] 3b23704 - [lldb][PDB] Fix test build after plugin namespace change

Author: David Spickett Date: 2023-10-16T10:23:45Z New Revision: 3b23704f161c3dd89d4a0b637c9008f573cb87c8 URL: https://github.com/llvm/llvm-project/commit/3b23704f161c3dd89d4a0b637c9008f573cb87c8 DIFF: https://github.com/llvm/llvm-project/commit/3b23704f161c3dd89d4a0b637c9008f573cb87c8.diff LOG

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/68866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -18,9 +18,10 @@ # Introduction DavidSpickett wrote: I think a stub README at the old lldb-vscode location is worth adding. It should just link here. https://github.com/llvm/llvm-project/pull/69264 ___ lldb-commi

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -18,9 +18,10 @@ # Introduction -The `lldb-vscode` tool creates a command line tool that implements the [Visual -Studio Code Debug API](https://code.visualstudio.com/docs/extensionAPI/api-debugging). -It can be installed as an extension for the Visual Studio Code and Nucli

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -196,6 +196,7 @@ Changes to LLDB for formatters to quickly find directly nested type when it's known where to search for it, avoiding more expensive global search via ``SBTarget::FindFirstType``. +* ``lldb-vscode`` was renamed to `lldb-dap``. DavidSpic

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send to others on UNIX systems: ```bash -mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin -cp package.json ~/llvm-org.lldb-vscode-0.1.0 -cd ~/llvm-org.lldb-vscode-0.1.0/bin -cp /path/to/a/built/lldb-vscode .

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

DavidSpickett wrote: Also I just gave you some conflicts with https://github.com/llvm/llvm-project/commit/4606712ef5b422edbe3799b665dcad7dcf348b90. I think only the "type" bit needs changing to "lldb-dap". https://github.com/llvm/llvm-project/pull/69264

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -1,5 +1,5 @@ { - "name": "lldb-vscode", + "name": "lldb-dap", DavidSpickett wrote: This and others are still in an "lldb-vscode" folder, that doesn't seem right. https://github.com/llvm/llvm-project/pull/69264

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -1,3 +1,10 @@ # REQUIRES: system-darwin +# TODO: This test is breaking with my output +# reformatting done for Large Watchpoint support, +# but the lines being output by lldb are identical, +# by visual inspection. +# FileCheck is seeing some difference between them, +# whi

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self): self.expect( error.GetCString(), exe=False, -substrs=["watch size of %d is not supported" % 365], +substrs=["Setting one of the

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,61 @@ +//===-- WatchpointResourceList.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -0,0 +1,61 @@ +//===-- WatchpointResourceList.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -2,8 +2,8 @@ #include int main() { - uint8_t x1 = 0; - uint16_t x2 = 0; + long x1 = 0; + long x2 = 0; DavidSpickett wrote: We need the type change here because? https://github.com/llvm/llvm-project/pull/68845 _

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterField (PR #69315)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69315 This means you don't have to do RegisterField("", 0, 0), you can do RegisterField("", 0). Which is useful for testing and even more useful when we are writing definitions of real registers which have 10s

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

DavidSpickett wrote: I built this locally and I did not get a `bin/lldb-dap` only `lldb-vscde` as before, but it was an existing build folder. So if your clean build is correct you can ignore that part. I followed the install instructions and got the "LLDB VSCode" extension with type "llda-da

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

DavidSpickett wrote: Actually there was a ninja target for `lldb-dap` but it wasn't built by default. Again, existing cmake config so if yours is fine then ignore this. https://github.com/llvm/llvm-project/pull/69264 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

@@ -17,11 +17,17 @@ class RegisterFlags { public: class Field { public: +/// Where start is the least significant bit and end is the most +/// significant bit. The start bit must be <= the end bit. Field(std::string name, unsigned start, unsigned end)

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

DavidSpickett wrote: > Is there anywhere you can begin to use this other than in the tests? Or is > this building up to [your proposal on adding register field info to > lldb-server](https://discourse.llvm.org/t/rfc-adding-register-field-information-to-lldb-server/74143)? Yes. I'm working on a

[Lldb-commits] [lldb] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69253)

DavidSpickett wrote: Same for AArch64 Ubuntu (https://lab.llvm.org/buildbot/#/builders/96/builds/47090) and Windows (https://lab.llvm.org/buildbot/#/builders/219/builds/6372) (32 bit ARM is out of action right now). Same symptom as the above comment. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] 0dca566 - Revert "Detect against invalid variant index for LibStdC++ std::variant data formatters (#69253)"

Author: David Spickett Date: 2023-10-18T10:25:41Z New Revision: 0dca56603b4e13232dfb1f1b80e01604fcf36314 URL: https://github.com/llvm/llvm-project/commit/0dca56603b4e13232dfb1f1b80e01604fcf36314 DIFF: https://github.com/llvm/llvm-project/commit/0dca56603b4e13232dfb1f1b80e01604fcf36314.diff LOG

[Lldb-commits] [lldb] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69253)

DavidSpickett wrote: I've reverted it as the failure reason wasn't immediately obvious to me. Looks like it will reproduce quite easily. https://github.com/llvm/llvm-project/pull/69253 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

@@ -17,11 +17,17 @@ class RegisterFlags { public: class Field { public: +/// Where start is the least significant bit and end is the most +/// significant bit. The start bit must be <= the end bit. Field(std::string name, unsigned start, unsigned end)

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

@@ -1,5 +1,5 @@ { - "name": "lldb-vscode", + "name": "lldb-dap", DavidSpickett wrote: This and disassembly.json are still in the wrong place. I think move everything up one level and delete the lldb-vscode folder. As the instructions refer to packa

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69315 >From 1f5a161cb9265f2761e93d2352c65e382a44a1e5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 17 Oct 2023 10:10:36 + Subject: [PATCH 1/2] [lldb] Add a single bit constructor for RegisterField

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

@@ -17,11 +17,17 @@ class RegisterFlags { public: class Field { public: +/// Where start is the least significant bit and end is the most +/// significant bit. The start bit must be <= the end bit. Field(std::string name, unsigned start, unsigned end)

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

DavidSpickett wrote: So, the automatic checkers here are going to complain about formatting and style - ignore them for now. We'll review all that once the important stuff is done. You should put this PR into "draft" mode, there is a button somewhere on the page (that only you can see). Just

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

DavidSpickett wrote: I see that https://github.com/llvm/llvm-project/commit/b66339575a9b541e67ce5ad2ba7e88da07cf9305 removed the variable, but I never saw this on a buildbot, must be a config we don't cover. What build configuration hits this issue? Please make a note of that in the commit m

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

DavidSpickett wrote: Ok now I understand. So please add what you just wrote to the commit message/ PR description. It will help anyone fighting the same issue later. https://github.com/llvm/llvm-project/pull/69458 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/69458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

DavidSpickett wrote: And thanks for the patch, looks like the issue you linked was fixed, then would have been broken again for a time, and will now be fixed! All's well that ends well. https://github.com/llvm/llvm-project/pull/69458 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

DavidSpickett wrote: If you have the ability to merge, go ahead. Otherwise I can click the button for you. https://github.com/llvm/llvm-project/pull/69458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb] Fix linking to libtinfo (PR #69458)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/69264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self): self.expect( error.GetCString(), exe=False, -substrs=["watch size of %d is not supported" % 365], +substrs=["Setting one of the

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/68845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

@@ -7183,7 +7183,8 @@ GetNthTemplateArgument(const clang::ClassTemplateSpecializationDecl *decl, // (including the ones preceding the parameter pack). const auto &pack = args[last_idx]; const size_t pack_idx = idx - last_idx; - assert(pack_idx < pack.pack_size() && "par

[Lldb-commits] [lldb] [lldb][AArch64] Read mte_ctrl register from core files (PR #69689)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69689 This register reports the configuration of the AArch64 Linux tagged address ABI, part of which is the memory tagging (MTE) settings. It will always be present in core files because even without MTE, there

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69696 There are some uses of "vscode" in `lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py` where I'm not sure if it's referring to the adapter or VS Code itself, so those remain. >From f84ecb7a5

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69726 Patches now go to PRs, mention the Discord server as well as the forum. >From 08c246316c2daa7dde701d5c4beb1de77021520a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Oct 2023 14:45:06 +0100 Su

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

DavidSpickett wrote: I thought I saw that the mailing lists would be closed but I must have imagined it, so I left them in. https://github.com/llvm/llvm-project/pull/69726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69726 >From 08c246316c2daa7dde701d5c4beb1de77021520a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Oct 2023 14:45:06 +0100 Subject: [PATCH 1/2] [lldb][docs] Update contributing links Patches now go

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

@@ -102,10 +102,13 @@ Additionally it builds: See the :doc:`LLDB Build Page ` for build instructions. Discussions about LLDB should go to the `LLDB forum -`__. Commit +`__ or the ``ll

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

DavidSpickett wrote: I don't have the experience to know if enabling this globally makes sense, but I do have a future use case for it. At a some point I want to be able to describe register fields as enums, and having the value as well as the name means you can match it up with the code you'

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

DavidSpickett wrote: > I think we do: I commented those out and got a bunch of test failures, so we're good on coverage there. https://github.com/llvm/llvm-project/pull/69815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

DavidSpickett wrote: @bulbazord Ok to land this? (looks like I'll be going ahead with the work presented in the RFC) https://github.com/llvm/llvm-project/pull/69315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1548,14 +1581,17 @@ static uint32_t LookupSymbolInModule(CommandInterpreter &interpreter, Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]); if (symbol) { if (symbol->ValueIsAddress()) { + // Using the new dump function to add colors in

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -642,7 +680,11 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (pointer_sc.function != nullptr || pointer_sc.symbol != nullptr) { s->PutCString(": "); - pointer_sc.

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -680,21 +722,33 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (show_stop_context) { // We have a function or a symbol from the same sections as this // address. - sc.DumpStopContex

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -680,21 +722,33 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (show_stop_context) { // We have a function or a symbol from the same sections as this // address. - sc.DumpStopContex

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -185,6 +226,111 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, return dumped_something; } +void SymbolContext::GetDescription(Stream *s, lldb::DescriptionLevel level, + Target *target, const char* nam

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -1506,13 +1513,39 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

DavidSpickett wrote: Cool, some good improvements so far. > Instead of this, should I call the next dump function with name parameter and > handle the name=nullptr in the PrintRed function. It would be a good idea to do this yes. I left some comments suggesting things to check there. I would

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

@@ -642,7 +680,11 @@ bool Address::Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, if (pointer_sc.function != nullptr || pointer_sc.symbol != nullptr) { s->PutCString(": "); - pointer_sc.

[Lldb-commits] [lldb] [lldb] Check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69932 Fixes #68987 Early on we load the interpreter (most commonly ld-linux) in LoadInterpreterModule. Then later when we get the first DYLD rendezvous we get a list of libraries that commonly includes ld-linux

[Lldb-commits] [lldb] [lldb] Check for duplicate interpreter modules without loading them (PR #69932)

DavidSpickett wrote: Following the code down into `ObjectFileELF::SetLoadAddress` for ELF, I don't see the value we get from `I->base_addr` being any different from the one we get later as `module_sp->GetObjectFile()->GetBaseAddress().GetLoadAddress`. We set `value_is_offset` to true, if it we

[Lldb-commits] [lldb] [lldb] On POSIX, check for duplicate interpreter modules without loading them (PR #69932)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69932 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7030623 - [lldb][docs] Add strace example to Debugging doc

Author: David Spickett Date: 2023-10-23T17:04:34+01:00 New Revision: 70306238cf3730fd7ef02170a1fdfa302676ac2b URL: https://github.com/llvm/llvm-project/commit/70306238cf3730fd7ef02170a1fdfa302676ac2b DIFF: https://github.com/llvm/llvm-project/commit/70306238cf3730fd7ef02170a1fdfa302676ac2b.diff

[Lldb-commits] [lldb] [lldb] Add a single bit constructor for RegisterFlags::Field (PR #69315)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending registerflags as XML (PR #69951)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69951 This adds ToXML methods to encode RegisterFlags and its fields into XML according to GDB's target XML format: https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Form

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

DavidSpickett wrote: For https://discourse.llvm.org/t/rfc-adding-register-field-information-to-lldb-server/74143. May be helpful to look at https://github.com/DavidSpickett/llvm-project/commit/93bdc630f6a4d27c4849b756838c5d70d23e2e90 which will be the next PR and adds the first register infor

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

DavidSpickett wrote: And if you're not familiar with lldb-server and XML, as I wasn't, it doesn't use libXML to generate it. That's why I'm building strings to fit with the existing target.xml code. https://github.com/llvm/llvm-project/pull/69951 ___

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

DavidSpickett wrote: > It's somewhat implied, but is the goal to (continue to) avoid that > dependency? Other parts of LLDB do rely on libxml2 but I can see how you'd > want to limit the dependencies of lldb-server. Yeah I agree with how lldb-server does it now, and don't want to change that.

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2325b3c - [lldb] Add test for reserved XML chars in register field names

Author: David Spickett Date: 2023-10-24T09:39:44Z New Revision: 2325b3cfdadf266651294ff469ce600a8ee402ce URL: https://github.com/llvm/llvm-project/commit/2325b3cfdadf266651294ff469ce600a8ee402ce DIFF: https://github.com/llvm/llvm-project/commit/2325b3cfdadf266651294ff469ce600a8ee402ce.diff LOG

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69951 >From 5c8b9538e1e5646f19d5bb40ab19afaf2c68e804 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 9 Oct 2023 10:33:08 +0100 Subject: [PATCH 1/4] [lldb][lldb-server] Enable sending registerflags as XML

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -175,3 +175,35 @@ std::string RegisterFlags::AsTable(uint32_t max_width) const { return table; } + +void RegisterFlags::ToXML(StreamString &strm) const { + // Example XML: + // + // + // + strm.Indent(); + strm << ""; + for (const Field &field : m_fields) { +

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -3113,6 +3119,10 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() { if (!format.empty()) response << "format=\"" << format << "\" "; +if (reg_info->flags_type) { + response << "type=\"" << reg_info->flags_type->GetID() << "\" "; +} --

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

@@ -10,6 +10,7 @@ #define LLDB_TARGET_REGISTERFLAGS_H #include "lldb/Utility/Log.h" +#include "lldb/Utility/StreamString.h" DavidSpickett wrote: Done. https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commit

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/69951 >From 5c8b9538e1e5646f19d5bb40ab19afaf2c68e804 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 9 Oct 2023 10:33:08 +0100 Subject: [PATCH 1/5] [lldb][lldb-server] Enable sending registerflags as XML

[Lldb-commits] [lldb] febc4ff - [lldb][AArch64][NFC] Fix typo in get trap handler function

Author: David Spickett Date: 2023-10-24T10:36:20Z New Revision: febc4ff74a4e0311c3663fa5d690c59f7f692583 URL: https://github.com/llvm/llvm-project/commit/febc4ff74a4e0311c3663fa5d690c59f7f692583 DIFF: https://github.com/llvm/llvm-project/commit/febc4ff74a4e0311c3663fa5d690c59f7f692583.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

DavidSpickett wrote: ping! I know you're very busy at the moment, but if you have time to review this week this is the most important patch I've got queued. https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (PR #70054)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/70054 As ReadRegister always read into a uint64_t, when it called operator= with uint64_t it was setting the RegisterValue's type to eTypeUInt64 regardless of its size. This mostly works because most registers

[Lldb-commits] [lldb] [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (PR #70054)

DavidSpickett wrote: > Please make sure there is a test that exercises this behavior in your > follow-up. This fixes a crash when trying to use cpsr field info with a core file, so this will be covered in those tests later. https://github.com/llvm/llvm-project/pull/70054 _

[Lldb-commits] [lldb] [lldb][AArch64] Correct type of 32 bit GPR RegisterValues when using core files (PR #70054)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/70054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    10   11   12   13   14   15   16   17   18   19   >