[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously if a register had fields we would always print them after the value if the register was asked for by

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett updated this revision to Diff 515271. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Use the getter for the format value instead of adding a WasSet to the group class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett added a comment. One alternative was to come up with a list of formats where printing fields afterwards makes sense. Hex makes sense, instruction does not. However it would be hard to judge and it doesn't solve the main issue where you want to see what you asked for without extras

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

DavidSpickett resigned from this revision. DavidSpickett added a comment. This is probably an obvious change, but I have no experience with this area so I don't feel comfortable approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett updated this revision to Diff 515669. DavidSpickett added a comment. dispayed -> displayed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148790/new/ https://reviews.llvm.org/D148790 Files: lldb/source/Commands/CommandObjectRegister

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9083bea1686: [LLDB] Don't print register fields when asked for a specific format (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

DavidSpickett edited reviewers, added: omjavaid; removed: DavidSpickett. DavidSpickett added a comment. I don't know enough to approve, Omair is the expert here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

DavidSpickett added a comment. > None of this should change behavior on linux, but if folks from the linux > world have a comment or reaction to this change, I would be interested to > hear opinions. I haven't done much testing beyond the one test corefile, and > I still need to work out how th

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This register is used as the pointer to the current thread local stora

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. The Scalable Matrix Extension (SME) does not req

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Strictly you could just use `--sve`, but it's nice to have an explicit option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152519/new

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

DavidSpickett added a comment. If you wanted to indent the long strings to the same level as the function's code you could use https://docs.python.org/3/library/textwrap.html#textwrap.dedent (but it's fine as is). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 530880. DavidSpickett added a comment. Correct size getter in read method. This just happened to work because the MTE set also contains one register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152516/ne

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm curious how you would end up with a signed PC value, but given this is unwind it could be a value from a previous frame that was signed when stored to the stack. LGTM. Rep

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Sinking the whole `if abi` dance into these methods will clean up a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152863

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

This revision was automatically updated to reflect the committed changes. Closed by commit rG01e30b30d09a: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new command that will show all the information lldb knows about a register. (lldb) register info

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This will be used by the "register info" command to show the layout of register contents. For example if we have

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett added a comment. I'm aware we likely have 10s of adhoc table printing functions across llvm and I'm surprised someone hasn't unified them yet. Which is to say, today I am not that person though I would like to collect a list of places that could benefit from it. Repository: r

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This teaches DumpRegisterInfo to generate a table from the register flags type. It just calls a method on Regist

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett added reviewers: jasonmolenda, labath, JDevlieghere. DavidSpickett added inline comments. Comment at: lldb/source/Core/DumpRegisterInfo.cpp:84 + +void lldb_private::DoDumpRegisterInfo( +Stream &strm, const char *name, const char *alt_name, uint32_t byte_size, --

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

DavidSpickett added a comment. I think "info" is a fairly safe name for this command. I thought about "register help" but then you could do "help register help" and while that's amusing it's also pretty silly. You might think at a glance "info" does something like check the register's value fo

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

DavidSpickett added a comment. This is the major use case for the command. With these diagrams matching the architecture manual (mostly) you can use them to work out what mask/shift you need. You'll be able to print a register, see that the field isn't the right value, then "register info" and

[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152922/new/ https://reviews.l

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett added a comment. TIL what gcore is. One can save a corefile from within lldb too, I assume you've checked what that does (and with this change, it wouldn't matter either way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286 src = (uint8_t *)GetMTEControl() + offset; + } else if (IsTLS(reg)) { +error = ReadTLSTPIDR(); --

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

DavidSpickett added a comment. I assume https://github.com/llvm/llvm-project/commit/244fcecb90fa7a3fb710ca5768d3bae9af5868cc already fixed this. It fixed the bot and there's no failures currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1531

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

DavidSpickett added a comment. Sure, what name and email address should go on the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153060/new/ https://reviews.llvm.org/D153060 ___ lldb-commits maili

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 532146. DavidSpickett added a comment. This revision is now accepted and ready to land. Move if up to before SVE registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152516/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 532156. DavidSpickett added a comment. Always add the TLS regset mask value. It worked on my QEMU setup because it also had the other extensions, but an armv8-a machine didn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett planned changes to this revision. DavidSpickett added a comment. Also found that clang at -00 will only read tpidr once vs. the gcc I had that would read it fresh each time. I can't rely on either of those to happen, so will change the test to use assembly to directly read and writ

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

This revision was automatically updated to reflect the committed changes. Closed by commit rG6947db2778e0: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed (authored by russelltg, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

DavidSpickett added a comment. Done, thanks for the contribution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153060/new/ https://reviews.llvm.org/D153060 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 532589. DavidSpickett added a comment. This revision is now accepted and ready to land. Change test so that we're reading with assembly and writing with lldb and vice versa. Instead of trying to get clever and actually move the thread storage about. R

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e229217f421: [lldb][AArch64] Add thread local storage tpidr register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152516/new/

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGba85f206fe6f: [lldb] Add "register info" command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b73a2e82191: [LLDB] Add table formatting for register fields (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152917/new/ https:/

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Sorry I missed the comments before landing, I've addressed those in https://github.com/llvm/llvm-project/commit/c7759df03825f63f8334d88c9525d655acfab685. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcfe5a52a39d: [lldb] Add register field tables to the "register info" command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1529

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While looking at https://github.com/llvm/llvm-project/issues/61955 I noticed that when we send qLaunchGDBServer

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added reviewers: JDevlieghere, jasonmolenda. DavidSpickett added a comment. I was about to say I don't have a way to test this but I think I might have now. Starting a platform, then moving lldb-server causes it to fail on Linux. Perhaps I can do that in an isolated way in a shell

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett updated this revision to Diff 533534. DavidSpickett added a comment. Added a test from Python, which avoids a bunch of lit and Linux shell specific issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/ https://reviews.llv

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added a comment. In the bug report the user didn't have a debugserver on the remote, but the handling is the same for lldb-server or debugserver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/ https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett created this revision. Herald added subscribers: ctetreau, atanasyan, jrtc27, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Previously lldb was using arr

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added reviewers: omjavaid, JDevlieghere, labath. DavidSpickett added a comment. This assumes that the usual use case is: - Make a small vector. - Resize it to what you need. - Use the content like an array. Every case I found matched that but still, it's not the safest API ever. So

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes #62068. After 8d1de7b34af46a089eb5433c700419ad9b2923ee

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. https://github.com/llvm/llvm-project/issues/62068 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added a comment. > The sanitized bot on GreenDragon runs on Intel and I assume the "risky' > changes only apply to arm64 as that's the only architecture that needs to > scale beyond the default 256? Anyway I haven't seen the leaks issue you've > mentioned locally so I'm happy to r

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534580. DavidSpickett added a comment. Make a resize in EmulateInstructionARM64::EmulateLDPSTP uncondintional. Though in this case the register for an ldp/stp could only be an x register which is 8 bytes, so there would have been enough allocated alread

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534596. DavidSpickett added a comment. Drop {} in one place now that the resize is not conditional. The logic there also seems faulty, but in other ways I will stay out of for now. I did attempt another sanitizers build and realised I should have been s

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0fc3585405: [LLDB] Fix the use of "platform process launch" with no extra arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956f5c5f6de8: [lldb] Use SmallVector for handling register data (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a comment. Do you or anyone else have a Mac they can reproduce this on? I don't. I know it works on Linux so far, unfortunately our Windows bot is down temporarily. I looked around similar tests and didn't see any skips for Mac. Sometimes the packet log will tell us more, I

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + This assert fails on Linux. Is it necessary or should I look into why it's null here on Linux? WaitForProc

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added a comment. Thanks for testing and fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153922/new/ https://reviews.llvm.org/D153922 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + DavidSpickett wrote: > This assert fails on Linux. Is it necessary or should I look into why it's > null he

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runC

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a comment. Relanded as https://github.com/llvm/llvm-project/commit/728101f97286c1665814e74686c083a4d5ff208c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 __

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/ https://reviews.llvm.org/D153513 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

DavidSpickett added a comment. Some random comments, I'll leave the real review to the VSCode experts. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:239 +/// useful to ensure the same column provided by the setBreakpoints request +/// are returned to the IDE as a fallb

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfbe3a79e20f: [lldb] Check that qLaunchGDBServer packet does not return an error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. During __do_global_dtors_aux glibc sets a flag that is right next to t

[Lldb-commits] [PATCH] D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Running this on Amazon Ubuntu the final backtrace is: (lldb) thread

[Lldb-commits] [PATCH] D154208: [lldb][AArch64] Handle different default vector length in SVE testing

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test previously ran on QEMU or A64FX both of which can/d

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

DavidSpickett added a comment. > I suspect that's what most people using write watchpoints would actually > want, outside of this issue of false watchpoint hits. Seems like the sensible route. The other option is understanding every instruction's behaviour, which is in theory possible but I wo

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

DavidSpickett created this revision. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously the following would crash: (lldb) run Process 25940

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

DavidSpickett added reviewers: labath, JDevlieghere. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:782 self.complete_from_to("register write rbx ", []) def test_common_completion_target_stophook_ids(sel

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

DavidSpickett updated this revision to Diff 537021. DavidSpickett added a comment. Added register info to the x86 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154413/new/ https://reviews.llvm.org/D154413 Files: lldb/source/Commands/

[Lldb-commits] [PATCH] D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test

This revision was automatically updated to reflect the committed changes. Closed by commit rG518320fd98d5: [lldb][AArch64] Account for extra libc frames in PAC unwind test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e76093ae8fe: [lldb][AArch64] Fix tagged watch test on Graviton 3 (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154201/new/ htt

[Lldb-commits] [PATCH] D154208: [lldb][AArch64] Handle different default vector length in SVE testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b37bfa15ecf: [lldb][AArch64] Handle different default vector length in SVE testing (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8929904d88: [lldb] Fix crash when completing register names after program exit (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D154413?vs=537021&id=537622#toc Repositor

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:451 Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues( lldb::DataBufferSP &data_sp) { omjavaid wrote: > DavidSpickett wro

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

DavidSpickett added a comment. Hopefully in the future we can get some kind of smarter container for this register data in future but this looks good for now with a few extra comments for the logic of it. (and so we know where to make changes later) CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

DavidSpickett added a comment. Maybe I can help a little with the error code approach/add on. lldb communicates to lldb-server using gdb-remote packets, you can enable logging of these with `log enable gdb-remote packets`. If you're running on the same machine, lldb will start an lldb-server in

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Apologies, I forgot about this for way too long. I don't think Omair is going to object anyway so let's get this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109427 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicati

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

DavidSpickett added a reviewer: teemperor. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Asking for review to double check. Nothing in lldb upstream calls this and I think that's because we switched to a style where we ask to attach then have a callback that will tell u

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2189b5c4b01: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with the clang-format warning fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108739/new/ https://reviews.llvm.org/D108739 ___

[Lldb-commits] [PATCH] D109778: [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109778/new/ https://reviews.llvm.org/D109778 _

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. https://docs.microsoft.com/en-us/cpp/intrinsics/debugbreak?view=msvc-160 confirms the AArch64 breakpoint instruction, were you able to find a source for the Arm/Thumb one? Otherwise the logic seems fine. It would be g

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a comment. > I don't have a formal source for that one, but compiling a __debugbreak() > with MSVC produces that opcode. As Windows is thumb-only, we can always do a > breakpoint with that single opcode (even if the targeted instruction happens > to be a wide thumb2 instruct

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a comment. One thing that I forgot to ask, are there already tests that cover the scenario the bug reported? Good chance there are but they only run on x86 due to the available bots. We (Linaro) are working to get more tests running on WoA bots so this would be covered even

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett created this revision. Herald added a subscriber: dang. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds an option to the memory region command to print all regions at once. Like you can do by starting a

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

DavidSpickett added a comment. I've seen commands print that they are an alias automatically: (lldb) help rbreak Sets a breakpoint or set of breakpoints in the executable. Syntax: rbreak <...> 'rbreak' is an abbreviation for 'breakpoint set -r %1' Is this not the case for reg

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett created this revision. Herald added subscribers: kristof.beyls, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a specific unwind plan for AArch64 Linux sigreturn frames. Previously we assumed t

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a reviewer: omjavaid. DavidSpickett added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Symbol/AArch64UnwindInfo.cpp:40 + // [1] + // https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/signal.c + int32_t offs

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1284 compiler = self.getCompilerBinary() -version_output = system([[compiler, "--version"]]) -for line in versi

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422 +def runBuildCommands(self, commands): +for cmd in commands: +self.trace(shlex.join(cmd)) Is this ever going to have more than one comman

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > Creating a new Platform entry point to provide the unwind plan (or somehow > refactoring the GetTrapHandlerSymbolNames so that it can also provide an > unwind plan) Makes sense, I'll try that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/source/Symbol/AArch64UnwindInfo.cpp:58 + unwind_plan_sp->SetSourcedFromCompiler(eLazyBoolYes); + unwind_plan_sp->SetUnwindPlanValidAtAllInstructions(eLazyBoolNo); + unwind_plan_sp->SetUnwindPlanForSignalTrap(eLazyBoolYes);

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382287. DavidSpickett added a comment. Set ValidAtAllInstructions. Move building unwind plan into PlatformLinux and add a platform method to lookup unwind plans for signal handlers. I'm still checking architecture in PlatformLinux but it does move the c

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:258 + UnwindPlanSP unwind_plan_sp; + if (name != "__kernel_rt_sigreturn") +return unwind_plan_sp; PlatformLinux lists 3 handlers: * _sigtramp * __kernel_rt

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382354. DavidSpickett added a comment. Set SP not FP based on the sigcontext. Before, the SP of the frame before sigcontext would be incorrect. (noticed while testing alt signal stacks) This was already done in the libunwind change but I got them mixed

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382575. DavidSpickett added a comment. Turns out comparing thread.get_thread_frames() doesn't work because you end up getting references to the same frames. Instead save the info we want to compare. One obvious reason this tactic should have failed is t

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > Thanks for doing this. Just a couple of comments inline. Will respond to these shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 __

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382590. DavidSpickett added a comment. Use generic register names and don't set type to DWARF. Pass triple instead of machine and use isAArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382591. DavidSpickett added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 Files: lldb/include/lldb/Target/Platform.h lldb/sourc

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > One way to demonstrate (and test) this would be to have a bit of inline asm, > which sets all registers to known values, and then raises a signal (SIGILL is > probably the easiest to raise from asm). I will give that a go, probably as a separate test case. Rep

<    4   5   6   7   8   9   10   11   12   13   >