DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment.
https://docs.microsoft.com/en-us/cpp/intrinsics/debugbreak?view=msvc-160 confirms the AArch64 breakpoint instruction, were you able to find a source for the Arm/Thumb one? Otherwise the logic seems fine. It would be good to dedupe these switches, in a file in `Plugins/Process/Windows/Common/`? Or move some of this into the register context? Assuming you have access to a register context in all of these places. It's a bit weird to put it there since the only register related thing is the single step bit but that's the only per architecture class at the moment. (also all the Windows code being in `Windows/Common` is odd but ok not a thing for now) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109777/new/ https://reviews.llvm.org/D109777 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
