[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fdfc1d64c51: [lldb] Add tests for DumpDataExtractor formats (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Using a base address or skipping it with LLDB_INVALID_ADDRESS - Using a data offset, which does not effect the printed addresses - Not prov

[Lldb-commits] [PATCH] D101631: [lldb] DumpDataExtractor tests for item byte size errors

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101631 Files: lldb/unittests/Core/DumpDataExtractorTest.cpp Index: lldb

[Lldb-commits] [PATCH] D101631: [lldb] DumpDataExtractor tests for item byte size errors

DavidSpickett updated this revision to Diff 341896. DavidSpickett added a comment. Retrigger Buildkite after adding the parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101631/new/ https://reviews.llvm.org/D101631 Files: lldb/unitt

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

DavidSpickett updated this revision to Diff 341916. DavidSpickett added a comment. Change function names to match coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101627/new/ https://reviews.llvm.org/D101627 Files: lldb/unittests/Core

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa86cbd475576: [lldb] More tests for DumpDataExtractor (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

DavidSpickett added a comment. > The_underscore_style_for_functions isn't LLDB (or LLVM) code style. I missed > that in the first review. So just rename the utility functions to > TestDumpMultiline and so on and this LGTM. I'm just going to accept this as > renaming the variables shouldn't need

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

DavidSpickett added inline comments. Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:40 +} + +static void testDumpWithOffset(offset_t start_offset, teemperor wrote: > I think you missed the capitalisation here and in the function above :) Doh. In fact i

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

DavidSpickett added inline comments. Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:40 +} + +static void testDumpWithOffset(offset_t start_offset, DavidSpickett wrote: > teemperor wrote: > > I think you missed the capitalisation here and in the functio

[Lldb-commits] [PATCH] D101631: [lldb] DumpDataExtractor tests for item byte size errors

DavidSpickett updated this revision to Diff 341931. DavidSpickett added a comment. Update function names to lldb style Pascal case names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101631/new/ https://reviews.llvm.org/D101631 Files: lldb/unit

[Lldb-commits] [PATCH] D101631: [lldb] DumpDataExtractor tests for item byte size errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8da5d111a5d2: [lldb] DumpDataExtractor tests for item byte size errors (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a reviewer: mgorny. DavidSpickett added a subscriber: mgorny. DavidSpickett added a comment. @mgorny Does FreeBSD do anything with the top byte ignore feature? Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp:476 + retur

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett added a comment. The code LGTM but others should decide if this fits with their efforts. Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/Makefile:3 + +CFLAGS := -g -Os -march=armv8.5-a -mbranch-protection=pac-ret+leaf + Nit: `a

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/main.c:53 + // smoke test in case something didn't account for them. + buf = (char *)((size_t)buf | ((size_t)0xAA << 56)); + return print_result(buf); omjavaid wrot

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 345099. DavidSpickett added a comment. Address all comments apart from address handling that I need to spend some time thinking about. It may end up that the best way to do this is have the tag manager provide a way to remove only the tags and let the o

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 345105. DavidSpickett added a comment. Rebase, fix missed clang-format-ing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 345106. DavidSpickett added a comment. Address comments in general. Added an assert in the loop where we call ptrace so that we catch any unexpected condition that would make it an infinite loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1464 + // get all tags back. + while (num_tags > 0) { +tags_vec.iov_base = dest; omjavaid wrote: > this

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 345113. DavidSpickett added a comment. Rebase, fix use of SendPacketAndWaitForResponse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 345117. DavidSpickett added a comment. Rebase onto earlier patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. I think the test files should go in `test/API/functionalities/ptrauth_diagnostics/` instead. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/ptrauth_diagnostics/BLRAA_error/blraa.c:1

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett added a comment. I think some of my questions are too detailed for this initial patch, I'm sure we can improve the diagnostics over time as situations come up. Glad to see this being upstreamed. Not very knowledgeable on Mach specifics so I'll leave the final review to others.

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126 +Address brk_address; +if (!target.ResolveLoadAddress(fixed_bad_address, brk_address)) + return false; vsk wrote: > DavidSpickett wrote

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett requested changes to this revision. DavidSpickett added a comment. This revision now requires changes to proceed. Realised that you've got an empty program file and no core file. I compiled main.c with: $ aarch64-unknown-linux-gnu-gcc -g -march=armv8.3-a -mbranch-protection=pac-

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is based on https://reviews.llvm.org/D99944. On AArch64 we have various things using the non

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added reviewers: omjavaid, labath, jasonmolenda, vsk. DavidSpickett added subscribers: vsk, jasonmolenda. DavidSpickett added a comment. One of the main reasons the MTE commands need to handle addresses is to lookup memory regions, this generalises the handling of that. I'm not sure

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

DavidSpickett added a comment. I assume this is caused by the removal of the specific `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but you're going to connect to another debug server (gdb, custom stub etc.). The problem with doing it this way is then if you build on a sup

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

DavidSpickett added inline comments. Comment at: llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp:302 -#if !defined(_MSC_VER) || _MSC_VER >= 1924 +#if !defined(_MSC_VER) || _MSC_VER >= 1926 // VS2017 has trouble compiling this: This should be done in a separat

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. @ychen Since this change the warning emitted in `AsmPrinterInlineAsm.cpp` about reserved registers no longer has location information for the file that the inline asm is in. Here's an example: void bar(void) { __asm__ __volatile__ ( "nop" : : : "sp");

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. Can you guide me on how I might correct this? Actually, now I see that MCContext has reportWarning/reportError and just needs a reportNote. I'll have something for you to review shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5af3a6645f38: Remove Windows editline from LLDB (authored by nealsid, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

DavidSpickett created this revision. Herald added subscribers: lldb-commits, danielkiss, kristof.beyls. Herald added a reviewer: rengolin. Herald added a project: LLDB. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. SVE is not required, it has its own tes

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Originally added in https://reviews.llvm.org/D77793. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85134/new/ https://reviews.llvm.org/D85134

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

This revision was automatically updated to reflect the committed changes. Closed by commit rGe82866d5d9ee: [lldb][AArch64] Correct compile options for Neon corefile (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85134/new/

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. EXP_MSG generates a message to show on assert failure. Currently it looks like: AssertionError: Fals

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

DavidSpickett added a comment. Ok to land this as is just to remove some confusion? I agree it could be much improved, I'll look into that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86603/new/ https://reviews.llvm.org/D86603 _

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad5d37fd917: [lldb] Correct wording of EXP_MSG (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86603/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. Specify type when constructing PromotionKeys, this fixes error: "chosen constructor is explicit in c

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. https://www.llvm.org/docs/GettingStarted.html gives the minimum gcc as 5.1. (I found this cross compiling, the apt package for AArch64 is 5.4.0) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D86690: [lldb] Fix gcc 5.4.0 compile error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e6f1a7b1a8: [lldb] Fix gcc 5.4.0 compile error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. This updates the errors reported by expect() to something like: ''' Ran command: "help" Got output:

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett added reviewers: teemperor, labath. DavidSpickett added a comment. I realise the test is a bit meta so if there might be a better place to put it. It does at least run successfully from the API test dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2460 +matched = output.startswith(startstr) +log_lines.append("{} start string: \"{}\" ({})".format( +expecting_str, startstr, found_str(ma

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett updated this revision to Diff 289448. DavidSpickett added a comment. Combined two functions into one single run command and check message function. With some odd kwargs, but I think it helps to be able to put the expected lines on the end. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett updated this revision to Diff 289663. DavidSpickett added a comment. - Use settings command so we don't have to substr help's output - Move list and dedent calls into assert function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86792/

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f18f3c858d5: [lldb] Improve test failure reporting for expect() (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86792/new/ https

[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

DavidSpickett added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86792/new/ https://reviews.llvm.org/D86792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. This extends the "memory region" command to show flags such as those found in /proc/smaps on

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. This is in support of AArch64 memory tagging support as described here: http://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html See "### Extending qMemoryRegion" smaps format described here: https://man7.org/linux/man-pages/man5/proc.5.html Support not add

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. What isn't covered in testing is checking that "memory region" will not print "flags:" if there aren't any. This would need a way to make a fake lldbserver that didn't reply with the flags field, I could write tests that ex

[Lldb-commits] [PATCH] D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77 + self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"], "foo") + self.assertEqual(serialized_da

[Lldb-commits] [PATCH] D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI

DavidSpickett added a comment. This LGTM but I don't know the API standards very well. Some else should give a final review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87491/new/ https://reviews.llvm.org/D87491

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 291835. DavidSpickett added a comment. - clang-format Minidump file - Remove HasFlags from API, return True/False from GetFlags instead - Rename MapKind to MapsKind and make it an enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett marked 3 inline comments as done. DavidSpickett added a comment. In D87442#2273064 , @omjavaid wrote: > This seems fine to me with some minor nits. Also do you plan on writing a > Linux API test for this which test memory regions on Linux? I

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Previously when in "memory region " didn't parse correctly, we'd print an error then also ask lldb-se

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett updated this revision to Diff 292142. DavidSpickett added a comment. - Return early - Only check for expected error in TestMemoryRegion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87694/new/ https://reviews.llvm.org/D87694 Files:

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1710 result.SetStatus(eReturnStatusFailed); } } labath wrote: > How about adding `return

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett updated this revision to Diff 292175. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Check complete error message instead of using regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87694/new/ https:

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:44-52 +# Test that when the address fails to parse, we do not carry on +# and ask lldb-server for an invalid address +interp.HandleCommand("me

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc687af0c30b4: [lldb] Don't send invalid region addresses to lldb server (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. This reverts commit c65627a1fe3be7521fc232d633bb6df577f55269

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. This is probably pretty trivial but my first dive into win32 stuff so wanted to double check my logic before relanding. References: https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualqueryex http

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett updated this revision to Diff 294266. DavidSpickett added a comment. - Convert memory region to early return style to make the logic clearer - Only call ::GetLastError once when VirtualQueryEx fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701 } else { if (command.GetArgumentCount() == 1) { auto load_addr_str = command[0].ref(); stella.stamenova wrote: > Actually, I would change

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett updated this revision to Diff 294272. DavidSpickett added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88229/new/ https://reviews.llvm.org/D88229 Files: lldb/source/Commands/CommandObjectMemory.cpp lldb

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71cf97e95b8c: Reland "[lldb] Don't send invalid region addresses to lldb server" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

DavidSpickett added a comment. Does it make sense to add a few tests for this to `lldb/test/API/assert_messages_test/TestAssertMessages.py`? (this is only checking expect() messages, despite the generic name) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. > The thing I'm not so sure about is the verbatim passing of the os-specific > flags. That's nice for the purpose of displaying them to the user, but it can > make things messy for programatic use, particularly if multiple platforms > start using these. What's do

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 296495. DavidSpickett added a comment. - reset flags in MemoryRegionInfo Clear() - add Linux specific memory region flags test - address comments from labath (doing this before any change of approach, to prevent any confusion) Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett marked 11 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1319 + // Linux kernel since 2.6.14 has /proc/{pid}/smaps + // if CONFIG_PROC_PAGE_MONITOR is enabled + auto BufferOrError

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 296517. DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Fix unit test failures due to dereferncing an empty optional when smaps parsing failed. To prevent this happening again pass an Optional to the callback and let it de

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

DavidSpickett added a comment. For what it's worth I'm aware of this change, don't hold back on my account. It doesn't overlap that much and I think I'll be reworking mine anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88387/new/ https://re

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > Yes, that's pretty much it. Great, I will rework this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442 _

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1400 +.ToError()) +return std::move(Err); + Is it possible that the page we find is executable but not writeable and is this

[Lldb-commits] [PATCH] D89121: [lldb/Utility] Introduce UnimplementedError

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I was going to need something like this myself shortly. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89121/new/ https://rev

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

DavidSpickett added inline comments. Comment at: lldb/test/API/lang/c/stepping/TestStepAndBreakpoints.py:23 @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr17932') -@expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr14437") @expectedFailureAll

[Lldb-commits] [PATCH] D89227: [lldb] Note different vFile:pread/pwrite format for lldb

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. https://sourceware.org/gdb/current/onlinedocs/gdb/Host-I_002fO-Packets.html States that all numbers

[Lldb-commits] [PATCH] D89227: [lldb] Note different vFile:pread/pwrite format for lldb

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. This is the compatibility issue I mentioned in the other review. I found it investigating why remotely debugging lldb would work with lldb but not gdb, turned out to be a >2gb file causing it but I saw the different formats i

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added inline comments. Comment at: lldb/docs/lldb-platform-packets.txt:10 defined there (vFile:size:, vFile:mode:, vFile:symlink, vFile:chmod:). Most importantly, the flags that lldb passes to vFile:open: are incompatible with the flags that gdb specifies. -

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1ee7cae9b2: [lldb] Note difference in vFile:pread/pwrite format for lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. > Given how often the '0x' prefix on base16 numbers is dropped in the remote > serial protocol Now you mention it, I thought I knew how strtoull worked but I don't. (I assumed it was some best effort that would roll back if somehow the digits didn't fit the assum

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. And I'm saying lldb-server and not that and debug-server because if I'm honest, I don't really know what the latter is. I assume this applies to both though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89227/new/ h

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. Sounds like a plan. I've raised https://bugs.llvm.org/show_bug.cgi?id=47820 to track this,.Tell me if I miss-stated anything there, otherwise I'll start the first part. debugserver is an apple-only implementation of the remote stub. However, I think that may be

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. > After some undefined transition period :) we change lldb to assume the > correct gdb-compatible behavior. > > The biggest hurdle for changing the default are iOS/watchOS devices out in > the field - we cannot update the old debugservers that run on them, so we >

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. The statement that lldb-server can handle decimal and hex numbers is misleading. (it can only handle

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 298371. DavidSpickett added a comment. - Move to llvm::Expected for callbacks - Use flag names based on Linux names but for all platforms - Show generic names/descriptions in memory region output - Add minidump cases for error handling Repository: rG

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. If you wondering, the average number of flags for a hello world's memory regions is 8 so 8 lines of output. Here's an example I had that does madvise. (lldb) memory region addr [0x77ed5000-0x77fd5000) rw- /dev/zero (deleted) flags: readable

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

DavidSpickett added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:370 + If no target is selected a startup, the lldb-server can be directed to launch + or attach a process by the LLDB client. + `attach a process` -> `attach to a process

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added a comment. > Woa, back up. I though you were just going to add the one flag you need right > now... :( I was going for the showing flags as a feature of the "memory region" command then later adding the memory tagging flag to that. I see your point though and yeah I don't ne

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett updated this revision to Diff 298954. DavidSpickett added a comment. - listing what we use decimal for is redundant - correct spelling of hexadecimal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89383/new/ https://reviews.llvm.org/D8

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a3b9b06c4a: [lldb] Correct vFile:pread/pwrite packet docs (authored by DavidSpickett). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett added a comment. Landed as already agreed on in https://reviews.llvm.org/D89227. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89383/new/ https://reviews.llvm.org/D89383 ___ lldb-commits ma

[Lldb-commits] [PATCH] D90225: [lldb] Correct --help output for qemu rootfs script

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. It was printing "Usage:" twice. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D90225: [lldb] Correct --help output for qemu rootfs script

This revision was automatically updated to reflect the committed changes. Closed by commit rG749f13e7635a: [lldb] Correct --help output for qemu rootfs script (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90225/new/ http

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

DavidSpickett added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:245 +// +// See lldb-enumerations for the list of available TraceType's. +// Saying `lldb-enumerations.h` might save someone some grepping time, also saying that it should be in deci

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 302843. DavidSpickett added a comment. - Only "mt" flag supported - Don't typedef expected MemoryRegionInfo - Link lldbPluginProcessUtility (not lldbPluginProcessLinux) in proc map tests - "mt" is now the only supported flag - "memory tagging: enabled" i

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 302845. DavidSpickett added a comment. - Revert stray change of run-qemu.sh file mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442 Files: lldb/docs/lldb-gdb-

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/main.c:9-14 + if (!(getauxval(AT_HWCAP2) & HWCAP2_MTE)) +return 1; + + int got = prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0); + if (got) +return 1; ---

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 304441. DavidSpickett added a comment. - Remove unused assert header - Simplify error handling in LinuxProcMapsTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/main.c:9-14 + if (!(getauxval(AT_HWCAP2) & HWCAP2_MTE)) +return 1; + + int got = prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0); + if (got) +return 1; ---

<    10   11   12   13   14   15   16   >