DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere.
https://sourceware.org/gdb/current/onlinedocs/gdb/Host-I_002fO-Packets.html States that all numbers should be hexidecimal but lldb uses decimals in vFile:pread and vFile:pwrite. lldb-server can accept either since it ends up using strtoull which will detect the base being used. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89227 Files: lldb/docs/lldb-platform-packets.txt Index: lldb/docs/lldb-platform-packets.txt =================================================================== --- lldb/docs/lldb-platform-packets.txt +++ lldb/docs/lldb-platform-packets.txt @@ -411,6 +411,12 @@ // // Response is F, followed by the number of bytes read (base 10), a // semicolon, followed by the data in the binary-escaped-data encoding. +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the number of bytes and offset. +// lldb-server can process either format. //---------------------------------------------------------------------- @@ -430,7 +436,11 @@ // 3. binary-escaped-data to be written // // Response is F, followed by the number of bytes written (base 10) - +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the offset. lldb-server can process either format.
Index: lldb/docs/lldb-platform-packets.txt =================================================================== --- lldb/docs/lldb-platform-packets.txt +++ lldb/docs/lldb-platform-packets.txt @@ -411,6 +411,12 @@ // // Response is F, followed by the number of bytes read (base 10), a // semicolon, followed by the data in the binary-escaped-data encoding. +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the number of bytes and offset. +// lldb-server can process either format. //---------------------------------------------------------------------- @@ -430,7 +436,11 @@ // 3. binary-escaped-data to be written // // Response is F, followed by the number of bytes written (base 10) - +// +// COMPATIBILITY +// The gdb-remote serial protocol documentation says that numbers +// in "vFile:" packets should be hexidecimal. Instead lldb uses +// decimal for the offset. lldb-server can process either format.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
