https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/164893
>From 3d2976b3e251bee88b9dee88fef0dcd9460dded2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 23 Oct 2025 13:48:29 -0700
Subject: [PATCH 1/7] [lldb][windows] print an error if python.dll is not
charles-zablit wrote:
Using `IMPORTED_LIBRARY_LOCATION` works great, thanks @compnerd !
https://github.com/llvm/llvm-project/pull/164893
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
Author: Julian Lettner
Date: 2025-10-24T17:08:25-07:00
New Revision: 10a975be0f4c6337fe981c4086d90c582a970010
URL:
https://github.com/llvm/llvm-project/commit/10a975be0f4c6337fe981c4086d90c582a970010
DIFF:
https://github.com/llvm/llvm-project/commit/10a975be0f4c6337fe981c4086d90c582a970010.diff
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/164506
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From 1673e1b93b9c4e5a99323ca9bdf8232c6d5fdfad Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/6] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
Author: Adrian Prantl
Date: 2025-10-24T15:29:14-07:00
New Revision: 9b80fc39606f6f02b88a21ac29e98a74b0b7426a
URL:
https://github.com/llvm/llvm-project/commit/9b80fc39606f6f02b88a21ac29e98a74b0b7426a
DIFF:
https://github.com/llvm/llvm-project/commit/9b80fc39606f6f02b88a21ac29e98a74b0b7426a.diff
compnerd wrote:
Pushing this into CMake feels like the right thing IMO. I think that we should
be able to do something more aggressive if we want. We could query the
`IMPORTED_LIBNAME` property on the runtime target, and then use
`get_filename_component` to get the basename and pass that value
@@ -776,8 +796,13 @@ int main(int argc, char const *argv[]) {
"~/Library/Logs/DiagnosticReports/.\n");
#endif
-#if defined(_WIN32) && defined(LLDB_PYTHON_DLL_RELATIVE_PATH)
- AddPythonDLLToSearchPath();
+#if defined(_WIN32) && defined(LLDB_PYTHON_SHARE
charles-zablit wrote:
> > I could not find a variable which points to `python3.dll`.
>
> According to the documentation of
> [`FindPython3.cmake`](https://cmake.org/cmake/help/latest/module/FindPython3.html#artifacts-specification),
> this should be in `Python3_SABI_LIBRARY` (CMake 3.26+).
My
@@ -37,6 +37,9 @@ add_dependencies(lldb
if(DEFINED LLDB_PYTHON_DLL_RELATIVE_PATH)
target_compile_definitions(lldb PRIVATE
LLDB_PYTHON_DLL_RELATIVE_PATH="${LLDB_PYTHON_DLL_RELATIVE_PATH}")
endif()
+if(DEFINED LLDB_PYTHON_SHARED_LIBRARY_FILENAME)
+ target_compile_definitions(
@@ -447,30 +448,66 @@ inline std::wstring GetPathToExecutableW() {
return L"";
}
-/// Resolve the full path of the directory defined by
+/// \brief Resolve the full path of the directory defined by
/// LLDB_PYTHON_DLL_RELATIVE_PATH. If it exists, add it to the list of DLL
charles-zablit wrote:
> > I ended up using `Python3_RUNTIME_LIBRARY` which points to `python310.dll`
> > or its equivalent. I could not find a variable which points to
> > `python3.dll`.
>
> `Python3_RUNTIME_LIBRARY` doesn't seem to be set in my case (when cross
> compiling from Linux). I don
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From 1673e1b93b9c4e5a99323ca9bdf8232c6d5fdfad Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/2] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
clayborg wrote:
All inline suggestions have been fixed. I also tried to make a minimal yaml
file that could create a large enough file, but it complains when trying to
emit the file as it runs into the 32 bit section offset limiation and refuses
to make a bad mach-o file. So no easy way to tes
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From 1673e1b93b9c4e5a99323ca9bdf8232c6d5fdfad Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/3] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/164739
>From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Wed, 22 Oct 2025 17:37:29 -0700
Subject: [PATCH 1/4] Refactor Breakpoint event notification
---
lldb/i
https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/164739
>From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Wed, 22 Oct 2025 17:37:29 -0700
Subject: [PATCH 1/4] Refactor Breakpoint event notification
---
lldb/i
@@ -1346,6 +1346,13 @@ class Target : public
std::enable_shared_from_this,
const lldb_private::RegisterFlags &flags,
uint32_t byte_size);
+ /// Sends a breakpoint notification event if any listener is registered.
@@ -1697,6 +1701,15 @@ void ObjectFileMachO::ProcessSegmentCommand(
// isn't stored in the abstracted Sections.
m_mach_sections.push_back(sect64);
+// Make sure we can load sections in mach-o files where some sections cross
+// a 4GB boundary. llvm::MachO::sect
@@ -1697,6 +1701,15 @@ void ObjectFileMachO::ProcessSegmentCommand(
// isn't stored in the abstracted Sections.
m_mach_sections.push_back(sect64);
+// Make sure we can load sections in mach-o files where some sections cross
+// a 4GB boundary. llvm::MachO::sect
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/164506
>From 5f6caec8cbd40aa92233045e231ee791b6fba136 Mon Sep 17 00:00:00 2001
From: Julian Lettner
Date: Tue, 21 Oct 2025 14:23:17 -0700
Subject: [PATCH 1/6] [lldb] Introduce internal stop hooks
Introduce the concept of i
@@ -87,6 +89,8 @@ if (LLDB_ENABLE_PYTHON)
set(LLDB_PYTHON_EXT_SUFFIX "_d${LLDB_PYTHON_EXT_SUFFIX}")
endif()
endif()
+ set(LLDB_PYTHON_SHARED_LIBRARY_FILENAME
+
"python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}${CMAKE_SHARED_LIBRARY_SUFFIX}")
-
@@ -776,8 +796,13 @@ int main(int argc, char const *argv[]) {
"~/Library/Logs/DiagnosticReports/.\n");
#endif
-#if defined(_WIN32) && defined(LLDB_PYTHON_DLL_RELATIVE_PATH)
- AddPythonDLLToSearchPath();
+#if defined(_WIN32) && defined(LLDB_PYTHON_SHARE
mstorsjo wrote:
> I ended up using `Python3_RUNTIME_LIBRARY` which points to `python310.dll` or
> its equivalent. I could not find a variable which points to `python3.dll`.
Ok, that sounds reasonable - especially as long as that is what we actually
link against right now.
https://github.com/l
Nerixyz wrote:
> I could not find a variable which points to `python3.dll`.
According to the documentation of
[`FindPython3.cmake`](https://cmake.org/cmake/help/latest/module/FindPython3.html#artifacts-specification),
this should be in `Python3_SABI_LIBRARY`.
https://github.com/llvm/llvm-proj
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/164905
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Premise makes sense to me. With the limited scope of this change, I don't have
any objections. I left one minor suggestion otherwise.
https://github.com/llvm/llvm-project/pull/164905
___
lldb-co
@@ -387,10 +387,13 @@ void MainLoopPosix::ProcessSignal(int signo) {
}
}
-void MainLoopPosix::Interrupt() {
+bool MainLoopPosix::Interrupt() {
if (m_interrupting.exchange(true))
-return;
+return true;
char c = '.';
- cantFail(m_interrupt_pipe.Write(&c, 1));
Author: Adrian Prantl
Date: 2025-10-24T11:29:11-07:00
New Revision: 4e7a8456b316bb20874cc1343747b36869eab7a2
URL:
https://github.com/llvm/llvm-project/commit/4e7a8456b316bb20874cc1343747b36869eab7a2
DIFF:
https://github.com/llvm/llvm-project/commit/4e7a8456b316bb20874cc1343747b36869eab7a2.diff
@@ -3098,6 +3107,23 @@ void Target::SetAllStopHooksActiveState(bool
active_state) {
}
}
+// FIXME: Ideally we would like to return a `const &` (const reference)
instead
yln wrote:
```
typedef std::map StopHookCollection;
StopHookCollection m_stop_hooks;
charles-zablit wrote:
That's where it's set:
https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindPython/Support.cmake#L3865
https://github.com/llvm/llvm-project/pull/164893
___
lldb-commits mailing list
[email protected]
https://l
@@ -3098,6 +3107,23 @@ void Target::SetAllStopHooksActiveState(bool
active_state) {
}
}
+// FIXME: Ideally we would like to return a `const &` (const reference)
instead
yln wrote:
Added new test to pin down the behavior: 27b1441d3e27a12a4
Made sure it go
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/164506
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Gentle ping to reviewers...
https://github.com/llvm/llvm-project/pull/156067
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/drodriguez edited
https://github.com/llvm/llvm-project/pull/164471
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1697,6 +1701,15 @@ void ObjectFileMachO::ProcessSegmentCommand(
// isn't stored in the abstracted Sections.
m_mach_sections.push_back(sect64);
+// Make sure we can load sections in mach-o files where some sections cross
+// a 4GB boundary. llvm::MachO::sect
https://github.com/drodriguez commented:
> I also tried to make a minimal yaml file that could create a large enough
> file, but it complains when trying to emit the file as it runs into the 32
> bit section offset limiation and refuses to make a bad mach-o file. So no
> easy way to test this
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/164893
>From 3d2976b3e251bee88b9dee88fef0dcd9460dded2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 23 Oct 2025 13:48:29 -0700
Subject: [PATCH 1/5] [lldb][windows] print an error if python.dll is not
@@ -61,6 +61,8 @@ if (LLDB_ENABLE_PYTHON)
"Path to python interpreter exectuable, relative to python's install
prefix")
set(cachestring_LLDB_PYTHON_EXT_SUFFIX
"Filename extension for native code python modules")
+ set(cachestring_LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/164893
>From 3d2976b3e251bee88b9dee88fef0dcd9460dded2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 23 Oct 2025 13:48:29 -0700
Subject: [PATCH 1/6] [lldb][windows] print an error if python.dll is not
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff origin/main HEAD --extensions cpp --
lldb/tools/driver/Driver.cpp --diff_from_common_
tgs-sc wrote:
@DavidSpickett, Hi!
I am sorry to bother you third time in this week, but can you please also merge
this PR as I don't have commit access?
@Michael137 approved it, and we were waiting when this one
(https://github.com/llvm/llvm-project/pull/157674) would be merged. I thought
that
@@ -158,7 +158,11 @@ def get_tests(self):
return tests
def test_lua_api(self):
-if "LUA_EXECUTABLE" not in os.environ or
len(os.environ["LUA_EXECUTABLE"]) == 0:
+if (
+"LUA_EXECUTABLE" not in os.environ
+or len(os.environ["L
https://github.com/vpalatin updated
https://github.com/llvm/llvm-project/pull/164793
>From 4e9d7a60d213e49370707708bfa9e9fb4e51537d Mon Sep 17 00:00:00 2001
From: Vincent Palatin
Date: Thu, 23 Oct 2025 12:02:19 +0200
Subject: [PATCH] [lldb][test] skip Lua tests when the Lua interpreter is not
DavidSpickett wrote:
I'll let Adrian approve or not since they had the problems with that specific
test.
> Remove test that starts and listens on a socket to avoid timeout issues
We have API tests for lldb-server in `lldb/test/API/tools/lldb-server/` and
there is a utility function `lldbutil.
DavidSpickett wrote:
Added Adrian on review and removed the mentions in the PR description (which
have a habit of persisting across forks).
https://github.com/llvm/llvm-project/pull/164904
___
lldb-commits mailing list
[email protected]
http
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/164904
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,6 +37,9 @@ add_dependencies(lldb
if(DEFINED LLDB_PYTHON_DLL_RELATIVE_PATH)
target_compile_definitions(lldb PRIVATE
LLDB_PYTHON_DLL_RELATIVE_PATH="${LLDB_PYTHON_DLL_RELATIVE_PATH}")
endif()
+if(DEFINED LLDB_PYTHON_SHARED_LIBRARY_FILENAME)
+ target_compile_definitions(
@@ -61,6 +61,8 @@ if (LLDB_ENABLE_PYTHON)
"Path to python interpreter exectuable, relative to python's install
prefix")
set(cachestring_LLDB_PYTHON_EXT_SUFFIX
"Filename extension for native code python modules")
+ set(cachestring_LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME
mstorsjo wrote:
> I ended up using `Python3_RUNTIME_LIBRARY` which points to `python310.dll` or
> its equivalent. I could not find a variable which points to `python3.dll`.
`Python3_RUNTIME_LIBRARY` doesn't seem to be set in my case (when cross
compiling from Linux). I don't find it documented
charles-zablit wrote:
@mstorsjo my understanding is that `Python3_RUNTIME_LIBRARY` should always be
set to something (according to
https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindPython/Support.cmake#L3868-3874)
and that it's an undocumented public variable.
I see 2 solutions:
https://github.com/ellishg approved this pull request.
https://github.com/llvm/llvm-project/pull/164471
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From c6ef435f628b964949b72cd6b78199493be9dfa9 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/6] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From 1673e1b93b9c4e5a99323ca9bdf8232c6d5fdfad Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/4] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/164471
>From 1673e1b93b9c4e5a99323ca9bdf8232c6d5fdfad Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 21 Oct 2025 11:19:30 -0700
Subject: [PATCH 1/5] Enable LLDB to load large dSYM files.
llvm-dsymutil can pro
@@ -1114,9 +1114,7 @@ class CommandObjectBreakpointList : public
CommandObjectParsed {
CommandObjectBreakpointList(CommandInterpreter &interpreter)
: CommandObjectParsed(
interpreter, "breakpoint list",
-"List some or all breakpoints at configur
naveen-seth wrote:
Ping
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3098,6 +3107,23 @@ void Target::SetAllStopHooksActiveState(bool
active_state) {
}
}
+// FIXME: Ideally we would like to return a `const &` (const reference)
instead
jimingham wrote:
Are you sure that using the iterator of the map will preserve the or
@@ -1346,6 +1346,13 @@ class Target : public
std::enable_shared_from_this,
const lldb_private::RegisterFlags &flags,
uint32_t byte_size);
+ /// Sends a breakpoint notification event if any listener is registered.
59 matches
Mail list logo
