================
@@ -3098,6 +3107,23 @@ void Target::SetAllStopHooksActiveState(bool
active_state) {
}
}
+// FIXME: Ideally we would like to return a `const &` (const reference)
instead
----------------
jimingham wrote:
Are you sure that using the iterator of the map will preserve the order of the
stop-hooks in this listing? I'm not concerned about internal stop-hooks, but
it wouldn't be good if you added a bunch of stop hooks, then deleted some, and
then the order of the stop-hooks in the listing got scrambled.
Might be good to add a test to ensure that this ordering is maintained to
ensure that.
https://github.com/llvm/llvm-project/pull/164506
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
