[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-30 Thread via lldb-commits
award999 wrote: So the approach in this PR still makes use of VSCode log rotation and persisting, where the log file goes in the same folder as LogOutputChannel would put it. So really the biggest difference I see is the verbosity of the file log vs. introducing a dependency. As long as you're

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-30 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: @mstorsjo @vvereschaka I can try reproducing the issue with the universal binaries on macOS, but I don't currently have a setup to try reproducing the issue with cross-compiling so I think I'll need some help there. I noted this in https://github.com/llvm/llvm-project/issu

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-07-30 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/150999 >From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Mon, 28 Jul 2025 18:58:44 +0200 Subject: [PATCH 1/5] [lldb] add TemplateRange and NameQualifiersRange to

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
https://github.com/delcypher requested changes to this pull request. https://github.com/llvm/llvm-project/pull/151231 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
@@ -0,0 +1,17 @@ +# REQUIRES: clang + +# RUN: %clang_host -g -O0 %S/Inputs/ubsan_add_overflow.cpp -o %t.out \ +# RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow + +# RUN: %lldb -b -s %s %t.out | FileCheck %s + +run +# CHECK: thread #{{.*}} stop rea

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-30 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > One big behavioral difference between your `CreateValueObjectFromValue` VO's > and the `CreateValueObjectFromAPInt` ones is that you set the child address > type to invalid, but the APInt one sets it to "load". That's fine so long as > the Value only holds ints and not pointer

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/151010 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread David Spickett via lldb-commits
@@ -224,67 +311,68 @@ def test_load_module_with_stripped_symbols_from_remote(self): @skipIfAsan @skipIfXmlSupportMissing -def test_load_module_from_file(self): -"""Test connecting to a WebAssembly engine via GDB-remote and loading a Wasm module from a fil

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread David Spickett via lldb-commits
@@ -0,0 +1,194 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/151343 >From f18f2c1b654fa6f5925109eae0277bbbceb48565 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 30 Jul 2025 14:13:02 + Subject: [PATCH 1/3] [lldb] Remove %T from lit tests %T has been depreca

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread David Spickett via lldb-commits
@@ -71,28 +124,62 @@ def qXferRead(self, obj, annex, offset, length): if obj == "libraries": xml = ( '' -% (self._module_name, load_address) +% (self._module_name, LOAD_ADDRESS) ) retu

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. supprot -> support, in the PR description. LGTM. https://github.com/llvm/llvm-project/pull/151056 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a7b58e7 - [lldb] Remove %T from lit tests (#151343)

2025-07-30 Thread via lldb-commits
Author: Aiden Grossman Date: 2025-07-30T09:09:54-07:00 New Revision: a7b58e74a080152c30fc5eb5f749e2254c277938 URL: https://github.com/llvm/llvm-project/commit/a7b58e74a080152c30fc5eb5f749e2254c277938 DIFF: https://github.com/llvm/llvm-project/commit/a7b58e74a080152c30fc5eb5f749e2254c277938.diff

[Lldb-commits] [lldb] [LLDB][NativePDB] Fix name access for classes in `CVTagRecord::name` (PR #151190)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151190 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6be3cc5 - [LLDB][NativePDB] Fix name access for classes in `CVTagRecord::name` (#151190)

2025-07-30 Thread via lldb-commits
Author: nerix Date: 2025-07-30T09:11:57-07:00 New Revision: 6be3cc5ad5ee0d33264bc202005e93c667b67698 URL: https://github.com/llvm/llvm-project/commit/6be3cc5ad5ee0d33264bc202005e93c667b67698 DIFF: https://github.com/llvm/llvm-project/commit/6be3cc5ad5ee0d33264bc202005e93c667b67698.diff LOG: [L

[Lldb-commits] [lldb] [LLDB][NativePDB] Fix name access for classes in `CVTagRecord::name` (PR #151190)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151190 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/148300 >From ac0cf25e78f48e24847ef814a273d71bf0b98ddc Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 11 Jul 2025 14:24:42 -0700 Subject: [PATCH 1/4] [lldb] Update JSONTransport to use MainLoop for reading. Thi

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -56,40 +84,88 @@ bool fromJSON(const llvm::json::Value &V, JSONTestType &T, llvm::json::Path P) { } // namespace TEST_F(HTTPDelimitedJSONTransportTest, MalformedRequests) { - std::string malformed_header = "COnTent-LenGth: -1{}\r\n\r\nnotjosn"; + std::string malformed_he

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -7,163 +7,122 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -7,163 +7,122 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -22,8 +23,28 @@ class TransportBase : public PipePairTest { protected: std::unique_ptr to_dap; std::unique_ptr from_dap; + lldb_private::MainLoop loop; void SetUp() override; + + template + void + RunOnce(std::function)> callback, + std::chrono::millis

[Lldb-commits] [lldb] c2548a8 - [lldb] Support DW_OP_WASM_location in DWARFExpression (#151010)

2025-07-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-30T09:20:37-07:00 New Revision: c2548a8c4c581bfd7c2b7738508fff4d85413cd6 URL: https://github.com/llvm/llvm-project/commit/c2548a8c4c581bfd7c2b7738508fff4d85413cd6 DIFF: https://github.com/llvm/llvm-project/commit/c2548a8c4c581bfd7c2b7738508fff4d85413cd6.d

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151010 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -7,127 +7,80 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper.

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -7,163 +7,122 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-07-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/151291 >From 40260f72bd61ab6d0b6b059b3c3ae68766d37479 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Jul 2025 00:56:06 -0700 Subject: [PATCH] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite inv

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
@@ -7,163 +7,122 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-07-30 Thread Michael Buch via lldb-commits
@@ -59,6 +73,18 @@ struct DemangledNameInfo { /// \endcode std::pair QualifiersRange; + /// Indicates the [start, end) of the function's name qualifiers. This is a + /// catch-all range for anything in between the basename and the arguments, + /// that is not tracked by

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/150999 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Add `ValueObject::CreateValueObjectFromScalar` function and adjust `Scalar::GetData` to be able to both extend and truncate the data bytes in Scalar to a desired size. --- Full diff: https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-30 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/151350 Add `ValueObject::CreateValueObjectFromScalar` function and adjust `Scalar::GetData` to be able to both extend and truncate the data bytes in Scalar to a desired size. >From ff14392e82fb5658c87b4376551a0dc366b

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-30 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: I'm trying here an alternative way of creating a const `ValueObject`. The way it's currently done with `CreateValueObjectFromAPInt` is getting its data bytes and sending them to `ValueObject::CreateValueObjectFromData`, which creates a `ValueObjectConstResult` with `ValueType::H

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-30 Thread Michael Buch via lldb-commits
@@ -328,6 +329,21 @@ class SymbolFile : public PluginInterface { GetMangledNamesForFunction(const std::string &scope_qualified_name, std::vector &mangled_names); + /// Resolves the function corresponding to the specified LLDB function + /// cal

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-30 Thread Michael Buch via lldb-commits
@@ -26,3 +30,74 @@ Expression::Expression(ExecutionContextScope &exe_scope) m_jit_end_addr(LLDB_INVALID_ADDRESS) { assert(m_target_wp.lock()); } + +/// Returns the components of the specified function call label. +/// +/// The format of \c label is described in \c Funct

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-30 Thread via lldb-commits
https://github.com/Nerixyz commented: I can't approve anything, but it works for me on Windows 11 👍 https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-30 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-30 Thread via lldb-commits
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const std::optional &O) { } // end namespace llvm +bool write_console_impl(int FD, llvm::StringRef Data); Nerixyz wrote: This should probably be in some `llvm` namespace - not in the global one.

[Lldb-commits] [lldb] eb9e526 - [lldb] Pick the builder for the target platform (#151262)

2025-07-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-30T08:24:28-07:00 New Revision: eb9e526af050611ceafa6a53b73d72a7d3ea065c URL: https://github.com/llvm/llvm-project/commit/eb9e526af050611ceafa6a53b73d72a7d3ea065c DIFF: https://github.com/llvm/llvm-project/commit/eb9e526af050611ceafa6a53b73d72a7d3ea065c.d

[Lldb-commits] [lldb] [lldb] Pick the builder for the target platform (PR #151262)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151262 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 ready_for_review https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Aiden Grossman (boomanaiden154) Changes %T has been deprecated for about seven years, mostly because it is not unique to each test which can lead to races. This patch updates the few remaining tests in lldb that use %T to not use it (eithe

[Lldb-commits] [lldb] [lldb] Remove a redundant call to std::unique_ptr::get (NFC) (PR #151283)

2025-07-30 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/151283 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151056 >From c9cea26faaede58bcc8a68eb91425fda21455983 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 28 Jul 2025 10:38:02 -0700 Subject: [PATCH 1/3] [lldb] Support DW_OP_WASM_location in DWARFExpressi

[Lldb-commits] [lldb] 5327eeb - [lldb] Remove a redundant call to std::unique_ptr::get (NFC) (#151283)

2025-07-30 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-07-30T07:30:30-07:00 New Revision: 5327eeb0bf4eed084b1761cd1b14f3f335383e95 URL: https://github.com/llvm/llvm-project/commit/5327eeb0bf4eed084b1761cd1b14f3f335383e95 DIFF: https://github.com/llvm/llvm-project/commit/5327eeb0bf4eed084b1761cd1b14f3f335383e95.diff L

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/151343 %T has been deprecated for about seven years, mostly because it is not unique to each test which can lead to races. This patch updates the few remaining tests in lldb that use %T to not use it (either di

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-30 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Hi @Nerixyz, is there anything else I can add to this patch to get it merged? https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -71,28 +124,62 @@ def qXferRead(self, obj, annex, offset, length): if obj == "libraries": xml = ( '' -% (self._module_name, load_address) +% (self._module_name, LOAD_ADDRESS) ) retu

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/151056 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/151343 >From f18f2c1b654fa6f5925109eae0277bbbceb48565 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Wed, 30 Jul 2025 14:13:02 + Subject: [PATCH 1/2] [lldb] Remove %T from lit tests %T has been depreca

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,228 @@ +--- !WASM JDevlieghere wrote: I added the invocation to the Python files. https://github.com/llvm/llvm-project/pull/151056 ___ lldb-commits mailing list [email protected] https://lists.llvm

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -224,67 +311,68 @@ def test_load_module_with_stripped_symbols_from_remote(self): @skipIfAsan @skipIfXmlSupportMissing -def test_load_module_from_file(self): -"""Test connecting to a WebAssembly engine via GDB-remote and loading a Wasm module from a fil

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,91 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/151231 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
https://github.com/delcypher approved this pull request. Mostly looks good. Please remove the uses of `volatile` unless there's a good reason for them to be there. Also please make the description/commit message be more descriptive. Something like ``` [lldb][NFC] Add test cases for UBSan trap

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/151231 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-30 Thread Dan Liew via lldb-commits
@@ -0,0 +1,8 @@ +#include + +int main() { + volatile int a = INT_MAX; delcypher wrote: Why is `volatile` here? https://github.com/llvm/llvm-project/pull/151231 ___ lldb-commits mailing list [email protected]

[Lldb-commits] [lldb] [lldb] add software watchpoints support (PR #151195)

2025-07-30 Thread via lldb-commits
dlav-sc wrote: > software implemented watchpoint is going to be so slow Well, yeah, they're quite slow, especially on targets that don't support hardware stepping. I've tested this patch on both riscv and x86 and the software watchpoints work significantly faster on x86 compared to riscv. I b

[Lldb-commits] [lldb] [lldb] add software watchpoints support (PR #151195)

2025-07-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I do wonder if we can reliably instruction step over every instruction on > every target (atomics instructions/sequences seem to be a sore point). https://github.com/llvm/llvm-project/issues/34572 / https://github.com/llvm/llvm-project/issues/24318 / https://github.com/

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Am I missing something or is `NameQualifiersRange` not being set/used in this patch? https://github.com/llvm/llvm-project/pull/150999 ___ lldb-commits mailing list [email protected] https://lists.llvm

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-30 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/148300 >From 7857cff5f79c603c72edb69f0c10294e5e042ebc Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 11 Jul 2025 14:24:42 -0700 Subject: [PATCH 1/5] [lldb] Update JSONTransport to use MainLoop for reading. Thi

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-30 Thread Adrian Prantl via lldb-commits
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const std::optional &O) { } // end namespace llvm +bool write_console_impl(int FD, llvm::StringRef Data); adrian-prantl wrote: This is making an internal API that only makes sense on Windows publi

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-30 Thread via lldb-commits
athierry-oct wrote: Hi, sorry for the delay. I investigated the `TestCallThatRestarts.py` failure, and I think I’ve figured out what’s going on. Toward the end of the test, we run: ```python value = frame.EvaluateExpression("call_me (%d)" % (num_sigchld), options) ``` Then we call: ```python

[Lldb-commits] [lldb] [windows][lldb] implement system logging on Windows (PR #150213)

2025-07-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/150213 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a14659a - [lldb] deactivate some tests on older SDKs (#147768)

2025-07-30 Thread via lldb-commits
Author: Charles Zablit Date: 2025-07-30T18:01:04+01:00 New Revision: a14659a2c8c82804b611925fa7a48fd26ef1d135 URL: https://github.com/llvm/llvm-project/commit/a14659a2c8c82804b611925fa7a48fd26ef1d135 DIFF: https://github.com/llvm/llvm-project/commit/a14659a2c8c82804b611925fa7a48fd26ef1d135.diff

[Lldb-commits] [lldb] [lldb] deactivate some tests on older SDKs (PR #147768)

2025-07-30 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/147768 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] NFC: Clean up construction of IntrusiveRefCntPtr from raw pointers for llvm::vfs::FileSystem. (PR #151407)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151407 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/151403 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jason Molenda via lldb-commits
@@ -355,6 +355,16 @@ ifeq "$(OS)" "Windows_NT" endif endif +#-- +# Darwin cross compilation +#-- +ifeq "$(HOST_OS)" "Darwin" +

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. lgtm. https://github.com/llvm/llvm-project/pull/151403 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. LGTM modulo the case. https://github.com/llvm/llvm-project/pull/149774 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-30 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/149774 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -355,6 +355,16 @@ ifeq "$(OS)" "Windows_NT" endif endif +#-- +# Darwin cross compilation +#-- +ifeq "$(HOST_OS)" "Darwin" +

[Lldb-commits] [lldb] f623702 - [lldb] Implement RegisterContextWasm (#151056)

2025-07-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-30T19:51:09-07:00 New Revision: f62370290a66f8d3a47a4b25c3896983424f97bd URL: https://github.com/llvm/llvm-project/commit/f62370290a66f8d3a47a4b25c3896983424f97bd DIFF: https://github.com/llvm/llvm-project/commit/f62370290a66f8d3a47a4b25c3896983424f97bd.d

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151056 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-07-30 Thread Daniel Sanders via lldb-commits
https://github.com/dsandersllvm updated https://github.com/llvm/llvm-project/pull/150732 >From bd27929645928939f319dc915da1a4636e4d317d Mon Sep 17 00:00:00 2001 From: Daniel Sanders Date: Wed, 28 Aug 2024 19:02:21 -0700 Subject: [PATCH 1/6] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_off

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Augusto Noronha via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); augusto2112 wro

[Lldb-commits] [lldb] 90aed4d - [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (#150579)

2025-07-30 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-07-30T12:54:58-07:00 New Revision: 90aed4dbdfe7354405db980d2b684bf91f69b4fb URL: https://github.com/llvm/llvm-project/commit/90aed4dbdfe7354405db980d2b684bf91f69b4fb DIFF: https://github.com/llvm/llvm-project/commit/90aed4dbdfe7354405db980d2b684bf91f69b4fb.diff L

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-30 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/150579 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-30 Thread via lldb-commits
@@ -242,3 +242,36 @@ def test_StackFrameFormat(self): frame = self.get_stackFrames(format={"parameters": False, "module": True})[0] self.assertEqual(frame["name"], "a.out recurse") + +@skipIfWindows +def test_stack_frame_module_id(self): +progr

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-30 Thread via lldb-commits
https://github.com/woruyu updated https://github.com/llvm/llvm-project/pull/149774 >From 33c94346ac2b96d9f68fd1b8d62aebfa7b273499 Mon Sep 17 00:00:00 2001 From: woruyu <[email protected]> Date: Mon, 21 Jul 2025 15:52:50 +0800 Subject: [PATCH 1/6] [lldb-dap] support moduleId in the stackTrace res

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Augusto Noronha via lldb-commits
@@ -182,11 +184,13 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - bool failed = errorToBool(dump_val_object(*valobj_sp)); - if (!failed) + Error err = dump_val_object(*valobj_sp); + if (!er

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Augusto Noronha via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); augusto2112 wro

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From 97435049d503045f22e169825244c944f31968c7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From a0fc19ed15fac0694309d0b1c8246c3d9cc3aeba Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Make AsmLabel parameter a std::string (PR #151355)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/151355 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Make AsmLabel parameter a llvm::StringRef (PR #151355)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/151355 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [windows][lldb] implement system logging on Windows (PR #150213)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/150213 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cade1e2 - [lldb][rpc] Only use guard names in framework script (#151391)

2025-07-30 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-07-30T23:04:22-07:00 New Revision: cade1e29b2c9ab0d0ff4931231b6958ad04d1ebc URL: https://github.com/llvm/llvm-project/commit/cade1e29b2c9ab0d0ff4931231b6958ad04d1ebc DIFF: https://github.com/llvm/llvm-project/commit/cade1e29b2c9ab0d0ff4931231b6958ad04d1ebc.d

[Lldb-commits] [lldb] [lldb][rpc] Only use guard names in framework script (PR #151391)

2025-07-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/151391 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Make AsmLabel parameter a llvm::StringRef (PR #151355)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/151355 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7410f6d - [lldb][TypeSystemClang] Make AsmLabel parameter a llvm::StringRef (#151355)

2025-07-30 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-31T07:11:30+01:00 New Revision: 7410f6d31de7fded4c0efdc342ab50223d3c7250 URL: https://github.com/llvm/llvm-project/commit/7410f6d31de7fded4c0efdc342ab50223d3c7250 DIFF: https://github.com/llvm/llvm-project/commit/7410f6d31de7fded4c0efdc342ab50223d3c7250.diff

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes The `EmulateInstructionARM64::EvaluateInstruction()` method used `uint32_t` to store the PC value, causing addresses greater than 2^32 to be truncated. As for now, the issue does not affect the mainline bec

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/Instruction/ARM64/EmulateInstruct

[Lldb-commits] [lldb] [lldb][FreeBSD] Add Auxv numbers for HWCAP3 and HWCAP4 (PR #151152)

2025-07-30 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good Thanks! https://github.com/llvm/llvm-project/pull/151152 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Michael Buch via lldb-commits
@@ -0,0 +1,91 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Michael Buch via lldb-commits
@@ -0,0 +1,91 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: SGTM Modulo the comment in `GetVendorDWARFOpcodeSize` https://github.com/llvm/llvm-project/pull/151010 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/l

  1   2   >