https://github.com/delcypher approved this pull request.

Mostly looks good. Please remove the uses of `volatile` unless there's a good 
reason for them to be there. Also please make the description/commit message be 
more descriptive. Something like

```
[lldb][NFC] Add test cases for UBSan trap reasons

In https://github.com/llvm/llvm-project/pull/145967 Clang was taught to emit 
trap reasons on UBSan traps in debug info using the same method as 
`__builtin_verbose_trap`. This patch adds a test case to make sure that the 
existing "Verbose Trap StackFrame Recognizer" recognizes the trap reason and 
sets the stop reason and stack frame appropriately.
```

https://github.com/llvm/llvm-project/pull/151231
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to