[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -1629,6 +1630,80 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "^std::optional<.+>(( )?&)?$", stl_summary_flags, true); } +static void LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -1372,6 +1373,37 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "${var.__y_} ${var.__m_} ${var.__wdl_}"))); } +static void RegisterStdStringSummaryProvider( +const lldb::TypeCategoryImplSP &category_sp, llvm::StringRef string_

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
@@ -175,15 +174,16 @@ static FormSize g_form_sizes[] = { {1, 8}, // 0x14 DW_FORM_ref8 {0, 0}, // 0x15 DW_FORM_ref_udata {0, 0}, // 0x16 DW_FORM_indirect -{1, 4}, // 0x17 DW_FORM_sec_offset +{0, + 0}, // 0x17 DW_FORM_sec_offset (4 bytes for DWARF32, 8

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
@@ -175,15 +174,16 @@ static FormSize g_form_sizes[] = { {1, 8}, // 0x14 DW_FORM_ref8 {0, 0}, // 0x15 DW_FORM_ref_udata {0, 0}, // 0x16 DW_FORM_indirect -{1, 4}, // 0x17 DW_FORM_sec_offset +{0, + 0}, // 0x17 DW_FORM_sec_offset (4 bytes for DWARF32, 8

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/145645 >From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Wed, 25 Jun 2025 02:06:05 -0400 Subject: [PATCH 1/5] [lldb][DWARF64] Enable support for DWARF64 format han

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread David Spickett via lldb-commits
@@ -21,9 +26,15 @@ TEST(Support, getProcFile_Pid) { } #endif // #ifndef __APPLE__ -#if defined(_AIX) && defined(LLVM_ENABLE_THREADING) +#if (defined(_AIX) || defined(__linux__)) && defined(LLVM_ENABLE_THREADING) TEST(Support, getProcFile_Tid) { - auto BufferOrError = getProc

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! Note that `Show MTE store only setting in mte_ctrl` is the commit with new code, rest is the previous PR. https://github.com/llvm/llvm-project/pull/145033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
@@ -175,15 +174,16 @@ static FormSize g_form_sizes[] = { {1, 8}, // 0x14 DW_FORM_ref8 {0, 0}, // 0x15 DW_FORM_ref_udata {0, 0}, // 0x16 DW_FORM_indirect -{1, 4}, // 0x17 DW_FORM_sec_offset +{0, + 0}, // 0x17 DW_FORM_sec_offset (4 bytes for DWARF32, 8

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please go ahead and merge this, or I can do so for you if you're happy with it. https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/145645 >From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Wed, 25 Jun 2025 02:06:05 -0400 Subject: [PATCH 1/5] [lldb][DWARF64] Enable support for DWARF64 format han

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-01 Thread Pavel Labath via lldb-commits
labath wrote: Sorry for going off-topic, but what does this say about the support for `i386-apple-*` as a whole? I find the prospect of dropping that exciting, as I believe that is the only target where eh_ and debug_frame register numbers are different. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-01 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +# All tests for the tool need lldb-rpc-gen to be built. +# As far as I can see, you need to check all possible ways to +# say "no" in a CMake option. +negation_options = ["OFF", "NO", 0] +if not config.lldb_has_lldbrpc or config.lldb_has_lldbrpc in negation_option

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > Assuming there is not a lot more work to be done for DWARF64, this needs a > release note - > https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb. > > You can do that in this PR or a follow up. Updated with this PR only, Please revie

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -31,6 +34,122 @@ static DWORD ToTimeout(std::optional point) { return ceil(dur).count(); } +namespace { + +class PipeEvent : public MainLoopWindows::IOEvent { +public: + explicit PipeEvent(HANDLE handle) + : IOEvent((IOObject::WaitableHandle)CreateEventW( +

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -124,7 +124,9 @@ TEST_F(MainLoopTest, NoSpuriousPipeReads) { // pipe is empty, and we should not be called anymore. char X; size_t len = sizeof(X); - EXPECT_THAT_EXPECTED(r->Read(&X, len).ToError(), llvm::HasValue(1)); + ASSERT

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: Assuming there is not a lot more work to be done for DWARF64, this needs a release note - https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb. You can do that in this PR or a follow up. https://github.com/llvm/llvm-project/pull/145645

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -41,10 +41,26 @@ Statusline::Statusline(Debugger &debugger) Statusline::~Statusline() { Disable(); } void Statusline::TerminalSizeChanged() { - UpdateTerminalProperties(); + const uint64_t terminal_width = m_debugger.GetTerminalWidth(); + const uint64_t terminal_height =

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: This messes up my terminal when reducing the height. It goes from ![down-before](https://github.com/user-attachments/assets/d14dd25d-dc99-4673-8cf9-6e8d1b7344e2) to ![down-after](https://github.com/user-attachments/assets/7e83e28e-0354-4bc6-9a22-a976df058659)

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/146435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update DIL to pass current 'frame var' tests. (PR #145055)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/145055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correctly restore the cursor column after resizing the statusline (PR #145823)

2025-07-01 Thread Pavel Labath via lldb-commits
labath wrote: Okay, I think I see the source of confusion. I was expecting the terminal to keep the status line at the bottom of the screen after a resize (just like it does with regular text), but my terminal (XFCE) at least simply discards it when decreasing the window size. It makes kind of

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-07-01 Thread Pavel Labath via lldb-commits
labath wrote: The way I understand this, this patch isn't trying to fix the step over problem (https://github.com/llvm/llvm-project/issues/144061). What it does is fix a different (but similar) problem in lldb-dap where it would show the wrong source code for in cases where the step operations

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -21,9 +26,15 @@ TEST(Support, getProcFile_Pid) { } #endif // #ifndef __APPLE__ -#if defined(_AIX) && defined(LLVM_ENABLE_THREADING) +#if (defined(_AIX) || defined(__linux__)) && defined(LLVM_ENABLE_THREADING) TEST(Support, getProcFile_Tid) { - auto BufferOrError = getProc

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,120 @@ +# coding=utf8 +""" +Test std::*string summaries with MSVC's STL. +""" labath wrote: I think it's mainly historical. We have `data-formatter/data-formatter-stl/generic/`, but it's a fairly recent addition. I think it would be nice to move ever

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
@@ -175,15 +174,16 @@ static FormSize g_form_sizes[] = { {1, 8}, // 0x14 DW_FORM_ref8 {0, 0}, // 0x15 DW_FORM_ref_udata {0, 0}, // 0x16 DW_FORM_indirect -{1, 4}, // 0x17 DW_FORM_sec_offset +{0, + 0}, // 0x17 DW_FORM_sec_offset (4 bytes for DWARF32, 8

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -41,10 +41,26 @@ Statusline::Statusline(Debugger &debugger) Statusline::~Statusline() { Disable(); } void Statusline::TerminalSizeChanged() { - UpdateTerminalProperties(); + const uint64_t terminal_width = m_debugger.GetTerminalWidth(); + const uint64_t terminal_height =

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/146500 >From 2b30e53ff0c1d03e3acfd10c06863463a99dec60 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 1 Jul 2025 12:06:23 +0200 Subject: [PATCH 1/2] [lldb] Add linux test for the three-arg version of getProcFile

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -239,122 +240,24 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -21,9 +26,15 @@ TEST(Support, getProcFile_Pid) { } #endif // #ifndef __APPLE__ -#if defined(_AIX) && defined(LLVM_ENABLE_THREADING) +#if (defined(_AIX) || defined(__linux__)) && defined(LLVM_ENABLE_THREADING) labath wrote: Good question. I assumed that's b

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: The above result is a flaky text, the next build was green so you can ignore it. https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in one of its call site (PR #146062)

2025-07-01 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/146062 >From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 27 Jun 2025 12:49:53 +0100 Subject: [PATCH 1/7] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From df589845dbccef086d966e21e8183a3dbada041a Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 18 Jun 2025 21:49:16 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- lldb/packages/Pyt

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -18,11 +18,11 @@ namespace lldb_private { namespace formatters { bool LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, -const TypeSummaryOptions &options); // libcstdc++ c++11 std::string +const TypeSummaryOptions &options); // libcstdc++ std:

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da0828b - [lldb] Enable support for DWARF64 format handling (#145645)

2025-07-01 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-07-01T18:35:40+05:30 New Revision: da0828b1e93c0fb6266225d8e6d41b2d9ef1f346 URL: https://github.com/llvm/llvm-project/commit/da0828b1e93c0fb6266225d8e6d41b2d9ef1f346 DIFF: https://github.com/llvm/llvm-project/commit/da0828b1e93c0fb6266225d8e6d41b2d9ef1f346.diff

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2