https://github.com/labath commented:

This messes up my terminal when reducing the height. It goes from
![down-before](https://github.com/user-attachments/assets/d14dd25d-dc99-4673-8cf9-6e8d1b7344e2)
to
![down-after](https://github.com/user-attachments/assets/7e83e28e-0354-4bc6-9a22-a976df058659)

The cursor ends up in the right place, but it ends up inside the former 
(inactive) copy of the status line. I guess that's related to the fact that the 
status line is automatically disabled on resize. Previous (unoptimized) code 
worked fine. (Note my window manager is configured to not to do "dynamic 
resizes" so lldb only gets one SIGWINCH with the new final size -- not all the 
ones in between. I haven't tried what would happen with dynamic resizes -- it 
might be better, or it might be much worse).

Since I was trying this out, I also noticed that changing the size *upwards* 
also has a bug (unrelated to this patch). This is how it looks like:
![up-before](https://github.com/user-attachments/assets/9fa49a65-5ac8-45cd-b7b3-5e11dbf8e6ab)
->
![up-after](https://github.com/user-attachments/assets/c6d896c8-791f-41e1-a96d-597d03dc496a)

I don't know exactly why, but I suspect it has something to do with the 
clearing code. It's definitely triggered by lldb, as this is what I get if I 
resize without any lldb involvement (I run lldb to set up the scroll window, 
but then I kill it so it doesn't do any extra work after resizing):

![raw-up-before](https://github.com/user-attachments/assets/5c895cb2-a54f-4c6c-a27a-2db289fefac8)
->
![raw-up-after](https://github.com/user-attachments/assets/b1a07640-9eb3-4a69-ba8b-baac0101421e)

I.e., the terminal just happily show the extra lines from the history and the 
(inactive) status line will stay at the bottom. (inactive means that if I press 
"return" the prompt will go into the status line remnant).

https://github.com/llvm/llvm-project/pull/146435
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to