https://github.com/yuvald-sweet-security edited
https://github.com/llvm/llvm-project/pull/145706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/145864
Revert the changes made in the following PRs as they are causing bot failures:
- https://github.com/llvm/llvm-project/pull/145744
- https://github.com/llvm/llvm-project/pull/144913
>From a540d68b0a882f0f
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
Changes
Revert the changes made in the following PRs as they are causing bot failures:
- https://github.com/llvm/llvm-project/pull/145744
- https://github.com/llvm/llvm-project/pull/144913
---
Full diff: htt
charles-zablit wrote:
> Looks like this does break all the modules tests:
> https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/28395/execution/node/106/log/
> ...
> Could we revert for now to unblock bots?
Just opened a revert PR for this commit and a child commit.
https://
Michael137 wrote:
Looks like this does break all the modules tests:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/28395/execution/node/106/log/
```
09:51:43
09:51:43 Failed Tests (19):
09:51:43lldb-api ::
commands/expression/import-std-module/
mh4ck-Thales wrote:
This PR hasn't moved in months now, are we missing something? It would be nice
to have this merged so we can build upon this to bring more interest and
support from the Wasm community and push for an implementation of lldb servers
in various Wasm runtimes.
https://github.c
DavidSpickett wrote:
It's been a while, so it's missing a clear summary of:
* Which features this PR enables for WASM
* Which runtimes or debug servers this can be used with
* Which features might be enabled in future
* Which features are simply not applicable
* What the plans are for testing thi
DavidSpickett wrote:
For the code:
* It was agreed to move DW_OP_WASM_location handling into a separate PR. I
don't think this got done, though we do have a few mentions of it in LLDB right
now.
* We will not add a top level `wasm` command as you can use `process connect`.
If this PR is accept
https://github.com/DavidSpickett commented:
So if I understand correctly, the newline acts like `\n` and `\r`. `\n` moves
the cursor down one line and `\r` moves it to the start of that line.
You're undoing the `\n` by moving up one row, and the `\r` by restoring the
column position.
https://
@@ -102,20 +103,36 @@ void Statusline::UpdateScrollWindow(ScrollWindowMode
mode) {
const unsigned scroll_height =
(mode == DisableStatusline) ? m_terminal_height : m_terminal_height - 1;
+ CursorPosition cursor_position = m_debugger.GetIOHandlerCursorPosition();
@@ -398,6 +397,20 @@ int Editline::GetLineIndexForLocation(CursorLocation
location, int cursor_row) {
return line;
}
+CursorPosition Editline::GetCursorPosition() {
+ if (!m_editline)
+return {};
+
+ const LineInfoW *info = el_wline(m_editline);
+ if (!info)
+ret
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/145823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
And how exactly does this fix
https://github.com/llvm/llvm-project/issues/134064?
As in, what steps are happening with this PR compared to before.
https://github.com/llvm/llvm-project/pull/145823
___
lldb-commits mailing list
lld
@@ -122,22 +122,21 @@ static int GetOperation(HistoryOperation op) {
// - The H_FIRST returns the most recent entry in the history.
//
// The naming of the enum entries match the semantic meaning.
- switch(op) {
-case HistoryOperation::Oldest:
- return H_LAST;
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/145864
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
configuration.libcxx_library_dir = args.libcxx_library_dir
configuration.cmake_build_type = args.cmake_build_type.lower()
+configuration.target_triple = args.target_triple
+
DavidSpickett wrote
tedwoodward wrote:
> Is there a reason we couldn't handle this the same way for all targets?
The llvm disassembler returns the size, and sets the Opcode (class
instantiation) to a certain type - 8 bit, 16 bit, 16 bit thumb, 32 bit, 64
bit, bytes. For RISC-V, it's set to bytes, which means it
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
configuration.libcxx_library_dir = args.libcxx_library_dir
configuration.cmake_build_type = args.cmake_build_type.lower()
+configuration.target_triple = args.target_triple
+
DavidSpickett wrote
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/145823
>From 6dc1ff8270e603def516bae230a5fe7108645978 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 26 Jun 2025 08:33:07 -0700
Subject: [PATCH] [lldb] Correctly restore the cursor column after resizi
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -156,3 +161,5 @@ class ProgressEventReporter {
};
} // namespace lldb_dap
+
+#endif // LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
JDevlieghere wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/145915
__
Author: Michael Buch
Date: 2025-06-26T17:10:12+01:00
New Revision: aeea062dd43e164889f35c24b98cb1994ead50cb
URL:
https://github.com/llvm/llvm-project/commit/aeea062dd43e164889f35c24b98cb1994ead50cb
DIFF:
https://github.com/llvm/llvm-project/commit/aeea062dd43e164889f35c24b98cb1994ead50cb.diff
Author: Ebuka Ezike
Date: 2025-06-26T17:42:33+01:00
New Revision: d83457eb83d817e773ed6740a6f0c92180ca585e
URL:
https://github.com/llvm/llvm-project/commit/d83457eb83d817e773ed6740a6f0c92180ca585e
DIFF:
https://github.com/llvm/llvm-project/commit/d83457eb83d817e773ed6740a6f0c92180ca585e.diff
L
https://github.com/DavidSpickett approved this pull request.
I am confused which bits are handled by editline the library and which are
handled by our code that interacts with editline, but I always have been so
that shouldn't block this :)
LGTM
https://github.com/llvm/llvm-project/pull/14582
ian-twilightcoder wrote:
It's not _just_ `BuiltinHeadersInSystemModules` either. There are lots of
things that the driver toolchain does that you shouldn't be skipping.
https://github.com/llvm/llvm-project/pull/144913
___
lldb-commits mailing list
lld
DavidSpickett wrote:
Just doing some googling, mostly people talk about modifying the binutils in
the gnu toolchain for custom instructions and rebuilding it.
[This](https://www.ashling.com/wp-content/uploads/PR_CUSTOM_INST_17-FEB-2022.pdf)
refers to some XML file, but I can't tell if they're
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/145915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Ok I get what we're doing now but...
> This PR uses the active IOHandler (i.e. Editline) to get the cursor position
> before we emit the newline and then uses an ANSI escape code to move the
> cursor back to its original column. I was curious why, depending on the
> timin
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: qxy11
Date: 2025-06-26T10:16:05-07:00
New Revision: 5c310d1ef0188d609b1d2837d403d2b3f2eeb609
URL:
https://github.com/llvm/llvm-project/commit/5c310d1ef0188d609b1d2837d403d2b3f2eeb609
DIFF:
https://github.com/llvm/llvm-project/commit/5c310d1ef0188d609b1d2837d403d2b3f2eeb609.diff
LOG: De
jeffreytan81 wrote:
@qxy11, have you requested merge permission yet? If not, I can merge for you,
but you probably want to ask for you own merge access.
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-06-26T18:22:47+01:00
New Revision: 0b8a656ba110884e40e9ec79c936139eb6fce0b6
URL:
https://github.com/llvm/llvm-project/commit/0b8a656ba110884e40e9ec79c936139eb6fce0b6
DIFF:
https://github.com/llvm/llvm-project/commit/0b8a656ba110884e40e9ec79c936139eb6fce0b6.diff
L
tedwoodward wrote:
> The only real "gotcha" question I can come up with is, wouldn't a user who is
> interested in custom instructions already have access to a compiler that
> produces them and that compiler is likely to be llvm, so is lldb from that
> llvm not within reach already?
>
> Educ
Author: Sterling-Augustine
Date: 2025-06-26T11:23:46-07:00
New Revision: cbf781f0bdf2f680abbe784faedeefd6f84c246e
URL:
https://github.com/llvm/llvm-project/commit/cbf781f0bdf2f680abbe784faedeefd6f84c246e
DIFF:
https://github.com/llvm/llvm-project/commit/cbf781f0bdf2f680abbe784faedeefd6f84c246e.
https://github.com/Sterling-Augustine closed
https://github.com/llvm/llvm-project/pull/145081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/145872
Desugar any potential references/typedefs before checking `isStdTemplate`.
Previously, the typename might've been:
```
const std::unordered_map<...> &
```
for references. This patch gets the pointee type befo
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143177
>From 7815eeb573f52617fb5a3ade247c9d45ae808371 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 18 Jun 2025 21:49:16 +0200
Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings
---
.../lldb/DataForm
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
configuration.libcxx_library_dir = args.libcxx_library_dir
configuration.cmake_build_type = args.cmake_build_type.lower()
+configuration.target_triple = args.target_triple
+
Nerixyz wrote:
> L
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/145872
>From f86827c1592779537b10dafcbf8b8abba4acccf2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 26 Jun 2025 12:06:13 +0100
Subject: [PATCH 1/2] [lldb][DataFormatter] Unwrap reference type when
formatti
@@ -64,3 +64,131 @@ def test_iterator_formatters(self):
ValueCheck(name="second", summary='"Qux"'),
],
)
+
+lldbutil.continue_to_breakpoint(process, bkpt)
+
+# Test references to std::unordered_map
+self.expect_var_pat
@@ -228,9 +228,9 @@ static const CoreDefinition g_core_definitions[] = {
{eByteOrderLittle, 4, 4, 4, llvm::Triple::hexagon,
ArchSpec::eCore_hexagon_hexagonv5, "hexagonv5"},
-{eByteOrderLittle, 4, 2, 4, llvm::Triple::riscv32, ArchSpec::eCore_riscv32,
+{eByteOrd
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/145872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> We could mark these tests as requiring macOS 15+, but given how often they
> break I am not sure we want to do that?
Happy to mark them as unsupported on older SDKs if it's blocking other work.
https://github.com/llvm/llvm-project/pull/144913
___
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/145915
>From fbfc26bd78b815334af4beb786ac8276f782b370 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Thu, 26 Jun 2025 16:07:28 +0100
Subject: [PATCH 1/2] [NFC][lldb-dap] add missing header guard.
delete the copy, m
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/144364
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
DavidSpickett wrote:
> For RISC-V, llvm-objdump mimics gnu objdump, so this change makes the RISC-V
> byte encodings match both.
Great, that's standard enough.
> That's one thing I'm trying to avoid - we don't want a filter app for objdump
> and another for the debugger. That's why I changed
DavidSpickett wrote:
@JDevlieghere / @jasonmolenda you have been in the RISC-V world lately, what do
you think to this approach?
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
Author: Charles Zablit
Date: 2025-06-26T11:56:50+01:00
New Revision: 9ae41f017d8e6264ded66e2e476efb1dc2a280a1
URL:
https://github.com/llvm/llvm-project/commit/9ae41f017d8e6264ded66e2e476efb1dc2a280a1
DIFF:
https://github.com/llvm/llvm-project/commit/9ae41f017d8e6264ded66e2e476efb1dc2a280a1.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Desugar any potential references/typedefs before checking `isStdTemplate`.
Previously, the typename might've been:
```
const std::unordered_map<...> &
```
for references. This patch gets the pointee type be
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/145872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -64,3 +64,131 @@ def test_iterator_formatters(self):
ValueCheck(name="second", summary='"Qux"'),
],
)
+
+lldbutil.continue_to_breakpoint(process, bkpt)
+
+# Test references to std::unordered_map
+self.expect_var_pat
@@ -64,3 +64,131 @@ def test_iterator_formatters(self):
ValueCheck(name="second", summary='"Qux"'),
],
)
+
+lldbutil.continue_to_breakpoint(process, bkpt)
+
+# Test references to std::unordered_map
+self.expect_var_pat
Author: Pavel Labath
Date: 2025-06-26T13:51:14+02:00
New Revision: b77114b723eb68563a0900846df5bd1b454edc2f
URL:
https://github.com/llvm/llvm-project/commit/b77114b723eb68563a0900846df5bd1b454edc2f
DIFF:
https://github.com/llvm/llvm-project/commit/b77114b723eb68563a0900846df5bd1b454edc2f.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/145516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Thanks, and sorry for not getting back to the Mac issue I said I'd debug,
> I've been preoccupied lately.
That's okay, no worries.
> To make sure I understand, this change hoists the logic that discovers the
> location of lldb-server (the function `GetDebugserverPath`) out of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
delete the copy, move constructor and assignment for ProgressEventReporter.
---
Full diff: https://github.com/llvm/llvm-project/pull/145915.diff
2 Files Affected:
- (modified) lldb/tools/lldb-dap/DAPError.h
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/145915
delete the copy, move constructor and assignment for ProgressEventReporter.
>From fbfc26bd78b815334af4beb786ac8276f782b370 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Thu, 26 Jun 2025 16:07:28 +0100
Subje
https://github.com/tedwoodward deleted
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -398,6 +397,20 @@ int Editline::GetLineIndexForLocation(CursorLocation
location, int cursor_row) {
return line;
}
+CursorPosition Editline::GetCursorPosition() {
+ if (!m_editline)
+return {};
+
+ const LineInfoW *info = el_wline(m_editline);
+ if (!info)
+ret
JDevlieghere wrote:
> And how exactly does this fix #134064?
https://github.com/llvm/llvm-project/issues/134064#issuecomment-2923315404 has
a visualization of the problem, which you've summarized in
https://github.com/llvm/llvm-project/pull/145823#pullrequestreview-2961296028.
> As in, what
@@ -102,20 +103,36 @@ void Statusline::UpdateScrollWindow(ScrollWindowMode
mode) {
const unsigned scroll_height =
(mode == DisableStatusline) ? m_terminal_height : m_terminal_height - 1;
+ CursorPosition cursor_position = m_debugger.GetIOHandlerCursorPosition();
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
tedwoodward wrote:
> Few more things:
>
> * Assuming this were to land, there needs to be a release note for it.
> * What solutions exist for people using GDB, and are they along the same
> lines?
I think that's a good idea. Do you know how to add something to release notes?
I've never done i
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/144364
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/145935
Document how to use MCP support in LLDB. I expect this to change significantly
as the feature matures. For now it covers configuring the server and two
example clients.
>From 2b6a7e22481761b244e98dff00f90
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Document how to use MCP support in LLDB. I expect this to change significantly
as the feature matures. For now it covers configuring the server and two
example clients.
---
Full diff: https://githu
jeffreytan81 wrote:
@cs01, can you get a more symbolicated stacktrace for the crash with debug info
and line info?
>From the current callstack, it seems to be a life time use after free issue?
>Like the `SyncService` is trying to access underlying `m_conn` object while it
>is destroyed?
If s
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/145111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-06-26T10:45:11-07:00
New Revision: e880cf74217d8b925f923185994dc8fe6f69a551
URL:
https://github.com/llvm/llvm-project/commit/e880cf74217d8b925f923185994dc8fe6f69a551
DIFF:
https://github.com/llvm/llvm-project/commit/e880cf74217d8b925f923185994dc8fe6f69a551.d
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while
building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/204/builds/13571
He
jplehr wrote:
> Reverted with
> [47fa4a6](https://github.com/llvm/llvm-project/commit/47fa4a6385cb4e8964cc6909c3554f6589b66eef)
>
> Will fix and reapply.
Has this reached `main` by now? I cannot see the revert and the bot is still
red.
https://github.com/llvm/llvm-project/pull/145081
___
https://github.com/Sterling-Augustine created
https://github.com/llvm/llvm-project/pull/145959
…145081)"
This reverts commit cbf781f0bdf2f680abbe784faedeefd6f84c246e.
Breaks a couple of buildbots.
>From 47fa4a6385cb4e8964cc6909c3554f6589b66eef Mon Sep 17 00:00:00 2001
From: Sterling Augustine
llvmbot wrote:
@llvm/pr-subscribers-pgo
@llvm/pr-subscribers-lldb
Author: None (Sterling-Augustine)
Changes
…145081)"
This reverts commit cbf781f0bdf2f680abbe784faedeefd6f84c246e.
Breaks a couple of buildbots.
---
Patch is 96.13 KiB, truncated to 20.00 KiB below, full version:
https:/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
bolt/
https://github.com/Sterling-Augustine closed
https://github.com/llvm/llvm-project/pull/145959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
The script used to fix up LLDB's header for use in the macOS framework
contained 2 bugs that this commit addreses:
1. The output contents were appended to the output file multiple times instead
of
Sterling-Augustine wrote:
I think it is there now.
https://github.com/llvm/llvm-project/pull/145081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/145961
The script used to fix up LLDB's header for use in the macOS framework
contained 2 bugs that this commit addreses:
1. The output contents were appended to the output file multiple times instead
of only b
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
bulbazord wrote:
I'm not an expert on regex but would it make sense to use `?` here instead of
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while
building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/205/builds/13548
He
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Could be worth updating all other instances of `{0,1}`
https://github.com
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Such that we have `r'#include "lldb/(API/)?(?P.*){0,1}"'`
instead of `r'#
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/145961
>From 7382a6a7e5636515c4882136d54c8133d77aa31d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 26 Jun 2025 13:05:56 -0700
Subject: [PATCH] [lldb][scripts] Fix bugs in framework fix script
The
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22`
while building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/203/builds/14758
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
dwblaikie wrote:
FYI: per https://llvm.org/docs/CodeReview.html#code-review-workflow - please
don't commit a PR without approval, once it's sent for review. If the intent
wasn't to precommit review the PR, it should be created with the
`skip-precommit-approval` tag.
https://github.com/llvm/ll
@@ -78,23 +80,232 @@ public:
__split_buffer,
void>;
- pointer __first_;
- pointer __begin_;
- pointer __end_;
- _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_);
+ struct __data {
+pointer __first_ = nullpt
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::__construct_
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n,
const_reference __x) {
- _ConstructTransaction __tx(std::add
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -111,36 +322,22 @@ public:
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI ~__split_buffer();
- _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI iterator begin()
_NOEXCEPT { return __begin_; }
- _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI const_iterator
1 - 100 of 132 matches
Mail list logo
