[Lldb-commits] [lldb] [LLDB] Consolidate C++ string buffer summaries (PR #144258)

2025-06-16 Thread via lldb-commits
@@ -199,13 +183,13 @@ bool lldb_private::formatters::WCharSummaryProvider( options.SetBinaryZeroIsTerminator(false); switch (wchar_size) { - case 8: + case 1: Nerixyz wrote: I refactored it to use `valobj.GetCompilerType().GetBasicTypeFromAST()` now. h

[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

2025-06-16 Thread Michael Buch via lldb-commits
Michael137 wrote: Looks plausible. Out of curiosity, why is this needed to implement `GetSDKPathFromDebugInfo` on Windows? Is there a follow-up PR already up? https://github.com/llvm/llvm-project/pull/144396 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-16 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > However, FileSpecList already has an AppendIfUnique method. So you could > (with less code than the current implementation) have all the new > lldb_private API's return what consumers actually want: an FileSpecList, and > then that would be trivially convertible to the SBFileS

[Lldb-commits] [lldb] [LLDB] Consolidate C++ string buffer summaries (PR #144258)

2025-06-16 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/144258 >From 7f6218a5b23231032988fe1e2d5d451fd5cf2e19 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 15 Jun 2025 12:23:27 +0200 Subject: [PATCH] [LLDB] Consolidate C++ string buffer summaries --- .../Language/CPlu

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread John Harrison via lldb-commits
@@ -510,6 +510,25 @@ DAP::SendFormattedOutput(OutputType o, const char *format, ...) { o, llvm::StringRef(buffer, std::min(actual_length, sizeof(buffer; } +int32_t DAP::CreateSourceReference(lldb::addr_t address) { + auto iter = llvm::find(source_references, addre

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread John Harrison via lldb-commits
@@ -510,6 +510,25 @@ DAP::SendFormattedOutput(OutputType o, const char *format, ...) { o, llvm::StringRef(buffer, std::min(actual_length, sizeof(buffer; } +int32_t DAP::CreateSourceReference(lldb::addr_t address) { + auto iter = llvm::find(source_references, addre

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread John Harrison via lldb-commits
@@ -37,10 +37,15 @@ protocol::Source CreateSource(const lldb::SBFileSpec &file); /// \param[in] target /// The target that has the address. /// +/// \param[in] create_reference +/// function used to create a source_reference +/// /// \return -/// A "Source" JSON ob

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -510,6 +510,25 @@ DAP::SendFormattedOutput(OutputType o, const char *format, ...) { o, llvm::StringRef(buffer, std::min(actual_length, sizeof(buffer; } +int32_t DAP::CreateSourceReference(lldb::addr_t address) { + auto iter = llvm::find(source_references, addre

[Lldb-commits] [lldb] c9ac167 - [lldb] Remove a redundant control flow statement (NFC) (#144284)

2025-06-16 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-06-16T08:59:10-07:00 New Revision: c9ac1679b5d3a3839640486dd4bd931a19f4725a URL: https://github.com/llvm/llvm-project/commit/c9ac1679b5d3a3839640486dd4bd931a19f4725a DIFF: https://github.com/llvm/llvm-project/commit/c9ac1679b5d3a3839640486dd4bd931a19f4725a.diff L

[Lldb-commits] [lldb] [lldb] Remove a redundant control flow statement (NFC) (PR #144284)

2025-06-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/144284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139174 >From d98210b81f7b49f5384e968b1a18e00e432aaf2c Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 16:21:53 -0700 Subject: [PATCH] Fix macOS FindProcessImpl() --- lldb/source/Host/macosx/objcxx/Host.

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-06-16 Thread Adrian Prantl via lldb-commits
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t func_load_addr, return GetExpressionAtAddress(func_load_addr, addr) != nullptr; } +llvm::Expected +DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr, +

[Lldb-commits] [lldb] d1dc080 - [lldb-dap] show function name in the instruction comment. (#144070)

2025-06-16 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-16T17:53:34+01:00 New Revision: d1dc080a858ca47c314334fb14f1ecb605fb4371 URL: https://github.com/llvm/llvm-project/commit/d1dc080a858ca47c314334fb14f1ecb605fb4371 DIFF: https://github.com/llvm/llvm-project/commit/d1dc080a858ca47c314334fb14f1ecb605fb4371.diff L

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/144070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-16 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM. Had one question about the strictness of a test. https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-16 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-16 Thread David Peixotto via lldb-commits
@@ -94,4 +94,128 @@ TEST_F(ObjectFileMachOTest, IndirectSymbolsInTheSharedCache) { for (size_t i = 0; i < 10; i++) OF->ParseSymtab(symtab); } + +TEST_F(ObjectFileMachOTest, ObjectFormatWithVersionLoadCommand) { + // A Mach-O file of arm64 CPU type and macOS 10.14.0 + c

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-16 Thread David Peixotto via lldb-commits
https://github.com/dmpots commented: There is one early return in this function: https://github.com/llvm/llvm-project/pull/144177/files#diff-1c2c090c5ff772b9b304dbdd4cf45803478f4f33d11d042817fea7358e0cc96bL5167 I wonder if we need to handle this case as well. https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/91404 >From 75061e1eb39383dae59ebd3ce3b77d8b550d0ab5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 9 May 2024 11:08:29 -0700 Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints This c

[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

2025-06-16 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/144396 This PR introduces a new class (`XcodeSDKPath`) which holds both an `XcodeSDK` and a `sysroot` for that SDK. This motivation for this refactor is to eventually implement `GetSDKPathFromDebugInfo` on `Pl

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes The [protocol](https://microsoft.github.io/debug-adapter-protocol//specification.html#Types_Source) expects that `sourceReference` be less than `(2^31)-1`, but we currently represent memory address as source

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/144364 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/144364 The [protocol](https://microsoft.github.io/debug-adapter-protocol//specification.html#Types_Source) expects that `sourceReference` be less than `(2^31)-1`, but we currently represent memory address as source

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [LLDB] Consolidate C++ string buffer summaries (PR #144258)

2025-06-16 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/144258 >From 6e0f22122c1c08d64b0e3b74a7a08d2177249d03 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 15 Jun 2025 12:23:27 +0200 Subject: [PATCH] [LLDB] Consolidate C++ string buffer summaries --- .../Language/CPlu

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-16 Thread John Harrison via lldb-commits
ashgti wrote: Ah, ok, if is already like this in other places, SGTM https://github.com/llvm/llvm-project/pull/144070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-06-16 Thread Adrian Prantl via lldb-commits
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t func_load_addr, return GetExpressionAtAddress(func_load_addr, addr) != nullptr; } +llvm::Expected +DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr, +

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-06-16 Thread Adrian Prantl via lldb-commits
@@ -59,6 +59,18 @@ class DWARFExpressionList { lldb::addr_t GetFuncFileAddress() { return m_func_file_addr; } + /// Represents an entry in the DWARFExpressionList with all needed metadata + struct DWARFExpressionEntry { +lldb::addr_t base; +lldb::addr_t end; -

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/91404 >From 8608a949e6579f9ee69961ceabf8158a6b91b208 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 9 May 2024 11:08:29 -0700 Subject: [PATCH 1/3] [lldb][breakpoint] Grey out disabled breakpoints Th

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/144070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add supported languages in package.json (PR #144414)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/144414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/143818 >From ab4b987aec591491d3805af41c7127ff6698fe0e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 11 Jun 2025 15:57:16 -0700 Subject: [PATCH 1/4] [lldb-dap] Refactring DebugCommunication to improve test con

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [lldb] Implement priority system for symbol locator plugin (PR #144406)

2025-06-16 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/144406 In the context if locate_module callback is registered and debuginfod is enabled. If debuginfod symbol locator is called first then we are double downloading the debuginfo file through locate module callba

[Lldb-commits] [lldb] [lldb-dap] Add supported languages in package.json (PR #144414)

2025-06-16 Thread via lldb-commits
https://github.com/DrSergei created https://github.com/llvm/llvm-project/pull/144414 This patch fixes the [problem](https://github.com/llvm/llvm-project/issues/144239). It was caused by missing supported languages list in `package.json`. VSCode uses `guessDebugger` [function](https://github.c

[Lldb-commits] [lldb] [lldb-dap] Add supported languages in package.json (PR #144414)

2025-06-16 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb-dap][test] fix not supported error. (PR #144419)

2025-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Fixes #144072 buildbot error. --- Full diff: https://github.com/llvm/llvm-project/pull/144419.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py (+7-

[Lldb-commits] [lldb] [lldb-dap][test] fix not supported error. (PR #144419)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/144419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/143818 >From ab4b987aec591491d3805af41c7127ff6698fe0e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 11 Jun 2025 15:57:16 -0700 Subject: [PATCH 1/5] [lldb-dap] Refactring DebugCommunication to improve test con

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,131 @@ +//===- Protocol.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -71,31 +173,27 @@ def read_packet(f, verbose=False, trace_file=None): if line.startswith(prefix): # Decode length of JSON bytes if verbose: -print('content: "%s"' % (line)) +print(f"content: {line}") ashgti wrote:

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-16 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap][test] fix not supported error. (PR #144419)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/144419 >From 31dc0abff52f4897f83d1405f65bf00ca0aa81cb Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 16 Jun 2025 20:33:34 +0100 Subject: [PATCH] [lldb-dap][test] fix not supported error. --- .../tools/lldb-da

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-16 Thread Alex Langford via lldb-commits
bulbazord wrote: > @bulbazord I have a auggestion for this patch. I want to have the minimum > CMake necessary to let the tool build. To accomplish this, I want to take out > all code in this tool that relates to the server/client code, leaving the > code that generates the byproducts. I'd the

[Lldb-commits] [lldb] [LLDB] Explicitly use python for version fixup (PR #144217)

2025-06-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/144217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,72 @@ +//===- Tool.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: A very lightweight review. I'm focusing on the low-level details. I have no clue about this AI stuff. https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [LLDB] Consolidate C++ string buffer summaries (PR #144258)

2025-06-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Moving the code seems fine, pending the two review comments https://github.com/llvm/llvm-project/pull/144258 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [LLDB] Consolidate C++ string buffer summaries (PR #144258)

2025-06-16 Thread via lldb-commits
@@ -199,13 +183,13 @@ bool lldb_private::formatters::WCharSummaryProvider( options.SetBinaryZeroIsTerminator(false); switch (wchar_size) { - case 8: + case 1: Nerixyz wrote: No, this wasn't wrong. It used the _bit size_ before, and the libc++ summary u

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -71,31 +173,27 @@ def read_packet(f, verbose=False, trace_file=None): if line.startswith(prefix): # Decode length of JSON bytes if verbose: -print('content: "%s"' % (line)) +print(f"content: {line}") da-viper wrote

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -152,35 +246,50 @@ def __init__( self.log_file = log_file self.send = send self.recv = recv -self.recv_packets: list[Optional[ProtocolMessage]] = [] -self.recv_condition = threading.Condition() -self.recv_thread = threading.Thr

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/143818 >From ab4b987aec591491d3805af41c7127ff6698fe0e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 11 Jun 2025 15:57:16 -0700 Subject: [PATCH 1/3] [lldb-dap] Refactring DebugCommunication to improve test con

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-16 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Explicitly use python for version fixup (PR #144217)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/144217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating protocol types for setExceptionBreakpoints. (PR #144153)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/include/lldb/Core/Debugger.h lldb/source/Break

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-16 Thread John Harrison via lldb-commits
@@ -582,6 +582,28 @@ llvm::json::Value toJSON(const SteppingGranularity &SG) { llvm_unreachable("unhandled stepping granularity."); } +bool fromJSON(const json::Value &Params, StepInTarget &SIT, json::Path P) { + json::ObjectMapper O(Params, P); + return O && O.map("id", S

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/144072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/91404 >From 8608a949e6579f9ee69961ceabf8158a6b91b208 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 9 May 2024 11:08:29 -0700 Subject: [PATCH 1/2] [lldb][breakpoint] Grey out disabled breakpoints Th

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-16 Thread Chelsea Cassanova via lldb-commits
@@ -838,6 +840,13 @@ void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level, bool show_locations) { assert(s != nullptr); + // Grey out any disabled breakpoints in the list of breakpoints. + if (!IsEnabled()) +if (s->As

[Lldb-commits] [lldb] [lldb-dap][test] fix not supported error. (PR #144419)

2025-06-16 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @JDevlieghere or @ashgti by any chance you have a mac or arm pc to check if this works locally merging ? https://github.com/llvm/llvm-project/pull/144419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread John Harrison via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -37,10 +37,15 @@ protocol::Source CreateSource(const lldb::SBFileSpec &file); /// \param[in] target /// The target that has the address. /// +/// \param[in] create_reference +/// function used to create a source_reference +/// /// \return -/// A "Source" JSON ob

[Lldb-commits] [lldb] [lldb-dap] Add supported languages in package.json (PR #144414)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/144414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-16 Thread via lldb-commits
https://github.com/qxy11 created https://github.com/llvm/llvm-project/pull/144424 ## Summary A new `totalLoadedDwoFileCount` is added to available statisctics when calling "statistics dump". 1. The counter in SymbolFileDWARF `m_loaded_dwo_file_count` is added, and accessed through the `GetLoa

[Lldb-commits] [lldb] [lldb-dap][test] fix not supported error. (PR #144419)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/144419 Fixes #144072 buildbot error. >From 22ea9d9c8afd879cacba769454ba115736df2c93 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 16 Jun 2025 20:33:34 +0100 Subject: [PATCH] [lldb-dap][test] fix not suppor

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (qxy11) Changes ## Summary A new `totalLoadedDwoFileCount` is added to available statisctics when calling "statistics dump". 1. The counter in SymbolFileDWARF `m_loaded_dwo_file_count` is added, and accessed through the `GetLoadedDwo

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-16 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-06-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > > I also needed to remove the brk #0xf000 instruction because lldb is not > > able to step over it -- it just ends up spinning forever. FWICS, it's not > > actually necessary now that you're stepping through the test. Nonetheless, > > this is a bug -- one that @DavidSpick

[Lldb-commits] [lldb] [lldb-dap] Add supported languages in package.json (PR #144414)

2025-06-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (DrSergei) Changes This patch fixes the [problem](https://github.com/llvm/llvm-project/issues/144239). It was caused by missing supported languages list in `package.json`. VSCode uses `guessDebugger` [function](https://github.com/mic

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-06-16 Thread Roman A via lldb-commits
https://github.com/GameRoMan created https://github.com/llvm/llvm-project/pull/144368 None >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of gram

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-06-16 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -189,262 +298,322 @@ def _read_packet_thread(self): while not done: packet = read_packet(self.recv, trace_file=self.trace_file) # `packet` will be `None` on EOF. We want to pass it down to -# handle_recv_packet anyw

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -10,17 +10,117 @@ import subprocess import signal import sys +from dataclasses import dataclass import threading import time -from typing import Any, Optional, Union, BinaryIO, TextIO +from typing import ( +IO, +Any, +Callable, +Dict, +List, +Option

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -152,35 +246,50 @@ def __init__( self.log_file = log_file self.send = send self.recv = recv -self.recv_packets: list[Optional[ProtocolMessage]] = [] -self.recv_condition = threading.Condition() -self.recv_thread = threading.Thr

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper commented: LGTM mostly just nits. https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr type and DMF integer calculation builtins (PR #142480)

2025-06-16 Thread Maryam Moghadas via lldb-commits
https://github.com/maryammo updated https://github.com/llvm/llvm-project/pull/142480 >From 5ef7a4ca7c2a838a6b2100968d5023e0797b2848 Mon Sep 17 00:00:00 2001 From: Maryam Moghadas Date: Mon, 2 Jun 2025 19:54:57 + Subject: [PATCH 1/3] [Clang][PowerPC] Add __dmr type and DMF integer calculati

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/143628 >From 42e664808a7bde374e5a1f2132d52636499bf4e6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 12 Jun 2025 16:33:55 -0700 Subject: [PATCH] [lldb] Add MCP support to LLDB https://discourse.llvm.

[Lldb-commits] [lldb] 539cf82 - [lldb-dap] Use structured types for stepInTargets request (#144072)

2025-06-16 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-16T19:24:59+01:00 New Revision: 539cf824259cbb23ccc68b83ef3cde575ca50842 URL: https://github.com/llvm/llvm-project/commit/539cf824259cbb23ccc68b83ef3cde575ca50842 DIFF: https://github.com/llvm/llvm-project/commit/539cf824259cbb23ccc68b83ef3cde575ca50842.diff L

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/144072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: - Added a CMake flag to disable building protocol servers at configuration time. - Added a link to the spec, settled on 2024-11-05 as that's what Claude Desktop supports right now and we weren't using anything from 2025-03-26. - Eliminated all threads except the one that

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,280 @@ +//===- ProtocolServerMCP.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/144364 >From 80f7d8b3ffd48a94414374518c022ba682fb7be1 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 16 Jun 2025 11:00:05 +0100 Subject: [PATCH 1/2] [lldb-dap] Fix source references The protocol expects that `

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-16 Thread Ebuka Ezike via lldb-commits
@@ -510,6 +510,25 @@ DAP::SendFormattedOutput(OutputType o, const char *format, ...) { o, llvm::StringRef(buffer, std::min(actual_length, sizeof(buffer; } +int32_t DAP::CreateSourceReference(lldb::addr_t address) { + auto iter = llvm::find(source_references, addre

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,72 @@ +//===- Tool.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/143628 >From 4d6de9076531ce66e0dc7aabaaba765a63c03e42 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 12 Jun 2025 16:33:55 -0700 Subject: [PATCH] [lldb] Add MCP support to LLDB https://discourse.llvm.

[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

2025-06-16 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > Is there a follow-up PR already up? Not yet, the original motivation is this issue on the Swift forums and more specifically this comment: https://forums.swift.org/t/lldb-crashes-during-vs-code-debug-session-on-windows-10/79902/10 `GetSDKPathFromDebugInfo` is not imple

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-16 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/144072 >From c4d909a9bb25983a955254956d3f0dab2ecc284f Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 12 Jun 2025 12:48:24 +0100 Subject: [PATCH 1/2] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-16 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! I look forward to trying this out and iterating on this. https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > 1. It seems to me the test binary `a.out` isn't running on the simulator > (doesn't appear in `platform process list`). Is this expected/intentional? I can definitely see the binary running: ``` jonas46758 0.0 0.0 410596000 22720 s000 SX2:43PM 0:00.

  1   2   >