[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/138698 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py `` Vie

[Lldb-commits] [lldb] 62385b8 - [lldb][docs] Correct spelling in debugging doc

2025-05-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-07T10:07:02Z New Revision: 62385b848757f2dc35070eadb2ccd921508497dc URL: https://github.com/llvm/llvm-project/commit/62385b848757f2dc35070eadb2ccd921508497dc DIFF: https://github.com/llvm/llvm-project/commit/62385b848757f2dc35070eadb2ccd921508497dc.diff LOG

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: (I see the failure on https://lab.llvm.org/buildbot/#/builders/197. I want to submit some additional logging code before I revert this.) https://github.com/llvm/llvm-project/pull/137978 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-07 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] 1815d62 - [lldb] Add more logging to a unit test

2025-05-07 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-05-07T16:11:09+02:00 New Revision: 1815d62d7c43455c55bfc1842e41a25ea04dcb9b URL: https://github.com/llvm/llvm-project/commit/1815d62d7c43455c55bfc1842e41a25ea04dcb9b DIFF: https://github.com/llvm/llvm-project/commit/1815d62d7c43455c55bfc1842e41a25ea04dcb9b.diff

[Lldb-commits] [lldb] [lldb-dap] Fix the package.json and format lldb-dap typescript. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/138918 >From 05b709033990e6cdfd7cb9fdbd7e8eab260e7a62 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 7 May 2025 10:46:55 -0700 Subject: [PATCH] [lldb-dap] Fix package.json after a bad merge. The package.json i

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: > @ashgti Hey John, do you mind splitting this patch? Sure, I'll make this fixing the package.json. > As for the package.json, do we have any tests that try to npm build? Should > we add them? I don't think they're run as part of the CI today. We could see if there is some way

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. Thanks @ashgti! https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/138925 I think the format checker isn't checking typescript files. I ran `npm run format` to fix the extenion typescript. >From 389bcb54b146ff707933146d561a272024f415fb Mon Sep 17 00:00:00 2001 From: John Harrison Dat

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes I think the format checker isn't checking typescript files. I ran `npm run format` to fix the extenion typescript. --- Full diff: https://github.com/llvm/llvm-project/pull/138925.diff 2 Files Affected: - (

[Lldb-commits] [lldb] bf59716 - [lldb-dap] Fix package.json after a bad merge. (#138918)

2025-05-07 Thread via lldb-commits
Author: John Harrison Date: 2025-05-07T10:55:11-07:00 New Revision: bf5971634a9244fd65c1bf8316b3d6ec407783ae URL: https://github.com/llvm/llvm-project/commit/bf5971634a9244fd65c1bf8316b3d6ec407783ae DIFF: https://github.com/llvm/llvm-project/commit/bf5971634a9244fd65c1bf8316b3d6ec407783ae.diff

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: FTR that test is skipped on darwin because _sigtramp in libc on aarch64 doesn't have any hand-supplied eh_frame right now :/ I have a test case put together, with a few functions written in assembly with hand-added cfi directives. It's probably darwin specific assembly, ob

[Lldb-commits] [clang] [lldb] [clang] Add support for `__ptrauth` being applied to integer types (PR #137580)

2025-05-07 Thread Oliver Hunt via lldb-commits
https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/137580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-05-07 Thread Dhruv Srivastava via lldb-commits
@@ -7,6 +7,9 @@ # CHECK: Stripped: false # CHECK: Type: executable # CHECK: Strata: unknown +# CHECK: Name: .text +# CHECK-NEXT: code +# CHECK-NEXT: r-x DhruvSrivastavaX wrote: Yes, I was a little hesitant to make it larger as other platform test cases are mu

[Lldb-commits] [lldb] df4eac2 - [lldb-dap] Temporarily disable the breakpoint tests

2025-05-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-07T23:08:51-07:00 New Revision: df4eac2f8b6d32772953d3d8063568fe4c0314c1 URL: https://github.com/llvm/llvm-project/commit/df4eac2f8b6d32772953d3d8063568fe4c0314c1 DIFF: https://github.com/llvm/llvm-project/commit/df4eac2f8b6d32772953d3d8063568fe4c0314c1.d

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138093 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -272,4 +272,204 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +lldb::ValueObjectSP +Interpreter::EvaluateMemberOf(lldb::ValueObjectSP value, + const std::vector

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: All the Linux and Windows buildbots are green, but GreenDragon is consistently failing with one of the breakpoint tests and it's not immediately obvious what the problem is. If I rerun the tests enough times, I can reproduce a failure locally. I've disabled those tests in d

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-07 Thread via lldb-commits
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + ConstString name) + : ASTNode(location, NodeKind::eMemberO

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Random example - `llvm/test/Analysis/BasicAA/separate_storage.ll`: ``` define i8 @simple_no(ptr %p1, ptr %p2) { ; CHECK-LABEL: @simple_no( ; CHECK-NEXT: entry: ; CHECK-NEXT:store i8 0, ptr [[P1:%.*]], align 1 ; CHECK-NEXT:store i8 1, ptr [[P2:%.*]], align 1 ; CHECK-N

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-07 Thread Pavel Labath via lldb-commits
@@ -24,6 +28,8 @@ qualified_id = ["::"] [nested_name_specifier] unqualified_id identifier = ? C99 Identifier ? ; +numeric_literal = ? C99 Integer constant ? ; labath wrote: I don't think you need to write the formal grammar. I'd be fine with just some text

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-07 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH] [lldb][AIX] get host info for AIX (cont..) --- lldb/sourc

[Lldb-commits] [lldb] [lldb] Fix block address resolution for functions in multiple sections (PR #137955)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137955 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-07 Thread Rahul Joshi via lldb-commits
jurahul wrote: Thanks @jpienaar. Given I have 2 approvals, will commit it today. https://github.com/llvm/llvm-project/pull/138174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: @DavidSpickett, I am confused by the error on this arm builder: https://lab.llvm.org/buildbot/#/builders/18/builds/15619 It says arm is not supported, but I think that error message is coming from [here](https://github.com/llvm/llvm-project/blob/3feb8b42e973f935883bc9e779645ecdae

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-07 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: Thank you for your patience! In general, I think adding a new qualifier to Clang needs to come with significant justification for the implementation and maintenance costs. In this specific case, those costs are somewhat amortized because we already have the `__ptrauth` qua

[Lldb-commits] [lldb] [lldb][DataFormatters] Change ExtractIndexFromString to return std::optional (PR #138297)

2025-05-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/138297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: As far as I can know, https://github.com/llvm/llvm-project/pull/138219 went onto main, so you can revert my revert to get that back. Then there was https://github.com/llvm/llvm-project/commit/69a0af35a5860156836e9e295ecef9de3474db11, which was later reverted in https://g

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've reverted this. Please take a look at the logs of https://lab.llvm.org/buildbot/#/builders/141/builds/8500 and see if any of it makes sense to you. We didn't have failures on Linux (though a lot of tests are disabled, they would be disabled everywhere) so my first ins

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: Thanks. > Probalby we can remove `#ifndef _WIN32` in > lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp, line 928 > too around `launch_info.AppendDuplicateFileAction((int)pass_comm_fd, > (int)pass_comm_fd);`. Indeed we should. In fact, that function is the reas

[Lldb-commits] [lldb] 18c5ad5 - [lldb] Fix block address resolution for functions in multiple sections (#137955)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T11:18:03+02:00 New Revision: 18c5ad5c6c178365d270439742863e14c8981ea3 URL: https://github.com/llvm/llvm-project/commit/18c5ad5c6c178365d270439742863e14c8981ea3 DIFF: https://github.com/llvm/llvm-project/commit/18c5ad5c6c178365d270439742863e14c8981ea3.diff

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Ebuka Ezike via lldb-commits
da-viper wrote: is there a branch tracking the reverted changes #138219, I have an old windows 10 pc i could use to reproduce it. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/138698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7c5f5f3 - [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:02:45+02:00 New Revision: 7c5f5f3ef83b1d1d43d63862a8431af3dded15bb URL: https://github.com/llvm/llvm-project/commit/7c5f5f3ef83b1d1d43d63862a8431af3dded15bb DIFF: https://github.com/llvm/llvm-project/commit/7c5f5f3ef83b1d1d43d63862a8431af3dded15bb.diff

[Lldb-commits] [lldb] 21501d1 - [lldb] Fix dynamic type resolutions for core files (#138698)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:02:21+02:00 New Revision: 21501d1cf290a63760904fb125e77b432db49933 URL: https://github.com/llvm/llvm-project/commit/21501d1cf290a63760904fb125e77b432db49933 DIFF: https://github.com/llvm/llvm-project/commit/21501d1cf290a63760904fb125e77b432db49933.diff

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-07 Thread Pavel Labath via lldb-commits
@@ -17,23 +17,32 @@ image show-unwind --cached true -n foo # CHECK: UNWIND PLANS for {{.*}}`foo # -# CHECK: Assembly language inspection UnwindPlan: -# CHECK-NEXT: This UnwindPlan originally sourced from assembly insn profiling -# CHECK-NEXT: This UnwindPlan is sourced fro

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d865f32 - [lldb] Parse DWARF CFI for discontinuous functions (#137006)

2025-05-07 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-07T15:04:22+02:00 New Revision: d865f32fe820f543f0a53bfeba08774f2c270589 URL: https://github.com/llvm/llvm-project/commit/d865f32fe820f543f0a53bfeba08774f2c270589 DIFF: https://github.com/llvm/llvm-project/commit/d865f32fe820f543f0a53bfeba08774f2c270589.diff

[Lldb-commits] [lldb] [lldb] Call Target::ClearAllLoadedSections earlier (PR #138892)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Minidump files contain explicit information about load addresses of modules, so it can load them itself. This works on other platforms, but fails on darwin because DynamicLoaderDarwin nukes the loaded module l

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Looking at the logs, the common theme appears to be that all the test binaries exit before they hit any breakpoints. My best guess as to why this is only happening on Windows is the way the dynamic loader there works. If that's the case, then it means that those tests are m

[Lldb-commits] [lldb] [lldb] Call Target::ClearAllLoadedSections earlier (PR #138892)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/138892 Minidump files contain explicit information about load addresses of modules, so it can load them itself. This works on other platforms, but fails on darwin because DynamicLoaderDarwin nukes the loaded module lis

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137155 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/137155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: This makes sense to me, but is there any way to write a test case for it? It sounds like something similar to [this test](https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/Unwind/signal-in-leaf-function-aarch64.test) could work. In fact, given that this test is disab

[Lldb-commits] [lldb] b643a52 - [lldb][debugserver] Add missing include to DNBTimer.h

2025-05-07 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-05-07T11:04:51+02:00 New Revision: b643a529dcd2b1b2e4e81c3be427edfcadc6d8fa URL: https://github.com/llvm/llvm-project/commit/b643a529dcd2b1b2e4e81c3be427edfcadc6d8fa DIFF: https://github.com/llvm/llvm-project/commit/b643a529dcd2b1b2e4e81c3be427edfcadc6d8fa.diff

[Lldb-commits] [lldb] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (PR #137978)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137978 >From 4eb94714ec3c8249fbccb10c2cfd29f8c45b9a07 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 9 Jan 2025 15:32:11 +0100 Subject: [PATCH 1/2] [lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Can we automate this with package.json? https://github.com/llvm/llvm-project/pull/138925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: I'm not sure, clang-format can format .json and .js/.ts files but I think the current config isn't applying it to those files. https://github.com/llvm/llvm-project/blob/main/llvm/utils/git/code-format-helper.py doesn't apply to those file extensions. We may be able to update tha

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/138909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix package.json after a bad merge. (PR #138918)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/138918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 47218ea - [lldb] Use -Wno-documentation-deprecated-sync if available (#138909)

2025-05-07 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-07T11:14:28-07:00 New Revision: 47218eadd8adf1926ced879caa50b8885d1b070d URL: https://github.com/llvm/llvm-project/commit/47218eadd8adf1926ced879caa50b8885d1b070d DIFF: https://github.com/llvm/llvm-project/commit/47218eadd8adf1926ced879caa50b8885d1b070d.diff L

[Lldb-commits] [lldb] Reapply "[lldb] Inherit DuplicateFileAction(HANDLE, HANDLE) handles on windows (#137978)" (PR #138896)

2025-05-07 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. I have tested the failed Host.LaunchProcessDuplicatesHandle test on the setup similar to [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197). It is fixed now. https://github.com/llvm/llvm-project/pull/138896 ___

[Lldb-commits] [lldb] 854b9e9 - [lldb-dap] Format extension typescript. (#138925)

2025-05-07 Thread via lldb-commits
Author: John Harrison Date: 2025-05-07T11:49:53-07:00 New Revision: 854b9e931703dd1b9d8a2b0fe8da787f9e26058d URL: https://github.com/llvm/llvm-project/commit/854b9e931703dd1b9d8a2b0fe8da787f9e26058d DIFF: https://github.com/llvm/llvm-project/commit/854b9e931703dd1b9d8a2b0fe8da787f9e26058d.diff

[Lldb-commits] [lldb] [lldb-dap] Format extension typescript. (PR #138925)

2025-05-07 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/138925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable flaky test_qThreadInfo_matches_qC_attach test on AArch64 Linux (PR #138940)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes See #138085 for details. https://lab.llvm.org/buildbot/#/builders/59/builds/16937 https://lab.llvm.org/buildbot/#/builders/59/builds/17224 --- Full diff: https://github.com/llvm/llvm-project/pull/138940.

[Lldb-commits] [lldb] [lldb][test] Disable flaky test_qThreadInfo_matches_qC_attach test on AArch64 Linux (PR #138940)

2025-05-07 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/138940 See #138085 for details. https://lab.llvm.org/buildbot/#/builders/59/builds/16937 https://lab.llvm.org/buildbot/#/builders/59/builds/17224 Rate limit · GitHub body {

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,94 @@ +LLDB RPC Upstreaming Design Doc +=== + +This document aims to explain the general structure of the upstreaming patches for adding LLDB RPC. The 2 primary concepts explained here will be: + +* How LLDB RPC is used +* How the ``lldb-rpc

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: > Why is that a bad thing? Can we do math operations later without types? Plus > it's a unified interface, node evaluation returns a `ValueObject`. > > > ... > > I mean... this works and is a basis for future patches, why remove something > that we will have to bring back shortl

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: >From what I've seen, this is a decent start but there are further issues to be >dealt with. Details on https://github.com/llvm/llvm-project/issues/138717. I have to work on some other SME changes first, so it will be a few weeks until I can do anything for this. @laverdet

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I am also not thrilled with the GetAsKind method for register numbering returning LLDB_INVALID_REGNUM, the code reads so poorly in this method because of it. But returning an optional would make other code more verbose unless I carried optionals through a lot further. I h

[Lldb-commits] [lldb] 47c7e73 - Revert "[lldb-dap] Change the launch sequence (#138219)"

2025-05-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-07T09:11:09Z New Revision: 47c7e73e5763f81f218cc4e1eae306d0427aa42d URL: https://github.com/llvm/llvm-project/commit/47c7e73e5763f81f218cc4e1eae306d0427aa42d DIFF: https://github.com/llvm/llvm-project/commit/47c7e73e5763f81f218cc4e1eae306d0427aa42d.diff LOG

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-05-07 Thread via lldb-commits
hapee wrote: Hi @JDevlieghere , I've corrected the typos. Could you please review my changes again? https://github.com/llvm/llvm-project/pull/137515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-07 Thread Pavel Labath via lldb-commits
@@ -280,6 +311,52 @@ void DILParser::BailOut(const std::string &error, uint32_t loc, m_dil_lexer.ResetTokenIdx(m_dil_lexer.NumLexedTokens() - 1); } +// Parse a numeric_literal. +// +// numeric_literal: +//? Token::numeric_constant ? +// +ASTNodeUP DILParser::ParseNumer

[Lldb-commits] [lldb] [lldb][DataFormatters] Change ExtractIndexFromString to return std::optional (PR #138297)

2025-05-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/138297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-05-07 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/131820 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] 1ad57b5 - [LLDB] Add IsCoreDumping to ProcessInstanceInfo (#138580)

2025-05-07 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-07T09:05:53-07:00 New Revision: 1ad57b58d6ba53be99bd6f2fa928a126c9deb91c URL: https://github.com/llvm/llvm-project/commit/1ad57b58d6ba53be99bd6f2fa928a126c9deb91c DIFF: https://github.com/llvm/llvm-project/commit/1ad57b58d6ba53be99bd6f2fa928a126c9deb91c.diff

[Lldb-commits] [lldb] [LLDB] Add IsCoreDumping to ProcessInstanceInfo (PR #138580)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/138580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-07 Thread John Harrison via lldb-commits
ashgti wrote: So, I was checking this and I see `lldb_dap::DAP::ResetDebuggerState() (/data/users/jeffreytan/llvm-sand/external/llvm-project/lldb/tools/lldb-dap/DAP.cpp:1411)` in the call stack. That function doesn't exist in the open source version of lldb-dap. I'm not sure what its doing bu

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/138551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/138698 >From 663db321027e05736344fe763a5473175f0c90f2 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 6 May 2025 16:35:01 +0200 Subject: [PATCH 1/2] [lldb] Fix dynamic type resolutions for core files We're readi

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-07 Thread Pavel Labath via lldb-commits
@@ -18,5 +20,18 @@ void HostInfoAIX::Terminate() { HostInfoBase::Terminate(); } FileSpec HostInfoAIX::GetProgramFileSpec() { static FileSpec g_program_filespec; + struct psinfo psinfoData; + auto BufferOrError = getProcFile(getpid(), "psinfo"); + if (BufferOrError) { +

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Pavel Labath via lldb-commits
labath wrote: Oh, it's [this one](https://github.com/llvm/llvm-project/blob/3feb8b42e973f935883bc9e779645ecdae1a586d/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp#L547). That makes more sense now. I'll skip the test on arm. Thanks for catching that. https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yep, called from AddThreadList: ``` #0 0xedfbe37c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/david.spickett/build-llvm-arm/local/lib/python3.10/dist-packages/lldb/_lldb.cpython-310-arm-linux-gnueabihf.so+0xdbe37c) #1 0xedfbca00 llvm::sys::RunS

[Lldb-commits] [lldb] 461ba2d - [lldb] XFAIL TestDynamicValue.py:test_from_core_file on arm(32)

2025-05-07 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-05-07T16:57:30+02:00 New Revision: 461ba2db5d15793d18a5c18ce417c30e335602cc URL: https://github.com/llvm/llvm-project/commit/461ba2db5d15793d18a5c18ce417c30e335602cc DIFF: https://github.com/llvm/llvm-project/commit/461ba2db5d15793d18a5c18ce417c30e335602cc.diff

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures (PR #138941)

2025-05-07 Thread Mikhail Zakharov via lldb-commits
https://github.com/real-mikhail created https://github.com/llvm/llvm-project/pull/138941 Original PR where test was introduced and improvements discussed: https://github.com/llvm/llvm-project/pull/129092#issuecomment-2855337004 Rate limit · GitHub body {

[Lldb-commits] [lldb] [lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures (PR #138941)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mikhail Zakharov (real-mikhail) Changes Original PR where test was introduced and improvements discussed: https://github.com/llvm/llvm-project/pull/129092#issuecomment-2855337004 --- Full diff: https://github.com/llvm/llvm-project/pull/138

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-05-07 Thread Mikhail Zakharov via lldb-commits
real-mikhail wrote: Thanks for the example and the link. I fixed test to work on both Windows-x86 and Windows-x64 and created new PR: https://github.com/llvm/llvm-project/pull/138941 https://github.com/llvm/llvm-project/pull/129092 ___ lldb-commits ma

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/138943 Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a problem,

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/138943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Add some buffer directories (PR #138943)

2025-05-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Add a generous amount of buffer directories. I found out some LLDB forks (internal and external) had custom ranges that could fail because we didn't pre-account for those. To prevent this from being a proble

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The following two tests are both setting breakpoints without stopping at entry, which means that we could have run past the breakpoint by the time it's set: ``` lldb-api :: tools/lldb-dap/completions/TestDAP_completions.py lldb-api :: tools/lldb-dap/startDebugging/TestDA

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Alex Langford via lldb-commits
@@ -16,6 +16,15 @@ if (CXX_SUPPORTS_DOCUMENTATION) PRIVATE -Wdocumentation) endif() +# Apply -Wno-documentation-deprecated-sync while we migrate away from +# report_fatal_error in llvm/include/llvm/Support/ErrorHandling.h +# and llvm/include/llvm/Support/Error.h. -

[Lldb-commits] [lldb] [lldb] Use -Wno-documentation-deprecated-sync if available (PR #138909)

2025-05-07 Thread Kazu Hirata via lldb-commits
@@ -16,6 +16,15 @@ if (CXX_SUPPORTS_DOCUMENTATION) PRIVATE -Wdocumentation) endif() +# Apply -Wno-documentation-deprecated-sync while we migrate away from +# report_fatal_error in llvm/include/llvm/Support/ErrorHandling.h +# and llvm/include/llvm/Support/Error.h. -

[Lldb-commits] [lldb] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (PR #138487)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138487 >From 780371cf111c97e2bce5f030625ff557bb2f40b6 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 4 May 2025 23:43:28 -0700 Subject: [PATCH 1/3] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous

[Lldb-commits] [lldb] 92d3029 - [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (#138487)

2025-05-07 Thread via lldb-commits
Author: cmtice Date: 2025-05-07T20:39:37-07:00 New Revision: 92d3029fa4a9c6ce21c50590e57ae834ae3db3bc URL: https://github.com/llvm/llvm-project/commit/92d3029fa4a9c6ce21c50590e57ae834ae3db3bc DIFF: https://github.com/llvm/llvm-project/commit/92d3029fa4a9c6ce21c50590e57ae834ae3db3bc.diff LOG: [

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I re-landed the launch sequence patch (aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd) and the Windows bots are happy again. Given that was the only objections, I'm going to merge this so we can get some insights overnight. As I said in the description, I expect the tests to be

[Lldb-commits] [lldb] [LLDB] Fix GetIndexOfChildMemberWithName to handle anonymous structs. (PR #138487)

2025-05-07 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/138487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] efce7a1 - [lldb-dap] Re-enable the lldb-dap tests (#138791)

2025-05-07 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-07T20:40:04-07:00 New Revision: efce7a169e58ec8b27d266ec4dfb851f85a7c6c2 URL: https://github.com/llvm/llvm-project/commit/efce7a169e58ec8b27d266ec4dfb851f85a7c6c2 DIFF: https://github.com/llvm/llvm-project/commit/efce7a169e58ec8b27d266ec4dfb851f85a7c6c2.d

[Lldb-commits] [lldb] [lldb] Change the statusline format to print "no target" (PR #139021)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/139021 >From fcd590a31f7b490f5fbc5996d9c5f2836ff4e7ee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 7 May 2025 21:20:47 -0700 Subject: [PATCH 1/2] [lldb] Change the statusline format to print "no tar

  1   2   >