[Lldb-commits] [lldb] 23c9cfc - [lldb] Small refactor of eh_frame parsing (#134806)

2025-04-11 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-11T09:27:56+02:00 New Revision: 23c9cfcb7494b2331a80661a0cb83f95a422833c URL: https://github.com/llvm/llvm-project/commit/23c9cfcb7494b2331a80661a0cb83f95a422833c DIFF: https://github.com/llvm/llvm-project/commit/23c9cfcb7494b2331a80661a0cb83f95a422833c.diff

[Lldb-commits] [lldb] [lldb] Small refactor of eh_frame parsing (PR #134806)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/134806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Format][NFCI] Refactor CPlusPlusLanguage::GetFunctionDisplayName into helpers and use LLVM style (PR #135331)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/135331 Same cleanup as in https://github.com/llvm/llvm-project/pull/135031. It pretty much is the same code that we had to duplicate in the language plugin. Maybe eventually we'll find a way of getting rid of the d

[Lldb-commits] [lldb] [lldb][Format][NFCI] Refactor CPlusPlusLanguage::GetFunctionDisplayName into helpers and use LLVM style (PR #135331)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Same cleanup as in https://github.com/llvm/llvm-project/pull/135031. It pretty much is the same code that we had to duplicate in the language plugin. Maybe eventually we'll find a way of getting rid of the

[Lldb-commits] [lldb] [lldb][Format][NFCI] Refactor CPlusPlusLanguage::GetFunctionDisplayName into helpers and use LLVM style (PR #135331)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/135331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (PR #135333)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is mainly useful for discontinuous functions because individual parts of the function will have separate FDE entries, which can begin many megabytes from the start of the function. However, I'm separating

[Lldb-commits] [lldb] [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (PR #135333)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -474,7 +474,7 @@ bool UnwindPlan::PlanValidAtAddress(Address addr) const { // If the 0th Row of unwind instructions is missing, or if it doesn't provide // a register to use to find the Canonical Frame Address, this is not a valid // UnwindPlan. - const Row *row0 = Ge

[Lldb-commits] [lldb] [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (PR #135333)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/135333 This is mainly useful for discontinuous functions because individual parts of the function will have separate FDE entries, which can begin many megabytes from the start of the function. However, I'm separating i

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135008 >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025 14:35:09 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] fix repeating commands in repl mode Fixes #1

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper milestoned https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: /cherry-pick 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e 4be5e33bf7b986e35808b83758e4a8d85b646a81 7417e79323c67ab478a0d41757ebb1679f4cb28c https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread via lldb-commits
llvmbot wrote: Failed to cherry-pick: 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e https://github.com/llvm/llvm-project/actions/runs/14400492146 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb][Format][NFCI] Refactor CPlusPlusLanguage::GetFunctionDisplayName into helpers and use LLVM style (PR #135331)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/135331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134626 >From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 10:24:02 +0100 Subject: [PATCH 1/3] [lldb] Fix SBTarget::ReadInstruction The disassemblyBytes par

[Lldb-commits] [lldb] b656915 - [lldb][Format][NFCI] Refactor CPlusPlusLanguage::GetFunctionDisplayName into helpers and use LLVM style (#135331)

2025-04-11 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-11T11:01:27+01:00 New Revision: b656915d5a4cbb35392d340142340bf9bef8d8d1 URL: https://github.com/llvm/llvm-project/commit/b656915d5a4cbb35392d340142340bf9bef8d8d1 DIFF: https://github.com/llvm/llvm-project/commit/b656915d5a4cbb35392d340142340bf9bef8d8d1.diff

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Pavel Labath via lldb-commits
labath wrote: I think this is a good idea. https://github.com/llvm/llvm-project/pull/135343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -122,7 +122,14 @@ constexpr Definition g_function_child_entries[] = { Definition("pc-offset", EntryType::FunctionPCOffset), Definition("initial-function", EntryType::FunctionInitial), Definition("changed", EntryType::FunctionChanged), -Definition("is-optimize

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,60 @@ +# Test the ${function.arguments} frame-format variable. labath wrote: Probably better to factor this according to the language dimension, since the objc parts will most likely need to be disabled on non-macosx. https://github.com/llvm/llvm-pr

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -208,6 +209,152 @@ static bool PrettyPrintFunctionNameWithArgs(Stream &out_stream, return true; } +static std::optional GetDemangledBasename(Function &function) { + auto demangled_name = function.GetName().GetStringRef(); + if (demangled_name.empty()) +return std:

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Just some drive-by comments. https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -208,6 +209,152 @@ static bool PrettyPrintFunctionNameWithArgs(Stream &out_stream, return true; } +static std::optional GetDemangledBasename(Function &function) { + auto demangled_name = function.GetName().GetStringRef(); + if (demangled_name.empty()) +return std:

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Pavel Labath via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/2] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #134757)

2025-04-11 Thread Pavel Labath via lldb-commits
labath wrote: I can see this too, and can reproduce it pretty much 100% of the time. The `GetRunLock` hypothesis seems believable because the process launching code (Process::LaunchPrivate) is mucking around with the private state thread. It's also possible this doesn't reproduce on darwin bec

[Lldb-commits] [lldb] [lldb] Remove vestigial remnants of reproducers (PR #135361)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Not touching the SB API. --- Full diff: https://github.com/llvm/llvm-project/pull/135361.diff 15 Files Affected: - (modified) lldb/include/lldb/API/SBReproducer.h (-6) - (modified) lldb/include/lldb/Core/De

[Lldb-commits] [lldb] [lldb] Remove vestigial remnants of reproducers (PR #135361)

2025-04-11 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/135361 Not touching the SB API. >From 092a72d271372030f530521dabb3559aebb306fe Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 11 Apr 2025 14:51:59 +0200 Subject: [PATCH] [lldb] Remove vestigial remnants of repr

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +""" +Test SBTarget Read Instruction. +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class TargetReadInstructionsFlavor(TestBase): +@skipIf(archs=no_match(["x86_64", "x86", "i386"]), oslist=["windows"])

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +""" +Test SBTarget Read Instruction. +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class TargetReadInstructionsFlavor(TestBase): +@skipIf(archs=no_match(["x86_64", "x86", "i386"]), oslist=["windows"])

[Lldb-commits] [lldb] 5b384c3 - [lldb][test] Adjust TestTargetReadInstructionsFlavor skipIfs

2025-04-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-11T13:14:16Z New Revision: 5b384c3015100ad815f4d994d7ef35cc947db711 URL: https://github.com/llvm/llvm-project/commit/5b384c3015100ad815f4d994d7ef35cc947db711 DIFF: https://github.com/llvm/llvm-project/commit/5b384c3015100ad815f4d994d7ef35cc947db711.diff LOG

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +""" +Test SBTarget Read Instruction. +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class TargetReadInstructionsFlavor(TestBase): +@skipIf(archs=no_match(["x86_64", "x86", "i386"]), oslist=["windows"])

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: separate it like this then it does not and it. ``` @skipIf(archs=no_match(["x86_64", "x86", "i386"])) @skipIfWindows ``` https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @DavidSpickett is there a way to run the merge build bot before merging to check if the test passes on other platforms ? https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: At this time no, it's a feature I'd like to have one day. My advice would have been to land it and see what happens :) Unless we had pre-commit Windows lldb, but I think right now it's only Linux and it gets disabled some times due to instability. It's fixed for AArch64 L

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Symbol/SymbolContext.h lldb/sourc

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-11 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: Thank you so much for your valuable feedback and suggestions. I have incorporated most of the requested changes, with just two remaining suggestions that I will address in a follow-up PR. 1. Moving to non-legacy approach to handle memoryWrite/memoryWrite. 2. Adding a utility

[Lldb-commits] [lldb] [lldb] Remove vestigial remnants of reproducers (PR #135361)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🪦 https://github.com/llvm/llvm-project/pull/135361 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 70627af - [lldb] Synchronize access to m_statusline in the Debugger (#134759)

2025-04-11 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-11T08:53:49-07:00 New Revision: 70627af91f577f5195a11ee44c6af39503e1ce52 URL: https://github.com/llvm/llvm-project/commit/70627af91f577f5195a11ee44c6af39503e1ce52 DIFF: https://github.com/llvm/llvm-project/commit/70627af91f577f5195a11ee44c6af39503e1ce52.d

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-11 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/129092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-11 Thread via lldb-commits
@@ -296,6 +296,9 @@ let Definition = "process" in { DefaultEnumValue<"eFollowParent">, EnumValues<"OptionEnumValues(g_follow_fork_mode_values)">, Desc<"Debugger's behavior upon fork or vfork.">; + def TrackMemoryCacheChanges: Property<"track-memory-cache-changes",

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-11 Thread via lldb-commits
@@ -1827,6 +1827,33 @@ class CommandObjectMultiwordProcessTrace : public CommandObjectMultiword { ~CommandObjectMultiwordProcessTrace() override = default; }; +// CommandObjectProcessDumpModificationId +class CommandObjectProcessDumpModificationId : public CommandObjectPars

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-11 Thread via lldb-commits
jimingham wrote: This looks pretty good to me. I had one trivial doc comment, and I think it's better not to start sprinkling internal debugging commands into the lldb command set. The debugger has enough commands already, I like to avoid adding ones that nobody but us will ever use. If we s

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
@@ -870,6 +870,16 @@ llvm::json::Value CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { return llvm::json::Value(std::move(object)); } +llvm::json::Array GetThreads(lldb::SBProcess process, lldb::SBFormat &format) { + llvm::json::Array threads; + const uint3

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
@@ -50,16 +50,22 @@ namespace lldb_dap { // } void ThreadsRequestHandler::operator()( const llvm::json::Object &request) const { - lldb::SBProcess process = dap.target.GetProcess(); llvm::json::Object response; FillResponse(request, response); - const uint32_t num

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
@@ -207,6 +207,9 @@ struct DAP { /// The set of features supported by the connected client. llvm::DenseSet clientFeatures; + /// The initial thread list upon attaching JDevlieghere wrote: ```suggestion /// The initial thread list upon attaching. ``` h

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/134339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Greg Clayton via lldb-commits
@@ -870,6 +870,16 @@ llvm::json::Value CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { return llvm::json::Value(std::move(object)); } +llvm::json::Array GetThreads(lldb::SBProcess process, lldb::SBFormat &format) { + llvm::json::Array threads; + const uint3

[Lldb-commits] [lldb] Revert "[lldb] Make sure the process is stopped when computing the symbol context (#134757)" (PR #135408)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/135408 This reverts commit e84a80408523a48d6eaacd795f1615e821ffb233 because on Linux there seems to be a race around GetRunLock. See #134757 for more context. >From 13689bce25a51d5054601b346b09c249afa31d3b Mon Se

[Lldb-commits] [lldb] Revert "[lldb] Make sure the process is stopped when computing the symbol context (#134757)" (PR #135408)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This reverts commit e84a80408523a48d6eaacd795f1615e821ffb233 because on Linux there seems to be a race around GetRunLock. See #134757 for more context. --- Full diff: https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Greg Clayton via lldb-commits
@@ -52,8 +64,14 @@ void ConfigurationDoneRequestHandler::operator()( dap.configuration_done_sent = true; if (dap.stop_at_entry) SendThreadStoppedEvent(dap); - else + else { +// Client requests the baseline of currently existing threads after +// a successful l

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread Greg Clayton via lldb-commits
@@ -870,6 +870,16 @@ llvm::json::Value CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { return llvm::json::Value(std::move(object)); } +llvm::json::Array GetThreads(lldb::SBProcess process, lldb::SBFormat &format) { + llvm::json::Array threads; + const uint3

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/5] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-11 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Yes, that is a more appropriate place to do that work. https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #134757)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I put up a revert in #135408. I'm going to see if I can reproduce this myself on Linux. I want to see what happens if the statusline uses the public API mutex, I don't think it needs the private one at all. If I can't reproduce I might ask one of you to try out a small patc

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-11 Thread via lldb-commits
@@ -18,6 +18,22 @@ namespace lldb_private::dil { +static lldb::ValueObjectSP +ArrayToPointerConversion(lldb::ValueObjectSP valobj, + std::shared_ptr ctx) { + assert(valobj->IsArrayType() && + "an argument to array-to-pointer conversion must be

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #134757)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I assume something else changed in the meantime (maybe the extra locking added in #134759?) but now if I revert this change I always crash on `run`: ``` * thread #51, name = '', stop reason = EXC_BAD_ACCESS (code=1, address=0xfffed77f38f8) frame #0: 0x00011332b6

[Lldb-commits] [lldb] 68ab45f - Revert "[lldb] ProcessGdbRemote header gardning"

2025-04-11 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-11T10:44:43-07:00 New Revision: 68ab45f0533f3bbfc1c96bddd53de7e769180219 URL: https://github.com/llvm/llvm-project/commit/68ab45f0533f3bbfc1c96bddd53de7e769180219 DIFF: https://github.com/llvm/llvm-project/commit/68ab45f0533f3bbfc1c96bddd53de7e769180219.d

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Paul Kirth via lldb-commits
ilovepi wrote: I think we're seeing this persist on x86_64 mac bots https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/lldb-mac-x64/b8717871333718166241/infra I'm not sure what the right spelling is to opt out.. I think @DavidSpickett's original suggestion may work better if we need to

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Macos x86_64 also follows the systemV amd64 abi calling convention. So it should not fail or be skipped. In the linked build bot, I could not see the test (lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py) failing could you link it j

[Lldb-commits] [lldb] [lldb] Clean up StartDebugserverProcess before I start refactoring it (PR #135342)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/135342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-11 Thread via lldb-commits
https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c2939b9 - Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (#135296)

2025-04-11 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-11T11:46:22-07:00 New Revision: c2939b9bf672713ac36910a3e6d00c19ace1bd44 URL: https://github.com/llvm/llvm-project/commit/c2939b9bf672713ac36910a3e6d00c19ace1bd44 DIFF: https://github.com/llvm/llvm-project/commit/c2939b9bf672713ac36910a3e6d00c19a

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-11 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 179d30f - Revert "[lldb] Make sure the process is stopped when computing the symbol context (#134757)" (#135408)

2025-04-11 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-11T11:50:42-07:00 New Revision: 179d30f8c3fddd3c85056fd2b8e877a4a8513158 URL: https://github.com/llvm/llvm-project/commit/179d30f8c3fddd3c85056fd2b8e877a4a8513158 DIFF: https://github.com/llvm/llvm-project/commit/179d30f8c3fddd3c85056fd2b8e877a4a8513158.d

[Lldb-commits] [lldb] Revert "[lldb] Make sure the process is stopped when computing the symbol context (#134757)" (PR #135408)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clean up StartDebugserverProcess before I start refactoring it (PR #135342)

2025-04-11 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM, thanks. Currently `GDBRemoteCommunication::ListenThread()` to get the bound port is weird. https://github.com/llvm/llvm-project/pull/135342 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/6] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-11 Thread Paul Kirth via lldb-commits
ilovepi wrote: @da-viper Ah, shoot. Sorry for the noise, I think it may have been https://github.com/llvm/llvm-project/commit/2fd860c1f559c0b0be66cc000e38270a04d0a1a3, which was just reverted. thanks for taking a look. :) https://github.com/llvm/llvm-project/pull/134626 ___

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/7] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-11 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From 0c4f6ca21ba6ae37e3a884f4bcc356b6f741ede7 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/3] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: @eaeltsin speculative fix here, but can you try with this patch? https://github.com/llvm/llvm-project/pull/135434 https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From c03108499d3e33b67846f6360ba71270b4139915 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/3] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-11 Thread via lldb-commits
@@ -52,8 +64,14 @@ void ConfigurationDoneRequestHandler::operator()( dap.configuration_done_sent = true; if (dap.stop_at_entry) SendThreadStoppedEvent(dap); - else + else { +// Client requests the baseline of currently existing threads after +// a successful l

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/9] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/8] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [lldb] 715c61e - [lldb][lldbp-dap] On Windoows, silence warnings when building with MSVC

2025-04-11 Thread Alexandre Ganea via lldb-commits
Author: Alexandre Ganea Date: 2025-04-11T17:50:15-04:00 New Revision: 715c61e9a7cc631fd0965b887941ccfd8c0133d6 URL: https://github.com/llvm/llvm-project/commit/715c61e9a7cc631fd0965b887941ccfd8c0133d6 DIFF: https://github.com/llvm/llvm-project/commit/715c61e9a7cc631fd0965b887941ccfd8c0133d6.dif

[Lldb-commits] [lldb] 84ed81b - [lldb] On Windows, silence warning when building with Clang ToT

2025-04-11 Thread Alexandre Ganea via lldb-commits
Author: Alexandre Ganea Date: 2025-04-11T17:49:26-04:00 New Revision: 84ed81bc8a5359f33818c876e43f6450e98deb35 URL: https://github.com/llvm/llvm-project/commit/84ed81bc8a5359f33818c876e43f6450e98deb35 DIFF: https://github.com/llvm/llvm-project/commit/84ed81bc8a5359f33818c876e43f6450e98deb35.dif

[Lldb-commits] [lldb] e1d91ba - [lldb] Fix erroneous return value

2025-04-11 Thread Alexandre Ganea via lldb-commits
Author: Alexandre Ganea Date: 2025-04-11T17:50:15-04:00 New Revision: e1d91ba06d250dd8bbd5bded4824c5b210c2667a URL: https://github.com/llvm/llvm-project/commit/e1d91ba06d250dd8bbd5bded4824c5b210c2667a DIFF: https://github.com/llvm/llvm-project/commit/e1d91ba06d250dd8bbd5bded4824c5b210c2667a.dif

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread via lldb-commits
eaeltsin wrote: Memory Sanitizer complains about initialized value [here](https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Serialization/ASTReader.h#L2438) Will try the patch now. https://github.com/llvm/llvm-project/pull/132401 ___

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread via lldb-commits
eaeltsin wrote: @mizvekov - no, the patch doesn't help, or I did something wrong. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Do you have a backtrace of that uninitialized read? https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Format] Display only the inlined frame name in backtraces if available (PR #135343)

2025-04-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/135343 >From 7d8455bd0b30ee5cd49788243646e75ae8938159 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 11 Apr 2025 11:02:19 +0100 Subject: [PATCH 1/9] [lldb][Format] Only display inlined frame name in backtra

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Okay, if the problem is an uninitialized source location somewhere, then that patch doesn't help at all. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread via lldb-commits
eaeltsin wrote: Well, to be honest, I'm not completely sure these are the same problems, these are just sanitizer finding for the same compilation. Here is the [MSan finding](https://gist.github.com/eaeltsin/834192fe5d8bbbc061e1488f113e34e1). Please note my source is somewhat behind the head,

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-11 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Thanks for that stack trace, could be unrelated to this, but that still helped find a bug: https://github.com/llvm/llvm-project/pull/135450 https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/135455 I traced the issue reported by Caroline and Pavel in #134757 back to the call to ProcessRunLock::TrySetRunning. When that fails, we get a somewhat misleading error message: > process resume at entry point

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes I traced the issue reported by Caroline and Pavel in #134757 back to the call to ProcessRunLock::TrySetRunning. When that fails, we get a somewhat misleading error message: > process resume at entr

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread via lldb-commits
@@ -29,8 +29,13 @@ class ProcessRunLock { bool ReadTryLock(); bool ReadUnlock(); + + /// Set the process to running. Returns true if the process was stopped. + /// Return true if the process was running. jimingham wrote: One of those two `true`'s has to

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread via lldb-commits
@@ -1325,9 +1323,9 @@ void Process::SetPublicState(StateType new_state, bool restarted) { Status Process::Resume() { Log *log(GetLog(LLDBLog::State | LLDBLog::Process)); LLDB_LOGF(log, "(plugin = %s) -- locking run lock", GetPluginName().data()); - if (!m_public_run_lock.

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread via lldb-commits
jimingham wrote: This looks good to me, but we've discussed this already so I'm a prejudiced judge. We should maybe wait on a second opinion... https://github.com/llvm/llvm-project/pull/135455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Remove ProcessRunLock::TrySetRunning (PR #135455)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/135455 >From b1416c5e13207eaa56985c84e9c2ac74db6a4d2b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 11 Apr 2025 22:48:44 + Subject: [PATCH 1/2] [lldb] Remove ProcessRunLock::TrySetRunning I trac

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #135458)

2025-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/135458 Make sure the process is stopped when computing the symbol context. Both Adrian and Felipe reported a handful of crashes in GetSymbolContext called from Statusline::Redraw on the default event thread. Given

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #135458)

2025-04-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Make sure the process is stopped when computing the symbol context. Both Adrian and Felipe reported a handful of crashes in GetSymbolContext called from Statusline::Redraw on the default event thread.

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-11 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/7] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-11 Thread David Peixotto via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-11 Thread David Peixotto via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-11 Thread David Peixotto via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

  1   2   >