================
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef 
&format_str,
   return parent;
 }
 
+/// Parses a single highlighting format specifier.
+///
+/// Example syntax for such specifier:
+/// \code
+/// ${function.name-with-args:%highlight_basename(ansi.fg.green)}
----------------
Michael137 wrote:

> Does the setting affect the format of the whole frame, or just the function 
> name. Because if it's the latter (which I also think would be a better 
> design), then it probably should be called something else... function-format, 
> function-name-format, ... ?

Yup it just affects the function name. I renamed it to `function-name-format`

> Shouldn't that be plugin.language.cplusplus.frame-format?

That would've been my preferred order too. But currently the setting names for 
plugins are derived as:
```
plugin.<plugin name>.<setting name>.<property>
```
For `CPlusPlusLanguage`, the plugin name is `cplusplus`. So i decided to call 
the settings for it `language` (for the lack of a better settings name). Any 
suggestions for what the `<setting name>` should be here?

https://github.com/llvm/llvm-project/pull/131836
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to