[Lldb-commits] [lldb] [lldb] Fix intel trace plugin tests (PR #133826)

2025-04-05 Thread David Peixotto via lldb-commits
dmpots wrote: Here are the relevant test result changes for this change. Trace Hardware Unsupported == Before --- -- Testing: 11 tests, 11 workers -- Unresolved Tests (7): lldb-api :: commands/trace/TestTraceDumpFunctionCalls.py lldb-api :: commands/trace/

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,104 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Prefer PointerType::get with LLVMContext over Type (NFC) (PR #133869)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mats Jun Larsen (junlarsen) Changes Part of #123569 --- Full diff: https://github.com/llvm/llvm-project/pull/133869.diff 2 Files Affected: - (modified) lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.cpp (+2-2) - (modified)

[Lldb-commits] [lldb] d4b586a - [LLDB][NFC] Fix typo in docs (#131388)

2025-04-05 Thread via lldb-commits
Author: Kon Date: 2025-03-20T09:19:33+01:00 New Revision: d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb URL: https://github.com/llvm/llvm-project/commit/d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb DIFF: https://github.com/llvm/llvm-project/commit/d4b586ad95d7a2d13e49c5e9cee8c5d6611efccb.diff LOG: [LLD

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-05 Thread Pavel Labath via lldb-commits
labath wrote: > > Global variables are > > [banned](https://llvm.org/docs/CodingStandards.html#do-not-use-static-constructors) > > by the coding standards, but I wouldn't be surprised if there were still > > some around that cause this. > > TypeSystemClang.cpp contains global `char TypeSystem

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -107,6 +107,10 @@ def read_packet_thread(vs_comm, log_file): # termination of lldb-dap and stop waiting for new packets. done = not vs_comm.handle_recv_packet(packet) finally: +# Wait for the process to fully exit before dumping the log fi

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -36,18 +36,19 @@ class FuncUnwinders { ~FuncUnwinders(); - lldb::UnwindPlanSP GetUnwindPlanAtCallSite(Target &target, Thread &thread); + std::shared_ptr GetUnwindPlanAtCallSite(Target &target, JDevlieghere wrote: Makes sense. > One idea I have had th

[Lldb-commits] [lldb] 51c2750 - [lldb] Update examples in docs/use/python-reference.rst to work with Python 3 (#134204)

2025-04-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-03T07:40:00-07:00 New Revision: 51c2750599d2472dafce0231aa8b95f5137c7de8 URL: https://github.com/llvm/llvm-project/commit/51c2750599d2472dafce0231aa8b95f5137c7de8 DIFF: https://github.com/llvm/llvm-project/commit/51c2750599d2472dafce0231aa8b95f5137c7de8.d

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self): self.runCmd("target create {}".format(self.getBuildArtifact("a.out"))) self.expect("run", substrs=["unable to launch a GDB server on"], error=True) + +@skipIfRemote +@skipUnlessPlatf

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-04-05 Thread via lldb-commits
jimingham wrote: I don't think it's necessary to turn off stepping past hidden frames with this patch. You need to get the ThreadPlanStepInRange's SetDefaultFlags to add eStepOutPastHiddenFunctions by or-ing that into the ThreadPlanStepInRange::s_default_flag_values. That will handle the cas

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-04-05 Thread Paul Kirth via lldb-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s ilovepi wrote: Lets move this down w/ the HTML FileChe

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-04-05 Thread Pavel Labath via lldb-commits
labath wrote: I've skipped them (I hope) with 6d38dbf6eb56fd2b3399565af455de96a99ffa0f. @rocallahan, it seems the only way to extract information from these bots is to commit PRs. Let me know what kind of information would help you and I'll try to find a way to get the test to do that. https:

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-04-05 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/131683 >From 6d9b82be9fc681f25967a57a5c23148f3d023022 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 17 Mar 2025 23:54:30 + Subject: [PATCH 1/5] [lldb] Add JSON serialization for FileSpec and FileSpecList

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "Reland: [clang] preserve class type sugar when taking pointer to member" (PR #132280)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Matheus Izvekov (mizvekov) Changes Reverts llvm/llvm-project#132234 Needs to be reverted due to dependency. This blocks reverting another PR, see here: https://github.com/llvm/llvm-project/pull/131965#issuecomment-2741619498

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > `test_platform_process_launch_gdb_server` is worth looking into. hm, seems useful. do you think it makes sense to just modify it to run through a symlink, e.g. ``` diff --git a/lldb/test/API/commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py b/ll

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-05 Thread Karl Traunmüller via lldb-commits
ktraunmueller wrote: Famous last words, haha https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix prologue size calculation for discontinuous functions (PR #131597)

2025-04-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/6462 Here is the relevant piece

[Lldb-commits] [lldb] [LLDB][NFC]Refactor common test setup into SetUp method (PR #131203)

2025-04-05 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/131203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134184 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add enable/disable api for SystemRuntime plugins (PR #133794)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This change LGTM. Are you able to share the motivation behind wanting to enable/disable plugins at runtime? I added support for disabling plugins at configuration/build time and at the time @labath had concerns about that as variou

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-05 Thread Pavel Labath via lldb-commits
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self): self.runCmd("target create {}".format(self.getBuildArtifact("a.out"))) self.expect("run", substrs=["unable to launch a GDB server on"], error=True) + +@skipIfRemote +@skipUnlessPlatf

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-05 Thread Robert O'Callahan via lldb-commits
@@ -744,6 +744,10 @@ let Command = "process continue" in { Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to, temporarily " "ignoring other breakpoints. Can be specified more than once. " "The continue action will be done synchronously if this o

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes debugserver isn't saving and restoring the SVE/SME register state around inferior function calls. Making arbitrary function calls while in Streaming SVE mode is generally a poor idea because a NEON ins

[Lldb-commits] [lldb] d7afafd - [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (#133247)

2025-04-05 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-02T12:48:57+02:00 New Revision: d7afafdbc464e65c56a0a1d77bad426aa7538306 URL: https://github.com/llvm/llvm-project/commit/d7afafdbc464e65c56a0a1d77bad426aa7538306 DIFF: https://github.com/llvm/llvm-project/commit/d7afafdbc464e65c56a0a1d77bad426aa7538306.diff

[Lldb-commits] [lldb] Fix the incorrect reporting of dwarf5 .debug_names index time during partial indexing (PR #134133)

2025-04-05 Thread David Peixotto via lldb-commits
@@ -65,6 +65,10 @@ class DebugNamesDWARFIndex : public DWARFIndex { void GetFunctions(const RegularExpression ®ex, llvm::function_ref callback) override; + StatsDuration::Duration GetIndexTime() override { +return m_fallback.GetIndexTime(); -

[Lldb-commits] [lldb] fcead25 - [lldb] Fix building with GCC without asserts

2025-04-05 Thread Martin Storsjö via lldb-commits
Author: Martin Storsjö Date: 2025-04-05T16:55:36+03:00 New Revision: fcead25550bb727215919ecf2dfad17765223c19 URL: https://github.com/llvm/llvm-project/commit/fcead25550bb727215919ecf2dfad17765223c19 DIFF: https://github.com/llvm/llvm-project/commit/fcead25550bb727215919ecf2dfad17765223c19.diff

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-04-05 Thread John Harrison via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb-dap] Swapping to not use FLAG_ENUM and just defining typed enums. (PR #133622)

2025-04-05 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/133622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use *Set::insert_range and a range constructor (NFC) (PR #133548)

2025-04-05 Thread Jakub Kuderski via lldb-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

2025-04-05 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/133299 This reverts commit d7cea2b18717f0cc31b7da4a03f772d89ee201db. It causes crashes in API tests. >From 4139d0625afed999878ff26bd86e61c873beb29f Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Thu, 27 Mar

[Lldb-commits] [lldb] [lldb-dap] Add progress events to the packet list (PR #134157)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @Jlalond changed the approach and the description. Please take another look. https://github.com/llvm/llvm-project/pull/134157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] a19c018 - Revert "[lldb][debugserver] Save and restore the SVE/SME register state (#134184)"

2025-04-05 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-02T23:01:51-07:00 New Revision: a19c018379a1d08eceb5db533a19a6bf37423975 URL: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975 DIFF: https://github.com/llvm/llvm-project/commit/a19c018379a1d08eceb5db533a19a6bf37423975.diff

[Lldb-commits] [lldb] [lldb] Fix use-after-free in SBMutexTest (PR #133840)

2025-04-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The `locked` variable can be accessed from the asynchronous thread until the call to f.wait() completes. However, the variable is scoped in a lexical block that ends before that, leading to a use-af

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread John Harrison via lldb-commits
@@ -0,0 +1,33 @@ +//===-- DAPError.h ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-04-05 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Sure, Thanks. I have modified my test case for this one. Please let me know your comments. @labath https://github.com/llvm/llvm-project/pull/131304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb] Update examples in docs/use/python-reference.rst to work with Python 3 (PR #134204)

2025-04-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-04-05 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,33 @@ +//===-- DAPError.h ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-05 Thread Jonas Devlieghere via lldb-commits
@@ -808,85 +808,35 @@ bool Process::HandleProcessStateChangedEvent( std::lock_guard guard(thread_list.GetMutex()); ThreadSP curr_thread(thread_list.GetSelectedThread()); -ThreadSP thread; -StopReason curr_thread_stop_reason = eStopReasonInvalid;

[Lldb-commits] [lldb] e6e8252 - [lldb][AIX] Minor AIX specific changes (#132718)

2025-04-05 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2025-03-25T15:16:23+05:30 New Revision: e6e8252ba0a090d3a43f9df88214b415f9bb4e77 URL: https://github.com/llvm/llvm-project/commit/e6e8252ba0a090d3a43f9df88214b415f9bb4e77 DIFF: https://github.com/llvm/llvm-project/commit/e6e8252ba0a090d3a43f9df88214b415f9bb4e77.di

<    1   2