jimingham wrote:

I don't think it's necessary to turn off stepping past hidden frames with this 
patch.  You need to get the ThreadPlanStepInRange's SetDefaultFlags to add 
eStepOutPastHiddenFunctions by or-ing that into the 
ThreadPlanStepInRange::s_default_flag_values.  That will handle the case where 
we step in through a hidden function, decide we aren't interested in stopping 
there and step back out again.

Regular user level step-out's will use QueueThreadPlanForStepOut, not the 
NoShouldStop version.  So they will always set the flags to the 
ThreadPlanStepOut::s_default_flags, though maybe that should be 

eStepOutPastHiddenFunctions | eStepOutPastThunks

https://github.com/llvm/llvm-project/pull/131800
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to