https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/130202
Updating the naming and adding documentation to better follow the style guide.
>From a0e065631c5cd071ccf371aa647dd206a99b4054 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 7 Mar 2025 00:13:53 +0100
Sub
@@ -0,0 +1,52 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+import { ChildProcessWithoutNullStreams, spawn } from "child_process";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override sp
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/130202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
I adopted the synchronization scheme that we do in other attach tests -- the
python provides a filename that the inferior should create with its pid, we
launch it and wait until that file exists (indicating that the inferior is done
setting up) and then the python tests exe
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/13] add a process picker for attaching by PID
---
l
Jlalond wrote:
@clayborg These are those docstring cleanups I pinged you about
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Attached are some images of docstrings I'm cleaning up (I also made the mess
:P).
SBSaveCore formatting breaks on the newline
SBProgress has quote blocks instead of just a code block
![imag
@@ -348,6 +351,71 @@ llvm::json::Value toJSON(const ExitedEventBody &);
// MARK: Requests
+// "CancelRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `cancel` request is used by the client in two
+//
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/130202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +38,7 @@ Expected OutputRedirector::GetWriteFileDescriptor() {
return m_fd;
}
-Error OutputRedirector::RedirectTo(std::FILE *file_override,
+Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
ashgti wrote:
Sorry for the churn, I saw I brok
@@ -857,29 +819,112 @@ lldb::SBError DAP::Disconnect(bool terminateDebuggee) {
return error;
}
+template
+static std::optional getArgumentsIfRequest(const protocol::Message &pm,
+ llvm::StringLiteral command) {
+ auto *const req
@@ -1526,7 +1526,8 @@ static void addStatistic(lldb::SBTarget &target,
llvm::json::Object &event) {
const char *key = keys.GetStringAtIndex(i);
FilterAndGetValueForKey(statistics, key, stats_body);
}
- event.try_emplace("statistics", std::move(stats_body));
+ llvm:
https://github.com/vogelsgesang approved this pull request.
LGTM
Side note: Please don't amend your commits, but rather push multiple separate
commits into your PR. That way, I can see the diff compared to the version
which I previously reviewed
https://github.com/llvm/llvm-project/pull/13002
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/12] add a process picker for attaching by PID
---
l
@@ -27,9 +28,14 @@ export class LinuxProcessTree extends BaseProcessTree {
return;
}
+ const command = line.slice(commandOffset, argumentsOffset).trim();
+ if (command === "-") {
matthewbastien wrote:
Added the comment. When `ps` doesn
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,19 @@
+C_SOURCES := main.c
+LD_EXTRAS = -Wl,-rpath "-Wl,$(shell pwd)" -L. -lno-nlists -lhas-nlists
+
+.PHONY: build-libno-nlists build-libhas-nlists
+all: build-libno-nlists build-libhas-nlists a.out
+
+include Makefile.rules
+
+build-libno-nlists: no-nlists.c no-nlist-
@@ -0,0 +1,152 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
matthewbastien wrote:
Fixed.
https://github.com/llvm/llvm-project/pull/128943
___
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
+process at the start of the debug session instead of setting the pid manually:
+
+```javascript
+{
+ "type
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -27,9 +28,14 @@ export class LinuxProcessTree extends BaseProcessTree {
return;
}
+ const command = line.slice(commandOffset, argumentsOffset).trim();
+ if (command === "-") {
vogelsgesang wrote:
when would command be `-`? Please ad
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +38,7 @@ Expected OutputRedirector::GetWriteFileDescriptor() {
return m_fd;
}
-Error OutputRedirector::RedirectTo(std::FILE *file_override,
+Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
JDevlieghere wrote:
Yeah no worries. Thanks for
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/14] add a process picker for attaching by PID
---
l
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/15] add a process picker for attaching by PID
---
l
@@ -67,7 +67,7 @@ static Status ReadExpected(IOObjectSP &descriptor,
llvm::StringRef expected) {
if (status.Fail())
return status;
if (expected != result) {
-return Status::FromErrorStringWithFormatv("expected %s, got %s", expected,
+return Status::FromErrorStr
https://github.com/JDevlieghere approved this pull request.
LGTM. I think you could simplify the test even further by using C++ but on the
other hand the C tests compile a little faster.
```
std::ofstream pid_file;
pid_file.open (pid_file_path);
pid_file << getpid();
pid_file.close();
```
htt
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> LGTM. I think you could simplify the test even further by using C++ but on
> the other hand the C tests compile a little faster.
yeah I was going to rewrite it into slightly nicer C but then I realized there
was more value in doing it exactly the same as the other test t
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/16] add a process picker for attaching by PID
---
l
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/129967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/130209
where it can overflow a 2GB offset by just a little bit by applying a heuristic.
rdar://145888306
>From a6caecd1e1bae614579783ac1952e999eae5959d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 6
@@ -0,0 +1,48 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override getCommand(): string {
+return "PowerShell";
+ }
+
+ protected overr
https://github.com/JDevlieghere commented:
Could you also update `docs/use/symbolfilejson.rst`? Doesn't need to be in this
PR.
https://github.com/llvm/llvm-project/pull/129916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
Author: Michael Buch
Date: 2025-03-07T07:09:18Z
New Revision: 39a4da20d88d797824f0e7be0f732ccaf0c7eee4
URL:
https://github.com/llvm/llvm-project/commit/39a4da20d88d797824f0e7be0f732ccaf0c7eee4
DIFF:
https://github.com/llvm/llvm-project/commit/39a4da20d88d797824f0e7be0f732ccaf0c7eee4.diff
LOG:
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/22] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
@@ -66,6 +80,52 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ /// If the command is/can be associated with a target
Author: Jason Molenda
Date: 2025-03-06T17:19:43-08:00
New Revision: cec36e279cb871dd011e105e0c9d3edccd0dcad9
URL:
https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9
DIFF:
https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9.diff
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129605
>From 6c8f3ee0b033917213c802ddd978c63f8947616b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 3 Mar 2025 15:12:29 -0800
Subject: [PATCH 1/2] Drop markdown backticks for codeblock
---
lldb/bindings/int
Author: Jacob Lalonde
Date: 2025-03-06T18:57:54-08:00
New Revision: 5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff
URL:
https://github.com/llvm/llvm-project/commit/5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff
DIFF:
https://github.com/llvm/llvm-project/commit/5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff.diff
Author: Adrian Prantl
Date: 2025-03-06T17:15:49-08:00
New Revision: ca0850f916a75a16264798fe7b7be08fdb892c97
URL:
https://github.com/llvm/llvm-project/commit/ca0850f916a75a16264798fe7b7be08fdb892c97
DIFF:
https://github.com/llvm/llvm-project/commit/ca0850f916a75a16264798fe7b7be08fdb892c97.diff
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From 0b7cc855990aad5d4b9b9beb2726e4b0ac5a3755 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
@@ -0,0 +1,16 @@
+import { ChildProcessWithoutNullStreams, spawn } from "child_process";
+import { LinuxProcessTree } from "./linux-process-tree";
+
+function fill(prefix: string, suffix: string, length: number): string {
matthewbastien wrote:
Thanks! I didn't kn
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/23] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> Is there a way we can use the LLDB platform layer to pick processes?
See discussion further up in the thread ([first
comment](https://github.com/llvm/llvm-project/pull/128943#issuecomment-2686308012)
and follow-up messages). It seems the [final
blocker](https://github.co
@@ -65,6 +65,19 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:PickProcess}` to select a
+process at the start of the debug session instead of setting the pid manually:
+
+```javascript
+{
+ "type
https://github.com/mpark converted_to_draft
https://github.com/llvm/llvm-project/pull/129982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
@@ -0,0 +1,48 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override getCommand(): string {
+return "PowerShell";
+ }
+
+ protected overr
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/128943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2025-03-06T17:03:16-08:00
New Revision: 00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977
URL:
https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977
DIFF:
https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977.diff
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/21306
Here is the relevant piece of th
jasonmolenda wrote:
FTR on the CI bot my API test did not make correctly. I reverted the PR,
rewrote the makefiles for the API test, relanded.
https://github.com/llvm/llvm-project/pull/129967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -838,19 +775,16 @@ llvm::Error DAP::Loop() {
StopEventHandlers();
});
while (!disconnecting) {
-llvm::json::Object object;
-lldb_dap::PacketStatus status = GetNextObject(object);
-
-if (status == lldb_dap::PacketStatus::EndOfFile) {
- break;
-}
-
@@ -219,65 +220,27 @@ void DAP::StopEventHandlers() {
}
}
-// Send the JSON in "json_str" to the "out" stream. Correctly send the
-// "Content-Length:" field followed by the length, followed by the raw
-// JSON bytes.
-void DAP::SendJSON(const std::string &json_str) {
- out
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere commented:
I left some small comments but but overall I really like this approach.
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -693,7 +690,14 @@ bool fromJSON(const llvm::json::Value &value,
o.map("address", section.address) && o.map("size", section.size) &&
o.map("read", section.read) && o.map("write", section.write) &&
o.map("execute", section.execute) &&
- o.map
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/129916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/128943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,56 @@
+//===-- Transport.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
SuibianP wrote:
Hi @ashgti, pinging just in case GitHub had its notification fall through the
cracks again :)
I have left several possibly debatable review chains open for your kind
attention, and would appreciate instructions on next steps.
https://github.com/llvm/llvm-project/pull/121269
__
Author: Jason Molenda
Date: 2025-03-06T17:19:43-08:00
New Revision: 82af9888dbbcd248ec4d41968c53135e12e13454
URL:
https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454
DIFF:
https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
LGTM
Should maybe file an ER on the lldb issues to plumb this (and the other
SymbolContext specifications) through the expression command so some ambitious
person could see and do that.
https://github.com/llvm/llvm-project/pull/129733
_
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/129733
>From da950b7a55c8ee0a35bcfb7e3565fbc11095ab6e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 4 Mar 2025 16:14:59 +
Subject: [PATCH 1/6] [lldb][Expression] Allow specifying a preferred
ModuleList
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130026
>From a53fafd8b63ce874166a1893fe3fe5abc912509a Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 10:18:36 +0100
Subject: [PATCH] [lldb-dap] Refactoring IOStream into Transport handler.
Instead o
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/129868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux`
running on `premerge-linux-1` while building
`clang,flang,lldb,llvm,mlir,offload,polly` at step 6 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/153/bu
ita-sc wrote:
@DavidSpickett, seems done: I've disabled `Keep my email addresses private`.
https://github.com/llvm/llvm-project/pull/89765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu`
running on `as-builder-7` while building
`clang,flang,lldb,llvm,mlir,offload,polly` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/180/builds/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130026
>From 228369443a418e23f82ddc47371f7531bd4a9cb7 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 10:18:36 +0100
Subject: [PATCH] [lldb-dap] Refactoring IOStream into Transport handler.
Instead o
dlav-sc wrote:
> @dlav-sc do you still have an interest in this? If not, I will close this PR.
Hi @DavidSpickett, I believe I still need this patch for two reasons:
1. I don't like the hardcoded ports used in the `GdbRemoteTestCases` for remote
debugging (check out the `get_next_port()` funct
@@ -195,8 +195,17 @@ def
test_qRegisterInfo_contains_required_generics_debugserver(self):
# Ensure we have a stack pointer register.
self.assertIn("sp", generic_regs)
-# Ensure we have a flags register.
-self.assertIn("flags", generic_regs)
+
https://github.com/DavidSpickett commented:
Yeah I didn't realise it generated them randomly, though I don't know what else
it was going to do :)
Do you need a CMake variable for this too? I wonder how you are getting the
argument to dotest.
For example
https://lab.llvm.org/buildbot/#/builde
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/112555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
If this PR is approved, and `TestGdbRemoteFork.py` gives you trouble, splitting
it sounds good.
I suspect folks will be on board with splitting these extremely long tests, but
I will hold off approving for a few days in case that's not the case.
https://github.com/llvm/ll
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/129614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/gribozavr approved this pull request.
https://github.com/llvm/llvm-project/pull/130091
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I read through this and all the usages look correct. I suppose there are some
places that could use the optional without doing value_or, but changing those
now would complicate the patch.
I'll leave it to @JDevlieghere to review fully since they did the previous part.
htt
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130090
>From 228369443a418e23f82ddc47371f7531bd4a9cb7 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 10:18:36 +0100
Subject: [PATCH 1/2] [lldb-dap] Refactoring IOStream into Transport handler.
Inste
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/130104
This adds a mechanism for registering well typed events with the DAP.
For a proof of concept, this updates the 'exited' event to use the new
protocol serialization handlers and updates the call sites to use the
n
@@ -195,8 +195,17 @@ def
test_qRegisterInfo_contains_required_generics_debugserver(self):
# Ensure we have a stack pointer register.
self.assertIn("sp", generic_regs)
-# Ensure we have a flags register.
-self.assertIn("flags", generic_regs)
+
@@ -1393,6 +1393,11 @@ def isLoongArchLSX(self):
def isLoongArchLASX(self):
return self.isLoongArch() and "lasx" in self.getCPUInfo()
+def isRISCV(self):
+"""Returns true if the architecture is RISCV64 or RISCV32."""
+arch = self.getArchitecture
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/6] Modify the localCache API to require an explicit commit
on
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/129919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
#130090 is a follow up to add improved type handling to `RequestHandler` for
encoding / decoding.
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Kuegel (akuegel)
Changes
Followup to
https://github.com/llvm/llvm-project/commit/878a64f94a264ea4b564d6063614ddb0b5da3f6c
---
Full diff: https://github.com/llvm/llvm-project/pull/130091.diff
1 Files Affected:
- (modified) lldb/so
DavidSpickett wrote:
> Do you have any suggestions on how we should handle the "expected" flakiness
> because of how we test the debugger? Do you think this is something we should
> try to solve as part of the lldb testing framework?
Super basic tip, in case you didn't notice already, Linaro's
@@ -0,0 +1,116 @@
+//===- Caching.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -30,6 +30,7 @@ class CachedFileStream {
CachedFileStream(std::unique_ptr OS,
std::string OSPath = "")
: OS(std::move(OS)), ObjectPathName(OSPath) {}
+ virtual Error commit() { return Error::success(); }
anjenner wrote:
I have mov
1 - 100 of 176 matches
Mail list logo
