https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/129030
>From 2f74eee802c1ace16a884e87ddb878b3dd0e010f Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 27 Feb 2025 10:58:08 +0100
Subject: [PATCH] [lldb] Clean up UnwindAssemblyInstEmulation
My main motivation wa
Author: Pavel Labath
Date: 2025-02-27T11:15:59+01:00
New Revision: c0b5451129bba52e33cd7957d58af897a58d14c6
URL:
https://github.com/llvm/llvm-project/commit/c0b5451129bba52e33cd7957d58af897a58d14c6
DIFF:
https://github.com/llvm/llvm-project/commit/c0b5451129bba52e33cd7957d58af897a58d14c6.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/128719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
My main motivation was trying to understand how the function and whether the
rows need to be (shared) pointers. I noticed that the function essentially
constructs two copies unwind plans in parallel (the secon
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/129030
My main motivation was trying to understand how the function and whether the
rows need to be (shared) pointers. I noticed that the function essentially
constructs two copies unwind plans in parallel (the second
@@ -226,13 +227,45 @@ lldb::SBError SBDebugger::InitializeWithErrorHandling() {
return error;
}
+#if LLVM_ENABLE_TELEMETRY
+#if ENABLE_BACKTRACES
+static void TelemetryHandler(void *) {
+ // TODO: get the bt into the msg?
+ // Also need to pre-alloc the memory for this ent
@@ -226,13 +227,45 @@ lldb::SBError SBDebugger::InitializeWithErrorHandling() {
return error;
}
+#if LLVM_ENABLE_TELEMETRY
+#if ENABLE_BACKTRACES
+static void TelemetryHandler(void *) {
+ // TODO: get the bt into the msg?
+ // Also need to pre-alloc the memory for this ent
@@ -226,13 +227,45 @@ lldb::SBError SBDebugger::InitializeWithErrorHandling() {
return error;
}
+#if LLVM_ENABLE_TELEMETRY
+#if ENABLE_BACKTRACES
oontvoo wrote:
Because to get the "exit-description" (ie., why did it crash), we need to print
the stacktrace.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/9] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/6] Modify the localCache API to require an explicit commit
on
@@ -761,12 +764,27 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+ lldb_private::telemetry::ScopeTelemetryCollector helper;
DebuggerSP debugger_sp(new De
@@ -987,6 +1005,20 @@ void Debugger::Clear() {
// static void Debugger::Destroy(lldb::DebuggerSP &debugger_sp);
// static void Debugger::Terminate();
llvm::call_once(m_clear_once, [this]() {
+lldb_private::telemetry::ScopeTelemetryCollector helper;
+if (he
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/10] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
DavidSpickett wrote:
@ita-sc is this still any use to you? If not I will close this.
(sorry this fell through the cracks, I am currently looking for a solution to
stop this happening)
https://github.com/llvm/llvm-project/pull/89765
___
lldb-commits m
@@ -38,29 +65,49 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
serializer.write("end_time", ToNanosec(end_time.value()));
}
-[[maybe_unused]] static std::string MakeUUID(Debugger *debugger) {
- uint8_t random_bytes[16];
- if (auto ec = llvm::g
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/11] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -88,9 +89,10 @@ Expected llvm::localCache(const Twine
&CacheNameRef,
AddBuffer(std::move(AddBuffer)), TempFile(std::move(TempFile)),
ModuleName(ModuleName), Task(Task) {}
- ~CacheStream() {
-// TODO: Manually commit rather than using no
DavidSpickett wrote:
@dlav-sc do you still have an interest in this? If not, I will close this PR.
https://github.com/llvm/llvm-project/pull/112555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
DavidSpickett wrote:
I forgot about this, apologies. If you have the time to fix the conflicts, I'll
take another look.
https://github.com/llvm/llvm-project/pull/94034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
DavidSpickett wrote:
Please update the title/description to mention that this is within atomic
sequences. I thought this was some kind of fused instruction pair/delay slot
type deal but it's not that.
Looks fine at a high level, but I always like to get an architecture expert in
just in case.
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/5] Modify the localCache API to require an explicit commit
on
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fd534e524dd3b683077cab2dae4c87b7c2f1b574
987f307fd361190a4801de3161db9c2f5dd7156d --e
@@ -73,9 +106,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
@@ -21,14 +22,17 @@
#include
#include
#include
+#include
#include
-#include
namespace lldb_private {
namespace telemetry {
struct LLDBEntryKind : public ::llvm::telemetry::EntryKind {
static const llvm::telemetry::KindType BaseInfo = 0b11000;
+ static const ll
@@ -41,6 +45,7 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
std::optional end_time;
// TBD: could add some memory stats here too?
+ uint64_t debugger_id = 0;
oontvoo wrote:
Yes - unless the ID could be zero? :thinking:
I ca
https://github.com/teresajohnson edited
https://github.com/llvm/llvm-project/pull/115331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/12] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -0,0 +1,116 @@
+//===- Caching.cpp
===//
teresajohnson wrote:
Can you test the error when there is no commit?
https://github.com/llvm/llvm-project/pull/115331
___
@@ -0,0 +1,116 @@
+//===- Caching.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -30,6 +30,7 @@ class CachedFileStream {
CachedFileStream(std::unique_ptr OS,
std::string OSPath = "")
: OS(std::move(OS)), ObjectPathName(OSPath) {}
+ virtual Error commit() { return Error::success(); }
teresajohnson wrote:
If th
https://github.com/teresajohnson commented:
I'm a little concerned about the added complexity of the cache interfaces. At
the very least, the required usage of the commit() function should be clearly
documented probably in the main Caching.h header, however, it is a bit
confusing right now bec
JDevlieghere wrote:
Ack, I'll always pick consistency over a slightly nicer interface. Let's keep
it the way it is. Thanks for considering it.
https://github.com/llvm/llvm-project/pull/127799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -41,6 +45,7 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
std::optional end_time;
// TBD: could add some memory stats here too?
+ uint64_t debugger_id = 0;
labath wrote:
Zero is probably fine (the first debugger instance s
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description && des
@@ -41,6 +45,7 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
std::optional end_time;
// TBD: could add some memory stats here too?
+ uint64_t debugger_id = 0;
oontvoo wrote:
Ah, never mind. found it. `#define LLDB_INVALID_UID
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/13] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -73,9 +106,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
@@ -73,9 +106,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From d34c8043bfe0d7bda5a4ef9c2c23915071d06bd5 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From 259dfbb0fc181b1f28d3678688778947dad5b317 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
@@ -226,13 +227,45 @@ lldb::SBError SBDebugger::InitializeWithErrorHandling() {
return error;
}
+#if LLVM_ENABLE_TELEMETRY
+#if ENABLE_BACKTRACES
+static void TelemetryHandler(void *) {
+ // TODO: get the bt into the msg?
+ // Also need to pre-alloc the memory for this ent
Author: Pavel Labath
Date: 2025-02-27T09:56:35+01:00
New Revision: 036f5c0f58d362ad5d28400ccbbecdb3aa6d3133
URL:
https://github.com/llvm/llvm-project/commit/036f5c0f58d362ad5d28400ccbbecdb3aa6d3133
DIFF:
https://github.com/llvm/llvm-project/commit/036f5c0f58d362ad5d28400ccbbecdb3aa6d3133.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/127799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I'm not sure what to think about that. The principal "result" of this function
is the `LineEntry` object (most of the call sites don't even use the index), so
the functional programmer in me wants to make this return an
`optional`. However, that doesn't sit very well with the cod
labath wrote:
> The one issue with this is that MainLoop on Windows only supports sockets,
> not Files. At the moment we primarily work over stdin/stdout for
> communication, although the `--connection` flag is in now, so we can support
> sockets.
Okay, I think I understand what you're saying
DavidSpickett wrote:
Existing GCS test case is here -
https://github.com/llvm/llvm-project/blob/f6262fa035d8b942bf76e084fa875409bc8ff83a/lldb/test/API/linux/aarch64/gcs/TestAArch64LinuxGCS.py#L286
These don't run on bots yet, only Arm's simulator.
https://github.com/llvm/llvm-project/pull/1290
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/129038
Fixes #124269
PrepareTrivalCall always had the possibility of failing, but given that it only
wrote to general purpose registers, if it did, you had bigger problems.
When it failed, we did not mark the t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Fixes #124269
PrepareTrivalCall always had the possibility of failing, but given that it only
wrote to general purpose registers, if it did, you had bigger problems.
When it failed, we did not mark t
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127661
>From 8419178c265d64ee07fe72089421f500f4bb5452 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 18 Feb 2025 16:14:30 +0100
Subject: [PATCH] [lldb] s/ValidRange/ValidRanges in UnwindPlan
To be able to descr
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-02-27T13:22:18+01:00
New Revision: 0865a3872ceb65af2660baf6951a4cee44b65fb1
URL:
https://github.com/llvm/llvm-project/commit/0865a3872ceb65af2660baf6951a4cee44b65fb1
DIFF:
https://github.com/llvm/llvm-project/commit/0865a3872ceb65af2660baf6951a4cee44b65fb1.diff
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127661
>From f64b9615f8ff1c144d28ca20311c96b67732f52e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 18 Feb 2025 16:14:30 +0100
Subject: [PATCH] [lldb] s/ValidRange/ValidRanges in UnwindPlan
To be able to descr
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From 3fdba46d41ad9668a114766fe892af497f121cd5 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/4] Modify the localCache API to require an explicit commit
on
labath wrote:
It looks like that the windows timeout fix didn't work -- the new test woke
ended up waking slightly sooner than expected (198 vs 200ms). At this point I'm
guessing that this is due to the use different clocks in the test
(`chrono::steady_clock`) and in `WaitForSingleObject` (I h
DavidSpickett wrote:
Our policy for the GCS registers is documented here -
https://lldb.llvm.org/use/aarch64-linux.html#id3 - but for the GCS enable bit,
we restore all of them after an expression.
https://github.com/llvm/llvm-project/pull/129038
___
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
After chewing through #129030, I started to think that the map isn't really
necessary and it's often better construct the unwind plan using an auxiliary
structure. The new version reverts the container change and the removal of
AppendRow. I've kept the AddressRanges change and th
101 - 161 of 161 matches
Mail list logo
