https://github.com/teresajohnson commented:
I'm a little concerned about the added complexity of the cache interfaces. At the very least, the required usage of the commit() function should be clearly documented probably in the main Caching.h header, however, it is a bit confusing right now because there is no requirement to use that in the base class (comment on that below). There should also be comments on the other commit() method declarations. https://github.com/llvm/llvm-project/pull/115331 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
