[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) { auto terminate_debugger = llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); }); - StreamDescriptor input; - StreamDescriptor output; - std::FILE *redirectOut = nullptr; - std::FILE *redirectErr = n

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { + eReturnStatusInvalid = 0, labath wrote: I'm not sure I understand that. What exactly happens if you leave thi

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,92 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/119716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,92 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think I don't see all of the updates you've made and the PR has the "Processing updates" forever-spinner. The same thing happened to @cmtice's PR, so you may want to check with her how she got the PR back on track. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,100 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] ad38c4c - [lldb] Document lldb `x` packet deprecation. (#125682)

2025-02-05 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-05T09:26:26+01:00 New Revision: ad38c4c625765c0319433b8c87852fbe40a1f7fd URL: https://github.com/llvm/llvm-project/commit/ad38c4c625765c0319433b8c87852fbe40a1f7fd DIFF: https://github.com/llvm/llvm-project/commit/ad38c4c625765c0319433b8c87852fbe40a1f7fd.diff

[Lldb-commits] [lldb] [lldb] Document lldb `x` packet deprecation. (PR #125682)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/125682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/125832 This commit upgrades our npm dependencies to the latest available version. I was prompted to this change because `npm run package` failed for me with an error. The error disappeared after upgrade `@vscode/

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit upgrades our npm dependencies to the latest available version. I was prompted to this change because `npm run package` failed for me with an error. The error disappeared after upgrade

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/123521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-02-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,160 @@ +//===-- DILLexerTests.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. This looks good now, thanks for your patience. https://github.com/llvm/llvm-project/pull/123521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-02-05 Thread Harald van Dijk via lldb-commits
hvdijk wrote: Thanks again, it ends up looking much better (IMO) with `InsertPosition`, and it manages to avoid the change on the users' side that I was hoping to avoid. https://github.com/hvdijk/llvm-project/commit/dibuilder-insertposition Since this allows us to have a single method rather t

[Lldb-commits] [lldb] [lldb/Host] Add ability to open URLs on macOS (PR #125893)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/125893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,100 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { + eReturnStatusInvalid = 0, oontvoo wrote: when i tried to do `json::Object({"ret_stat", returnStatus})`, I got

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread John Harrison via lldb-commits
@@ -28,11 +28,11 @@ ], "devDependencies": { "@types/node": "^18.11.18", -"@types/vscode": "~1.74.0", -"@vscode/vsce": "^2.19.0", -"prettier-plugin-curly": "^0.1.3", -"prettier": "^3.1.1", -"typescript": "^4.6.4" +"@types/vscode": "1.75.0", --

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors and extend watchpoint numbers (PR #126020)

2025-02-05 Thread via lldb-commits
https://github.com/seehearfeel created https://github.com/llvm/llvm-project/pull/126020 1. [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK,WATCH} 2. [LLDB][LoongArch] Extend the maximum number of watchpoints >From 67dd4198073a2b87f7dbaa37cd6103f2230f326e Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes PR #86603 broke unwinding in for unwind info added via "target symbols add". #86770 attempted to fix this, but the fix was only partial -- it accepted new sources of unwind information, but didn't take into ac

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/125839 PR #86603 broke unwinding in for unwind info added via "target symbols add". #86770 attempted to fix this, but the fix was only partial -- it accepted new sources of unwind information, but didn't take into acco

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
oontvoo wrote: > I think I don't see all of the updates you've made and the PR has the > "Processing updates" forever-spinner. The same thing happened to @cmtice's > PR, so you may want to check with her how she got the PR back on track. Seems to be back to normal now! :) https://github.com/l

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetFunctionOrSymbolAddress (PR #123340)

2025-02-05 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Yes, that's good. https://github.com/llvm/llvm-project/pull/123340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors and extend watchpoint numbers (PR #126020)

2025-02-05 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors and extend watchpoint numbers (PR #126020)

2025-02-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (seehearfeel) Changes 1. [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK,WATCH} 2. [LLDB][LoongArch] Extend the maximum number of watchpoints --- Full diff: https://github.com/llvm/llvm-project/pull/126020.diff 1 File

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors and extend watchpoint numbers (PR #126020)

2025-02-05 Thread via lldb-commits
https://github.com/seehearfeel updated https://github.com/llvm/llvm-project/pull/126020 >From 67dd4198073a2b87f7dbaa37cd6103f2230f326e Mon Sep 17 00:00:00 2001 From: Tiezhu Yang Date: Thu, 23 Jan 2025 15:30:20 +0800 Subject: [PATCH 1/2] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-05 Thread via lldb-commits
cmtice wrote: This is NOT ready for review at this time: I need to clean up the code in this PR to handle the changes made to the lexer. https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Jason Molenda via lldb-commits
@@ -3471,6 +3471,17 @@ class CommandObjectTargetModulesShowUnwind : public CommandObjectParsed { m_type = eLookupTypeFunctionOrSymbol; break; + case 'c': +bool value, success; +value = OptionArgParser::ToBoolean(option_arg, false, &success

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Jason Molenda via lldb-commits
@@ -3494,6 +3506,7 @@ class CommandObjectTargetModulesShowUnwind : public CommandObjectParsed { // parsing options std::string m_str; // Holds name lookup lldb::addr_t m_addr = LLDB_INVALID_ADDRESS; // Holds the address to lookup +

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/125839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. I'm fine with changing the default to show the current cached unwind plans, this command is only used by lldb maintainers (mostly, me), normal users won't notice a change here. Jonas' suggestion of moving this command under `t

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/5] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] d9a7498 - [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (#123521)

2025-02-05 Thread via lldb-commits
Author: cmtice Date: 2025-02-05T10:47:11-08:00 New Revision: d9a7498aa24a35bdd95fd20a5c63e9495b6669f6 URL: https://github.com/llvm/llvm-project/commit/d9a7498aa24a35bdd95fd20a5c63e9495b6669f6 DIFF: https://github.com/llvm/llvm-project/commit/d9a7498aa24a35bdd95fd20a5c63e9495b6669f6.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-02-05 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/123521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
@@ -28,11 +28,11 @@ ], "devDependencies": { "@types/node": "^18.11.18", -"@types/vscode": "~1.74.0", -"@vscode/vsce": "^2.19.0", -"prettier-plugin-curly": "^0.1.3", -"prettier": "^3.1.1", -"typescript": "^4.6.4" +"@types/vscode": "1.75.0", --

[Lldb-commits] [lldb] [lldb] Clear cached unwind plans when adding symbols (PR #125839)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: My bad, I misread "add a flag" as "add a command". I think moving the command and making it an alias would be a nice-to-have (in your copious amounts of spare time ;-), but obviously that's outside the scope of this PR. https://github.com/llvm/llvm-project/pull/125839

[Lldb-commits] [lldb] [lldb] s/GetAddressRange().GetBaseAddress()/GetAddress() (PR #125847)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/125847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to StrictPackMatch (PR #125418)

2025-02-05 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/125418 >From 29c48b0785af13572a785f90747529ffe7a572ed Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sun, 2 Feb 2025 13:31:20 -0300 Subject: [PATCH] [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to Strict

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-05 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/125791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/4] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-02-05 Thread Harald van Dijk via lldb-commits
hvdijk wrote: Given that https://llvm.org/docs/RemoveDIsDebugInfo.html specifically documents these functions as "no plans to deprecate", even though I personally feel like they are a bad idea, I just updated them so they compile with no deprecation warnings. Does this look like a good approac

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-05 Thread Erich Keane via lldb-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/125791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,92 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -9,7 +9,13 @@ #include "FifoFiles.h" #include "JSONUtils.h" SuibianP wrote: Removed one empty line and preserved those around `ifdef` guarded includes, the same way `lldb-dap.cpp` does it. https://github.com/llvm/llvm-project/pull/121269

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm; namespace lldb_dap { -FifoFile::FifoFile(StringRef path) : m_path(path) {} +std::error_code EC; +FifoFile::FifoFile(StringRef path) +: m_path(path), m_file(fopen(path.data(), "r+")) { + if (m_file == nullptr) { +EC = std::e

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-05 Thread Michael Buch via lldb-commits
@@ -280,7 +280,8 @@ std::optional CxxModuleHandler::tryInstantiateStdTemplate(Decl *d) { new_class_template->getDeclContext(), new_class_template->getTemplatedDecl()->getLocation(), new_class_template->getLocation(), new_class_template, imported_args, -

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm; namespace lldb_dap { -FifoFile::FifoFile(StringRef path) : m_path(path) {} +std::error_code EC; +FifoFile::FifoFile(StringRef path) +: m_path(path), m_file(fopen(path.data(), "r+")) { + if (m_file == nullptr) { +EC = std::e

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm; namespace lldb_dap { -FifoFile::FifoFile(StringRef path) : m_path(path) {} +std::error_code EC; +FifoFile::FifoFile(StringRef path) +: m_path(path), m_file(fopen(path.data(), "r+")) { + if (m_file == nullptr) { +EC = std::e

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm; namespace lldb_dap { -FifoFile::FifoFile(StringRef path) : m_path(path) {} +std::error_code EC; +FifoFile::FifoFile(StringRef path) +: m_path(path), m_file(fopen(path.data(), "r+")) { + if (m_file == nullptr) { +EC = std::e

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -2249,6 +2249,11 @@ llvm::Error request_runInTerminal(DAP &dap, } }); + llvm::errs() << "WaitForLauncher\n"; SuibianP wrote: Oops, debug leftover again... Removed. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -21,21 +23,22 @@ namespace lldb_dap { /// The file is destroyed when the destructor is invoked. struct FifoFile { FifoFile(llvm::StringRef path); + FifoFile(llvm::StringRef path, FILE *f); + // FifoFile(llvm::StringRef path, FILE *f); SuibianP wrote: Re

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -2249,6 +2249,11 @@ llvm::Error request_runInTerminal(DAP &dap, } }); + llvm::errs() << "WaitForLauncher\n"; + auto err = comm_channel.WaitForLauncher(); + llvm::errs() << "WaitForLauncher returned\n";

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm; namespace lldb_dap { -FifoFile::FifoFile(StringRef path) : m_path(path) {} +std::error_code EC; SuibianP wrote: Unintended, moved into function. https://github.com/llvm/llvm-project/pull/121269 _

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
@@ -21,21 +23,22 @@ namespace lldb_dap { /// The file is destroyed when the destructor is invoked. struct FifoFile { FifoFile(llvm::StringRef path); + FifoFile(llvm::StringRef path, FILE *f); + // FifoFile(llvm::StringRef path, FILE *f); + FifoFile(FifoFile &&other); + +

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-02-05 Thread Hu Jialun via lldb-commits
https://github.com/SuibianP updated https://github.com/llvm/llvm-project/pull/121269 >From c656de0311a7ecb954b1ac1ce0eda1879efffeb6 Mon Sep 17 00:00:00 2001 From: Hu Jialun Date: Sat, 28 Dec 2024 22:39:33 +0800 Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows Currently, the name

[Lldb-commits] [clang] [lldb] [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to StrictPackMatch (PR #125418)

2025-02-05 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/125418 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Host] Add ability to open URLs on macOS (PR #125893)

2025-02-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/125893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-05 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,92 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-05 Thread via lldb-commits
jimingham wrote: If possible, yes. It would be even more apropos if you could convince yourself that the dynamic type was bigger than the buffer for the static type, and you refused to read past the buffer... Jim > On Feb 4, 2025, at 3:12 PM, Augusto Noronha ***@***.***> wrote: > > > To ma

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { +

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
@@ -174,6 +174,20 @@ The default hostname being used `localhost`. } ``` +### Launching via `vscode://` URIs + +Debugging sessions can also be starting using special URIs. + +The `vscode://llvm-vs-code-extensions.lldb-dap/launch/config?config={launch-config}` +URI accepts a [U

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! LGTM with small nits. https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/125832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/125832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Update npm dependencies (PR #125832)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
@@ -28,11 +28,11 @@ ], "devDependencies": { "@types/node": "^18.11.18", -"@types/vscode": "~1.74.0", -"@vscode/vsce": "^2.19.0", -"prettier-plugin-curly": "^0.1.3", -"prettier": "^3.1.1", -"typescript": "^4.6.4" +"@types/vscode": "1.75.0", --

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/125843 >From cd525991ef676df7108e825eff35610638f8d7ea Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 5 Feb 2025 10:11:38 + Subject: [PATCH 1/2] [lldb-dap] Support vscode launch URLs This commit

[Lldb-commits] [clang] [lldb] [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to StrictPackMatch (PR #125418)

2025-02-05 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/125418 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c94d930 - [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to StrictPackMatch (#125418)

2025-02-05 Thread via lldb-commits
Author: Matheus Izvekov Date: 2025-02-05T13:16:33-03:00 New Revision: c94d930a212248d7102822ca7d0e37e72fd38cb3 URL: https://github.com/llvm/llvm-project/commit/c94d930a212248d7102822ca7d0e37e72fd38cb3 DIFF: https://github.com/llvm/llvm-project/commit/c94d930a212248d7102822ca7d0e37e72fd38cb3.dif

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks. I updated the PR with your suggestions. I will keep the PR open for a couple more days, in case other reviewers also have comments https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread John Harrison via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { -

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-05 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From 88a8522f1b29b2ff392974322acdb722b7e00b70 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Jan 2025 12:39:38 -0800 Subject: [PATCH 1/3] [lldb-dap] Refactoring lldb-dap port listening mode to allow

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/125969 SBFrame::GetRegisters() (and the .registers / .regs extensions in Python) returns an array of register-set's, not registers like you might expect from the API name. Document this. >From 7418a7074cba0ad4e

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-05 Thread John Harrison via lldb-commits
@@ -5058,72 +5053,144 @@ int main(int argc, char *argv[]) { auto terminate_debugger = llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); }); - StreamDescriptor input; - StreamDescriptor output; - std::FILE *redirectOut = nullptr; - std::FILE *redirectErr = n

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes SBFrame::GetRegisters() (and the .registers / .regs extensions in Python) returns an array of register-set's, not registers like you might expect from the API name. Document this. --- Full diff: https

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: not wedded to the specific words I used here, if anyone has an opinion. just want to get something in there. https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM with or without my nitpicking... https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread via lldb-commits
@@ -87,8 +87,8 @@ STRING_EXTENSION_OUTSIDE(SBFrame) args = property(get_arguments, None, doc='''A read only property that returns a list() that contains a collection of lldb.SBValue objects that represent the argument variables in this stack frame.''') argument

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/125969 >From 7418a7074cba0ad4e28232d08b48d6d7a31c8cdb Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Feb 2025 16:12:17 -0800 Subject: [PATCH 1/3] [lldb][NFC] Add documentation for SBFrame::GetRegisters

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/125969 >From 7418a7074cba0ad4e28232d08b48d6d7a31c8cdb Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 5 Feb 2025 16:12:17 -0800 Subject: [PATCH 1/4] [lldb][NFC] Add documentation for SBFrame::GetRegisters

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Hope that those little tweaks help! I appreciate the added documentation! Great suggestions, thanks! https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jason Molenda via lldb-commits
@@ -78,6 +78,22 @@ See also SBThread." See also GetFunctionName()." ) lldb::SBFrame::IsInlined; +%feature("docstring", " +Returns an SBValueList which is an array of one or more register +sets that exist for this thread. +Each SBValue in the SBValueList repre

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-05 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/125143 >From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Jan 2025 16:33:09 -0800 Subject: [PATCH 1/6] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-05 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/125143 >From a280e7bc731818143cc89f3ce1150694a44784b3 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Jan 2025 16:33:09 -0800 Subject: [PATCH 1/6] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-05 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: Jim I was able to write a unit test. https://github.com/llvm/llvm-project/pull/125143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! Thanks for improving this, this has fooled me once before 😅 https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-05 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/124059 >From f404df6b2ac7b7ab33e3baadd3830154904a Mon Sep 17 00:00:00 2001 From: Ray Wang Date: Thu, 23 Jan 2025 12:13:32 +0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetFunctionOrSymbolAddress (PR #123340)

2025-02-05 Thread Pavel Labath via lldb-commits
labath wrote: @jimingham, is the new version of the patch (new function name) what you had in mind? https://github.com/llvm/llvm-project/pull/123340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Here is a screen recording https://github.com/user-attachments/assets/2092beca-3c52-4395-93a6-cf6ad16d1178 and the [example script](https://gist.github.com/vogelsgesang/572b04dc1d447776964fb7e40fd8b261). Note that I had to launch my program using `${CWD}/a.out` instead