https://github.com/Michael137 deleted
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jmorse wrote:
Ooooff, yeah we missed that. I think (90% confident) that overloading the
relevant DIBuilder methods with iterator-taking versions should work fine, and
we should be able to pick that into llvm20 before rc1, we'll look at it
momentarily.
(In theory downstream compatibility isn't
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData {
uint64_t GetCompleted() const { return m_completed; }
uint64_t GetTotal() const { return m_total; }
std::string GetMessage() const {
-std::string message = m_title;
-if (!m_details.empty()) {
-
DavidSpickett wrote:
I will deal with the formatting in a follow up after this lands.
https://github.com/llvm/llvm-project/pull/124735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData {
uint64_t GetCompleted() const { return m_completed; }
uint64_t GetTotal() const { return m_total; }
std::string GetMessage() const {
-std::string message = m_title;
-if (!m_details.empty()) {
-
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/124811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/124811
This change is required as a result of the changes made in D132642
(bb26ebb4d18c1877cc6fd17aa803609abeb95096).
>From 48ad5798b113db624ff2543ff35f907fcb3090ef Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: T
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
This change is required as a result of the changes made in D132642
(bb26ebb4d18c1877cc6fd17aa803609abeb95096).
---
Full diff: https://github.com/llvm/llvm-project/pull/124811.diff
1 Files Affected:
- (modi
labath wrote:
@rocallahan
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
**Do not merge before the 20 branch is taken!**
As decided on
https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731.
LLDB 20 recommended >= 3.8 but did no
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/124735
**Do not merge before the 20 branch is taken!**
As decided on
https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731.
LLDB 20 recommended >= 3.8 but did not re
@@ -447,6 +447,9 @@ Changes to the LLVM tools
Changes to LLDB
-
+* When building LLDB with Python support, the minimum version of Python is now
+ 3.8.
+
DavidSpickett wrote:
This looks weird now but when I rebase after the bra
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124295
>From de84dc94ee6e5f15450f9e2729bfdbafd212b7f0 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 14:35:28 +0100
Subject: [PATCH] [lldb][AArch64] Add register fields for Guarded Control S
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2c934dc5e1a3ef7b717400f27d6b9ea21f4e20a0
7d2b1ef31e16aeb369c2e45edae01feebfef866b --e
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/124733
>From bf011ccc02c0122e7dfd74e089143eb833c1686e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 28 Jan 2025 12:27:46 +0100
Subject: [PATCH] [lldb] Add support for gdb-style 'x' packet
DO NOT SUBMIT until t
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/124733
DO NOT SUBMIT until the mechanism for detection of the packet format is
confirmed.
>From dfecd933978f1554624eb93d7c78f93364b8965a Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 28 Jan 2025 12:27:46 +010
kastiglione wrote:
the build failures are unrelated (`clang/Driver/Options.td`)
https://github.com/llvm/llvm-project/pull/124811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/124836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/124811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/124843
I wanted to clarify the semantics around SBProgress. Given the nature of
Progress events, copying seems like the wrong idea. Making SBProgress move-only
(like SBStream) seems like the better choice here.
>Fr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
I wanted to clarify the semantics around SBProgress. Given the nature of
Progress events, copying seems like the wrong idea. Making SBProgress move-only
(like SBStream) seems like the better choice here.
Author: Alex Langford
Date: 2025-01-28T13:30:14-08:00
New Revision: 9d7999885a6aa2c4afc252a645448b4f1666e951
URL:
https://github.com/llvm/llvm-project/commit/9d7999885a6aa2c4afc252a645448b4f1666e951
DIFF:
https://github.com/llvm/llvm-project/commit/9d7999885a6aa2c4afc252a645448b4f1666e951.diff
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/124843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -59,6 +63,9 @@ class LLDB_API SBProgress {
lldb_private::Progress &ref() const;
private:
+ SBProgress(const SBProgress &rhs) = delete;
Jlalond wrote:
Oh! I didn't originally do this because I thought we weren't adding deletes in
the header.
https://gi
https://github.com/Jlalond approved this pull request.
LGTM, left you one comment @bulbazord that is mostly a question
https://github.com/llvm/llvm-project/pull/124843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -51,6 +51,10 @@ class LLDB_API SBProgress {
SBProgress(const char *title, const char *details, uint64_t total_units,
SBDebugger &debugger);
+#ifndef SWIG
Jlalond wrote:
Why the move operator for only Swig? Wouldn't this be useful if say DAP
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/124836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/124811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-01-28T13:36:40-08:00
New Revision: e89e7c4685aa673173220eace7a0a8b64dbd2391
URL:
https://github.com/llvm/llvm-project/commit/e89e7c4685aa673173220eace7a0a8b64dbd2391
DIFF:
https://github.com/llvm/llvm-project/commit/e89e7c4685aa673173220eace7a0a8b64dbd2391.diff
LOG:
https://github.com/puremourning created
https://github.com/llvm/llvm-project/pull/124847
The WatchAddress API includes a flag to indicate if watchpoint should be for
read, modify or both. This API uses 2 booleans, but the 'modify' flag was
ignored and WatchAddress unconditionally watched write
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From afae250c45e769006a5ae7d078e2e0ae39a4d8c0 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 3baafc236fb722a27799bd3abccb74e01656afab Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2e5a5237daf82a657561c490845c406e13657311...afae250c45e769006a5ae7d078e2e0ae39a4d8c0
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ben Jackson (puremourning)
Changes
The WatchAddress API includes a flag to indicate if watchpoint should be for
read, modify or both. This API uses 2 booleans, but the 'modify' flag was
ignored and WatchAddress unconditionally watched writ
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/124843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2025-01-28T14:03:17-08:00
New Revision: 1f7eb6f403bc0e453b76d9274994d840561e96cf
URL:
https://github.com/llvm/llvm-project/commit/1f7eb6f403bc0e453b76d9274994d840561e96cf
DIFF:
https://github.com/llvm/llvm-project/commit/1f7eb6f403bc0e453b76d9274994d840561e96cf.diff
@@ -51,6 +51,10 @@ class LLDB_API SBProgress {
SBProgress(const char *title, const char *details, uint64_t total_units,
SBDebugger &debugger);
+#ifndef SWIG
bulbazord wrote:
This is a header guard that prevents SWIG from processing the move con
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 1edd2a7cae5acbe11ae58f486f5bca7c182184f5 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
@@ -59,6 +63,9 @@ class LLDB_API SBProgress {
lldb_private::Progress &ref() const;
private:
+ SBProgress(const SBProgress &rhs) = delete;
bulbazord wrote:
SBStream does this to enforce no copying. :)
https://github.com/llvm/llvm-project/pull/124843
__
@@ -1342,7 +1342,9 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBWatchpointOptions options;
options.SetWatchpointTypeRead(read);
- options.SetWatchpointTypeWrite(eWatchpointWriteTypeOnModify);
+ if (modify) {
+options.SetWatchpointTy
@@ -1342,7 +1342,9 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBWatchpointOptions options;
options.SetWatchpointTypeRead(read);
JDevlieghere wrote:
Shouldn't this check the `read` flag in a similar fashion?
https://git
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/124843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-28T12:05:24Z
New Revision: c5840cc609a3674cf7453a45946f7e4a2a73590b
URL:
https://github.com/llvm/llvm-project/commit/c5840cc609a3674cf7453a45946f7e4a2a73590b
DIFF:
https://github.com/llvm/llvm-project/commit/c5840cc609a3674cf7453a45946f7e4a2a73590b.diff
LOG
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
hvdijk wrote:
Hi, in principle this change makes sense but it causes a bit of an issue with
[`DIBuilder`](https://llvm.org/doxygen/classllvm_1_1DIBuilder.html) not yet
having been updated to take iterators. The workaround for that at the moment is
trivial (change e.g. `DIB.insertDeclare(..., B
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Can we not just leave this whole block in
https://github.com/omjavaid approved this pull request.
Looks good. Thanks!
https://github.com/llvm/llvm-project/pull/124293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-28T11:32:24Z
New Revision: 75aa5a35568b9e0b3eabd1e7f991a6a0f5525e0c
URL:
https://github.com/llvm/llvm-project/commit/75aa5a35568b9e0b3eabd1e7f991a6a0f5525e0c
DIFF:
https://github.com/llvm/llvm-project/commit/75aa5a35568b9e0b3eabd1e7f991a6a0f5525e0c.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid approved this pull request.
Looks Good Thanks
https://github.com/llvm/llvm-project/pull/124295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-01-28T11:38:58Z
New Revision: 6d0dd3d5c41e5b564714de9226c0623012538051
URL:
https://github.com/llvm/llvm-project/commit/6d0dd3d5c41e5b564714de9226c0623012538051
DIFF:
https://github.com/llvm/llvm-project/commit/6d0dd3d5c41e5b564714de9226c0623012538051.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
I see why you moved it. It's because we're
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
labath wrote:
> If this were super difficult, I'd be uncomfortable about telling other people
> that their usages were too esoteric to support but willing to do so as a
> tradeoff. But I don't think it's a good idea to do that unless we have to.
> After all, you're basing the argument on commo
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5028,48 +5021,128 @@ int main(int argc, char *argv[]) {
#endif
// Initialize LLDB first before we do anything.
- lldb::SBDebugger::Initialize();
+ lldb::SBError error = lldb::SBDebugger::InitializeWithErrorHandling();
+ if (error.Fail()) {
+llvm::errs() << "Failed
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From 61fefbe13eaf98600d308e0873e98134fbadc452 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH] [lldb-dap] Refactoring lldb-dap port listening mode to allow
mul
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From f946fd70bb550320bb153a59b8acd702dc97e75d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH] [lldb-dap] Refactoring lldb-dap port listening mode to allow
mul
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
For lldb-server/debugserver, we might want to distinguish if the connecting
lldb is old-lldb (only knows the lldb x) or new-lldb (knows lldb x and gdb x).
I think in `GDBRemoteCommunicationClient::GetRemoteQSupported` lldb should add
`binary-upload+` to the `features` list
@@ -1342,7 +1342,9 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t
addr, size_t size,
SBWatchpointOptions options;
options.SetWatchpointTypeRead(read);
puremourning wrote:
It doesn't need to: It passes read bool directly to the Set... method so
ZequanWu wrote:
> > > I'd rather keep the flexibility, if you don't mind doing the work to add
> > > that. For now, it seems okay for the current libc++/libstdc++ ones to
> > > declare what they support (which is 1 pointer depth). If someone has a
> > > reason to come back and extend these one
jimingham wrote:
> > > > I'd rather keep the flexibility, if you don't mind doing the work to
> > > > add that. For now, it seems okay for the current libc++/libstdc++ ones
> > > > to declare what they support (which is 1 pointer depth). If someone has
> > > > a reason to come back and extend
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cc97653d534e80745a0cfb0143972e8d4dec9f74
60d2ba572b2f597f66e5876d3796d295bbb1aa27 --e
https://github.com/brad0 updated
https://github.com/llvm/llvm-project/pull/124682
>From 9046fce2f1ff2e4ff540e47c2daa70d1ea6df34e Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Mon, 27 Jan 2025 22:16:53 -0500
Subject: [PATCH] [lldb] Remove PATH workaround for Android
---
lldb/source/Host/posi
@@ -904,11 +928,14 @@ bool StartDebuggingRequestHandler::DoExecute(
"startDebugging",
llvm::json::Object{{"request", request},
{"configuration", std::move(*configuration)}},
- [](llvm::Expected value) {
+ [](auto dap, auto value) {
ashgti wrote:
I've updated this after splitting parts of this off into multiple smaller
patches (#118330, #118565, #122783)
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
@@ -1154,34 +1154,38 @@ class DebugAdaptorServer(DebugCommunication):
def __init__(
self,
executable=None,
+launch=True,
port=None,
+unix_socket=None,
init_commands=[],
log_file=None,
env=None,
):
@@ -32,35 +34,44 @@ using namespace lldb_dap;
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, ReplMode repl_mode)
-: debug_adaptor_path(path), broadcaster("lldb-dap"),
- exception_breakpoints(), focus_tid(LLDB_INVALID_THREAD_ID),
- stop_at_entry(false), is_
@@ -180,8 +195,9 @@ Status TCPSocket::Listen(llvm::StringRef name, int backlog)
{
if (host_port->hostname == "*")
host_port->hostname = "0.0.0.0";
- std::vector addresses = SocketAddress::GetAddressInfo(
- host_port->hostname.c_str(), nullptr, AF_UNSPEC, SOCK_STRE
https://github.com/jasonmolenda approved this pull request.
This looks good to me, thanks for fixing this. This method used to take two
bools, `read`, and `write`, I redefined the second to `modified` when I changed
the default watchpoints to be modify-style. The method previously had a block
https://github.com/brad0 updated
https://github.com/llvm/llvm-project/pull/124682
>From fa2ef2fb98942b4d0f52c441f29fa48063b314b4 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Mon, 27 Jan 2025 22:16:53 -0500
Subject: [PATCH] [lldb] Remove PATH workaround for Android
---
lldb/source/Host/posi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (kper)
Changes
As discussed with @DavidSpickett in discord. Running the test runner
caused the following issue:
```
gmake: Entering directory
'/home/kper/oss/llvm-project/build/lldb-test-build.noindex/functionalities/thread/concurren
https://github.com/kper created https://github.com/llvm/llvm-project/pull/124758
As discussed with @DavidSpickett in discord. Running the test runner caused the
following issue:
```
gmake: Entering directory
'/home/kper/oss/llvm-project/build/lldb-test-build.noindex/functionalities/thread/conc
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f8ab91f74f152c8a6d8aaedb8165109c497a618d...be1c2a0b1b2014b66fe0f4418230395a25016cc8
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
See also
https://discourse.llvm.org/t/rfc-fixing-incompatibilties-of-the-x-packet-w-r-t-gdb/84288
and https://sourceware.org/pipermail/gdb/2025-January/051705.html
---
Full diff: https://github.com/llvm/llvm-
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 096eb85718d70721cec1e539cfa4b05a96475c7a Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH 1/3] lldb: Extended if conditions to support alias names for
registers
jmorse wrote:
Prototype here
https://github.com/jmorse/llvm-project/commit/8e68a722e0e2925f042cd6479f8b86578ba3042d
, is that the sort of thing that would be useful? It's lacking unit test
coverage right now.
https://github.com/llvm/llvm-project/pull/124287
___
hvdijk wrote:
Yes, thank you, something like that looks great! I should be able to do some
testing with that tomorrow to check to make sure I am not missing anything.
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks.
My understanding of this is it generates `-m64` and `-m32` flags for
architectures that need it, and RISC-V is not one of those.
(I have heard of toolchains with both 32 and 64 bit but they use a different
triple for e
kper wrote:
I have created two tests. However, it turned out that `register read x8` is not
working. I think, there is some edge case because it has `fp` and `s0`.
I am not sure whether to try to fix this in this PR or another one?
https://github.com/llvm/llvm-project/pull/124475
__
labath wrote:
Gdb uses the same feature string to detect the packet, and a version with that
fix is going to released soon. I've tested that an lldb with this patch can
communicate with gdbserver with the fix (at least that they get far enough to
start reading memory).
(We are also able to co
Author: David Spickett
Date: 2025-01-28T13:50:58Z
New Revision: 0cf6714279d4146ee5d6a5e34195d6fae56ed475
URL:
https://github.com/llvm/llvm-project/commit/0cf6714279d4146ee5d6a5e34195d6fae56ed475
DIFF:
https://github.com/llvm/llvm-project/commit/0cf6714279d4146ee5d6a5e34195d6fae56ed475.diff
LOG
enh-google wrote:
> Let's delete the FixupEnvironment function as well (replace it with a direct
> `env.getEnvp() call`) -- it only exists to hide the android hack.
+1 --- seems weird to say "fix up" when doing nothing. otherwise lgtm...
https://github.com/llvm/llvm-project/pull/124682
___
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath ready_for_review
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/124836
Some clients only include LLDB.h and they won't get access to SBProgress
without this.
>From f740e0f6fd3a355dc427c6e5b6de823bd6182426 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 28 Jan 2025 12:57
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
Some clients only include LLDB.h and they won't get access to SBProgress
without this.
---
Full diff: https://github.com/llvm/llvm-project/pull/124836.diff
2 Files Affected:
- (modified) lldb/include/ll
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 096eb85718d70721cec1e539cfa4b05a96475c7a Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH 1/5] lldb: Extended if conditions to support alias names for
registers
96 matches
Mail list logo
