@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat());
- dump_options.SetHideRootName(suppress_result);
+ dump_opt
jasonmolenda wrote:
Updated patch to have a local `symtab_command` structure in ObjectFileMachO
with larger offset fields, and read the load command fields into this
structure. Simplifies the patch; the exiting slide calculations can remain
unmodified now that 64-bit offsets are being used.
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/117832
>From 00a429c14d159ebc42ac7c3a7e98a91851ece236 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 26 Nov 2024 17:56:06 -0800
Subject: [PATCH 1/2] [lldb][Mach-O] Handle shared cache binaries correctly
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/117832
>From 00a429c14d159ebc42ac7c3a7e98a91851ece236 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 26 Nov 2024 17:56:06 -0800
Subject: [PATCH 1/3] [lldb][Mach-O] Handle shared cache binaries correctly
labath wrote:
Great. Can you turn that into a test?
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,43 @@
+//===-- HostInfoAIX.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
bwendling wrote:
Fine.
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bwendling closed
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/9] [Clang] Improve Sema diagnostic performance for
__builtin
@@ -14690,6 +14690,13 @@ void Sema::FinalizeDeclaration(Decl *ThisDecl) {
}
}
+ // The result of __builtin_counted_by_ref cannot be assigned to a variable.
+ // It allows leaking and modification of bounds safety information.
+ if (IsBuiltinCountedByRef(VD->getInit())
https://github.com/AaronBallman approved this pull request.
LGTM modulo the request for a helper function (that two reviewers asked for the
same thing is a pretty reasonable indication that we should probably have the
helper, but if you feel strongly about it, I won't block the PR over it).
ht
@@ -32,35 +34,44 @@ using namespace lldb_dap;
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, ReplMode repl_mode)
-: debug_adaptor_path(path), broadcaster("lldb-dap"),
- exception_breakpoints(), focus_tid(LLDB_INVALID_THREAD_ID),
- stop_at_entry(false), is_
@@ -180,8 +195,9 @@ Status TCPSocket::Listen(llvm::StringRef name, int backlog)
{
if (host_port->hostname == "*")
host_port->hostname = "0.0.0.0";
- std::vector addresses = SocketAddress::GetAddressInfo(
- host_port->hostname.c_str(), nullptr, AF_UNSPEC, SOCK_STRE
@@ -904,11 +928,14 @@ bool StartDebuggingRequestHandler::DoExecute(
"startDebugging",
llvm::json::Object{{"request", request},
{"configuration", std::move(*configuration)}},
- [](llvm::Expected value) {
+ [](auto dap, auto value) {
@@ -0,0 +1,182 @@
+//===-- Socket.h *- C++
-*-===//
labath wrote:
Cool. Thanks.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commi
@@ -118,6 +124,15 @@ std::string TCPSocket::GetRemoteConnectionURI() const {
return "";
}
+std::string TCPSocket::GetListeningConnectionURI() const {
labath wrote:
Let's put these into a separate patch (with a test case). I also believe these
should return
@@ -5028,48 +5021,128 @@ int main(int argc, char *argv[]) {
#endif
// Initialize LLDB first before we do anything.
- lldb::SBDebugger::Initialize();
+ lldb::SBError error = lldb::SBDebugger::InitializeWithErrorHandling();
+ if (error.Fail()) {
+llvm::errs() << "Failed
labath wrote:
> I can split this into smaller patches.
Please, do that. Multithreading and servers and stuff are very tricky to get
right, and it'd be a lot easier to review this if it was in smaller chunks. I
think there's a lot of prepwork so that the code is prepared to handle multiple
con
@@ -52,11 +51,11 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
- bool read_full(std::ofstream *log, size_t length, std::string &text);
+ bool read_full(llvm::raw_ostream *log, size_t length, std::string &text);
- bool read_line(std::ofst
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/117699
>From 6471ca1dfdf32d448c21b277dc9ea8cd1623317f Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Sat, 19 Oct 2024 18:17:23 +0200
Subject: [PATCH] [lldb] Remove child_process_inherit from the socket classes
It's
https://github.com/kendalharland closed
https://github.com/llvm/llvm-project/pull/104514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
kendalharland wrote:
Superceded by https://github.com/swiftlang/llvm-project/pull/9370
https://github.com/llvm/llvm-project/pull/104514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
jasonmolenda wrote:
> Is changing `struct symtab_command` to have the right-sized fields a no-go?
Yes, this is one possibility, and maybe the best. The current structure
reflects the in-binary layout, so it can be read (with endian fixing) on one go.
https://github.com/llvm/llvm-project/pull/
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/117906
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
cmtice wrote:
Here's the test case I used:
$ cat main.cpp
struct A {
struct {
int x = 1;
};
int y = 2;6
} a;
struct B {
// Anonymous struct inherits another struct.
struct : public A {
int z = 3;
};
int w = 4;
A a;
} b;
return 0; // Set a br
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/11
>From 4ba15cd7e64f8f4a2a5d804a1f986aafff9f6d17 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 26 Nov 2024 12:07:57 -0800
Subject: [PATCH] Add 'FindFirstSymbolWithNameAndType()' to ModuleList.
---
lldb/inc
Author: Saleem Abdulrasool
Date: 2024-11-27T08:39:15-08:00
New Revision: 24593f1814dc02c7404526674838ccfb1c61d780
URL:
https://github.com/llvm/llvm-project/commit/24593f1814dc02c7404526674838ccfb1c61d780
DIFF:
https://github.com/llvm/llvm-project/commit/24593f1814dc02c7404526674838ccfb1c61d780.
https://github.com/compnerd closed
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mbucko wrote:
> Do you have a link to a PR that exercises this new API?
I'm only using it in an internal branch
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat());
- dump_options.SetHideRootName(suppress_result);
+ dump_opt
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/117500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/117699
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath commented:
I think most of this file could be deleted or moved into HostInfoPOSIX. If we
can do everything in the inline comments, then that will leave us with a couple
of small functions that are copied from linux. We can then think about whether
we want to merge tho
Author: Pavel Labath
Date: 2024-11-28T08:27:36+01:00
New Revision: c1dff7152592f1beee9059ee8e2cb3cc68baea4d
URL:
https://github.com/llvm/llvm-project/commit/c1dff7152592f1beee9059ee8e2cb3cc68baea4d
DIFF:
https://github.com/llvm/llvm-project/commit/c1dff7152592f1beee9059ee8e2cb3cc68baea4d.diff
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/4] Added XCOFF Header Parsing
---
.../ObjectFile/
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks for adding this documentation!
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -151,10 +151,23 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
result.SetStatus(eReturnStatusSuccessFinishResult);
};
- // First, try `expr` as the name of a frame variable.
- if (frame) {
-auto valobj_sp = frame->FindVariable(ConstString(expr));
-
@@ -154,5 +163,25 @@ def test_preserves_persistent_variables(self):
def test_missing_type(self):
"""The expected output of po opaque is its address (no error)"""
self.build()
-lldbutil.run_to_source_breakpoint(self, "break here",
lldb.SBFileSpec("ma
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Makes sense to me!
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
The meat of this is how we execute expressions and deal with the aftermath. For
most users this will never be a concern, so it functions more as a design doc
than anything else.
---
Full diff: https:
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/117860
The meat of this is how we execute expressions and deal with the aftermath. For
most users this will never be a concern, so it functions more as a design doc
than anything else.
>From 4838ed0ef8a62041981
DavidSpickett wrote:
This is actually one of the last patches for GCS, but I'm putting it up first
so you have something to refer to for the actual code changes.
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commi
Michael137 wrote:
Looks like this broke the macOS CI:
```
/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/unittests/debugserver/RNBSocketTest.cpp:123:33:
error: no matching member function for call to 'Accept'
Status err = server_socket->Accept(connected_socket);
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/117861
This is intended for use with Arm's Guarded Control Stack extension (GCS).
Which reuses some existing shadow stack support in Linux. It should also work
with the x86 equivalent.
A "ss" flag is added to t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This is intended for use with Arm's Guarded Control Stack extension (GCS).
Which reuses some existing shadow stack support in Linux. It should also work
with the x86 equivalent.
A "ss" flag is added
Author: Pavel Labath
Date: 2024-11-27T09:50:33+01:00
New Revision: 072387042021b0f74c24c617b940fe8157f9f1a5
URL:
https://github.com/llvm/llvm-project/commit/072387042021b0f74c24c617b940fe8157f9f1a5
DIFF:
https://github.com/llvm/llvm-project/commit/072387042021b0f74c24c617b940fe8157f9f1a5.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/117691
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-11-27T09:51:59+01:00
New Revision: e8a01e75e6b17e84710e7cc3bfb70d95a3a696a2
URL:
https://github.com/llvm/llvm-project/commit/e8a01e75e6b17e84710e7cc3bfb70d95a3a696a2
DIFF:
https://github.com/llvm/llvm-project/commit/e8a01e75e6b17e84710e7cc3bfb70d95a3a696a2.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/117683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
This function is definitely due for a cleanup. Do you have a reduced test-case
for this by any chance? One way I see the vector would get cleared is if the
recursive call ended up failing in `GetIndexForRecordBase`. This does seem like
a plausible crash
DavidSpickett wrote:
RFC here:
https://discourse.llvm.org/t/rfc-aarch64-guarded-control-stack-support-for-lldb/83364
Should help you understand the test case.
https://github.com/llvm/llvm-project/pull/117861
___
lldb-commits mailing list
lldb-commits
DavidSpickett wrote:
RFC here:
https://discourse.llvm.org/t/rfc-aarch64-guarded-control-stack-support-for-lldb/83364
https://github.com/llvm/llvm-project/pull/117860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
DavidSpickett wrote:
> Also the wording is "shadow stack: yes" because the shadow stack region is
> just where it's stored. It's enabled for the whole process or it isn't. As
> opposed to memory tagging which can be enabled per region, so "memory
> tagging: enabled" fits better for that.
Thou
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -353,6 +353,10 @@ class ModuleList {
lldb::ModuleSP FindFirstModule(const ModuleSpec &module_spec) const;
+ const Symbol *
Michael137 wrote:
Can we add a doxygen comment?
https://github.com/llvm/llvm-project/pull/11
___
@@ -524,6 +524,19 @@ void ModuleList::FindGlobalVariables(const
RegularExpression ®ex,
module_sp->FindGlobalVariables(regex, max_matches, variable_list);
}
+const Symbol *
+ModuleList::FindFirstSymbolWithNameAndType(ConstString name,
+
https://github.com/Michael137 commented:
Do you have a link to a PR that exercises this new API?
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Is changing `struct symtab_command` to have the right-sized fields a no-go?
https://github.com/llvm/llvm-project/pull/117832
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
DavidSpickett wrote:
I don't have any objections to this.
Please update the PR description before landing, it will be used as the commit
message.
https://github.com/llvm/llvm-project/pull/117615
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Author: Pavel Labath
Date: 2024-11-27T09:34:53Z
New Revision: 17b87853c3b07b8e1c7f000c3818efab7fdd8883
URL:
https://github.com/llvm/llvm-project/commit/17b87853c3b07b8e1c7f000c3818efab7fdd8883
DIFF:
https://github.com/llvm/llvm-project/commit/17b87853c3b07b8e1c7f000c3818efab7fdd8883.diff
LOG:
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks.
I'll keep an eye on the buildbot.
https://github.com/llvm/llvm-project/pull/117756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/117756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat());
- dump_options.SetHideRootName(suppress_result);
+ dump_opt
Michael137 wrote:
> Fixed in
> [284d4e0](https://github.com/llvm/llvm-project/commit/284d4e0a7a789848b7af7f85158ccf522d70c6f0).
> FWIW, I did not get any emails for that breakage.
Thanks! Yea IIRC email notifications for green dragon are disabled at the
moment (@JDevlieghere @adrian-prantl an
labath wrote:
Fixed in 284d4e0a7a789848b7af7f85158ccf522d70c6f0. FWIW, I did not get any
emails for that breakage.
https://github.com/llvm/llvm-project/pull/117691
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
Author: Pavel Labath
Date: 2024-11-27T13:16:41+01:00
New Revision: 284d4e0a7a789848b7af7f85158ccf522d70c6f0
URL:
https://github.com/llvm/llvm-project/commit/284d4e0a7a789848b7af7f85158ccf522d70c6f0
DIFF:
https://github.com/llvm/llvm-project/commit/284d4e0a7a789848b7af7f85158ccf522d70c6f0.diff
80 matches
Mail list logo
