llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The problem here is the assumption that the entire function will be placed in a
single section. This will ~never be the case for a discontinuous function, as
the point of splitting the function is to let the l
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/116777
The problem here is the assumption that the entire function will be placed in a
single section. This will ~never be the case for a discontinuous function, as
the point of splitting the function is to let the lin
Author: Jonas Devlieghere
Date: 2024-11-19T10:46:57-08:00
New Revision: dd78d7c7be5b8948cf5841e8033e59adebf230ad
URL:
https://github.com/llvm/llvm-project/commit/dd78d7c7be5b8948cf5841e8033e59adebf230ad
DIFF:
https://github.com/llvm/llvm-project/commit/dd78d7c7be5b8948cf5841e8033e59adebf230ad.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/116456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
This is even better than the original suggestion!
https://github.com/llvm/llvm-project/pull/116876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](const std::vector &details) {
+uint16_t column = 0;
+std::vector result, group;
Author: Adrian Prantl
Date: 2024-11-19T13:01:08-08:00
New Revision: 5681f756c058204d7e41d065f91c5f3c36a434a7
URL:
https://github.com/llvm/llvm-project/commit/5681f756c058204d7e41d065f91c5f3c36a434a7
DIFF:
https://github.com/llvm/llvm-project/commit/5681f756c058204d7e41d065f91c5f3c36a434a7.diff
Author: Adrian Prantl
Date: 2024-11-19T13:02:47-08:00
New Revision: 174899f738b31216750ac59562475966b0b0be42
URL:
https://github.com/llvm/llvm-project/commit/174899f738b31216750ac59562475966b0b0be42
DIFF:
https://github.com/llvm/llvm-project/commit/174899f738b31216750ac59562475966b0b0be42.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Based on post-commit review feedback by Felipe Piovezan!
---
Full diff: https://github.com/llvm/llvm-project/pull/116876.diff
1 Files Affected:
- (modified) lldb/source/Utility/DiagnosticsRendering.c
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/116850
None
>From f7462578ac8e5977310279ea8f9f01f01bbcedcd Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Mon, 18 Nov 2024 16:21:18 -0800
Subject: [PATCH] [lldb] Fix comment in ~Thread (NFC)
---
lldb/source/Targe
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/116876
Based on post-commit review feedback by Felipe Piovezan!
>From 60d427280f59fdca843332cefa03d960d0fb6587 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 19 Nov 2024 12:51:50 -0800
Subject: [PATCH]
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](const std::vector &details) {
+uint16_t column = 0;
+std::vector result, group;
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From d16492dc12891cf15e41225abff890462c9f8460 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH 1/2] Modify the localCache API to require an explicit commit
on
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/116827
We got a bug report that this message is confusing. In this particular case,
the line zero was due to compiler tail merging (in optimized code). The main
issue was the "no source code" part: in this case it's k
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
We got a bug report that this message is confusing. In this particular case,
the line zero was due to compiler tail merging (in optimized code). The main
issue was the "no source code" part: in this case it's
@@ -32,6 +32,19 @@ class SimpleTypeSerializer {
ArrayRef serialize(const FieldListRecord &Record) = delete;
};
+// Needed by RandomAccessVisitorTest.cpp
+#define TYPE_RECORD(EnumName, EnumVal, Name)
\
+ class Name##Record;
@@ -495,7 +495,8 @@ class ClassRecord : public TagRecord {
};
// LF_UNION
-struct UnionRecord : public TagRecord {
+class UnionRecord : public TagRecord {
+public:
compnerd wrote:
Why the change here? The use of `struct` _should_ be fine. Or was it that there
Author: Dave Lee
Date: 2024-11-19T13:42:51-08:00
New Revision: e3ff649abe975c04aa179622c6f4757e7aa66aaf
URL:
https://github.com/llvm/llvm-project/commit/e3ff649abe975c04aa179622c6f4757e7aa66aaf
DIFF:
https://github.com/llvm/llvm-project/commit/e3ff649abe975c04aa179622c6f4757e7aa66aaf.diff
LOG:
https://github.com/Sirraide commented:
The main thing I’m concerned about here is that I feel like there ought to be a
better way of doing this than checking for and disallowing it in every place
where we can have a subexpression in C.
CC @AaronBallman for opinions on this.
Also, if we’re doi
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/116827
>From 02637dab316797b0bf6440b549497bf59db2d3c7 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 19 Nov 2024 17:03:48 +0100
Subject: [PATCH 1/3] [lldb] Reword the "line 0" warning
We got a bug report that t
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/116827
>From 02637dab316797b0bf6440b549497bf59db2d3c7 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 19 Nov 2024 17:03:48 +0100
Subject: [PATCH 1/2] [lldb] Reword the "line 0" warning
We got a bug report that t
bwendling wrote:
I removed the Placeholder code. It's a much smaller patch and has the better
timing profile. PTAL.
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/116904
This is motivated by exposing some Swift language-specific flags through the
API, in the example here it is used to communicate the Objective-C runtime
version. This could also be a meaningful extension p
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This is motivated by exposing some Swift language-specific flags through the
API, in the example here it is used to communicate the Objective-C runtime
version. This could also be a meaningful extensio
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6205,10 +6212,24 @@ bool Sema::CheckArgsForPlaceholders(MultiExprArg args) {
for (size_t i = 0, e = args.size(); i != e; i++) {
if (isPlaceholderToRemoveAsArg(args[i]->getType())) {
ExprResult result = CheckPlaceholderExpr(args[i]);
- if (result.isInvalid()
@@ -50,6 +50,20 @@ class ContinuationRecordBuilder {
std::vector end(TypeIndex Index);
};
+
+// Needed by RandomAccessVisitorTest.cpp
+#define TYPE_RECORD(EnumName, EnumVal, Name)
+#define TYPE_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName)
+#define MEMBER_RECORD(EnumName,
bwendling wrote:
> Hmm, I don’t think this is the right way of going about it—copy-pasting the
> check across 6 or so different places seems like it’s missing the point of
> using a placeholder in the first place.
Could you point to a place in the code where it creates a placeholder? I'm
unab
@@ -755,6 +755,7 @@ static ExprResult BuiltinDumpStruct(Sema &S, CallExpr
*TheCall) {
case BuiltinType::PseudoObject:
case BuiltinType::UnknownAny:
case BuiltinType::BuiltinFn:
+case BuiltinType::BuiltinCountedByRef:
bwendling wrote:
Then shou
@@ -259,22 +256,19 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges(
}
}
- if (ranges.IsEmpty()) {
-if (lo_pc != LLDB_INVALID_ADDRESS) {
- if (hi_pc != LLDB_INVALID_ADDRESS && hi_pc > lo_pc)
-ranges.Append(DWARFRangeList::Entry(lo_pc, hi_pc - lo_pc));
@@ -14690,6 +14690,17 @@ void Sema::FinalizeDeclaration(Decl *ThisDecl) {
}
}
+ // The result of __builtin_counted_by_ref cannot be assigned to a variable.
+ // It allows leaking and modification of bounds safety information.
+ if (const auto *CE = dyn_cast_if_present
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
565a9ac7df3815ed038938942be4cf1471de4755...776f10f61603e922bdc38962836583da42e4f650
lldb/
https://github.com/bwendling updated
https://github.com/llvm/llvm-project/pull/116719
>From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 00:00:00 2001
From: Bill Wendling
Date: Fri, 15 Nov 2024 15:41:48 -0800
Subject: [PATCH 1/3] [Clang] Improve Sema diagnostic performance for
__builtin
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/116827
>From 02637dab316797b0bf6440b549497bf59db2d3c7 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 19 Nov 2024 17:03:48 +0100
Subject: [PATCH] [lldb] Reword the "line 0" warning
We got a bug report that this
Author: Jason Molenda
Date: 2024-11-19T16:01:27-08:00
New Revision: d29a50f358e71a695b23e456d66ed2924617deb9
URL:
https://github.com/llvm/llvm-project/commit/d29a50f358e71a695b23e456d66ed2924617deb9
DIFF:
https://github.com/llvm/llvm-project/commit/d29a50f358e71a695b23e456d66ed2924617deb9.diff
Sirraide wrote:
> Could you point to a place in the code where it creates a placeholder?
I mean, e.g. `CheckPointerToMemberOperands()` can return `BoundMemberTy` as the
type of a `.*` expression, and `CreateBuiltinMatrixSubscriptExpr()` creates a
`MatrixSubscriptExpr` with type `IncompleteMatr
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7e85cb8a8a9de57ed10635b843662148a87b17e5...59f306aed0736a861f5d084f6e203337234bfb96
lldb/
https://github.com/DavidSpickett approved this pull request.
Thanks! LGTM.
Probably for the best since the interface will have changed since the older
videos, I hope they are preserved somewhere inside Apple though.
https://github.com/llvm/llvm-project/pull/116838
_
@@ -906,13 +907,18 @@ Function *SymbolFileDWARF::ParseFunction(CompileUnit
&comp_unit,
AddressRanges ranges;
ModuleSP module_sp(die.GetModule());
- for (const auto &range : die.GetDIE()->GetAttributeAddressRanges(
- die.GetCU(), /*check_hi_lo_pc=*/true)) {
-
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/116727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM modulo formatting.
https://github.com/llvm/llvm-project/pull/116904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -259,22 +256,19 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges(
}
}
- if (ranges.IsEmpty()) {
-if (lo_pc != LLDB_INVALID_ADDRESS) {
- if (hi_pc != LLDB_INVALID_ADDRESS && hi_pc > lo_pc)
-ranges.Append(DWARFRangeList::Entry(lo_pc, hi_pc - lo_pc));
@@ -906,13 +907,18 @@ Function *SymbolFileDWARF::ParseFunction(CompileUnit
&comp_unit,
AddressRanges ranges;
ModuleSP module_sp(die.GetModule());
- for (const auto &range : die.GetDIE()->GetAttributeAddressRanges(
- die.GetCU(), /*check_hi_lo_pc=*/true)) {
-
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/116620
>From 08a947e3a8d6a76d7898a1f3390c4f2ac0446702 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 18 Nov 2024 14:33:40 +0100
Subject: [PATCH 1/2] [lldb/DWARF]
s/DWARFRangeList/llvm::DWARFAddressRangeVector
https://github.com/DavidSpickett approved this pull request.
LGTM
For an expert this wording can imply that the previous wording might be the
case, and for the non-experts it's less misleading.
https://github.com/llvm/llvm-project/pull/116827
___
lld
adrian-prantl wrote:
> This reminds me, could you add a release note talking about these diagnostic
> improvements? They might have started in 19 but we didn't add one then and
> things have improved more since, and I think it's a cool feature.
https://github.com/llvm/llvm-project/pull/116841
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/116838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/116727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/8419
Here is the relevant piece of the bu
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/116838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/116456
>From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Nov 2024 16:06:47 -0800
Subject: [PATCH 1/6] [lldb] Improve editline completion formatting
This
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/116727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](auto &ds) {
augusto2112 wrote:
I'd prefer to spell out the type of `d
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/116711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,69 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class EditlineCompletionsTest(PExpectTest):
+@skipIfAsan
+@skipIfEdit
@@ -2007,19 +2007,9 @@ bool StackFrame::GetStatus(Stream &strm, bool
show_frame_info, bool show_source,
if (num_lines != 0)
have_source = true;
// TODO: Give here a one time warning if source file is missing.
- if (!m_sc.line_entry.line
@@ -0,0 +1,69 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class EditlineCompletionsTest(PExpectTest):
+@skipIfAsan
+@skipIfEdit
https://github.com/felipepiovezan approved this pull request.
Nice catch
https://github.com/llvm/llvm-project/pull/116711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/116711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/116827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](auto &ds) {
+uint16_t column = 0;
+std::vector result, group;
+for (auto d
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/116727
>From 4a9a4b0346e711b596eb14ca9f92f157ae67e469 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 18 Nov 2024 17:33:10 -0800
Subject: [PATCH] [lldb] Improve rendering of inline diagnostics on the colu
Author: Adrian Prantl
Date: 2024-11-19T08:58:49-08:00
New Revision: 8b2dff960d9d987c583c3a6d5729f01d101dc401
URL:
https://github.com/llvm/llvm-project/commit/8b2dff960d9d987c583c3a6d5729f01d101dc401
DIFF:
https://github.com/llvm/llvm-project/commit/8b2dff960d9d987c583c3a6d5729f01d101dc401.diff
Author: Adrian Prantl
Date: 2024-11-19T09:13:00-08:00
New Revision: 6b4f67545d87d5305cbbc20a678fb97ede995579
URL:
https://github.com/llvm/llvm-project/commit/6b4f67545d87d5305cbbc20a678fb97ede995579
DIFF:
https://github.com/llvm/llvm-project/commit/6b4f67545d87d5305cbbc20a678fb97ede995579.diff
labath wrote:
BTW, the main loop changes are something that you should be able to upstream
quite easily. It sounds like the main problem is that you don't have a ppoll
syscall, but the last round of changes means that ppoll is not actually
necessary for its operation (the only reason to use it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/116850.diff
1 Files Affected:
- (modified) lldb/source/Target/Thread.cpp (+1-1)
``diff
diff --git a/lldb/source/Target/Thread.cpp b/lldb/
66 matches
Mail list logo
