[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-15 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/7002 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-15 Thread Jason Molenda via lldb-commits
@@ -6184,7 +6184,14 @@ Status Process::GetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo &range_info) { if (const lldb::ABISP &abi = GetABI()) load_addr = abi->FixAnyAddress(load_addr); - return DoGetMemoryRegionInfo(load_a

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/116338 >From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Fri, 15 Nov 2024 02:16:31 -0600 Subject: [PATCH 1/2] Added XCOFF Header Parsing --- .../ObjectFile/

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5845688e91d85d46c0f47daaf4edfdfc772853cf 132418ff433eb684b23dcb7d6fa8374b774bb06c --e

[Lldb-commits] [lldb] fda4a32 - [lldb] Only run scripted process test on x86_64/arm64

2024-11-15 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-11-15T00:56:34-08:00 New Revision: fda4a324a384af8dc57cbe0a9b6284c2e8ca073f URL: https://github.com/llvm/llvm-project/commit/fda4a324a384af8dc57cbe0a9b6284c2e8ca073f DIFF: https://github.com/llvm/llvm-project/commit/fda4a324a384af8dc57cbe0a9b6284c2e8ca073f.diff

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header Parsing (PR #116337)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/116337 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX created https://github.com/llvm/llvm-project/pull/116338 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issu

[Lldb-commits] [lldb] a1a1a4c - [lldb] Handle an empty SBMemoryRegionInfo from scripted process (#115963)

2024-11-15 Thread via lldb-commits
Author: Jason Molenda Date: 2024-11-15T00:26:10-08:00 New Revision: a1a1a4ced9d4ecba428175c45a24da476bdc55f4 URL: https://github.com/llvm/llvm-project/commit/a1a1a4ced9d4ecba428175c45a24da476bdc55f4 DIFF: https://github.com/llvm/llvm-project/commit/a1a1a4ced9d4ecba428175c45a24da476bdc55f4.diff

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header Parsing (PR #116337)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX created https://github.com/llvm/llvm-project/pull/116337 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issu

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header Parsing (PR #116337)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/116337 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header Parsing (PR #116337)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/116337 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Hi @labath , not sure why the `Labelling new pull requests` check failed. Also, the build check didnt automatically start for this one. https://github.com/llvm/llvm-project/pull/116338 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] [lldb] Make CompilerDecl::GetName (always) return template args (PR #116068)

2024-11-15 Thread Pavel Labath via lldb-commits
labath wrote: > Very interesting find, I _think_ this makes sense since the `FindTypes` query > expects to find template parameters if we're looking up templates. And given > this API is used specifically to perform these kinds of queries, this LGTM. > But please confirm if my understanding is

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/116338 >From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Fri, 15 Nov 2024 02:16:31 -0600 Subject: [PATCH 1/3] Added XCOFF Header Parsing --- .../ObjectFile/

[Lldb-commits] [lldb] [lldb] Make CompilerDecl::GetName (always) return template args (PR #116068)

2024-11-15 Thread Michael Buch via lldb-commits
Michael137 wrote: > I think the problem here is of a more fundamental nature. `FindTypes` finds > **types**. `bar` is _not_ a type. `bar` is. So, while a type query for > `bar` will find the definition DIE with `DW_AT_name="bar"`, that DIE will > actually be defining the type `bar`. So when th

[Lldb-commits] [lldb] [lldb] Make CompilerDecl::GetName (always) return template args (PR #116068)

2024-11-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/116068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: > Do you actually need to parse the headers yourself? The reason for using the > llvm implementation was so that we can avoid that. FWICS, all of this data > should be available through the `(file|auxiliary)Header(32|64)` APIs. Okay, I'll take a look at that. > BTW,

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap.cpp to not use global DAP variable. (PR #116272)

2024-11-15 Thread John Harrison via lldb-commits
@@ -5046,30 +5026,48 @@ int main(int argc, char *argv[]) { pause(); } #endif + + // Initialize LLDB first before we do anything. + lldb::SBDebugger::Initialize(); + + // Terminate the debugger before the C++ destructor chain kicks in. + auto terminate_debugger = +

[Lldb-commits] [lldb] [lldb-da] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/116392 This refactors the port listening mode to allocate a new DAP object for each connection, allowing multiple connections to run concurrently. >From 43b8fc2a222e5460dd56782e31bd1b1ac399e03e Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [lldb-da] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From acfdb2da30b7a49711c3d1ec3be3c9282d6c51b4 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 15 Nov 2024 09:56:43 -0500 Subject: [PATCH] [lldb-da] Refactoring lldb-dap port listening mode to allow mult

[Lldb-commits] [lldb] [lldb-da] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-da] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0fb8fac5d6c10610574e6e472670823eaff0c949 acfdb2da30b7a49711c3d1ec3be3c9282d6c51b4 --e

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes First, `SRE_Pattern` does not exist on newer Python's, use `type(re.compile(''))` like other Python extensions do. The dynamic type is because some earlier versions of Python 3 do not have `re.Pattern`. Seco

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/116452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/116456 This patch improves the formatting of editline completions. The current implementation is naive and doesn't account for the terminal width. Concretely, the old implementation suffered from the following is

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/116456 >From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 15 Nov 2024 16:06:47 -0800 Subject: [PATCH] [lldb] Improve editline completion formatting This pat

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
jimingham wrote: Ah, right. The one place where a ThreadPlan should be messing with the ThreadPlanStack (through its Thread) is ThreadPlan::DidPush. The point of that is largely that thread plans can't push new thread plans on the stack in their constructor - since they aren't on the stack y

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t variablesReference) { } } -SOCKET AcceptConnection(DAP &dap, int portno) { - // Accept a socket connection from any host on "portno". - SOCKET newsockfd = -1; - struct sockaddr_in serv_addr, cli

[Lldb-commits] [lldb] [lldb] Add logging for missing `.dwo` files (PR #116436)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes I had a hard time to debug a `dwo` file whose file was not found. This log message would have saved me a lot of time. --- Full diff: https://github.com/llvm/llvm-project/pull/116436.diff 1 Files

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/116438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/116452 First, `SRE_Pattern` does not exist on newer Python's, use `type(re.compile(''))` like other Python extensions do. The dynamic type is because some earlier versions of Python 3 do not have `re.Pattern`. Seco

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-15 Thread Dave Lee via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -22,8 +22,17 @@ def port: S<"port">, HelpText<"Communicate with the lldb-dap tool over the defined port.">; def: Separate<["-"], "p">, Alias, + MetaVarName<"">, HelpText<"Alias for --port">; +def unix_socket: S<"unix-socket">, + MetaVarName<"">, + HelpText<"Commu

[Lldb-commits] [lldb] [lldb] Convert file address to load address when reading memory for DW_OP_piece (PR #116411)

2024-11-15 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/116411 When parsing an optimized value and reading a piece from a file address, LLDB tries to read the data from memory using that address. This patch converts file address to load address before reading the memory. Fi

[Lldb-commits] [lldb] [lldb] Convert file address to load address when reading memory for DW_OP_piece (PR #116411)

2024-11-15 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/116411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -22,8 +22,17 @@ def port: S<"port">, HelpText<"Communicate with the lldb-dap tool over the defined port.">; def: Separate<["-"], "p">, Alias, + MetaVarName<"">, HelpText<"Alias for --port">; +def unix_socket: S<"unix-socket">, + MetaVarName<"">, + HelpText<"Commu

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t variablesReference) { } } -SOCKET AcceptConnection(DAP &dap, int portno) { - // Accept a socket connection from any host on "portno". - SOCKET newsockfd = -1; - struct sockaddr_in serv_addr, cli

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -140,13 +137,16 @@ struct DAP { llvm::StringRef debug_adaptor_path; InputStream input; OutputStream output; + lldb::SBFile in; + lldb::SBFile out; + lldb::SBFile err; lldb::SBDebugger debugger; lldb::SBTarget target; Variables variables; lldb::SBBroadcas

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -22,8 +22,17 @@ def port: S<"port">, HelpText<"Communicate with the lldb-dap tool over the defined port.">; def: Separate<["-"], "p">, Alias, + MetaVarName<"">, HelpText<"Alias for --port">; +def unix_socket: S<"unix-socket">, + MetaVarName<"">, + HelpText<"Commu

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,6 @@ +#include + +int main(int argc, char const *argv[]) { + printf("hello world!\n"); // breakpoint 1 + return 0; +} vogelsgesang wrote: missing trailing new line (afaik, we are using UNIX conventions, not Windows conventions?) https://github.com

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t variablesReference) { } } -SOCKET AcceptConnection(DAP &dap, int portno) { - // Accept a socket connection from any host on "portno". - SOCKET newsockfd = -1; - struct sockaddr_in serv_addr, cli

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -116,6 +118,8 @@ enum LaunchMethod { Launch, Attach, AttachForSuspendedLaunch }; /// Page size used for reporting addtional frames in the 'stackTrace' request. constexpr int StackPageSize = 20; +void RegisterRequestCallbacks(DAP &dap); vogelsgesang wrote:

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -137,42 +141,232 @@ lldb::SBValueList *GetTopLevelScope(DAP &dap, int64_t variablesReference) { } } -SOCKET AcceptConnection(DAP &dap, int portno) { - // Accept a socket connection from any host on "portno". - SOCKET newsockfd = -1; - struct sockaddr_in serv_addr, cli

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4d4024e1edf354113e8d0d11661d466ae5b0bee7 943bad7a8faa41d21651de765858dbb49584547c --e

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
jimingham wrote: That is a "resource deadlock detected" error, so presumably we are managing to recursively use this ThreadPlanStack lock. I'm a bit confused that none of the stacks printed actually show any ThreadPlanStack functions on the stack??? https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/116452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Convert file address to load address when reading memory for DW_OP_piece (PR #116411)

2024-11-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. This looks plausible. I wish we had just one place where we read from an address so this logic isn't duplicated all over the interpreter. https://github.com/llvm/llvm-project/pull/116411 ___

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() { read_fds.push_back(pfd); } - if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 && + if (ppoll(read_fds.data(), read_fds.size(), +/*timeout=*/nullptr, labath wr

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
@@ -384,6 +313,21 @@ void MainLoopPosix::ProcessReadObject(IOObject::WaitableHandle handle) { it->second(*this); // Do the work } +void MainLoopPosix::ProcessSignals() { + std::vector signals; labath wrote: It's the type that the OS signal APIs use. I t

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/115963 >From f8f1d70d1d9eac6d36c0fa84e2a94c032385da39 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 12 Nov 2024 15:55:15 -0800 Subject: [PATCH 1/6] [lldb] Handle an empty SBMemoryRegionInfo from scripted

[Lldb-commits] [lldb] 10b048c - [lldb] Make CompilerDecl::GetName (always) return template args (#116068)

2024-11-15 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-15T12:24:12+01:00 New Revision: 10b048c8922d746b14e991f468e00b3ca67c9d95 URL: https://github.com/llvm/llvm-project/commit/10b048c8922d746b14e991f468e00b3ca67c9d95 DIFF: https://github.com/llvm/llvm-project/commit/10b048c8922d746b14e991f468e00b3ca67c9d95.diff

[Lldb-commits] [lldb] [lldb] Make CompilerDecl::GetName (always) return template args (PR #116068)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/116068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
labath wrote: > I'm not expert, but everything looks rigorous and you've added a lot of > comments. > > I left a few nits and a singular question. I would encourage comments on some > file descriptors for the less knowledgeable of us (namely me!) That you for the review. Making sure the code

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Do you actually need to parse the headers yourself? The reason for using the llvm implementation was so that we can avoid that. FWICS, all of this data should be available through the `(file|auxiliary)Header(32|64)` APIs. BTW, this is exactly the kind of gr

[Lldb-commits] [lldb] [lldb] rm DWARFDebugRanges (PR #116379)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/116379 The class is only used from one place, which is trivial to implement using the llvm class. The main difference is that in the new implementation, the ranges are parsed each time anew (instead of being parsed at

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/115197 >From 2627a1fc1c0722c72793a3f3e4e9520a65897c20 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 29 Oct 2024 16:56:40 +0100 Subject: [PATCH 1/2] [lldb] Unify/improve MainLoop signal handling Change the sign

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Thanks Jason. Looks good. (I think the arm failure is due to it being a 32-bit machine. Maybe it would be sufficient to use 32-bit values everywhere?) https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commi

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() { read_fds.push_back(pfd); } - if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 && + if (ppoll(read_fds.data(), read_fds.size(), +/*timeout=*/nullptr, +/*sigmask=*/n

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap.cpp to not use global DAP variable. (PR #116272)

2024-11-15 Thread Pavel Labath via lldb-commits
@@ -5046,30 +5026,48 @@ int main(int argc, char *argv[]) { pause(); } #endif + + // Initialize LLDB first before we do anything. + lldb::SBDebugger::Initialize(); + + // Terminate the debugger before the C++ destructor chain kicks in. + auto terminate_debugger = +

[Lldb-commits] [lldb] [lldb][test] Add test categories for Linux and Darwin tests (PR #116194)

2024-11-15 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/116194 >From 34047d525f1caeda6817142ec0d53ec8129a6adb Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Thu, 14 Nov 2024 10:21:36 +0100 Subject: [PATCH 1/2] [lldb][test] Add test categories for Linux and Dar

[Lldb-commits] [lldb] e0b76ba - [lldb][test] Disable inline_sites_live.cpp for non-Windows targets (#116196)

2024-11-15 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-11-15T14:15:29+01:00 New Revision: e0b76bafde197c4813aa52dbcfeaf6bd1f9d96da URL: https://github.com/llvm/llvm-project/commit/e0b76bafde197c4813aa52dbcfeaf6bd1f9d96da DIFF: https://github.com/llvm/llvm-project/commit/e0b76bafde197c4813aa52dbcfeaf6bd1f9d96d

[Lldb-commits] [lldb] [lldb][test] Add test categories for Linux and Darwin tests (PR #116194)

2024-11-15 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Is the real, underlying problem that `skipUnlessDarwin` is checking the host > platform instead of the target platform? I'm somewhat worried about adding a > category that (at first glance) competes with the existing decorators and the > associated risk of folks misundersta

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-15 Thread Pavel Labath via lldb-commits
@@ -17,29 +17,53 @@ #include #include #include +#include #include // Multiplexing is implemented using kqueue on systems that support it (BSD -// variants including OSX). On linux we use ppoll, while android uses pselect -// (ppoll is present but not implemented proper

[Lldb-commits] [lldb] fix: Target Process may crash or freezes on detaching process on windows (PR #115712)

2024-11-15 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/115712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5bbe63e - fix: Target Process may crash or freezes on detaching process on windows (#115712)

2024-11-15 Thread via lldb-commits
Author: anatawa12 Date: 2024-11-15T10:52:36+01:00 New Revision: 5bbe63ec91226c0026c6f1ed726c45bb117544e0 URL: https://github.com/llvm/llvm-project/commit/5bbe63ec91226c0026c6f1ed726c45bb117544e0 DIFF: https://github.com/llvm/llvm-project/commit/5bbe63ec91226c0026c6f1ed726c45bb117544e0.diff LOG

[Lldb-commits] [lldb] fix: Target Process may crash or freezes on detaching process on windows (PR #115712)

2024-11-15 Thread via lldb-commits
github-actions[bot] wrote: @anatawa12 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread Pavel Labath via lldb-commits
labath wrote: > Hi @labath , not sure why the `Labelling new pull requests` check failed. > Also, the build check didnt automatically start for this one. I don't know, but I wouldn't be worried about that. The test failure is more of a concern. https://github.com/llvm/llvm-project/pull/116338

[Lldb-commits] [lldb] [lldb][test] Disable inline_sites_live.cpp for non-Windows targets (PR #116196)

2024-11-15 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/116196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add logging for missing `.dwo` files (PR #116436)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/116436 I had a hard time to debug a `dwo` file whose file was not found. This log message would have saved me a lot of time. >From 042426896e517cf9e424279c2b25bbf655879a47 Mon Sep 17 00:00:00 2001 From: Adrian Vo

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/116438 I have some reports of A/B inversion deadlocks between the ThreadPlanStack and the StackFrameList accesses. There's a fair bit of reasonable code in lldb that does "While accessing the ThreadPlanStack, look

[Lldb-commits] [lldb] [lldb] Convert file address to load address when reading memory for DW_OP_piece (PR #116411)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes When parsing an optimized value and reading a piece from a file address, LLDB tries to read the data from memory using that address. This patch converts file address to load address before reading the memory. F

[Lldb-commits] [lldb] [lldb] Convert file address to load address when reading memory for DW_OP_piece (PR #116411)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Ilia Kuklin (kuilpd) Changes When parsing an optimized value and reading a piece from a file address, LLDB tries to read the data from memory using that address. This patch converts file address to load address before reading the memor

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -22,8 +22,17 @@ def port: S<"port">, HelpText<"Communicate with the lldb-dap tool over the defined port.">; def: Separate<["-"], "p">, Alias, + MetaVarName<"">, HelpText<"Alias for --port">; +def unix_socket: S<"unix-socket">, + MetaVarName<"">, + HelpText<"Commu

[Lldb-commits] [lldb] [lldb] rm DWARFDebugRanges (PR #116379)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Beautiful. https://github.com/llvm/llvm-project/pull/116379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -250,6 +251,13 @@ def which(program): return None +def pickrandomport(): +"""Returns a random open port.""" +with socket.socket() as sock: +sock.bind(("", 0)) +return sock.getsockname()[1] vogelsgesang wrote: afaict, this will

[Lldb-commits] [lldb] [llvm] [DebugInfo] Add explicit visibility macros to CodeView template functions (PR #113102)

2024-11-15 Thread Vassil Vassilev via lldb-commits
vgvassilev wrote: @zmodem, ping. https://github.com/llvm/llvm-project/pull/113102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/116438 >From 943bad7a8faa41d21651de765858dbb49584547c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 15 Nov 2024 12:20:33 -0800 Subject: [PATCH 1/2] Convert ThreadPlanStack's mutex to a shared mutex. Since sha

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Mechanically this change looks good, plus I'm always happy to see another recursive mutex go. One side-effect of this change is that previously, the ThreadPlanStack mutex was indirectly protecting some operations on ThreadPlans too. For example, `Th

[Lldb-commits] [lldb] [lldb][sbapi][NFC] Remove commented out typedef from SBBreakpointName (PR #116434)

2024-11-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/116434 SBBreakpointName has a typedef for BreakpointHitCallback used in SetCallback(), but this typedef has been commented out in SBBreakpointName and added instead to SBDefines. Since SB API callbacks are place

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/116438 >From 943bad7a8faa41d21651de765858dbb49584547c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 15 Nov 2024 12:20:33 -0800 Subject: [PATCH 1/3] Convert ThreadPlanStack's mutex to a shared mutex. Since sha

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes I have some reports of A/B inversion deadlocks between the ThreadPlanStack and the StackFrameList accesses. There's a fair bit of reasonable code in lldb that does "While accessing the ThreadPlanStack, look at tha

[Lldb-commits] [lldb] [lldb][sbapi][NFC] Remove commented out typedef from SBBreakpointName (PR #116434)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes SBBreakpointName has a typedef for BreakpointHitCallback used in SetCallback(), but this typedef has been commented out in SBBreakpointName and added instead to SBDefines. Since SB API callbacks ar

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header Parsing (PR #116337)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I've made this a draft because this still needs a test. https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][sbapi][NFC] Remove commented out typedef from SBBreakpointName (PR #116434)

2024-11-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/116434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This refactors the port listening mode to allocate a new DAP object for each connection, allowing multiple connections to run concurrently. --- Patch is 32.80 KiB, truncated to 20.00 KiB below, full version:

[Lldb-commits] [lldb] [lldb] rm DWARFDebugRanges (PR #116379)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The class is only used from one place, which is trivial to implement using the llvm class. The main difference is that in the new implementation, the ranges are parsed each time anew (instead of being parsed

[Lldb-commits] [lldb] [lldb][AIX] Header Parsing for XCOFF Object File in AIX (PR #116338)

2024-11-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-projec