[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #113121)

https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

https://github.com/SixWeining approved this pull request. LGTM and thanks! https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Push down cpython module to the submodule (PR #113066)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/113066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Push down cpython module to the submodule (PR #113066)

@@ -145,7 +145,7 @@ add_lldb_library(liblldb SHARED ${option_framework} ${option_install_prefix} ) -# lib/pythonX.Y/dist-packages/lldb/_lldb.so is a symlink to lib/liblldb.so, +# lib/pythonX.Y/site-packages/lldb/_lldb.so is a symlink to lib/liblldb.so, JDevl

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -508,8 +508,20 @@ void BreakpointLocation::GetDescription(Stream *s, s->PutCString("re-exported target = "); else s->PutCString("where = "); + + // If there's a preferred line entry for printing, use that. + bool show_function_info = true; +

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 911a6f2 - [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (#112296)

Author: Liu An Date: 2024-10-21T10:04:55+01:00 New Revision: 911a6f2fcc719c46b5b392823473ba0bb5b1f4e1 URL: https://github.com/llvm/llvm-project/commit/911a6f2fcc719c46b5b392823473ba0bb5b1f4e1 DIFF: https://github.com/llvm/llvm-project/commit/911a6f2fcc719c46b5b392823473ba0bb5b1f4e1.diff LOG: [

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

DavidSpickett wrote: ping! @omjavaid https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

https://github.com/lawn123 updated https://github.com/llvm/llvm-project/pull/112296 >From ba485de763a08f6ff3c7468c1a1bfbbfb25ac48f Mon Sep 17 00:00:00 2001 From: Liu An Date: Tue, 15 Oct 2024 10:31:35 +0800 Subject: [PATCH 1/5] [LoongArch64]: Add support for LoongArch64 in elf-core for lldb -

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

lawn123 wrote: @DavidSpickett @SixWeining I have fix CI fail and fcsr format issues https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

github-actions[bot] wrote: @lawn123 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] c47df3e - [lldb][test] Make vector operator[] return T& to workaround Arm codegen issue

Author: David Spickett Date: 2024-10-21T11:54:54Z New Revision: c47df3e8c8f47bab8a8302757c50710e0e1c43fb URL: https://github.com/llvm/llvm-project/commit/c47df3e8c8f47bab8a8302757c50710e0e1c43fb DIFF: https://github.com/llvm/llvm-project/commit/c47df3e8c8f47bab8a8302757c50710e0e1c43fb.diff LOG

[Lldb-commits] [lldb] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (PR #112062)

CarlosAlbertoEnciso wrote: @adrian-prantl It seems that this change is causing the 'lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp' to fail when building using GCC. c2750807ba2a [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (#112062) ``` ../llvm-project/lldb/uni

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

abhina-sree wrote: Closing this because an alternative solution was implemented here https://github.com/llvm/llvm-project/pull/111723 https://github.com/llvm/llvm-project/pull/110661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/110661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 38b7837bcc5da9e89778191654f9552ebccacbd5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[Lldb-commits] [clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

https://github.com/Michael137 commented: gentle ping @efriedma-quic mind taking another look? Latest iteration skips over empty fields that overlap. https://github.com/llvm/llvm-project/pull/97443 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] 1bf1e92 - [lldb] Avoid repeated map lookups (NFC) (#113121)

Author: Kazu Hirata Date: 2024-10-21T06:51:25-07:00 New Revision: 1bf1e92c72ec9086ab24103cf968e115b7248101 URL: https://github.com/llvm/llvm-project/commit/1bf1e92c72ec9086ab24103cf968e115b7248101 DIFF: https://github.com/llvm/llvm-project/commit/1bf1e92c72ec9086ab24103cf968e115b7248101.diff L

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #113121)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/113121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove stack_logging.h (PR #112987)

https://github.com/jasonmolenda approved this pull request. ah, hilarious. good cleanup. https://github.com/llvm/llvm-project/pull/112987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] 4de708e - [lldb] Remove stack_logging.h (#112987)

Author: Jonas Devlieghere Date: 2024-10-21T10:45:55-07:00 New Revision: 4de708e32e31ac32b924dfeb020086636700c0f7 URL: https://github.com/llvm/llvm-project/commit/4de708e32e31ac32b924dfeb020086636700c0f7 DIFF: https://github.com/llvm/llvm-project/commit/4de708e32e31ac32b924dfeb020086636700c0f7.d

[Lldb-commits] [lldb] [lldb] Remove stack_logging.h (PR #112987)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/112987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/113166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/112939 >From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 3 Oct 2024 18:24:46 -0700 Subject: [PATCH 1/7] Add the ability to break on call-site locations, report the c

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 30a4028 - [lldb][NFC] Fix doxygen comment on top of GetMangledTypeName

Author: Augusto Noronha Date: 2024-10-21T10:37:46-07:00 New Revision: 30a402833f50b14148c8b963f3ffaaeaeea5fd78 URL: https://github.com/llvm/llvm-project/commit/30a402833f50b14148c8b963f3ffaaeaeea5fd78 DIFF: https://github.com/llvm/llvm-project/commit/30a402833f50b14148c8b963f3ffaaeaeea5fd78.dif

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

JDevlieghere wrote: Now that the system log is a Darwin-only concept and the review comments have been addressed, I assume nobody objects to merging this? https://github.com/llvm/llvm-project/pull/111911 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -87,6 +87,22 @@ void BreakpointSite::GetDescription(Stream *s, lldb::DescriptionLevel level) { m_constituents.GetDescription(s, level); } +std::optional BreakpointSite::GetSuggestedStackFrameIndex() { + + std::optional result; + std::lock_guard guard(m_constituents_mut

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -508,8 +508,20 @@ void BreakpointLocation::GetDescription(Stream *s, s->PutCString("re-exported target = "); else s->PutCString("where = "); + + // If there's a preferred line entry for printing, use that. + bool show_function_info = true; +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -71,7 +71,7 @@ int Declaration::Compare(const Declaration &a, const Declaration &b) { } bool Declaration::FileAndLineEqual(const Declaration &declaration) const { - int file_compare = FileSpec::Compare(this->m_file, declaration.m_file, true); + int file_compare = FileSpe

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -87,6 +87,22 @@ void BreakpointSite::GetDescription(Stream *s, lldb::DescriptionLevel level) { m_constituents.GetDescription(s, level); } +std::optional BreakpointSite::GetSuggestedStackFrameIndex() { + + std::optional result; + std::lock_guard guard(m_constituents_mut

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

labath wrote: Actually (and, in retrospect, obviously) llvm already has [functions](https://github.com/llvm/llvm-project/blob/7dc2542ac24fcae89dfd179fa58c4ec4fb959e2b/llvm/include/llvm/Support/ConvertUTF.h#L227C6-L227C23) for wstring<->string conversions, so it would be best to use those. http

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: GkvJwa wrote: In fact, for many developers on Windows, `make.exe` will not be in the environment

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

https://github.com/DavidSpickett approved this pull request. I guess it sees each `# ...` as the start of a new document? Strange. https://github.com/llvm/llvm-project/pull/113166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext( 0, file_indexes, src_location_spec, &line_entry); } + // If we didn't manage to find a breakpoint that matched the line number + // requested, that might be because it is only an inline call site, and +

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/113166 Currently all the headings marked as `#` show up as a top-level entry in the `Developing LLDB` toctree. This patch marks these as `##` so only `Adding Programming Language Support` is displayed in the table of

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Currently all the headings marked as `#` show up as a top-level entry in the `Developing LLDB` toctree. This patch marks these as `##` so only `Adding Programming Language Support` is displayed in the table

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

jimingham wrote: > On Oct 19, 2024, at 8:29 PM, Med Ismail Bennani ***@***.***> wrote: > > > @rocallahan does rr work on Mac? > > No, it doesn't. It does work on Linux AAarch64 though. > > This didn't work because we also build lldb-server on macOS. > > Hmm,

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

zmodem wrote: Thanks for reverting! I must have missed this PR originally. I oppose letting Git change any line endings. It always ends like this. https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] 40ea92c - [lldb] Update ScriptInterpreterTests for CommandReturnObject API change

Author: Jonas Devlieghere Date: 2024-10-21T11:37:26-07:00 New Revision: 40ea92c859234d536553cf26650e89d6e52071c6 URL: https://github.com/llvm/llvm-project/commit/40ea92c859234d536553cf26650e89d6e52071c6 DIFF: https://github.com/llvm/llvm-project/commit/40ea92c859234d536553cf26650e89d6e52071c6.d

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext( 0, file_indexes, src_location_spec, &line_entry); } + // If we didn't manage to find a breakpoint that matched the line number + // requested, that might be because it is only an inline call site, and +

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -87,6 +87,22 @@ void BreakpointSite::GetDescription(Stream *s, lldb::DescriptionLevel level) { m_constituents.GetDescription(s, level); } +std::optional BreakpointSite::GetSuggestedStackFrameIndex() { + + std::optional result; + std::lock_guard guard(m_constituents_mut

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -87,6 +87,22 @@ void BreakpointSite::GetDescription(Stream *s, lldb::DescriptionLevel level) { m_constituents.GetDescription(s, level); } +std::optional BreakpointSite::GetSuggestedStackFrameIndex() { + + std::optional result; + std::lock_guard guard(m_constituents_mut

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #113248)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/113248 None >From 89e3f1ca679e8e821205d1c0e729ea575cac5031 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 21 Oct 2024 07:04:48 -0700 Subject: [PATCH] [lldb] Avoid repeated hash lookups (NFC) --- .../Fr

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #113248)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/113248.diff 1 Files Affected: - (modified) lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp (+3-3) ```

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/113251 TestUseSourceCache attempts to write to a build artifact copied from the source tree, and asserts the write succeeded. If the source tree is read only, the copy will also be read only, causing it to fail. Whe

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes TestUseSourceCache attempts to write to a build artifact copied from the source tree, and asserts the write succeeded. If the source tree is read only, the copy will also be read only, causing it to fai

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/112939 >From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 3 Oct 2024 18:24:46 -0700 Subject: [PATCH 1/8] Add the ability to break on call-site locations, report the c

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -656,6 +671,49 @@ void BreakpointLocation::SendBreakpointLocationChangedEvent( } } +std::optional BreakpointLocation::GetSuggestedStackFrameIndex() { + if (!GetPreferredLineEntry()) +return {}; + LineEntry preferred = *GetPreferredLineEntry(); jimi

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/112939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/112939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -537,7 +549,10 @@ void BreakpointLocation::GetDescription(Stream *s, if (sc.line_entry.line > 0) { s->EOL(); s->Indent("location = "); - sc.line_entry.DumpStopContext(s, true); + if (GetPreferredLineEntry()) +GetPrefe

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -71,7 +71,7 @@ int Declaration::Compare(const Declaration &a, const Declaration &b) { } bool Declaration::FileAndLineEqual(const Declaration &declaration) const { - int file_compare = FileSpec::Compare(this->m_file, declaration.m_file, true); + int file_compare = FileSpe

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/112939 >From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 3 Oct 2024 18:24:46 -0700 Subject: [PATCH 1/9] Add the ability to break on call-site locations, report the c

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

rupprecht wrote: A more platform-agnostic way to do this would be to do it from Python: ```py src = self.getBuildArtifact("main-copy.cpp") statinfo = os.stat(src) os.chmod(src, statinfo.st_mode | stat.S_IWUSR) ``` However, I don't understand the test case well enough to

[Lldb-commits] [lldb] Add the ability to break on call-site locations, improve inline stepping (PR #112939)

@@ -71,7 +71,7 @@ int Declaration::Compare(const Declaration &a, const Declaration &b) { } bool Declaration::FileAndLineEqual(const Declaration &declaration) const { - int file_compare = FileSpec::Compare(this->m_file, declaration.m_file, true); + int file_compare = FileSpe

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

https://github.com/igorkudrin edited https://github.com/llvm/llvm-project/pull/113251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestUseSourceCache for readonly source trees (PR #113251)

@@ -6,3 +6,6 @@ include Makefile.rules # Copy file into the build folder to enable the test to modify it. main-copy.cpp: main.cpp cp -f $< $@ +ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows igorkudrin wrote: If I understand correctly, w

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +llvm::sort(ds.begin(), ds.end(), [](

[Lldb-commits] [lldb] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (PR #112062)

adrian-prantl wrote: @JDevlieghere fixed this in 40ea92c859234d536553cf26650e89d6e52071c6 https://github.com/llvm/llvm-project/pull/112062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112582 >From de19f43fbee9aff2a99106a23b7f264012ab5485 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 21 Oct 2024 13:40:02 -0700 Subject: [PATCH] [lldb] Use LLVM's helper for Unicode conversion (NFC)

[Lldb-commits] [lldb] 7b703bd - [lldb][docs] Fix "Developing LLDB" table of contents (#113166)

Author: Michael Buch Date: 2024-10-21T22:19:26+01:00 New Revision: 7b703bd3e7c1f8fa2274978679664d41673cdea1 URL: https://github.com/llvm/llvm-project/commit/7b703bd3e7c1f8fa2274978679664d41673cdea1 DIFF: https://github.com/llvm/llvm-project/commit/7b703bd3e7c1f8fa2274978679664d41673cdea1.diff

[Lldb-commits] [lldb] [lldb][docs] Fix "Developing LLDB" table of contents (PR #113166)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/113166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/113220 None >From 417e6f4c27d1603d118dadd8327e57b766626e6d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 21 Oct 2024 13:57:09 -0700 Subject: [PATCH] [lldb] Fix the sorting function for diagnostics ---

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +llvm::sort(ds.begin(), ds.end(), [](

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/113220.diff 2 Files Affected: - (modified) lldb/source/Utility/DiagnosticsRendering.cpp (+2-2) - (modified) lldb/unittests/Utility/Diagnosti

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/113220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 74e1554 - [lldb] Fix the sorting function for diagnostics (#113220)

Author: Adrian Prantl Date: 2024-10-21T14:03:49-07:00 New Revision: 74e1554d7b4013a975cf5fb8df64a6419bb14a45 URL: https://github.com/llvm/llvm-project/commit/74e1554d7b4013a975cf5fb8df64a6419bb14a45 DIFF: https://github.com/llvm/llvm-project/commit/74e1554d7b4013a975cf5fb8df64a6419bb14a45.diff

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/113220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the sorting function for diagnostics (PR #113220)

https://github.com/slackito approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/113220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Push down cpython module to the submodule (PR #113066)

https://github.com/JDevlieghere commented: Can you reference documentation about the `.native` import and explain why this is necessary? Intuitively it makes sense but I want to make sure I fully understand this change and having it documented will help the next person that sees this. https:

[Lldb-commits] [lldb] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (PR #112062)

CarlosAlbertoEnciso wrote: > @JDevlieghere fixed this in > [40ea92c](https://github.com/llvm/llvm-project/commit/40ea92c859234d536553cf26650e89d6e52071c6) @adrian-prantl, @JDevlieghere Thanks for the fix. https://github.com/llvm/llvm-project/pull/112062