Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com>, Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com>, Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com>, Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com>, Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com>, Stefan =?utf-8?q?Gränitz?= <stefan.graen...@gmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/111...@github.com>
GkvJwa wrote: In fact, for many developers on Windows, `make.exe` will not be in the environment PATH, which will cause cmake to fail to find and ultimately delay the build of the project error. I personally think it is better to use `FATAL_ERROR` instead of `SEND_ERROR`. After all, it will cause cmake to continue executing for a short period of time and finally display ``` CMake Error at C:/llvm-project/lldb/test/API/CMakeLists.txt:60 (message): LLDB tests require 'make' tool. Please pass via `LLDB_TEST_MAKE` (or otherwise disable tests with `LLDB_INCLUDE_TESTS=OFF`) -- BugpointPasses ignored -- Loadable modules not supported on this platform. -- Google Benchmark version: v0.0.0, normalized to 0.0.0 -- Looking for shm_open in rt -- Looking for shm_open in rt - not found -- Performing Test HAVE_CXX_FLAG_EHS_ -- Performing Test HAVE_CXX_FLAG_EHS_ - Success -- Performing Test HAVE_CXX_FLAG_EHA_ -- Performing Test HAVE_CXX_FLAG_EHA_ - Success -- Compiling and running to test HAVE_GNU_POSIX_REGEX -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile -- Compiling and running to test HAVE_POSIX_REGEX -- Performing Test HAVE_POSIX_REGEX -- failed to compile CMake Warning at C:/llvm-project/third-party/benchmark/CMakeLists.txt:319 (message): Using std::regex with exceptions disabled is not fully supported -- Compiling and running to test HAVE_STEADY_CLOCK -- Performing Test HAVE_STEADY_CLOCK -- success -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - not found -- Found Threads: TRUE -- Compiling and running to test HAVE_PTHREAD_AFFINITY -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile -- Configuring incomplete, errors occurred! ``` https://github.com/llvm/llvm-project/pull/111531 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
