https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/112720
This allows languages to provide an opinion on whether two symbol contexts are
equivalent (i.e. belong to the same function).
It is useful to drive the comparisons done by stepping plans that need to
en
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This allows languages to provide an opinion on whether two symbol contexts are
equivalent (i.e. belong to the same function).
It is useful to drive the comparisons done by stepping plans
@@ -212,15 +209,14 @@ TEST_F(MainLoopTest, PendingCallbackTrigger) {
ASSERT_TRUE(callback2_called);
}
-// Regression test for assertion failure if a lot of callbacks end up
-// being queued after loop exits.
-TEST_F(MainLoopTest, PendingCallbackAfterLoopExited) {
+TEST_F(Mai
labath wrote:
Thanks for the reviews.
https://github.com/llvm/llvm-project/pull/112565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112566
>From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Oct 2024 15:48:47 +0100
Subject: [PATCH 1/4] [lldb][test] Add test for ASTImporter's name conflict
res
Michael137 wrote:
Skipped for now
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
felipepiovezan wrote:
> do we have in mind any other languages that will implement this?
I suspect any language wanting to implement this notion of function splitting
(e.g. all the users of corosplitter) and virtual frames could have a use for
this
https://github.com/llvm/llvm-project/pull/1
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f113a66c29b17e4937ff5d0ab67dc087fa6ee27e...110b0d6ba90be4041a880a9a9963019850782e75
lldb/
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/111814
>From 08c9d5ae66ca857d165dc878ebd1b2e0de364a24 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Thu, 10 Oct 2024 02:24:42 -0500
Subject: [PATCH 1/6] Taking base file structure from ELF as reference
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,243 @@
+//===-- ObjectFileXCOFF.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
kusmour wrote:
> What you describe makes some sense, but could you give an example of where
> this is used?
>
> Can this be triggered with `lldb program file --`? If
> so it would be good to 1. put that in the commit message in case anyone hits
> the same problem and searches the log, and 2.
DhruvSrivastavaX wrote:
> This is exactly what I had in mind -- thank you.
>
> The patch looks mostly good, apart from the inline comments. My main question
> is about the "dependant modules" parsing code. AFAICT, its not actually
> functional (and not tested). Is yaml2objs xcoff backend suffi
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112748
This patch emits a warning into the expression log when we call `MapImported`
on a decl which has already been imported, but with a new `to` destination
decl. In asserts builds this would lead to triggering
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch emits a warning into the expression log when we call `MapImported`
on a decl which has already been imported, but with a new `to` destination
decl. In asserts builds this would lead to triggerin
labath wrote:
It would be nice to have a test which verifies actual behavior rather than just
some flag being set somewhere. For example, you could add to/extend
`test/API/python_api/process/io/TestProcessIO.py` so that it writes some
initial data to the output file, and then verify that the
@@ -365,10 +365,7 @@ Status MainLoopPosix::Run() {
Status error;
RunImpl impl(*this);
- // run until termination or until we run out of things to listen to
- // (m_read_fds will always contain m_trigger_pipe fd, so check for > 1)
- while (!m_terminate_request &&
---
kastiglione wrote:
do we have in mind any other languages that will implement this?
https://github.com/llvm/llvm-project/pull/112720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2024-10-17T07:45:50-07:00
New Revision: 9173fd77394aa9617b235e1b146114f76c6d77d6
URL:
https://github.com/llvm/llvm-project/commit/9173fd77394aa9617b235e1b146114f76c6d77d6
DIFF:
https://github.com/llvm/llvm-project/commit/9173fd77394aa9617b235e1b146114f76c6d77d6.diff
L
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/112565
>From 8a531630f6b233d83f33740ce9dbbd9b3a778641 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 16 Oct 2024 16:54:06 +0200
Subject: [PATCH 1/4] [lldb] Don't exit the main loop when in runs out of
things to
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/112655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko approved this pull request.
https://github.com/llvm/llvm-project/pull/111951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
Author: Jonas Devlieghere
Date: 2024-10-17T08:19:58-07:00
New Revision: 8c7f80f77505b7ff275d67a49f4f2dd07d604403
URL:
https://github.com/llvm/llvm-project/commit/8c7f80f77505b7ff275d67a49f4f2dd07d604403
DIFF:
https://github.com/llvm/llvm-project/commit/8c7f80f77505b7ff275d67a49f4f2dd07d604403.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112446
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-17T08:22:56-07:00
New Revision: 4897fc44a918b8da886d48082b6cf004cf3ffe0b
URL:
https://github.com/llvm/llvm-project/commit/4897fc44a918b8da886d48082b6cf004cf3ffe0b
DIFF:
https://github.com/llvm/llvm-project/commit/4897fc44a918b8da886d48082b6cf004cf3ffe0b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/112276
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/112565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-10-17T17:29:38+02:00
New Revision: 98b419ca7688aa2823df1e87f58051aaa8d9c37f
URL:
https://github.com/llvm/llvm-project/commit/98b419ca7688aa2823df1e87f58051aaa8d9c37f
DIFF:
https://github.com/llvm/llvm-project/commit/98b419ca7688aa2823df1e87f58051aaa8d9c37f.diff
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112735
Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without
specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never
built (and linked). We should probably make that a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without
specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never
built (and linked). We should probably make that
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112566
>From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Oct 2024 15:48:47 +0100
Subject: [PATCH 1/5] [lldb][test] Add test for ASTImporter's name conflict
res
jimingham wrote:
Note that a lot of lldb was written before C++11 was allowed in llvm projects.
So looking through code that hasn't been touched recently, you will likely find
constructs that could be made more efficient with some of the newer C++
gadgets. We probably shouldn't be doing chan
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
jimingham wrote:
> > do we have in mind any other languages that will implement this?
>
> I suspect any language wanting to implement this notion of function splitting
> (e.g. all the users of corosplitter) and virtual frames could have a use for
> this
We already have `.cold` functions that
101 - 137 of 137 matches
Mail list logo
