[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-25 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/108907 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/2] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-25 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/108907 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/2] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-25 Thread via lldb-commits
@@ -301,7 +301,8 @@ using Entry = llvm::DWARFDebugNames::Entry; /// If any parent does not have an `IDX_parent`, or the Entry data is corrupted, /// nullopt is returned. std::optional> -getParentChain(Entry entry, uint32_t max_parents) { +getParentChain(Entry entry, +

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-25 Thread Tom Yang via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] 3d04695 - [lldb] fix one-off error in vformat specifier

2024-09-25 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-09-25T21:36:51-07:00 New Revision: 3d0469516c687b6dad3e6482fd94d64c65fa4a01 URL: https://github.com/llvm/llvm-project/commit/3d0469516c687b6dad3e6482fd94d64c65fa4a01 DIFF: https://github.com/llvm/llvm-project/commit/3d0469516c687b6dad3e6482fd94d64c65fa4a01.diff

[Lldb-commits] [lldb] 0f98497 - [lldb] [Mach-O corefiles] Sanity check malformed dyld

2024-09-25 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-09-25T21:51:38-07:00 New Revision: 0f984976897857a8f4003063be6fa38a733fa624 URL: https://github.com/llvm/llvm-project/commit/0f984976897857a8f4003063be6fa38a733fa624 DIFF: https://github.com/llvm/llvm-project/commit/0f984976897857a8f4003063be6fa38a733fa624.diff

[Lldb-commits] [lldb] [DWARF]Set uuid for symbol file spec (PR #110066)

2024-09-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Change makes sense, but is there a way to test this? https://github.com/llvm/llvm-project/pull/110066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve namespace lookup review (PR #110062)

2024-09-25 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/110062 ## Summary This PR is a continuation of https://github.com/llvm/llvm-project/pull/108907 by using `.debug_names` parent chain faster lookup for namespaces. ## Implementation Similar to https://github.com/

[Lldb-commits] [lldb] Improve namespace lookup review (PR #110062)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes ## Summary This PR is a continuation of https://github.com/llvm/llvm-project/pull/108907 by using `.debug_names` parent chain faster lookup for namespaces. ## Implementation Similar to https://github.com/llvm/l

[Lldb-commits] [lldb] Improve namespace lookup review (PR #110062)

2024-09-25 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/110062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve namespace lookup review (PR #110062)

2024-09-25 Thread via lldb-commits
jeffreytan81 wrote: This is a stack PR from https://github.com/llvm/llvm-project/pull/108907, so please review the new namespaces lookup changes and ignore the changes in https://github.com/llvm/llvm-project/pull/108907. Let me know if there is a way to only show the delta changes (not merged

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-25 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106470 >From 9f4ba3fdb8b144736e51134ced3019a2c57ca861 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an l

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-09-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/110065 This fixes a functionality gap with GDB, where GDB will properly decode the stop reason and give the address for SIGSEGV. I also added descriptions to all stop reasons, following the same code path that the Nat

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This fixes a functionality gap with GDB, where GDB will properly decode the stop reason and give the address for SIGSEGV. I also added descriptions to all stop reasons, following the same code path that the

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-25 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > > > This seems like it could be problematic for IDEs, if they don't print the > > > error in the same window as the expression being evaluated. The arrows > > > could end up pointing to nowhere, or to the wrong place in the expression > > > (if we don't get the right off

[Lldb-commits] [lldb] [DWARF]Set uuid for symbol file spec (PR #110066)

2024-09-25 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/110066 The gnu build id was lost while creating the new module spec, this result in the SymbolLocatorDebuginfod not able to locate symbol file. before this change while connecting to debuginfod server I am seeing

[Lldb-commits] [lldb] [DWARF]Set uuid for symbol file spec (PR #110066)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes The gnu build id was lost while creating the new module spec, this result in the SymbolLocatorDebuginfod not able to locate symbol file. before this change while connecting to debuginfod server I am seeing this

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Adrian Prantl via lldb-commits
@@ -254,14 +256,46 @@ class ClangDiagnosticManagerAdapter : public clang::DiagnosticConsumer { std::string stripped_output = std::string(llvm::StringRef(m_output).trim()); - auto new_diagnostic = std::make_unique( - stripped_output, severity, Inf

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff df4f828938db807fc7c4611896fe9659af482e81 8e1c59729905fb89a8764ace3dfa0d04119d273e --e

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/110058 They are close enough to swap lldb's `DWARFDebugArangeSet` with the llvm one. The difference is that llvm's `DWARFDebugArangeSet` add empty ranges when extracting. To accommodate this, `DWARFDebugAranges` in l

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes They are close enough to swap lldb's `DWARFDebugArangeSet` with the llvm one. The difference is that llvm's `DWARFDebugArangeSet` add empty ranges when extracting. To accommodate this, `DWARFDebugAranges` in ll

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From d6eec42d53f17bfa34fec7623d1616fbca0a0140 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Adrian Prantl via lldb-commits
@@ -61,8 +65,50 @@ std::string DiagnosticManager::GetString(char separator) { stream << message.drop_front(severity_pos + severity.size()); stream << separator; } + return str; +} - return ret; +void DiagnosticManager::Dump(Log *log) { + if (!log) +return;

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/2] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 9f4ba3fdb8b144736e51134ced3019a2c57ca861 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM In theory we could test this but it'd be platform specific and error injection is always tricky, the change is straightforward, so let's not worry about it. https://github.com/llvm/llvm-project/pull/106950 __

[Lldb-commits] [lldb] c93e294 - [lldb] fix vFile:open, vFile:unlink error codes (#106950)

2024-09-25 Thread via lldb-commits
Author: dlav-sc Date: 2024-09-25T10:13:40+01:00 New Revision: c93e29439b1ab8ef6873c385f152a06e3395cb59 URL: https://github.com/llvm/llvm-project/commit/c93e29439b1ab8ef6873c385f152a06e3395cb59 DIFF: https://github.com/llvm/llvm-project/commit/c93e29439b1ab8ef6873c385f152a06e3395cb59.diff LOG:

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/106950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Feels like we diverted you from your original problem though, which was the remote taking the informative errno and changing it to some meaningless value. If you've solved your problem then no obligation to do any more but if you do want to look into the other reporting me

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-09-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: We're almost there for the save all / restore all anyway. We'll need special cases for SME of course but SME is weird enough to justify that. https://github.com/llvm/llvm-project/pull/106695 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] 5ee2dea - [lldb][AArch64][Linux] Add Floating Point Mode Register (#106695)

2024-09-25 Thread via lldb-commits
Author: David Spickett Date: 2024-09-25T10:27:57+01:00 New Revision: 5ee2deac0c3b85deaeb0031b4030db99d266abdc URL: https://github.com/llvm/llvm-project/commit/5ee2deac0c3b85deaeb0031b4030db99d266abdc DIFF: https://github.com/llvm/llvm-project/commit/5ee2deac0c3b85deaeb0031b4030db99d266abdc.diff

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-09-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > There will be more features in future meaning more read/ write routines doing > almost similar stuff. IMO We may later consider refactoring the code to provide a top level interface for feature registers read and write. Yes I would like a "data driven" model for it. I go

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/106695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 706821b - [lldb][test] Skip TestConcurrentVFork on all Linux

2024-09-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-25T10:08:10+01:00 New Revision: 706821ba8ff9db829252581dd12d8c5ee2e7b3f0 URL: https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0 DIFF: https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0.diff

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-25 Thread Pavel Labath via lldb-commits
labath wrote: > Is the following correct: Even if the user does not have debug symbols > installed, it would always be sufficient to match the **first** named frame. That *might* work. The complication is that the name of the "first named frame" will different depending on whether you have deb

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-09-25 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. This looks good to me. I haven't tested it myself though. Just one thing that's bothering me is that we are now gradually implementing a number of similar functions to read/write feature registers like ZT ZA or FPMR etc. There will be m

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-25 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, the thing which makes the core files different from live processes is that core files (at least minidumps, the situation is a bit fuzzier for elf cores) often have a better idea of where the files are located. OTOH, the dynamic loader plugin is a (I'm deliberately not using

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-25 Thread via lldb-commits
jimingham wrote: > On Sep 24, 2024, at 10:25 AM, Adrian Vogelsgesang ***@***.***> wrote: > > > However, with these new "hiding frame" recognizers, we are using the frame > hiding recognizers to handle "step out past hidden frames". So if - as was > done in the original implementation - we'r

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-25 Thread via lldb-commits
jimingham wrote: > On Sep 25, 2024, at 10:33 AM, Jim Ingham ***@***.***> wrote: > >> >> >> >>> On Sep 24, 2024, at 10:25 AM, Adrian Vogelsgesang ***@***.***> wrote: >>> >>> >>> However, with these new "hiding frame" recognizers, we are using the frame >>> hiding recognizers to handle "st

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Adrian Prantl via lldb-commits
@@ -224,6 +224,14 @@ const char *Status::AsCString(const char *default_error_str) const { if (!m_string.empty() && m_string[m_string.size() - 1] == '\n') m_string.pop_back(); + // FIXME: Workaround for ErrorList[ExpressionError, ...]. + if (m_error.isA()) { +w

[Lldb-commits] [lldb] b3b6141 - [lldb] Fix two formatv issues in LDB_LOG (NFC)

2024-09-25 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-09-25T10:17:09-07:00 New Revision: b3b6141ba1105ad5b9712a9c93891003170c32ac URL: https://github.com/llvm/llvm-project/commit/b3b6141ba1105ad5b9712a9c93891003170c32ac DIFF: https://github.com/llvm/llvm-project/commit/b3b6141ba1105ad5b9712a9c93891003170c32ac.d

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-25 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Feels like we diverted you from your original problem though, which was the > remote taking the informative errno and changing it to some meaningless value. It should do that though, shouldn't it? We look up the ERRNO constant we got in the GDBRemoteErrno table, sending

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/108495 >From 2bf9eaf7e01293e6c1f388daf14cb8099314a5cf Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 25 Sep 2024 11:04:56 -0700 Subject: [PATCH] [lldb] Introduce an always-on system log category/chann

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased + addressed @labath and @adrian-prantl's feedback. https://github.com/llvm/llvm-project/pull/108495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -224,6 +224,14 @@ const char *Status::AsCString(const char *default_error_str) const { if (!m_string.empty() && m_string[m_string.size() - 1] == '\n') m_string.pop_back(); + // FIXME: Workaround for ErrorList[ExpressionError, ...]. + if (m_error.isA()) { +w

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -61,8 +65,50 @@ std::string DiagnosticManager::GetString(char separator) { stream << message.drop_front(severity_pos + severity.size()); stream << separator; } + return str; +} - return ret; +void DiagnosticManager::Dump(Log *log) { + if (!log) +return;

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-25 Thread Michael Buch via lldb-commits
@@ -90,9 +79,28 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; -for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetNameNoArguments())) +// Check if we have a regex match +for (Regu

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-25 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/109934 The FP8 formats have a "_" in the name so that they are: 1. Easier to read. 2. Possible to use in register expressions if/when they are supported. Some other bits do have defined meanings but they are not

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes The FP8 formats have a "_" in the name so that they are: 1. Easier to read. 2. Possible to use in register expressions if/when they are supported. Some other bits do have defined meanings but they are

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: Core files will be the next PR and a test will be added to ensure fields show up when using a core file too. https://github.com/llvm/llvm-project/pull/109934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) dzhidzhoev wrote: I thought it failed because of

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) dzhidzhoev wrote: https://lab.llvm.org/staging/#

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) DavidSpickett wrote: Ok fair enough, maybe it's

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Decide what to do with the remote test change but otherwise this LGTM. https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/109961 >From 025276a52939c4091181dea5f633e443c908c4ef Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Mon, 16 Sep 2024 17:48:15 +0200 Subject: [PATCH 1/3] [lldb][test] Use tools from llvm instead of compi

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) dzhidzhoev wrote: Fixed https://github.com/llvm

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Decide what to do with the remote test change but otherwise this LGTM. Some other tests are unexpectedly passing on remote config, so they'll need extra attention. https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits

[Lldb-commits] [lldb] aea0668 - [lldb][test] Use tools from llvm instead of compiler tools (#109961)

2024-09-25 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-09-25T16:19:02+02:00 New Revision: aea06684992873f70c5834e2f455f913e5b8d671 URL: https://github.com/llvm/llvm-project/commit/aea06684992873f70c5834e2f455f913e5b8d671 DIFF: https://github.com/llvm/llvm-project/commit/aea06684992873f70c5834e2f455f913e5b8d67

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 26e0b50 - [lldb][lldb-dap] Fix compilation error on 32 bit platforms

2024-09-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-25T14:31:57Z New Revision: 26e0b5077236064d9ab0548e049dffce4d476c06 URL: https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06 DIFF: https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06.diff LOG

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-25 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 786dc5a - [lldb-dap] Simplify `readMemory` (#109485)

2024-09-25 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-25T13:49:42+02:00 New Revision: 786dc5a2da9bb55d98c65d018de25d9bd31485ff URL: https://github.com/llvm/llvm-project/commit/786dc5a2da9bb55d98c65d018de25d9bd31485ff DIFF: https://github.com/llvm/llvm-project/commit/786dc5a2da9bb55d98c65d018de25d9bd31485ff

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-25 Thread Adrian Vogelsgesang via lldb-commits
@@ -90,9 +79,28 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; -for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetNameNoArguments())) +// Check if we have a regex match +for (Regu

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
@@ -161,6 +165,11 @@ def getToolchainUtil(util_name): } utils = [] +# Required by API TestBSDArchives.py tests. +# TODO don't forget to fix the test's Makefile when porting to mainline DavidSpickett wrote: TODO left in https:/

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
@@ -149,9 +153,9 @@ def getToolchainSpec(self, compiler): cc_dir = cc_path.parent def getToolchainUtil(util_name): -return cc_dir / (cc_prefix + util_name + cc_ext) +return os.path.join(configuration.llvm_tools_dir, util_name + exe_ext)

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) DavidSpickett wrote: And this works now because.

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: My only question here is, is there some tool that every bot is going to have to add an override for because it's not something in `/bin`? If there is such a tool, that doesn't make this change bad, but we may want to delay while that's accounted for.

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/109961 >From 025276a52939c4091181dea5f633e443c908c4ef Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Mon, 16 Sep 2024 17:48:15 +0200 Subject: [PATCH 1/2] [lldb][test] Use tools from llvm instead of compi

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: A better version of my question, do you have a list of tools this effects, is it just the ones where you have modified lines in this PR? If so we probably have nothing to worry about. https://github.com/llvm/llvm-project/pull/109961

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > A better version of my question, do you have a list of tools this effects, is > it just the ones where you have modified lines in this PR? > > If so we probably have nothing to worry about. These are the tools listed in util_names dictionary https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-25 Thread via lldb-commits
dlav-sc wrote: @lhames could you take a look, please? https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-25 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/9] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -161,6 +165,11 @@ def getToolchainUtil(util_name): } utils = [] +# Required by API TestBSDArchives.py tests. +# TODO don't forget to fix the test's Makefile when porting to mainline dzhidzhoev wrote: Thanks! https://github.

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -8,6 +8,7 @@ #include "lldb/Utility/Status.h" +#include "lldb/Expression/DiagnosticManager.h" labath wrote: Definitely not a good idea. https://github.com/llvm/llvm-project/pull/106470 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -486,19 +603,37 @@ bool CommandObjectExpression::EvaluateExpression(llvm::StringRef expr, result.SetStatus(eReturnStatusSuccessFinishResult); } else { -const char *error_cstr = result_valobj_sp->GetError().AsCString(); -if (error_cstr && error

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-25 Thread Pavel Labath via lldb-commits
labath wrote: > > This seems like it could be problematic for IDEs, if they don't print the > > error in the same window as the expression being evaluated. The arrows > > could end up pointing to nowhere, or to the wrong place in the expression > > (if we don't get the right offset). > > Even

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler-based tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/109961 In #102185, toolchain detection for API tests has been rewritten to Python. However, tools paths for tests are determined from compiler path. Here tools are taken from `--llvm-tools-dir` dotest.py argument,

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler-based tools (PR #109961)

2024-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes In #102185, toolchain detection for API tests has been rewritten in Python. However, tools paths for tests are determined from compiler path. Here tools are taken from `--llvm-tools-dir` dotest.py

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler-based tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler-based tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Is there some tool that every bot is going to have to add an override for > because it's not something in `/bin`? AFAIK no. All these tools have llvm alternatives. https://github.com/llvm/llvm-project/pull/109961 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][test] Use tools from llvm instead of compiler tools (PR #109961)

2024-09-25 Thread David Spickett via lldb-commits
@@ -25,7 +25,6 @@ def setUp(self): oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows", ) -@expectedFailureAll(remote=True) DavidSpickett wrote: Just need a basic explanati

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-09-25 Thread Bernhard Kaindl via lldb-commits
bernhardkaindl wrote: @davide-q: The patch linked from this comment avoids this issue https://github.com/llvm/llvm-project/issues/101368: https://github.com/spack/spack/pull/46504#issuecomment-2372520318 https://github.com/llvm/llvm-project/pull/92865 ___

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,273 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,273 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,273 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { labath wrote: How does this relate to the rest of the patch? https://github.com/llvm/llvm-project/pull/98528 __

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-25 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think it'd be good to separate the general mechanics of creating and managing a telemetry (telemeter) instance from the details of logging individual telemetry entries. I.e. one PR for the general infrastructure (maybe include one simple (startup?) teleme

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-25 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > I think that would make sense, though I also think that the current behavior > (attempting to relocate it also does) -- my core question is: how likely is > it that the dynamic loader will find the right thread-local for a module > which was loaded by the process class, if the

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/108495 >From c2d2758c68c661153bae0cda857b4c0cb7eddafe Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 25 Sep 2024 11:04:56 -0700 Subject: [PATCH] [lldb] Introduce an always-on system log category/chann

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-25 Thread Pavel Labath via lldb-commits
labath wrote: The way I see it, there should be no distinction between "loading in a core file" and "actually loading" a module. "Loading of a module", in the sense that I'm using it here, consists of two steps: - adding the module to the target's list of modules (usually via target.GetOrCreat

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-25 Thread Dmitry Vasilyev via lldb-commits
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {