https://github.com/omjavaid approved this pull request.
This looks good to me. I haven't tested it myself though. Just one thing that's bothering me is that we are now gradually implementing a number of similar functions to read/write feature registers like ZT ZA or FPMR etc. There will be more features in future meaning more read/ write routines doing almost similar stuff. IMO We may later consider refactoring the code to provide a top level interface for feature registers read and write. Also we can avoid caching these single registers at all. We don't have much of performance benefit in this day n age to store them in temporary NativeRegisterContext variables. Instead read from ptrace every time we need them. https://github.com/llvm/llvm-project/pull/106695 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
