kadircet wrote:
i think limiting this to `RealFileSystem::openFileForRead` LG, but can we make
sure `IsText` defaults to `false` and we can only set it in `#ifdef __MVS__`
block to make sure this is really a no-op for other platforms. e.g.:
```cppp
auto OpenFlags = sys::fs::OF_None;
#ifdef __MV
https://github.com/kiyolee updated
https://github.com/llvm/llvm-project/pull/109643
>From 3990c1616403808000241c93fa38b44e2d7f966a Mon Sep 17 00:00:00 2001
From: Kelvin Lee
Date: Mon, 23 Sep 2024 19:43:20 +1000
Subject: [PATCH] [lldb][FreeBSD] Fix a typo in
NativeProcessFreeBSD::MonitorSIGTRAP
https://github.com/kiyolee updated
https://github.com/llvm/llvm-project/pull/109643
>From 036d7f64d052165d0535d48ef1d52c61d67a7eb2 Mon Sep 17 00:00:00 2001
From: Kelvin Lee
Date: Mon, 23 Sep 2024 19:43:20 +1000
Subject: [PATCH] [lldb][FreeBSD] Fix a typo in
NativeProcessFreeBSD::MonitorSIGTRAP
Author: Kelvin Lee
Date: 2024-09-23T11:44:58+01:00
New Revision: 85220a0c651e565ab576c5be17c1ec5c9eb2a350
URL:
https://github.com/llvm/llvm-project/commit/85220a0c651e565ab576c5be17c1ec5c9eb2a350
DIFF:
https://github.com/llvm/llvm-project/commit/85220a0c651e565ab576c5be17c1ec5c9eb2a350.diff
LO
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109643
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Caused by https://github.com/llvm/llvm-project/pull/108504.
Thanks for the fix.
https://github.com/llvm/llvm-project/pull/109643
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
Author: dlav-sc
Date: 2024-09-23T08:54:16+01:00
New Revision: 6ad268e3913cb6814fabae420a8e80156e1632a7
URL:
https://github.com/llvm/llvm-project/commit/6ad268e3913cb6814fabae420a8e80156e1632a7
DIFF:
https://github.com/llvm/llvm-project/commit/6ad268e3913cb6814fabae420a8e80156e1632a7.diff
LOG:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -333,6 +335,23 @@ ArchSpec ProcessMinidump::GetArchitecture() {
return ArchSpec(triple);
}
+DynamicLoader *ProcessMinidump::GetDynamicLoader() {
+ if (m_dyld_up.get() == nullptr)
+m_dyld_up.reset(DynamicLoader::FindPlugin(
+this, DynamicLoaderPOSIXDYLD::GetPl
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
CreateCoreFileMemoryRange(region));
}
+static void AddRegisterSections(Process &process, ThreadSP &thread_sp,
+CoreFileMemoryRanges
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/109477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
It may be best to separate the loading and saving parts into separate PRs, as
the two are functionality separate. (and I have -- separate -- questions about
each part).
For loading, I'd like to discuss the back door you're adding DidAttach
function. The th
labath wrote:
What's the exact situation that triggered these extra packets. Could it be
simulated from a gdb-remote client test (i.e., by mocking server responses)?
https://github.com/llvm/llvm-project/pull/109499
___
lldb-commits mailing list
lldb-c
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/3] [lldb][docs] Resurrect the information on adding a ne
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Jay Foad (jayfoad)
Changes
This will be used in ASTContext::getTypeInfo which needs this
information for all builtin types, not just pointers.
---
Patch is 20.84 KiB, truncated to 20.00 KiB below, full version:
https://github.co
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-lldb
Author: Jay Foad (jayfoad)
Changes
This will be used in ASTContext::getTypeInfo which needs this
information for all builtin types, not just pointers.
---
Patch is 20.84 KiB, trunc
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/109656
This will be used in ASTContext::getTypeInfo which needs this
information for all builtin types, not just pointers.
>From 0ef4ea17a711a1ee95080bc1635ae9aa824df596 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jay Foad (jayfoad)
Changes
This will be used in ASTContext::getTypeInfo which needs this
information for all builtin types, not just pointers.
---
Patch is 20.84 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/l
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -195,18 +195,31 @@ void ConnectToRemote(MainLoop &mainloop,
bool reverse_connect, llvm::StringRef host_and_port,
const char *const progname, const char *const subcommand,
const char *const named_pipe_path, pipe_t
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
jankratochvil wrote:
> I did not add a testcase because it would require a specific glibc.
Does some standard testcase FAIL->PASS by this fix when the testsuite is being
run on Ubuntu 22.04? If not could you write such a testcase which would
FAIL->PASS only on Ubuntu 22.04?
https://github.com
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/2] [lldb][docs] Resurrect the information on adding a ne
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
DavidSpickett wrote:
> I think this page leaves a lot to be desired but it's a good start.
Given that language support runs from:
* Pretend it's C++ and hope (Rust) to -
* Have an entire llvm fork (Swift).
The documentation is never going to be great, this is true. Next time a
language is adde
slydiman wrote:
> But do both of those callers need the "optional launch" functionality? AIUI,
> it's only the Handle_qLaunchGDBServer that does, and the code in
> lldb-platform.cpp should launch a server unconditionally.
We can launch gdbserver with tcp protocol only after accepting the conne
Author: Adrian Prantl
Date: 2024-09-23T09:35:27-07:00
New Revision: 40df13fb54b0fe840deef23054de6544c184
URL:
https://github.com/llvm/llvm-project/commit/40df13fb54b0fe840deef23054de6544c184
DIFF:
https://github.com/llvm/llvm-project/commit/40df13fb54b0fe840deef23054de6544c184.diff
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
Author: Adrian Prantl
Date: 2024-09-23T10:50:51-07:00
New Revision: 97b0d2076f53f669f27dc6d0539a3d01f28381e7
URL:
https://github.com/llvm/llvm-project/commit/97b0d2076f53f669f27dc6d0539a3d01f28381e7
DIFF:
https://github.com/llvm/llvm-project/commit/97b0d2076f53f669f27dc6d0539a3d01f28381e7.diff
https://github.com/walter-erquinigo approved this pull request.
beautiful.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/109611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
I read through the patch, this looks good to me.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
Author: Jason Molenda
Date: 2024-09-23T10:29:21-07:00
New Revision: 3336d73126ae7ebaadf7c3a4d85e373eaae8cda6
URL:
https://github.com/llvm/llvm-project/commit/3336d73126ae7ebaadf7c3a4d85e373eaae8cda6
DIFF:
https://github.com/llvm/llvm-project/commit/3336d73126ae7ebaadf7c3a4d85e373eaae8cda6.diff
jasonmolenda wrote:
> What's the exact situation that triggered these extra packets. Could it be
> simulated from a gdb-remote client test (i.e., by mocking server responses)?
We've always done it when we step over our dynamic loader notification
breakpoint (when new solibs are loaded and lldb
vogelsgesang wrote:
I just realized that this was previously mentioned in #56144. The comments on
that item make me wonder if this commit here actually even uses the right
approach... Should I instead extend the recognizer framework to also match on
the non-topmost frame?
https://github.com/l
Jlalond wrote:
@labath I really like the idea to add the TLS saving to the dynamic loader,
I'll add that,
As for the dynamic loader, I don't like how I've modified it. When a minidump
is loaded, the link map isn't properly relocated, so TLS data is searched for
relative to module lowest in m
vogelsgesang wrote:
CC @labath since you aparrently already put some thoughts into this 2 years
ago, when opening #56144
https://github.com/llvm/llvm-project/pull/109594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 6 Sep 2024 16:12:50 +0400
Subject: [PATCH 1/4] [lldb] Removed gdbserver ports map from lldb-server
Liste
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict):
print("Script exited with code %s" % e.code)
+class LLDBInteractiveConsole(code.InteractiveConsole):
+def __init__(self, locals=None):
+super().__init__(locals)
+self.result_output =
https://github.com/labath approved this pull request.
Thanks for doing this. I'll respond to your
[https://github.com/llvm/llvm-project/pull/104317#issuecomment-2364684837] for
the other thread here:
> > The method I'd recommend is to call ReadMemory
> I assume I should prefer Target::ReadMem
@@ -93,20 +93,19 @@ def test_readMemory(self):
# We can read the complete string
mem = self.dap_server.request_readMemory(memref, 0, 5)["body"]
-self.assertEqual(mem["unreadableBytes"], 0)
self.assertEqual(b64decode(mem["data"]), b"dead\0")
abhina-sree wrote:
> OpenFlags |= sys::fs::OF_Text;
Thanks, I've made your suggested change and I opened a new PR here
https://github.com/llvm/llvm-project/pull/109664. A short explanation for why
distinguishing text and binary files on z/OS is important is because the native
encoding is not
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -346,6 +346,31 @@ Third-party Integrations
Libc++ provides integration with a few third-party tools.
+Debugging libc++ internals in LLDB
+--
+
+LLDB hides the implementation details of libc++ by default.
+
+E.g., when setting a breakpoint in
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
Michael137 wrote:
Ad
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
+ Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
+
if (fd != SharedSocket::kInvalidFD) {
nikic wrote:
@dtcxzyw Thanks for pointing that out! I think truncation here is the
semantically wrong thing to do. I added a check that we fit the bit width
instead in
https://github.com/llvm/llvm-project/commit/6f194a6dea4b4067336431e699ea3588417d4b96.
https://github.com/llvm/llvm-project/pu
https://github.com/Michael137 approved this pull request.
> I did not add a testcase because it would require a specific glibc.
To test this you could probably build a `libc.so` as part of building the test.
Then have a dummy `__pthread_kill_implementation` in it. But given we haven't
done thi
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
https://github.com/kiyolee created
https://github.com/llvm/llvm-project/pull/109643
Apparently a typo is causing compile error.
>From f6af406b5465c190885be2364b3f8d48a2162780 Mon Sep 17 00:00:00 2001
From: Kelvin Lee
Date: Mon, 23 Sep 2024 19:43:20 +1000
Subject: [PATCH] [lldb][FreeBSD] Fix a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kelvin Lee (kiyolee)
Changes
Apparently a typo is causing compile error.
---
Full diff: https://github.com/llvm/llvm-project/pull/109643.diff
1 Files Affected:
- (modified) lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp
(+
https://github.com/felipepiovezan approved this pull request.
As someone who was just recently learning about these parts of the codebase,
this renaming will definitely make things easier! Thanks for creating this
patch!
https://github.com/llvm/llvm-project/pull/109611
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
This PR has been updated to only contain the type lookup using .debug_names
parent chain.
Later PRs will add namespace changes and `SameAsATName` algorithm change.
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits
https://github.com/medismailben approved this pull request.
LGTM! Thanks for addressing my comments :)
https://github.com/llvm/llvm-project/pull/109062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/109485
>From 48718649469aae62b2945e7de22cf7280316b757 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 20 Sep 2024 21:05:54 +
Subject: [PATCH 1/2] [lldb-dap] Simplify `readMemory`
The `readMemory
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/7] [lldb][libc++] Hide all libc++ implementation det
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/109485
>From f461249eed7bf26f87b156d071ad2a12ecd231ab Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 20 Sep 2024 21:05:54 +
Subject: [PATCH 1/3] [lldb-dap] Simplify `readMemory`
The `readMemory
vogelsgesang wrote:
> [...] it may returned cached data from disk for running processes (which
> means it will be faster, but potentially return incorrect data).
I think the 2nd point shouldn't be an issue because `SBTarget::ReadMemory` sets
`force_live_memory` to true when calling `Target::Re
@@ -3271,6 +3273,11 @@ Status Process::PrivateResume() {
if (!GetModID().IsLastResumeForUserExpression())
ResetExtendedCrashInfoDict();
+ if (m_last_run_direction != direction) {
jimingham wrote:
In the "resolved" discussion we talked about the fact th
jimingham wrote:
> @clayborg @jimingham Can I please have some love? I don't want to keep
> telling users "you should be using GDB" and I've done a significant amount of
> work here.
Ack, sorry I'm bad at the formalities. I was under the impression that most of
the actual reviewing had been
https://github.com/jimingham approved this pull request.
LGTM. I went through and made a couple non-essential comment suggestions. But
this looks ready to go in to me.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lld
https://github.com/jimingham approved this pull request.
LGTM.
Given InvalidateIfNeeded (which by name seems harmless) can have these
undesirably effects (presumably only when you pass true for force) it might be
nice to warn developers about this by adding an instructive comment to
Invalid
@@ -3169,6 +3176,7 @@ void PruneThreadPlans();
// m_currently_handling_do_on_removals are true,
// Resume will only request a resume, using this
// flag to check.
+ lldb::RunDirection m_last_run_d
@@ -142,6 +142,9 @@ class StopInfo : public
std::enable_shared_from_this {
static lldb::StopInfoSP
CreateStopReasonProcessorTrace(Thread &thread, const char *description);
+ static lldb::StopInfoSP
jimingham wrote:
Do you somewhere make it obvious what
@@ -510,8 +510,9 @@ def start(self):
self._thread.start()
def stop(self):
-self._thread.join()
-self._thread = None
+if self._thread is not None:
jimingham wrote:
It's not obvious when you'd get a stop with no thread. Why
@@ -142,6 +142,9 @@ class StopInfo : public
std::enable_shared_from_this {
static lldb::StopInfoSP
CreateStopReasonProcessorTrace(Thread &thread, const char *description);
+ static lldb::StopInfoSP
jimingham wrote:
Ah, okay, you do for eStopReasonHistor
Author: Adrian Prantl
Date: 2024-09-23T14:33:41-07:00
New Revision: 1fae1314f1ff58f3601640c0a2c48cee3a322e5d
URL:
https://github.com/llvm/llvm-project/commit/1fae1314f1ff58f3601640c0a2c48cee3a322e5d
DIFF:
https://github.com/llvm/llvm-project/commit/1fae1314f1ff58f3601640c0a2c48cee3a322e5d.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/109499
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-09-23T12:13:48-07:00
New Revision: 6e6d5eae765939cc4074bdd606658e78c4a2a559
URL:
https://github.com/llvm/llvm-project/commit/6e6d5eae765939cc4074bdd606658e78c4a2a559
DIFF:
https://github.com/llvm/llvm-project/commit/6e6d5eae765939cc4074bdd606658e78c4a2a559.diff
vogelsgesang wrote:
@Michael137 thanks for the review! I updated the pull request accordingly
https://github.com/llvm/llvm-project/pull/108870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det
@@ -346,6 +346,31 @@ Third-party Integrations
Libc++ provides integration with a few third-party tools.
+Debugging libc++ internals in LLDB
+--
+
+LLDB hides the implementation details of libc++ by default.
+
+E.g., when setting a breakpoint in
1 - 100 of 115 matches
Mail list logo
