[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-10 Thread Michael Buch via lldb-commits
Michael137 wrote: > As I understand it, minimal import is used in LLDB for performance reasons, > so we don't waste time parsing and loading AST elements that we don't need. > It sounds like a fine idea in general. Implicit imports of external sources > in Clang, however, turn import process i

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -274,8 +274,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, builder.setEngineKind(llvm::EngineKind::JIT) .setErrorStr(&error_string) - .setRelocationModel(triple.isOSBinFormatMachO() ? llvm::Reloc::PIC_ -

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); + if (lldb::TargetSP target_sp = exe_ctx.GetTargetSP()) { +Architecture *arch = tar

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -1011,6 +1011,135 @@ void RuntimeDyldELF::resolveBPFRelocation(const SectionEntry &Section, } } +static void applyUTypeImmRISCV(uint8_t *InstrAddr, uint32_t Imm) { Michael137 wrote: I'm not sure if this was discussed elsewhere in the thread, but we shou

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" Michael137 wrote: What happens if you run the test-suite on RISC-V? I do think it's good to document what doesn't work, but the successful cases should already be tested elsewhere. So should we jus

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); Michael137 wrote: ```suggestion std::unique_ptr arch_passes; ``` ht

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" DavidSpickett wrote: Yeah I'm not sure if this is known failures or known passes. Adding skipif riscv or xfail to the known failures seems like the better option. Tip for that, the lldb tests call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,217 @@ +//===--- DirectCallReplacementPass.cpp - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,62 @@ +//===--- DirectCallReplacementPass.h - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
dlav-sc wrote: I've added float, doubles and pointers support in lldb expressions. Currently, just several python API tests that check expressions with static class members (BTW, static methods work) and complex expressions like `expr struct Test { int a; int b; }; auto t = Test{3, 4}; t;` fai

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" dlav-sc wrote: If I'm not mistaken, I've supported all types that frontend can generate (https://github.com/llvm/llvm-project/pull/99336#issuecomment-2340245433), so these tests are no longer relev

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX created https://github.com/llvm/llvm-project/pull/108000 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for porting

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dhruv Srivastava (DhruvSrivastavaX) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. #101657 The complete changes for po

[Lldb-commits] [lldb] [lldb] Recurse through DW_AT_signature when looking for attributes (PR #107241)

2024-09-10 Thread Pavel Labath via lldb-commits
labath wrote: > Wouldn't block the PR on this, but is there a way the `ElaboratingDIIterator` > changes can be tested? Maybe a unit-test where we instantiate > `elaborating_dies` on something that has `DW_AT_signature` and makes sure we > actually iterate over the original DWARF? We couldn't

[Lldb-commits] [lldb] 925b220 - [lldb] Recurse through DW_AT_signature when looking for attributes (#107241)

2024-09-10 Thread via lldb-commits
Author: Pavel Labath Date: 2024-09-10T12:57:54+02:00 New Revision: 925b220ee424f8489bc8d7b1a247f2c5f3edde5d URL: https://github.com/llvm/llvm-project/commit/925b220ee424f8489bc8d7b1a247f2c5f3edde5d DIFF: https://github.com/llvm/llvm-project/commit/925b220ee424f8489bc8d7b1a247f2c5f3edde5d.diff

[Lldb-commits] [lldb] [lldb] Recurse through DW_AT_signature when looking for attributes (PR #107241)

2024-09-10 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/107241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-10 Thread Michael Buch via lldb-commits
Michael137 wrote: Looks like this broke the macOS bots for one of the tests: ``` runCmd: expr std::reverse(a.begin(), a.end()) Assertion failed: (isa(Decl->TypeForDecl)), function getInjectedClassNameType, file ASTContext.cpp, line 5057. PLEASE submit a bug report to https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

2024-09-10 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

2024-09-10 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Looks good now, just remove the dead code. https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -96,17 +98,105 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: This is exactly the style of PR I was looking for, thanks. I don't want this to land without some code that uses it however. So I suggest we iterate on this until it's approved, then you put up the next PR and so on. We'll find some later point where

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This started failing on the macOS CI after https://github.com/llvm/llvm-project/pull/106885: ``` lldb-api :: commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStd

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108003 This started failing on the macOS CI after https://github.com/llvm/llvm-project/pull/106885: ``` lldb-api :: commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdMo

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 925b220ee424f8489bc8d7b1a247f2c5f3edde5d...cbc5d1316b5103a109bce905976fb9d5d937b330 lldb

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-10 Thread Abhina Sree via lldb-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/107906 >From 758745c955471b0ad65cd3a33381f753e2b63797 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH 1/2] Propagate IsText parameter to openFileForRead f

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -0,0 +1,62 @@ +//===--- DirectCallReplacementPass.h - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread David Spickett via lldb-commits
@@ -0,0 +1,62 @@ +//===--- DirectCallReplacementPass.h - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); dlav-sc wrote: addressed https://github.com/llvm/llvm-project/pull/99

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -1441,6 +1443,26 @@ lldb_private::Status ClangExpressionParser::DoPrepareForExecution( custom_passes.EarlyPasses->run(*llvm_module_up); } + std::unique_ptr arch_passes(nullptr); + if (lldb::TargetSP target_sp = exe_ctx.GetTargetSP()) { +Architecture *arch = tar

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -0,0 +1,217 @@ +//===--- DirectCallReplacementPass.cpp - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Glad to hear that! Sure that should be okay. I can proceed with the files which directly rely on this one for the next PRs, so that we can plan accordingly. https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/108000 >From 426874ab276182858b75e9bbf8704dab1742757c Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Tue, 10 Sep 2024 04:38:32 -0500 Subject: [PATCH 1/3] Ptrace code base for AIX --- lldb/include/lldb

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! Not sure why the formatter is complaining about a single line deletion https://github.com/llvm/llvm-project/pull/108003 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
dlav-sc wrote: Also Large Code Model for RISCV targets has been merged 2 days ago (https://github.com/llvm/llvm-project/pull/70308), so I'm going to remove DirectCallReplacementPass and use large model in MCJIT instead. https://github.com/llvm/llvm-project/pull/99336 __

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108003 >From cbc5d1316b5103a109bce905976fb9d5d937b330 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 10 Sep 2024 12:20:22 +0100 Subject: [PATCH 1/2] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: sk

[Lldb-commits] [lldb] 2bcab9b - [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (#108003)

2024-09-10 Thread via lldb-commits
Author: Michael Buch Date: 2024-09-10T16:00:40+01:00 New Revision: 2bcab9ba7139cfa96c85433fa85b29c8a6d7008b URL: https://github.com/llvm/llvm-project/commit/2bcab9ba7139cfa96c85433fa85b29c8a6d7008b DIFF: https://github.com/llvm/llvm-project/commit/2bcab9ba7139cfa96c85433fa85b29c8a6d7008b.diff

[Lldb-commits] [lldb] [lldb][test] TestDbgInfoContentVectorFromStdModule.py: skip test on Darwin (PR #108003)

2024-09-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/108003 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

2024-09-10 Thread Jennifer Phillips via lldb-commits
jennphilqc wrote: Please add @clayborg as Reviewer. https://github.com/llvm/llvm-project/pull/108036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/108000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,44 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
labath wrote: Given https://github.com/llvm/llvm-project/pull/108000#discussion_r1752296507, my feeling is that this file just should not (need not) exist. For now, I'd suggest moving the header into NativeProcessAIX (that's the only place which uses it, right?), and then we can figure out wha

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-10 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/107937 >From 2bdc8c0bd8b92989420b798d90e47f27d8a06e66 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 9 Sep 2024 13:54:37 -0700 Subject: [PATCH 1/4] Reapply "[LLDB] Reappply SBSaveCore AddMemoryList" (#107731)

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

2024-09-10 Thread Pavel Labath via lldb-commits
labath wrote: (NativeProcessAIX is one of the classes which I'm certain they will **not** be shared with their linux counterpart, so there's really no reason to emulate linux implementation if it does not come natural. And "inventing" OS constants to make the code layout similar definitely fal

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

2024-09-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/106791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-09-10 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/105905 >From 6612efb0e51d700eeb545a421a34f7a57aafc509 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 23 Aug 2024 16:04:44 -0700 Subject: [PATCH 1/8] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP requ

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-09-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 22144e2 - [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (#102708)

2024-09-10 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-09-10T09:58:43-07:00 New Revision: 22144e20cbd237a432fdc4106abe3960555aff42 URL: https://github.com/llvm/llvm-project/commit/22144e20cbd237a432fdc4106abe3960555aff42 DIFF: https://github.com/llvm/llvm-project/commit/22144e20cbd237a432fdc4106abe3960555aff42.diff

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-09-10 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 71986c7633f6f2d8e8e8ed5dba332c822204d211 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -274,8 +274,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, builder.setEngineKind(llvm::EngineKind::JIT) .setErrorStr(&error_string) - .setRelocationModel(triple.isOSBinFormatMachO() ? llvm::Reloc::PIC_ -

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-09-10 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/105905 >From 6612efb0e51d700eeb545a421a34f7a57aafc509 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 23 Aug 2024 16:04:44 -0700 Subject: [PATCH 1/9] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP requ

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-10 Thread Jacob Lalonde via lldb-commits
@@ -450,6 +450,8 @@ class RangeDataVector { void Append(const Entry &entry) { m_entries.emplace_back(entry); } + void Append(B &&b, S &&s, T &&t) { m_entries.emplace_back(Entry(b, s, t)); } Jlalond wrote: Nit to self, add code comments about Base Size And

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
@@ -0,0 +1,194 @@ +//===--- DirectToIndirectFCR.cpp - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
dlav-sc wrote: > Also Large Code Model for RISCV targets has been merged 2 days ago (#70308), > so I'm going to remove DirectCallReplacementPass and use large model in MCJIT > instead. I've removed DirectCallReplacementPass and added large code model instead. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 71986c7633f6f2d8e8e8ed5dba332c822204d211 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

2024-09-10 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/108060 Implement operators `<=` and `>=` to explicitly check the comparison results to be `cmpLessThan` or `cmpEqual` instead of negating the result of `operators<`. Fixes #85947 >From 1e83cdfeb7e3a6fba4b190e95dd7947

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

2024-09-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Implement operators `<=` and `>=` to explicitly check the comparison results to be `cmpLessThan` or `cmpEqual` instead of negating the result of `operators<`. Fixes #85947 --- Full diff: https://github.com/l

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI { using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance // instead. bool m_is_rv64; // true if target is riscv64; fa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64, return total_size; } +static bool UpdateRegister(RegisterContext *reg_ctx, + const lldb::RegisterKind reg_kind, + const uint32_t reg_num, const addr_t value) { + Log

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -471,6 +498,18 @@ static void SetupTargetOpts(CompilerInstance &compiler, // Set the target ABI if (std::string abi = GetClangTargetABI(target_arch); !abi.empty()) compiler.getTargetOpts().ABI = std::move(abi); + + if ((target_machine == llvm::Triple::riscv64 && +

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64, return total_size; } +static bool UpdateRegister(RegisterContext *reg_ctx, + const lldb::RegisterKind reg_kind, + const uint32_t reg_num, const addr_t value) { + Log

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-10 Thread Vy Nguyen via lldb-commits
@@ -754,6 +760,7 @@ class Debugger : public std::enable_shared_from_this, uint32_t m_interrupt_requested = 0; ///< Tracks interrupt requests std::mutex m_interrupt_mutex; + std::shared_ptr m_telemeter; oontvoo wrote: The use of "shared_ptr" here is to

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/107937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-10 Thread Adrian Prantl via lldb-commits
@@ -170,12 +215,8 @@ class Status { bool Success() const; protected: - Status(llvm::Error error); - /// Status code as an integer value. - ValueType m_code = 0; - /// The type of the above error code. - lldb::ErrorType m_type = lldb::eErrorTypeInvalid; - /// A string r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 31f3217635d937f5c3ff2733eb34905d63714085 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 0091613ba2ab277d469d946fdce605d6afc0596d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-10 Thread Adrian Prantl via lldb-commits
@@ -37,48 +39,75 @@ class raw_ostream; using namespace lldb; using namespace lldb_private; -Status::Status() {} +char CloneableError::ID; +char MachKernelError::ID; +char Win32Error::ID; +char ExpressionError::ID; + +namespace { +/// A std::error_code category for eErrorTypeGe

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

2024-09-10 Thread Jennifer Phillips via lldb-commits
https://github.com/jennphilqc updated https://github.com/llvm/llvm-project/pull/108036 >From b7e59ca0739240796b89b3d114d6c96c3b09c687 Mon Sep 17 00:00:00 2001 From: Jennifer Phillips Date: Tue, 27 Aug 2024 10:48:37 -0700 Subject: [PATCH 1/2] Added readMemory and WriteMemory, var type correction

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-10 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/107937 >From 2bdc8c0bd8b92989420b798d90e47f27d8a06e66 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 9 Sep 2024 13:54:37 -0700 Subject: [PATCH 1/5] Reapply "[LLDB] Reappply SBSaveCore AddMemoryList" (#107731)

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6f8d2781f604cfcf9ea6facecc0bea8e4d682e1e f172f08473d9aee702829c46fdb6cb26ec67c331 --e

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-09-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/2290 Here is the relevant piece of t

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid created https://github.com/llvm/llvm-project/pull/108072 This pull request adds support for hardware breakpoints and watchpoints in LLDB on Windows on ARM. ### Known Issues: 1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not provide the

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Omair Javaid (omjavaid) Changes This pull request adds support for hardware breakpoints and watchpoints in LLDB on Windows on ARM. ### Known Issues: 1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not provide th

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5537ae87b3a87b3abeb4e6983cecd9b103648243 1c29d30f0b9eb47da63c35f775ad69e1ef40c4de --e

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

2024-09-10 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid updated https://github.com/llvm/llvm-project/pull/108072 >From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001 From: Muhammad Omair Javaid Date: Tue, 10 Sep 2024 18:03:29 +0500 Subject: [PATCH] WoA hardware breakpoint/watchpoint support --- .../Wi

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 604d06560549ce7821c5710e566179b7a6faaa42 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 4 Sep 2024 12:50:37 -0700 Subject: [PATCH] [lldb] Change the implementation of Status to store an llv

  1   2   >