labath wrote: > Wouldn't block the PR on this, but is there a way the `ElaboratingDIIterator` > changes can be tested? Maybe a unit-test where we instantiate > `elaborating_dies` on something that has `DW_AT_signature` and makes sure we > actually iterate over the original DWARF?
We couldn't make a meaningful test in the current form because the class is defined in the cpp file, and it's only user uses it in a context where DW_AT_signature doesn't make sense. We could move it to the header file, and then test it through its public API, but I'm somewhat reluctant to do that, as we don't have a use case for it. I guess that could be interpreted as a reason to not make this change to it (and that's the thing I'd probably do if you insisted on testing), but it's also a very trivial change that's very unlikely to go wrong. https://github.com/llvm/llvm-project/pull/107241 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
