[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-08 Thread Jacob Lalonde via lldb-commits
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-08 Thread Jacob Lalonde via lldb-commits
@@ -109,7 +109,7 @@ class ProcessMinidump : public PostMortemProcess { private: lldb::DataBufferSP m_core_data; llvm::ArrayRef m_thread_list; - const minidump::ExceptionStream *m_active_exception; + std::unordered_map m_exceptions_by_tid; Jlalond wrote:

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-08 Thread Jacob Lalonde via lldb-commits
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jeffreytan81 wrote: > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > (like a random breakpoint hit) that on the face of it it's not responsible for We are doing so to ensure `ThreadPlanSingleThreadTimeout` can stay in the leaf thread plan. And it comes from your su

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Walter Erquinigo via lldb-commits
@@ -58,10 +58,17 @@ DAP::DAP() DAP::~DAP() = default; +/// Return string with first character capitalized. +static std::string capitalize(llvm::StringRef str) { + if (str.empty()) +return ""; + return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str(); +} +

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/97871 >From aa2ad3b675f67581dde07a476725d2574fc6e7da Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 5 Jul 2024 20:30:44 -0400 Subject: [PATCH] [lldb-dap] Support throw and catch exception breakpoin

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/98089 Fixes https://github.com/llvm/llvm-project/issues/97511 >From 31b3d4db2389dd4bd72b54618ba12c86f51fe02f Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 8 Jul 2024 13:24:49 -0700 Subject: [PATCH] [lldb]

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Fixes https://github.com/llvm/llvm-project/issues/97511 --- Full diff: https://github.com/llvm/llvm-project/pull/98089.diff 1 Files Affected: - (modified) lldb/source/Target/StackFrameList.cpp (+3-3)

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Alex Langford via lldb-commits
bulbazord wrote: This is the exact same PR as https://github.com/apple/llvm-project/pull/8952 (on apple's LLVM fork). It should have gone here first. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Refactor address writers (PR #98094)

2024-07-08 Thread Sayhaan Siddiqui via lldb-commits
https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/98094 Refactors address writers to create an instance for each CU and its DWO CU. >From b2fe35ae825dc757ea1daaf49142e789c4a560fc Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject:

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jimingham wrote: > > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > > (like a random breakpoint hit) that on the face of it it's not responsible > > for > > Just a quick comment to add the context for this question: we are doing so to > ensure `ThreadPlanSingleThr

[Lldb-commits] [lldb] 2a7abb0 - [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (#96802)

2024-07-08 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-08T16:44:16-07:00 New Revision: 2a7abb04e258542679476fa6527418c34412283c URL: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c DIFF: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c.diff LO

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

2024-07-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/96802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (PR #96802)

2024-07-08 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/1213 Here is the relevant piece of the bui

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei created https://github.com/llvm/llvm-project/pull/98101 Reverts llvm/llvm-project#96802 Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no ability to even *detect* these failures without _landing_ a diff. In the mean time, we have no testin

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei ready_for_review https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes Reverts llvm/llvm-project#96802 Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no ability to even *detect* these failures without _landing_ a diff. In the mean time, we have no testi

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f6eda6fb7a335861d8a8ce32ea805830685f218d 76f102112c8a8a1292929b65ebb7db8b033ee344 --

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/98101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b2fd1eb - Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (#98101)

2024-07-08 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-08T17:59:00-07:00 New Revision: b2fd1ebc3523d225956120052bcc0698adf4579f URL: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f DIFF: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f.diff LO

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-08 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/96260 >From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 20 Jun 2024 17:53:17 -0700 Subject: [PATCH 1/6] [lldb] Change lldb's breakpoint handling behavior lldb

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-08 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Thanks again for all the help @AlexK0 I pushed an update that should compile correctly with my update. It's great to hear that the testsuite looks clean -- that's the part that worried me the most about these changes. I finished an aarch64 Ubuntu testsuite run and it is cl

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

2024-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2