labath wrote:
> > FWIW, I think this feature would be more useful and easier to implement if
> > there was just a single setting called "connection url" or something, which
> > accepted all of the usual lldb connection urls (unix-abstract-connect://,
> > listen://, ...).
> > Since a simple tcp
@@ -0,0 +1,202 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -0,0 +1,202 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -0,0 +1,202 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
https://github.com/AlexeyMerzlyakov updated
https://github.com/llvm/llvm-project/pull/93297
>From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001
From: Alexey Merzlyakov
Date: Fri, 24 May 2024 11:54:16 +0300
Subject: [PATCH 1/4] Add RegisterContextPOSIXCore for RISC-V 64
Fix
@@ -2244,30 +2108,26 @@ bool DWARFExpression::Evaluate(
const uint64_t piece_bit_offset = opcodes.GetULEB128(&offset);
switch (stack.back().GetValueType()) {
case Value::ValueType::Invalid:
- return false;
+ return llvm::createStringErr
@@ -2042,7 +2043,7 @@ bool RegisterContextUnwind::ReadFrameAddress(
return true;
}
UnwindLogMsg("Failed to set CFA value via DWARF expression: %s",
- error.AsCString());
+ llvm::toString(result.takeError()).c_str());
---
@@ -572,28 +572,32 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const
SymbolContext &sc,
static std::optional
ExtractDataMemberLocation(DWARFDIE const &die, DWARFFormValue const
&form_value,
ModuleSP module_sp) {
+ Log *log = GetLog(DWARFLog::T
@@ -1277,6 +1277,11 @@ inline Error createStringError(const Twine &S) {
return createStringError(llvm::inconvertibleErrorCode(), S);
}
+template
+inline Error createStringError(char const *Fmt, const Ts &...Vals) {
+ return createStringError(llvm::inconvertibleErrorCode(),
@@ -2244,30 +2108,26 @@ bool DWARFExpression::Evaluate(
const uint64_t piece_bit_offset = opcodes.GetULEB128(&offset);
switch (stack.back().GetValueType()) {
case Value::ValueType::Invalid:
- return false;
+ return llvm::createStringErr
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
e3ed9e30b7b7102daf37f9464efc06b3d2e1a160...183f76dfb73821640cfdf19901703d0a8ff447ff
lldb/
DavidSpickett wrote:
Not sure I agree with the formatter here but we must bow to it regardless :)
Please fix the formatting and then I'll merge this. Thanks for the
contribution!
https://github.com/llvm/llvm-project/pull/93297
___
lldb-commits maili
https://github.com/AlexeyMerzlyakov updated
https://github.com/llvm/llvm-project/pull/93297
>From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001
From: Alexey Merzlyakov
Date: Fri, 24 May 2024 11:54:16 +0300
Subject: [PATCH 1/5] Add RegisterContextPOSIXCore for RISC-V 64
Fix
AlexeyMerzlyakov wrote:
Oops, I've checked it with flake8, but did not have an idea about the darker
tool. Fixed in
[latest](https://github.com/llvm/llvm-project/pull/93297/commits/041f5729920ed5f1b22745970b488d12438af1ba)
commit. Thank you!
https://github.com/llvm/llvm-project/pull/93297
___
DavidSpickett wrote:
Yeah we settled on https://github.com/psf/black as the formatter, but that
itself didn't have a way to format the contents of a commit. So "darker" is
black but it can do that.
https://github.com/llvm/llvm-project/pull/93297
___
Author: Alexey Merzlyakov
Date: 2024-06-05T10:14:48+01:00
New Revision: d3a9043ec2ee7ea278be4f3c86823512e44d01bf
URL:
https://github.com/llvm/llvm-project/commit/d3a9043ec2ee7ea278be4f3c86823512e44d01bf
DIFF:
https://github.com/llvm/llvm-project/commit/d3a9043ec2ee7ea278be4f3c86823512e44d01bf.d
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/93297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@AlexeyMerzlyakov Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/94455
The the function is doing two fairly different things, depending on how it is
called. While this allows for some code reuse, it also makes it hard to
override it correctly. Possibly for this reason ValueObjectSyn
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/94455
>From d3d666886d6397bb031a3ad88f147fb9b1e2b3ed Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 5 Jun 2024 10:21:10 +
Subject: [PATCH] [lldb] Split ValueObject::CreateChildAtIndex into two
functions
Th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The the function is doing two fairly different things, depending on how it is
called. While this allows for some code reuse, it also makes it hard to
override it correctly. Possibly for this reason ValueObject
@@ -488,66 +488,85 @@ void ValueObject::SetNumChildren(uint32_t num_children) {
m_children.SetChildrenCount(num_children);
}
-ValueObject *ValueObject::CreateChildAtIndex(size_t idx,
- bool synthetic_array_member,
-
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/87197
>From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 31 Mar 2024 10:59:38 -0700
Subject: [PATCH 1/5] [LLDB] Add more helper functions to ValueObject class.
Create
cmtice wrote:
I've updated with a few minor fixes. I've addressed all the review comments (I
think). I've verified/tested that all the casting, etc. works properly. Please
review/approve this. Thanks!
https://github.com/llvm/llvm-project/pull/87197
___
@@ -2042,7 +2043,7 @@ bool RegisterContextUnwind::ReadFrameAddress(
return true;
}
UnwindLogMsg("Failed to set CFA value via DWARF expression: %s",
- error.AsCString());
+ llvm::toString(result.takeError()).c_str());
---
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/94494
Test Plan:
llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
>From 0d1eb164ab12773cb574de6066b717fd4c4c9e31 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Wed, 5 Jun 2024 09:03:38 -07
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Miro Bucko (mbucko)
Changes
Test Plan:
llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
---
Full diff: https://github.com/llvm/llvm-project/pull/94494.diff
1 Files Affected:
- (modified) lldb/test/API/tools/l
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94420
>From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 4 Jun 2024 17:04:15 -0700
Subject: [PATCH 1/5] [Support] Add variadic createStringError overload (NF
JDevlieghere wrote:
Would this affect other calls to `collect_console` too? Do we usually look for
a particular string? If so, would it make sense to change the function (rather
than this particular call site) or have a little helper?
https://github.com/llvm/llvm-project/pull/94494
__
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/94420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int &sink, int x) {
//% expect_cmd_failure=True)
//% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR",
//% expect_cmd_failure=True)
- // FUNC4-EXPR-FAIL: couldn't get the value of variab
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
if (pick_idx < stack.size())
stack.push_back(stack[stack.size() - 1 - pick_idx]);
else {
-if (error_ptr)
- error_ptr->SetErrorStringWithFormat(
- "Index %u out of range for
@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate(
// the stack by the called expression may be used as return values by prior
// agreement between the calling and called expressions.
case DW_OP_call2:
- if (error_ptr)
-error_ptr->SetErrorString("Uni
https://github.com/adrian-prantl approved this pull request.
This is going to be great! Thanks.
Minor nitpicks inside.
https://github.com/llvm/llvm-project/pull/94420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
if (pick_idx < stack.size())
stack.push_back(stack[stack.size() - 1 - pick_idx]);
else {
-if (error_ptr)
- error_ptr->SetErrorStringWithFormat(
- "Index %u out of range for
@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int &sink, int x) {
//% expect_cmd_failure=True)
//% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR",
//% expect_cmd_failure=True)
- // FUNC4-EXPR-FAIL: couldn't get the value of variab
https://github.com/jimingham approved this pull request.
I wish I knew why the original code was ignoring `GetDynamicValueType` here,
when it does use it on the very next line... The old code looks wrong to me.
However, the places where dynamic values matter for the Format choice are
uncommo
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94420
>From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 4 Jun 2024 17:04:15 -0700
Subject: [PATCH 1/6] [Support] Add variadic createStringError overload (NF
mbucko wrote:
> Would this affect other calls to `collect_console` too? Do we usually look
> for a particular string? If so, would it make sense to change the function
> (rather than this particular call site) or have a little helper?
The problem is that the console hasn't had enough time to c
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/94420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-06-05T10:57:46-07:00
New Revision: 539b72f2e15f0d8a74a6c05c7085035040a3a831
URL:
https://github.com/llvm/llvm-project/commit/539b72f2e15f0d8a74a6c05c7085035040a3a831
DIFF:
https://github.com/llvm/llvm-project/commit/539b72f2e15f0d8a74a6c05c7085035040a3a831.d
Author: Augusto Noronha
Date: 2024-06-05T11:08:36-07:00
New Revision: 59e9160ac8c906c5448c2094cd28cb5bc7678a3f
URL:
https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f
DIFF:
https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f.dif
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/93262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94513
This patch adds the `--no-parallel-image-loading` to the crashlog command. By
default, image loading will happen in parallel in the crashlog script however,
sometimes, when running tests or debugging the cr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch adds the `--no-parallel-image-loading` to the crashlog command. By
default, image loading will happen in parallel in the crashlog script however,
sometimes, when running tests or debuggi
@@ -1720,6 +1735,13 @@ def CreateSymbolicateCrashLogOptions(
help="show source for all threads, not just the crashed thread",
default=False,
)
+arg_parser.add_argument(
+"--no-parallel-image-loading",
+dest="parallel_image_loading",
-
@@ -555,30 +555,44 @@ def load_images(self, options, loaded_images=None):
futures = []
with tempfile.TemporaryDirectory() as obj_dir:
-with concurrent.futures.ThreadPoolExecutor() as executor:
-def add_module(image, target, obj_dir
@@ -1720,6 +1735,13 @@ def CreateSymbolicateCrashLogOptions(
help="show source for all threads, not just the crashed thread",
default=False,
)
+arg_parser.add_argument(
+"--no-parallel-image-loading",
+dest="parallel_image_loading",
+
Author: Jonas Devlieghere
Date: 2024-06-05T11:25:17-07:00
New Revision: 39e12e0ab2dd3b0ed9741c9796de15a020741727
URL:
https://github.com/llvm/llvm-project/commit/39e12e0ab2dd3b0ed9741c9796de15a020741727
DIFF:
https://github.com/llvm/llvm-project/commit/39e12e0ab2dd3b0ed9741c9796de15a020741727.d
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94517
In lldb, users can change the `dsymForUUID` binary using the
`LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable.
This patch changes the crashlog to support the same behaviour as lldb and uses
this en
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
In lldb, users can change the `dsymForUUID` binary using the
`LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable.
This patch changes the crashlog to support the same behaviour as lldb and uses
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/94517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -555,30 +555,44 @@ def load_images(self, options, loaded_images=None):
futures = []
with tempfile.TemporaryDirectory() as obj_dir:
-with concurrent.futures.ThreadPoolExecutor() as executor:
-def add_module(image, target, obj_dir
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/94518
`SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the
Python API has no coverage in the
API test suite, so this commits exposes and adds a test for it. Doing this
involves also addin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
`SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the
Python API has no coverage in the
API test suite, so this commits exposes and adds a test for it. Doing this
involves al
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c6c08eee37bada190bd1aa4593c88a5e2c8cdaac...90602ed1b2f27fecb9e1fc28419587cf6bcb04bf
lldb/
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94513
>From eb62de94ceaf3ee440046a2884210fb4f8774edf Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 5 Jun 2024 12:28:59 -0700
Subject: [PATCH] [lldb/crashlog] Add `--no-parallel-image-loading` hidden
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From e4ba69ac4983e4e2882200e7efe0e850eeefae21 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
SBCommandInterpreter:
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1099,6 +1099,19 @@ static void
LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t
}
}
+static bool
LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void
*baton, const char **argv) {
+ bool b = false;
+ if (baton != Py_None) {
+
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+PyCallable_Chec
mysterymath wrote:
@JDevlieghere , we just landed a patch that adds packaging for Fuchsia. Should
be good to go ahead.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94513
>From cc405078245b248b2102f2b24272bee17e5ec752 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 5 Jun 2024 13:12:01 -0700
Subject: [PATCH] [lldb/crashlog] Add `--no-parallel-image-loading` hidden
Author: Med Ismail Bennani
Date: 2024-06-05T13:21:27-07:00
New Revision: f8afa763c6194f5bf485480e1fb94b953942f876
URL:
https://github.com/llvm/llvm-project/commit/f8afa763c6194f5bf485480e1fb94b953942f876
DIFF:
https://github.com/llvm/llvm-project/commit/f8afa763c6194f5bf485480e1fb94b953942f876.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1099,6 +1099,19 @@ static void
LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t
}
}
+static bool
LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void
*baton, const char **argv) {
+ bool b = false;
+ if (baton != Py_None) {
+
@@ -3015,11 +3017,12 @@ llvm::Expected
ValueObject::CastDerivedToBaseType(
lldb::TargetSP target = GetTargetSP();
// The `value` can be a pointer, but GetChildAtIndex works for pointers too.
- lldb::ValueObjectSP inner_value;
+ lldb::ValueObjectSP inner_value = GetSP();
@@ -3015,11 +3017,12 @@ llvm::Expected
ValueObject::CastDerivedToBaseType(
lldb::TargetSP target = GetTargetSP();
// The `value` can be a pointer, but GetChildAtIndex works for pointers too.
- lldb::ValueObjectSP inner_value;
+ lldb::ValueObjectSP inner_value = GetSP();
@@ -3138,13 +3141,13 @@ lldb::ValueObjectSP
ValueObject::CastToBasicType(CompilerType type) {
val_byte_size = temp.value();
if (is_pointer) {
-if (type.IsBoolean() && type_byte_size < val_byte_size) {
+if (!type.IsBoolean() && type_byte_size < val_byte_size) {
-
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/94539
Rewrite an inline test as an API test, to be a little easier to debug, and add
some additional checks that we're in the inlined test1, then step and we are
now in the inlined test2 functions.
>From c02e38e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Rewrite an inline test as an API test, to be a little easier to debug, and add
some additional checks that we're in the inlined test1, then step and we are
now in the inlined test2 functions.
---
Full
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/94513
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
55d2fffdae5531759569e4ea8985c3de2e96bcc1...c02e38e5ef017a966ef8b94a56e394309462
lldb/
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/94539
>From c02e38e5ef017a966ef8b94a56e394309462 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 5 Jun 2024 15:27:23 -0700
Subject: [PATCH 1/2] [lldb] [NFC] Rewrite TestRedefinitionsInInlines.py as an
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/94539
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-06-05T15:39:40-07:00
New Revision: 19bce1702bd1e399bea76d0de2a649a14551b000
URL:
https://github.com/llvm/llvm-project/commit/19bce1702bd1e399bea76d0de2a649a14551b000
DIFF:
https://github.com/llvm/llvm-project/commit/19bce1702bd1e399bea76d0de2a649a14551b000.diff
Author: Med Ismail Bennani
Date: 2024-06-05T15:45:42-07:00
New Revision: 68a9cb799511506045ca26c04e7933f0e0ed46ec
URL:
https://github.com/llvm/llvm-project/commit/68a9cb799511506045ca26c04e7933f0e0ed46ec
DIFF:
https://github.com/llvm/llvm-project/commit/68a9cb799511506045ca26c04e7933f0e0ed46ec.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94513
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3015,11 +3017,12 @@ llvm::Expected
ValueObject::CastDerivedToBaseType(
lldb::TargetSP target = GetTargetSP();
// The `value` can be a pointer, but GetChildAtIndex works for pointers too.
- lldb::ValueObjectSP inner_value;
+ lldb::ValueObjectSP inner_value = GetSP();
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,75 +46,116 @@ lldb::ValueObjectSP
ValueObjectConstResultImpl::Dereference(Status &error) {
return m_impl_backend->ValueObject::Dereference(error);
}
-ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex(
-size_t idx, bool synthetic_array_member, int32_t sy
@@ -46,75 +46,116 @@ lldb::ValueObjectSP
ValueObjectConstResultImpl::Dereference(Status &error) {
return m_impl_backend->ValueObject::Dereference(error);
}
-ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex(
-size_t idx, bool synthetic_array_member, int32_t sy
https://github.com/jimingham approved this pull request.
This is much nicer. I would actually prefer we returned names that are ""
rather than nullptr, but in any case I agree there's no particular reason to
make that a contract.
https://github.com/llvm/llvm-project/pull/94455
___
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94553
This PR removes the `target-aarch64` requirement on the crashlog tests to
exercice them on Intel bots and make image loading single-threaded temporarily
while implementing a fix for a deadlock issue when lo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This PR removes the `target-aarch64` requirement on the crashlog tests to
exercice them on Intel bots and make image loading single-threaded temporarily
while implementing a fix for a deadlock issu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/94554
This patch make all errors start with a lowercase letter and removes trailing
periods and newlines. This fixes inconsistencies between error messages and
facilitate concatenating them.
>From aa32cb4434a0e8
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
if (pick_idx < stack.size())
stack.push_back(stack[stack.size() - 1 - pick_idx]);
else {
-if (error_ptr)
- error_ptr->SetErrorStringWithFormat(
- "Index %u out of range for
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This patch make all errors start with a lowercase letter and removes trailing
periods and newlines. This fixes inconsistencies between error messages and
facilitate concatenating them.
---
Patch i
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/94556
None
>From b20884bc0db2a0cb0bb928beb629670d8c86369f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 5 Jun 2024 19:36:39 -0700
Subject: [PATCH] [lldb] Refactor ReadRegisterValueAsScalar to return
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94556.diff
1 Files Affected:
- (modified) lldb/source/Expression/DWARFExpression.cpp (+56-74)
``diff
diff --git a/lldb/source/E
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/94558
None
>From 6bb911ab3ee8a9f9d10662ed41442be85da9df14 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 5 Jun 2024 19:42:50 -0700
Subject: [PATCH] [lldb] Refactor ResolveLoadAddress to return an
ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94558.diff
1 Files Affected:
- (modified) lldb/source/Expression/DWARFExpression.cpp (+17-31)
``diff
diff --git a/lldb/source/E
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate(
case DW_OP_eq:
if (stack.size() < 2) {
return llvm::createStringError(
-"Expression stack needs at least 2 items for DW_OP_eq.");
+"expression stack needs at least 2 items
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate(
case DW_OP_eq:
if (stack.size() < 2) {
return llvm::createStringError(
-"Expression stack needs at least 2 items for DW_OP_eq.");
+"expression stack needs at least 2 items
Author: Jonas Devlieghere
Date: 2024-06-05T19:47:49-07:00
New Revision: 6ca0f44cd89aa802c306c303764eabf83a7f5029
URL:
https://github.com/llvm/llvm-project/commit/6ca0f44cd89aa802c306c303764eabf83a7f5029
DIFF:
https://github.com/llvm/llvm-project/commit/6ca0f44cd89aa802c306c303764eabf83a7f5029.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/94554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 106 matches
Mail list logo
