[Lldb-commits] [lldb] a756dc4 - [lldb][test] Try a workaround for module cache test on Arm/AArch64 Linux

2023-12-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-20T08:46:10Z New Revision: a756dc4724a279d76898bacd054a04832b02caa8 URL: https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8 DIFF: https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8.diff LOG

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: > It would be interesting to see if changing the test to explicitly kill the > process, then its target, then the Debugger makes the crash go away. Trying this as https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8. https://github.com/llvm

[Lldb-commits] [compiler-rt] [lld] [lldb] [flang] [clang] [mlir] [llvm] [libcxx] [builtins] Refactor cpu_model support to reduce #if nesting. NFCI (PR #75635)

2023-12-20 Thread Petr Hosek via lldb-commits
petrhosek wrote: I have discovered another issue, on Fuchsia `libclang_rt.builtins.a` now has a reference to `getauxval` which it didn't have before. This is really undesirable because on Fuchsia, there's no `auxv` to begin with. I believe this is because before, the `__init_cpu_features` defi

[Lldb-commits] [llvm] [libc] [mlir] [lldb] [clang] [flang] Make 'UnrollMaxUpperBound' to be overridable by target. (PR #76029)

2023-12-20 Thread via lldb-commits
https://github.com/boxu-zhang updated https://github.com/llvm/llvm-project/pull/76029 >From 60030d96d27d23ef2049a3888d65721be51c4481 Mon Sep 17 00:00:00 2001 From: "boxu.zhang" Date: Wed, 20 Dec 2023 17:35:25 +0800 Subject: [PATCH] Make 'UnrollMaxUpperBound' to be overridable by target. The de

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/76030 If adding a user commands fails because a command with the same name already exists, we only say that "force replace is not set" without telling the user _how_ to set it. There are two ways to do so; this

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes If adding a user commands fails because a command with the same name already exists, we only say that "force replace is not set" without telling the user _how_ to set it. There are two wa

[Lldb-commits] [lldb] d14d521 - [lldb][test] Add extra logging for module cache test

2023-12-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-20T09:41:33Z New Revision: d14d52158bc444e2d036067305cf54aeea7c9edb URL: https://github.com/llvm/llvm-project/commit/d14d52158bc444e2d036067305cf54aeea7c9edb DIFF: https://github.com/llvm/llvm-project/commit/d14d52158bc444e2d036067305cf54aeea7c9edb.diff LOG

[Lldb-commits] [lldb] 01c4ecb - [lldb][test] Remove Arm/AArch64 Linux skip for global modules test

2023-12-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-20T09:42:07Z New Revision: 01c4ecb7ae21a61312ff0c0176c0ab9f8656c159 URL: https://github.com/llvm/llvm-project/commit/01c4ecb7ae21a61312ff0c0176c0ab9f8656c159 DIFF: https://github.com/llvm/llvm-project/commit/01c4ecb7ae21a61312ff0c0176c0ab9f8656c159.diff LOG

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread David Spickett via lldb-commits
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef name, if (UserCommandExists(name)) { if (!can_replace) { - result.SetErrorString("user command exists and force replace not set"); + result.SetErrorString( + "user command

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread David Spickett via lldb-commits
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef name, if (UserCommandExists(name)) { if (!can_replace) { - result.SetErrorString("user command exists and force replace not set"); + result.SetErrorString( + "user command

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread David Spickett via lldb-commits
@@ -161,6 +161,17 @@ def cleanup(): ) self.expect("my_command", substrs=["a.out"]) +# Test that without --overwrite we are not allowed to redefine the command. +self.expect( +"command script add my_command --class welcome.Targetname

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

2023-12-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/75927 >From a7770da9e2a997eefced82b9ebb305b464fec70d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 19 Dec 2023 12:46:54 + Subject: [PATCH] [lldb][DWARF] Searchfor symbols in all external modules T

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

2023-12-20 Thread David Spickett via lldb-commits
@@ -175,7 +175,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const SymbolContext &sc, *sc.comp_unit, results.GetSearchedSymbolFiles(), [&](Module &module) { module.FindTypes(query, results); pcm_type_sp = results.GetTypeMap().FirstType()

[Lldb-commits] [lld] [llvm] [libc] [clang] [clang-tools-extra] [lldb] [compiler-rt] [libcxx] [mlir] [flang] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars.

2023-12-20 Thread via lldb-commits
https://github.com/UmeshKalappa0 updated https://github.com/llvm/llvm-project/pull/75564 >From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001 From: Umesh Kalappa Date: Fri, 15 Dec 2023 11:52:52 +0530 Subject: [PATCH 1/4] Problem :For Kernel Modules ,emitting the relocs like

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -161,6 +161,17 @@ def cleanup(): ) self.expect("my_command", substrs=["a.out"]) +# Test that without --overwrite we are not allowed to redefine the command. +self.expect( +"command script add my_command --class welcome.Targetname

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef name, if (UserCommandExists(name)) { if (!can_replace) { - result.SetErrorString("user command exists and force replace not set"); + result.SetErrorString( + "user command

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/76030 >From a9a1cbc1ac42b2eb66dac8a60aa9d8f54df291c3 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 18 Dec 2023 11:26:41 -0300 Subject: [PATCH 1/2] [lldb] Add actionable feedback when overw

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Address review comments https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -161,6 +161,19 @@ def cleanup(): ) self.expect("my_command", substrs=["a.out"]) +# Test that without --overwrite we are not allowed to redefine the command. +self.expect( +"command script add my_command --class welcome.Targetname

[Lldb-commits] [lldb] 83f8cae - [lldb][test] Skip runlocker test on AArch64 Linux

2023-12-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-20T11:05:52Z New Revision: 83f8caeab476646eea21bdde619b0beb84ebd70b URL: https://github.com/llvm/llvm-project/commit/83f8caeab476646eea21bdde619b0beb84ebd70b DIFF: https://github.com/llvm/llvm-project/commit/83f8caeab476646eea21bdde619b0beb84ebd70b.diff LOG

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread David Spickett via lldb-commits
@@ -161,6 +161,19 @@ def cleanup(): ) self.expect("my_command", substrs=["a.out"]) +# Test that without --overwrite we are not allowed to redefine the command. +self.expect( +"command script add my_command --class welcome.Targetname

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [flang] [clang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-12-20 Thread Markos Horro via lldb-commits
markoshorro wrote: @fhahn yeah, thanks. I'm investigating this. https://github.com/llvm/llvm-project/pull/71072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [flang] [clang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-12-20 Thread Florian Hahn via lldb-commits
fhahn wrote: @markoshorro Great thanks. Please revert the patch if you won't be able to fix this today. https://github.com/llvm/llvm-project/pull/71072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] a8af51d - [lldb][test] Skip global module cache on Arm/AArch64 Linux (again)

2023-12-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-20T13:56:40Z New Revision: a8af51dfa54c4d66a25fafb79dd8fbf00c98be59 URL: https://github.com/llvm/llvm-project/commit/a8af51dfa54c4d66a25fafb79dd8fbf00c98be59 DIFF: https://github.com/llvm/llvm-project/commit/a8af51dfa54c4d66a25fafb79dd8fbf00c98be59.diff LOG

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: The problem will require a more involved fix I think, I've written up the details in https://github.com/llvm/llvm-project/issues/76057. https://github.com/llvm/llvm-project/pull/74894 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] 7767c58 - [lldb][DWARF] Search for symbols in all external modules (#75927)

2023-12-20 Thread via lldb-commits
Author: David Spickett Date: 2023-12-20T14:48:01Z New Revision: 7767c5856d85cd1acf2efc32f77fdf07f00f9ff4 URL: https://github.com/llvm/llvm-project/commit/7767c5856d85cd1acf2efc32f77fdf07f00f9ff4 DIFF: https://github.com/llvm/llvm-project/commit/7767c5856d85cd1acf2efc32f77fdf07f00f9ff4.diff LOG

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

2023-12-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/75927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

2023-12-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Didn't want to leave this broken over the holiday break so I've merged it as obvious. I would still like to add a test so if @adrian-prantl or anyone else can tell me how to write one, I'll do that as a follow up. Need some clues as I've not used modules before. https://

[Lldb-commits] [clang-tools-extra] [clang] [llvm] [mlir] [lldb] [compiler-rt] [lld] [flang] [libcxx] [builtins][arm64] Implement __init_cpu_features_resolver on Apple platforms (PR #75636)

2023-12-20 Thread Pavel Iliin via lldb-commits
@@ -0,0 +1,69 @@ +#include +#if TARGET_OS_OSX || TARGET_OS_IPHONE +#include +#include + +static bool isKnownAndSupported(const char *name) { + int32_t val = 0; + size_t size = sizeof(val); + if (sysctlbyname(name, &val, &size, NULL, 0)) +return false; + return val; +} +

[Lldb-commits] [flang] [lld] [libcxx] [clang] [lldb] [mlir] [llvm] [compiler-rt] [builtins] Refactor cpu_model support to reduce #if nesting. NFCI (PR #75635)

2023-12-20 Thread Jon Roelofs via lldb-commits
jroelofs wrote: @petrhosek I don't have a Fucshia sysroot to build this against, so I think it would help me a lot if you could grab the preprocessed version of the `cpu_model.c` before all these changes and stick it in a github gist... I feel a little bad for dragging this out in-tree. > The

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove 2nd "error: " substring in output to developer (PR #72150)

2023-12-20 Thread Pete Lawrence via lldb-commits
PortalPete wrote: My apologies. I renamed the branch and apparently that's GitHub's cue to close all the PRs coming from that branch. In this case, it's probably for the best because we decided to break this up into 2-3 PRs. https://github.com/llvm/llvm-project/pull/72150

[Lldb-commits] [lldb] [lldb] In-progress — All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-20 Thread Pete Lawrence via lldb-commits
PortalPete wrote: My apologies. I renamed the branch and apparently that's GitHub's cue to close all the PRs coming from that branch. I'll recreate the PR but please feel free to ask questions and make suggestions here in the meantime. I'll post the replacement PR when it's up. https://github

[Lldb-commits] [lldb] [lldb] Add actionable feedback when overwriting a command fails (PR #76030)

2023-12-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/76030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-20 Thread via lldb-commits
jimingham wrote: This can happen if you don't succeed in shutting down the private state thread as part of exiting, so that it is still trying to operate on a process that has been finalized. Not sure why the shutdown ordering seems wrong in the Linux case, however. Jim > On Dec 15, 2023, a

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-20 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete created https://github.com/llvm/llvm-project/pull/76111 For example, the following message has the severity string "error: " twice. > "error: :3:1: error: cannot find 'bogus' in scope This method already appends the severity string in the beginning, but wit

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pete Lawrence (PortalPete) Changes For example, the following message has the severity string "error: " twice. > "error: :3:1: error: cannot find 'bogus' in scope This method already appends the severity string in the beginnin

[Lldb-commits] [lldb] [lldb] Remove redundant severity substring within a diagnostic message. (PR #76111)

2023-12-20 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/76111 >From b87fd5cef3463e463589a3fbce2bbd6cb08566dd Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Tue, 19 Dec 2023 19:25:36 -1000 Subject: [PATCH] [lldb] Remove redundant severity substring within a diagnosti

[Lldb-commits] [lldb] [lldb] enchance colorize process for image lookup command (PR #76112)

2023-12-20 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl created https://github.com/llvm/llvm-project/pull/76112 Follow-up to #69422. This commit builds upon the previous contribution that introduced symbol colorization in the image lookup command when using regex. In response to feedback from reviewers, this follow-up

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl edited https://github.com/llvm/llvm-project/pull/76112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-lldb Author: José Lira Junior (junior-jl) Changes Follow-up to #69422. This commit builds upon the previous contribution that introduced symbol colorization in the image lookup command when using r

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 912506b75d8a508353a701c230e73ca

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/76112 From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001 From: taalhaataahir0102 <23100...@lums.edu.pk> Date: Wed, 13 Dec 2023 15:12:29 +0500 Subject: [PATCH 1/5] Using struct for transfering patte

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/76112 From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001 From: taalhaataahir0102 <23100...@lums.edu.pk> Date: Wed, 13 Dec 2023 15:12:29 +0500 Subject: [PATCH 1/6] Using struct for transfering patte

[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

2023-12-20 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: taalhaataahir0102 wrote: Hi! @DavidSpickett, made the above changes. 1. struct has been introduced inside stream.h and all the information is being passed using optional struct (`std: