=?utf-8?q?José?= L. Junior <jljunio...@gmail.com>, =?utf-8?q?José?= L. Junior <jljunio...@gmail.com>, =?utf-8?q?José?= L. Junior <jljunio...@gmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/76...@github.com>
taalhaataahir0102 wrote: Hi! @DavidSpickett, made the above changes. 1. struct has been introduced inside stream.h and all the information is being passed using optional struct (`std::optional<Information> pattern_info`) and all the member variables inside the struct are `llvm::StringRef`. Were not able to solve the issue for `llvm::regex` 2. For function search, it was similar to symbol search as it also passes all the information to the same dumping functions. 3. For test cases, Right now all the test cases are for -s flag (symbol search) i..e, 11 in total. Should we split the current test cases like 4 for symbol search, 4 for function search (-F flag) and 3 for symbol-or-function search (-n flag) or we should add more test cases for each flag? https://github.com/llvm/llvm-project/pull/76112 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
