taalhaataahir0102 wrote:
Hi David!
I've updated the feedback. I got your point of somehow embedding the use-color
and name in a single argument. Now we're doing the following:
In the very first function (`LookupSymbolInModule`) which calls other dump:
```
bool use_color = interpreter.GetDebugge
taalhaataahir0102 wrote:
Added the wrong test case in the previous commit by mistake. Have removed it in
the new one :/ Sorry for the inconvenience
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70639
>From 81bd54091451eb2021007bc10b8a7c6965178800 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 27 Oct 2023 16:19:47 +0100
Subject: [PATCH 1/8] [clang][DebugInfo] Emit global variable definitions for
st
DavidSpickett wrote:
> Was facing some issues while checking for empty string using:
You don't need to check for an empty string here. You're checking that it found
0 symbols, that's the string you want (which will be colourless of course).
The check for this is not "check my functions did the
Author: Michael Buch
Date: 2023-11-06T10:23:26Z
New Revision: 4909814c08fdf4ec8bd9dad4f157d03de7c3c800
URL:
https://github.com/llvm/llvm-project/commit/4909814c08fdf4ec8bd9dad4f157d03de7c3c800
DIFF:
https://github.com/llvm/llvm-project/commit/4909814c08fdf4ec8bd9dad4f157d03de7c3c800.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70639
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-06T10:23:47Z
New Revision: 934c573b7d24327fafea916a1d0e9a9fc88f87ab
URL:
https://github.com/llvm/llvm-project/commit/934c573b7d24327fafea916a1d0e9a9fc88f87ab
DIFF:
https://github.com/llvm/llvm-project/commit/934c573b7d24327fafea916a1d0e9a9fc88f87ab.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-06T10:24:05Z
New Revision: ef3febadf606c2fc4f1ad8d85a7ecdde16e4cbb3
URL:
https://github.com/llvm/llvm-project/commit/ef3febadf606c2fc4f1ad8d85a7ecdde16e4cbb3
DIFF:
https://github.com/llvm/llvm-project/commit/ef3febadf606c2fc4f1ad8d85a7ecdde16e4cbb3.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71372
This fails on the matrix build bot for Clang versions < 9.0
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7309/execution/node/102/log/?consoleFull
```
FAIL: LLDB :: test_vtable (TestVTableV
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This fails on the matrix build bot for Clang versions < 9.0
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7309/execution/node/102/log/?consoleFull
```
FAIL: LLDB :: test_vtable (TestVTab
Michael137 wrote:
Looks like this caused a build test failure on linux for
`lang/cpp/symbols/TestSymbols.test_dwo`:
```
make
VPATH=/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/lang/cpp/symbols
-C
/home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/lang/cpp
https://github.com/ramosian-glider updated
https://github.com/llvm/llvm-project/pull/70660
>From 3be71f474ee11326567458c8145c3b4e56031189 Mon Sep 17 00:00:00 2001
From: Alexander Potapenko
Date: Mon, 30 Oct 2023 12:18:47 +0100
Subject: [PATCH 1/2] [sanitizer][msan] fix AArch64 vararg support fo
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71378
This reverts commit 934c573b7d24327fafea916a1d0e9a9fc88f87ab.
We had to revert dependencies of this patch due to test failures on Linux:
```
4909814c08fdf4ec8bd9dad4f157d03de7c3c800
ef3febadf606c2fc4f1ad8d85a7
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This reverts commit 934c573b7d24327fafea916a1d0e9a9fc88f87ab.
We had to revert dependencies of this patch due to test failures on Linux:
```
4909814c08fdf4ec8bd9dad4f157d03de7c3c800
ef3febadf606c2fc4f1ad8d8
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-06T10:55:27Z
New Revision: 947a32aed8eba20022a2bf4b1678937310de019f
URL:
https://github.com/llvm/llvm-project/commit/947a32aed8eba20022a2bf4b1678937310de019f
DIFF:
https://github.com/llvm/llvm-project/commit/947a32aed8eba20022a2bf4b1678937310de019f.diff
LOG:
Author: Michael Buch
Date: 2023-11-06T10:56:49Z
New Revision: 5f86b49146902a37ea93470b5992206b20665128
URL:
https://github.com/llvm/llvm-project/commit/5f86b49146902a37ea93470b5992206b20665128
DIFF:
https://github.com/llvm/llvm-project/commit/5f86b49146902a37ea93470b5992206b20665128.diff
LOG:
Author: Michael Buch
Date: 2023-11-06T10:58:02Z
New Revision: 333124cfd6dfa413294e80f9be75460b9a9314f9
URL:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9
DIFF:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9.diff
LOG:
Author: David Spickett
Date: 2023-11-06T11:30:19Z
New Revision: 3f5fd4b3c1d670649b59f3631287b6f54c6b85ee
URL:
https://github.com/llvm/llvm-project/commit/3f5fd4b3c1d670649b59f3631287b6f54c6b85ee
DIFF:
https://github.com/llvm/llvm-project/commit/3f5fd4b3c1d670649b59f3631287b6f54c6b85ee.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/70950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/71175
>From e14805de814d60f15a2671dd739caf10d19f2ea6 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 3 Nov 2023 10:58:15 +
Subject: [PATCH] [lldb] Replace some register handling asserts with lldbasse
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/71175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/71175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
`report_fatal_error` goes against not crashing the debugger, so despite what
the docs say, `lldbassert` does fit here I think.
https://github.com/llvm/llvm-project/pull/71175
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/71402
GDBRemoteRegisterContext only needs to iterate them, ArchitectureAArch64 needs
to mutate them if scalable registers change size.
>From 8b074aa5024deadfb74db6c10a812e5a474c6f1a Mon Sep 17 00:00:00 2001
From
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
GDBRemoteRegisterContext only needs to iterate them, ArchitectureAArch64 needs
to mutate them if scalable registers change size.
---
Full diff: https://github.com/llvm/llvm-project/pull/71402.diff
3
@@ -1548,14 +1566,29 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
if (symbol) {
if (symbol->ValueIsAddress()) {
+ // Using the new dump function to add colors in
@@ -403,9 +407,48 @@ bool Address::GetDescription(Stream &s, Target &target,
return false;
}
+//==
+
+// Function to print the searched symbol in red color
+void Address::re_pattern(Stream *strm,
@@ -253,9 +264,20 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
m_addr_range.GetBaseAddress().GetOffset());
}
ConstString demangled = GetMangled().GetDemangledName();
- if (demangled)
+
+ // Checking if the name (i.e., searched s
@@ -163,6 +175,12 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
+
+ // Similar here, Using re_pattern if
@@ -793,8 +852,10 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
}
}
}
-if (fallback_style != DumpStyleInvalid)
+if (fallback_style != DumpStyleInvalid && !name)
return Dump(s, exe_scope, fallback_style, Dum
@@ -762,8 +818,11 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
}
}
} else {
- if (fallback_style != DumpStyleInvalid)
+ if (fallback_style != DumpStyleInvalid && !name)
return Dump(s, exe_scope, fallba
@@ -680,21 +729,28 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
if (show_stop_context) {
// We have a function or a symbol from the same sections as this
// address.
- sc.DumpStopContex
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/71372
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,3 +130,29 @@ def test_dwos_not_loaded_table_output(self):
"0x[a-zA-Z0-9]{16}\s+E\s+.*foo\.dwo",
],
)
+
+@skipIfRemote
+@skipIfDarwin
+@skipIfWindows
bulbazord wrote:
The TestDumpOso is good, but I was mor
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
bulbazord wrote:
This is probably a gap in my underst
@@ -60,6 +60,52 @@ def move_blueprint_to_dsym(self, blueprint_name):
)
shutil.copy(blueprint_origin_path, blueprint_destination_path)
+def test_missing_methods_scripted_register_context(self):
+"""Test that we only instanciate scripted processes if
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) {
return PyDict_Check(py_obj);
}
+bool PythonDictionary::HasKey(const llvm::Twine &key) const {
bulbazord wrote:
You could avoid a potential allocation with the creation of the `PythonStrin
Author: GeorgeHuyubo
Date: 2023-11-06T09:49:29-08:00
New Revision: 10ec3bc9773e7e31255d5d3997f3966354a67d0d
URL:
https://github.com/llvm/llvm-project/commit/10ec3bc9773e7e31255d5d3997f3966354a67d0d
DIFF:
https://github.com/llvm/llvm-project/commit/10ec3bc9773e7e31255d5d3997f3966354a67d0d.diff
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/71258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -228,7 +228,9 @@ bool GDBRemoteRegisterContext::ReadRegisterBytes(const
RegisterInfo *reg_info) {
SetAllRegisterValid(true);
return true;
} else if (buffer_sp->GetByteSize() > 0) {
- for (auto x : llvm::enumerate(m_reg_info_sp->registers
@@ -108,10 +104,11 @@ bool
ArchitectureAArch64::ReconfigureRegisterInfo(DynamicRegisterInfo ®_info,
if (!vg_reg_value && !svg_reg_value)
return false;
+ auto regs = reg_info.registers();
medismailben wrote:
nit: If you specify the type of `regs` (inst
https://github.com/medismailben approved this pull request.
Nice! Looks good to me! Left some comments but it's mostly a matter of style.
Pick what approach you like the most :)
https://github.com/llvm/llvm-project/pull/71402
___
lldb-commits mailing
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
medismailben wrote:
The same way we instantiate a bas
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/71372
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,6 +32,42 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ enum class AbstractMethodCheckerCases {
+eNotImplemented,
+eN
https://github.com/JDevlieghere commented:
Is there any way we could avoid ever having to instantiate a
`Scripted{.*}Interface`?
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,27 +32,66 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ enum class AbstractMethodCheckerCases {
+eNotImplemented,
+e
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
JDevlieghere wrote:
I think I asked something similar
@@ -99,25 +135,87 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
}
llvm::Expected expected_return_object =
- llvm::createStringError(llvm::inconvertibleErrorCode(),
- "Resulting object is not initial
https://github.com/clayborg approved this pull request.
These asserts are testing that the static representation of register contexts
is ok and building and testing with asserts enabled should flush out any
issues. `lldbassert()` is perfect for this since it is enabled for debug builds
while t
@@ -32,27 +32,66 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ enum class AbstractMethodCheckerCases {
+eNotImplemented,
+e
@@ -99,25 +135,87 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
}
llvm::Expected expected_return_object =
- llvm::createStringError(llvm::inconvertibleErrorCode(),
- "Resulting object is not initial
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Is there any way we could avoid ever having to instantiate a
> `Scripted{.*}Interface`?
@JDevlieghere I actually suggested something here
https://github.com/llvm/llvm-project/pull/71260#discussion_r1383748012
https://github.com/llvm/llvm-project/pull/71260
__
JDevlieghere wrote:
> These asserts are testing that the static representation of register contexts
> is ok and building and testing with asserts enabled should flush out any
> issues. `lldbassert()` is perfect for this since it is enabled for debug
> builds while testing happens.
The [contri
Author: Michael Buch
Date: 2023-11-06T19:15:39Z
New Revision: 876bd794fc33c74fc8689015699b9fec06dd0580
URL:
https://github.com/llvm/llvm-project/commit/876bd794fc33c74fc8689015699b9fec06dd0580
DIFF:
https://github.com/llvm/llvm-project/commit/876bd794fc33c74fc8689015699b9fec06dd0580.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71372
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,102 @@
+//===-- RegisterFlagsLinux_arm64.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -67,6 +70,21 @@
RegisterContextCorePOSIX_arm64::RegisterContextCorePOSIX_arm64(
: RegisterContextPOSIX_arm64(thread, std::move(register_info)) {
::memset(&m_sme_pseudo_regs, 0, sizeof(m_sme_pseudo_regs));
+ ProcessElfCore *process =
+ static_cast(thread.GetProc
@@ -0,0 +1,77 @@
+//===-- RegisterFlagsLinux_arm64.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/bulbazord approved this pull request.
Works for me.
https://github.com/llvm/llvm-project/pull/71402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -89,12 +89,18 @@ class DynamicRegisterInfo {
GetRegisterInfo(llvm::StringRef reg_name) const;
typedef std::vector reg_collection;
- llvm::iterator_range registers() const {
-return llvm::iterator_range(m_regs);
+
+ template T registers();
bulbazo
Author: Alex Langford
Date: 2023-11-06T12:45:02-08:00
New Revision: f4df0c48e912f01abe2ecaad207b469745620c5d
URL:
https://github.com/llvm/llvm-project/commit/f4df0c48e912f01abe2ecaad207b469745620c5d
DIFF:
https://github.com/llvm/llvm-project/commit/f4df0c48e912f01abe2ecaad207b469745620c5d.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/71241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
@jimingham Does this work for you?
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
FWIW the "plugin-ification" has landed so this should be able to move forward
as a plugin.
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) {
return PyDict_Check(py_obj);
}
+bool PythonDictionary::HasKey(const llvm::Twine &key) const {
medismailben wrote:
Done!
https://github.com/llvm/llvm-project/pull/71260
__
@@ -330,6 +330,23 @@ def getStdFlag(cfg, std):
default=f"{shlex.quote(sys.executable)}
{shlex.quote(str(Path(__file__).resolve().parent.parent.parent / 'run.py'))}",
help="Custom executor to use instead of the configured default.",
actions=lambda execut
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
medismailben wrote:
Ok, I'll make the the base class
https://github.com/slinder1 requested changes to this pull request.
I don't mean to make existing debt your problem, but if it isn't too much work
could you post a pre-patch that just adds the `FileCheck`s to the existing
tests where the behavior changes, so the test diff is more self-documenti
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
https://github.com/slinder1 edited
https://github.com/llvm/llvm-project/pull/70898
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/71260
>From 4f15a3dfa7fdf600f76e434dc93879de910b317b Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 6 Nov 2023 14:15:12 -0800
Subject: [PATCH] [lldb] Check for abstract methods implementation in Scri
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I'm on board
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71455
- [LLDB][easy] Fix a bug in DummySyntheticFrontEnd
- [LLDB] Don't forcefully initialize the process trace plugin
>From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001
From: walter erqu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
- [LLDB][easy] Fix a bug in DummySyntheticFrontEnd
- [LLDB] Don't forcefully initialize the process trace plugin
---
Full diff: https://github.com/llvm/llvm-project/pull/71455.diff
3 Files Affe
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71455
>From d877ef80bbaa62afed2c7656c5ff6e84a8628786 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 6 Nov 2023 17:57:45 -0500
Subject: [PATCH] [LLDB] Don't forcefully initialize the process trace p
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71456
This commit adds an MD5 checksum (`Checksum`) class to LLDB. Its purpose is to
store the MD5 hash added to the DWARF 5 line table.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
Fro
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This commit adds an MD5 checksum (`Checksum`) class to LLDB. Its purpose is to
store the MD5 hash added to the DWARF 5 line table.
---
Full diff: https://github.com/llvm/llvm-project/pull/71456.diff
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71457
Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added
to the DWARF 5 line table.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added
to the DWARF 5 line table.
---
Full diff: https://github.com/llvm/llvm-project/pull/71457.diff
8 Files Affected:
- (added)
JDevlieghere wrote:
Depends on #71456.
I considered an alternative where we don't store the `Checksum` in the
`FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a
`FileSpec`. The reason I didn't got with this approach is because of the
`FileSpecList`. The latter has
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71458
Read the MD5 checksum from DWARF line tables and store it in the
corresponding support files.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 6 Nov
JDevlieghere wrote:
Depends on #71457.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Read the MD5 checksum from DWARF line tables and store it in the
corresponding support files.
---
Full diff: https://github.com/llvm/llvm-project/pull/71458.diff
9 Files Affected:
- (added) lldb/i
1 - 100 of 154 matches
Mail list logo
