@@ -17,11 +17,17 @@ class RegisterFlags {
public:
class Field {
public:
+/// Where start is the least significant bit and end is the most
+/// significant bit. The start bit must be <= the end bit.
Field(std::string name, unsigned start, unsigned end)
DavidSpickett wrote:
> Is there anywhere you can begin to use this other than in the tests? Or is
> this building up to [your proposal on adding register field info to
> lldb-server](https://discourse.llvm.org/t/rfc-adding-register-field-information-to-lldb-server/74143)?
Yes. I'm working on a
DavidSpickett wrote:
Same for AArch64 Ubuntu
(https://lab.llvm.org/buildbot/#/builders/96/builds/47090) and Windows
(https://lab.llvm.org/buildbot/#/builders/219/builds/6372) (32 bit ARM is out
of action right now).
Same symptom as the above comment.
https://github.com/llvm/llvm-project/pull
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/69355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-10-18T10:25:41Z
New Revision: 0dca56603b4e13232dfb1f1b80e01604fcf36314
URL:
https://github.com/llvm/llvm-project/commit/0dca56603b4e13232dfb1f1b80e01604fcf36314
DIFF:
https://github.com/llvm/llvm-project/commit/0dca56603b4e13232dfb1f1b80e01604fcf36314.diff
LOG
DavidSpickett wrote:
I've reverted it as the failure reason wasn't immediately obvious to me. Looks
like it will reproduce quite easily.
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -17,11 +17,17 @@ class RegisterFlags {
public:
class Field {
public:
+/// Where start is the least significant bit and end is the most
+/// significant bit. The start bit must be <= the end bit.
Field(std::string name, unsigned start, unsigned end)
@@ -1,5 +1,5 @@
{
- "name": "lldb-vscode",
+ "name": "lldb-dap",
DavidSpickett wrote:
This and disassembly.json are still in the wrong place. I think move everything
up one level and delete the lldb-vscode folder. As the instructions refer to
packa
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/69315
>From 1f5a161cb9265f2761e93d2352c65e382a44a1e5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 17 Oct 2023 10:10:36 +
Subject: [PATCH 1/2] [lldb] Add a single bit constructor for RegisterField
@@ -17,11 +17,17 @@ class RegisterFlags {
public:
class Field {
public:
+/// Where start is the least significant bit and end is the most
+/// significant bit. The start bit must be <= the end bit.
Field(std::string name, unsigned start, unsigned end)
DavidSpickett wrote:
So, the automatic checkers here are going to complain about formatting and
style - ignore them for now. We'll review all that once the important stuff is
done.
You should put this PR into "draft" mode, there is a button somewhere on the
page (that only you can see). Just
https://github.com/taalhaataahir0102 converted_to_draft
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/haampie created
https://github.com/llvm/llvm-project/pull/69458
None
>From 69f81114712171f09d859a15324b061181f5a72c Mon Sep 17 00:00:00 2001
From: Harmen Stoppels
Date: Wed, 18 Oct 2023 14:42:29 +0200
Subject: [PATCH] LLDB: fix linking to libtinfo
---
lldb/source/Core/CMak
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Harmen Stoppels (haampie)
Changes
`TERMINFO_LIB` is defined nowhere
---
Full diff: https://github.com/llvm/llvm-project/pull/69458.diff
1 Files Affected:
- (modified) lldb/source/Core/CMakeLists.txt (+1-1)
``diff
diff --git a/
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I see that
https://github.com/llvm/llvm-project/commit/b66339575a9b541e67ce5ad2ba7e88da07cf9305
removed the variable, but I never saw this on a buildbot, must be a config we
don't cover.
What build configuration hits this issue? Please make a note of that in the
commit m
haampie wrote:
It's basically the same issue as #25067. Happens when ncurses is configured
with `--with-termlib`, which puts certain symbols that lldb uses in `libtinfo`
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lld
DavidSpickett wrote:
Ok now I understand.
So please add what you just wrote to the commit message/ PR description. It
will help anyone fighting the same issue later.
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-c
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
And thanks for the patch, looks like the issue you linked was fixed, then would
have been broken again for a time, and will now be fixed! All's well that ends
well.
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits
https://github.com/haampie edited
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
haampie wrote:
Updated the PR description. That's sufficient?
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eugeneswalker wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
If you have the ability to merge, go ahead. Otherwise I can click the button
for you.
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
haampie wrote:
I can't merge, feel free to do so!
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Harmen Stoppels
Date: 2023-10-18T16:06:50+01:00
New Revision: 0a9bdc276d2598d7525fa91bbf9cb663f1fde01a
URL:
https://github.com/llvm/llvm-project/commit/0a9bdc276d2598d7525fa91bbf9cb663f1fde01a
DIFF:
https://github.com/llvm/llvm-project/commit/0a9bdc276d2598d7525fa91bbf9cb663f1fde01a.dif
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/69458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -280,29 +81,13 @@ void InstrumentationRuntimeASan::Activate() {
if (!process_sp)
return;
- ConstString symbol_name("_ZN6__asanL7AsanDieEv");
- const Symbol *symbol = GetRuntimeModuleSP()->FindFirstSymbolWithNameAndType(
- symbol_name, eSymbolTypeCode);
+ Break
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
bulbazord wrote:
+1
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
https://github.com/bulbazord commented:
Overall looks alright to me. Aside from the inline feedback, I have 2 general
pieces of feedback.
1. It might be easier if you broke this up into 2 separate commits. You're
doing 2 things in 1 commit: Refactoring InstrumentationRuntimeAsan and adding a
n
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self):
self.expect(
error.GetCString(),
exe=False,
-substrs=["watch size of %d is not supported" % 365],
+substrs=["Setting one of the
https://github.com/tstellar approved this pull request.
https://github.com/llvm/llvm-project/pull/68920
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/69516
This commit adds a boolean flag `is_discrete` is to progress reports in LLDB.
The flag is set to false by default and indicates if a progress event is
discrete, i.e. an operation that has no clear start an
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/69517
Add a way to set a *static* callback to locate DWO files in `SBModule`.
```
SBError SBLocateDwoCallback(void *baton, const SBFileSpec &objfile_spec, const
char *dwo_name, const char *comp_dir, const int64_t dwo_id,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit adds a boolean flag `is_discrete` is to progress reports in LLDB.
The flag is set to false by default and indicates if a progress event is
discrete, i.e. an operation that has no clear
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tom Yang (zhyty)
Changes
Add a way to set a *static* callback to locate DWO files in `SBModule`.
```
SBError SBLocateDwoCallback(void *baton, const SBFileSpec &objfile_spec,
const char *dwo_name, const char *comp_dir, const int64_t dwo_id,
https://github.com/topperc updated
https://github.com/llvm/llvm-project/pull/69289
>From ceadfba61ebd4d208d1b0b07b9344841d6fd3ac4 Mon Sep 17 00:00:00 2001
From: Craig Topper
Date: Mon, 16 Oct 2023 22:34:53 -0700
Subject: [PATCH] [RISCV][GISel][WIP] Support passing arguments through the
stack.
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2219,7 +2219,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const FileSpec &file = m_file ? m_file : module_sp->GetFileSpec();
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_na
@@ -1426,7 +1427,8 @@ void Debugger::ReportProgress(uint64_t progress_id,
std::string title,
if (debugger_sp)
PrivateReportProgress(*debugger_sp, progress_id, std::move(title),
std::move(details), completed, total,
-
https://github.com/slackito approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
@@ -2219,7 +2219,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const FileSpec &file = m_file ? m_file : module_sp->GetFileSpec();
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_na
@@ -1426,7 +1427,8 @@ void Debugger::ReportProgress(uint64_t progress_id,
std::string title,
if (debugger_sp)
PrivateReportProgress(*debugger_sp, progress_id, std::move(title),
std::move(details), completed, total,
-
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/2] [lldb][progress] Add discrete boolean flag to progr
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/3] [lldb][progress] Add discrete boolean flag to progr
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/3] [lldb][progress] Add discrete boolean flag to progre
https://github.com/medismailben approved this pull request.
LGTM! Thanks!
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/69531
The method DWARFDebugInfoEntry::Extract needs to skip over all the data in the
debug_info / debug_types section for each DIE. It had the logic to do so
hardcoded inside a loop, when it already exists in a
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
The method DWARFDebugInfoEntry::Extract needs to skip over all the data in the
debug_info / debug_types section for each DIE. It had the logic to do so
hardcoded inside a loop, when
https://github.com/clayborg approved this pull request.
Please manually verify all cases are handled in the DWARFFormValue::SkipValue()
function to ensure we are not losing functionality. LGTM.
https://github.com/llvm/llvm-project/pull/69531
___
lldb-
@@ -2,8 +2,8 @@
#include
int main() {
- uint8_t x1 = 0;
- uint16_t x2 = 0;
+ long x1 = 0;
+ long x2 = 0;
jasonmolenda wrote:
You're right. I thought this test was *unintentionally* testing the case where
we have two hardware watchpoint register watchin
@@ -1,3 +1,10 @@
# REQUIRES: system-darwin
+# TODO: This test is breaking with my output
+# reformatting done for Large Watchpoint support,
+# but the lines being output by lldb are identical,
+# by visual inspection.
+# FileCheck is seeing some difference between them,
+# whi
@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
m_tag = abbrevDecl->getTag();
m_has_children = abbrevDecl->hasChildren();
// Skip all data in the .debug_info or .debug_types for the attributes
- dw_form_t form;
for (const auto &
felipepiovezan wrote:
> Please manually verify all cases are handled in the
> DWARFFormValue::SkipValue() function to ensure we are not losing
> functionality. LGTM.
Yup, I've compared the two functions twice, so I'm fairly confident they are
identical :)
https://github.com/llvm/llvm-projec
@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
m_tag = abbrevDecl->getTag();
m_has_children = abbrevDecl->hasChildren();
// Skip all data in the .debug_info or .debug_types for the attributes
- dw_form_t form;
for (const auto &
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/69531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
Looks fine but it doesn't look like `is_discrete` is being propagated correctly
everywhere?
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits
@@ -16,7 +16,7 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
bulbazord wrote:
You added this parameter but it do
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message = progress_data.Ge
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message = progress_data.Ge
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message = progress_data.Ge
@@ -16,7 +16,7 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
chelcassanova wrote:
Yes it was, left it out by mis
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/4] [lldb][progress] Add discrete boolean flag to progr
@@ -16,9 +16,10 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
lldb_private::Debugger *debugger)
-: m_title
https://github.com/bulbazord approved this pull request.
I looked at the implementations and I didn't notice anything too different
either. This brings us from 3 implementations of this logic to 2. Hopefully we
can make it 1 someday soon. 😄
https://github.com/llvm/llvm-project/pull/69531
@@ -16,9 +16,10 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
lldb_private::Debugger *debugger)
-: m_title
@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
m_tag = abbrevDecl->getTag();
m_has_children = abbrevDecl->hasChildren();
// Skip all data in the .debug_info or .debug_types for the attributes
- dw_form_t form;
for (const auto &
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/69517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -139,6 +139,13 @@ typedef void (*SBDebuggerDestroyCallback)(lldb::user_id_t
debugger_id,
typedef SBError (*SBPlatformLocateModuleCallback)(
void *baton, const SBModuleSpec &module_spec, SBFileSpec &module_file_spec,
SBFileSpec &symbol_file_spec);
+
+typedef SBError
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -475,6 +484,8 @@ class SymbolFile : public PluginInterface {
private:
SymbolFile(const SymbolFile &) = delete;
const SymbolFile &operator=(const SymbolFile &) = delete;
+
+ static LocateDwoCallback LOCATE_DWO_CALLBACK;
clayborg wrote:
static variable a
@@ -296,6 +296,20 @@ class LLDB_API SBModule {
/// Remove any global modules which are no longer needed.
static void GarbageCollectAllocatedModules();
+ /// Set a callback which is called to find separate DWARF DWO debug info
+ /// files.
+ ///
+ /// This is useful whe
@@ -1742,20 +1742,37 @@ SymbolFileDWARF::GetDwoSymbolFileForCompileUnit(
if (std::shared_ptr dwp_sp = GetDwpSymbolFile())
return dwp_sp;
- FileSpec dwo_file(dwo_name);
- FileSystem::Instance().Resolve(dwo_file);
- bool found = false;
+ const char *comp_dir =
+ c
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -52,12 +52,17 @@ llvm::StringRef GetAsString(const llvm::json::Value &value);
/// \param[in] key
/// The key to use when extracting the value
///
+/// \param[in] defaultValue
+/// The default value to return if the key is not present
+///
/// \return
/// A llvm
@@ -418,7 +419,9 @@ ExpressionContext
VSCode::DetectExpressionContext(lldb::SBFrame &frame,
if (!auto_repl_mode_collision_warning) {
llvm::errs() << "Variable expression '" << text
<< "' is hiding an lldb command, prefix an expression "
1 - 100 of 102 matches
Mail list logo
