https://github.com/bulbazord commented:
Overall looks alright to me. Aside from the inline feedback, I have 2 general pieces of feedback. 1. It might be easier if you broke this up into 2 separate commits. You're doing 2 things in 1 commit: Refactoring InstrumentationRuntimeAsan and adding a new plugin. That makes it more difficult to review since as I'm reading it, I'm having to determine what each portion of the diff is doing. 2. There were a few places where the formatting looks a bit odd. Could you run clang-format over all the code you changed/added just to make sure? If you haven't done so already, that is. https://github.com/llvm/llvm-project/pull/69388 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
