[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

RamNalamothu created this revision. RamNalamothu added reviewers: DavidSpickett, MaskRay. Herald added subscribers: luke, sunshaoce, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, s

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

mstorsjo added a comment. I noticed this review is accepted but not committed. If you don't have commit access, what's your preferred git identity, i.e. `Real Name `? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156817/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

JDevlieghere added a comment. + @aprantl for impact on the Swift REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This should probably be a language-specific setting, but I see no problem in doing it this way right now, since there is practically only one language. Please update any REPL tests on the Swi

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

yshui added a comment. In D156817#4620998 , @mstorsjo wrote: > I noticed this review is accepted but not committed. If you don't have commit > access, what's your preferred git identity, i.e. `Real Name `? "Yuxuan Shui " Thanks. Repository: rG LLVM

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

jasonmolenda added a comment. Thanks for the feedback @bulbazord & @JDevlieghere , I will address those points. I am still trying to decide on the scope of this JSON LC_NOTE. Right now it's "thread extrainfo" and a dictionary with a "threads" key by definition. But I have a feeling it should

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The majority of UnixSignals strings are static in

[Lldb-commits] [PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554016. ldionne marked an inline comment as done. ldionne added a comment. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, Enna1, yota9, ayermolo, jvesely. Herald ad

[Lldb-commits] [PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne added a comment. Herald added a subscriber: JDevlieghere. Sorry for spamming everyone, I'm trying to ensure that the CI will work with all the sub-projects in the monorepo once we move to GH PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace added a comment. @aprantl, how should I proceed with the swift branch? Should I create a new branch in https://github.com/apple/swift and share it here so it's available for whoever does the merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 8e946fe - Revert "[mlir][complex] Convert complex.abs to arith with fastmath flag"

Author: Muhammad Omair Javaid Date: 2023-08-29T02:01:20+05:00 New Revision: 8e946fec0441e7a4eb4604c806afed20c6930cc4 URL: https://github.com/llvm/llvm-project/commit/8e946fec0441e7a4eb4604c806afed20c6930cc4 DIFF: https://github.com/llvm/llvm-project/commit/8e946fec0441e7a4eb4604c806afed20c6930c

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, gkistanova. mib added a project: LLDB. Herald added a subscriber: Michael137. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch does various things to sile

[Lldb-commits] [lldb] 47aca75 - [LLDB][REPL] Change the default tab size

Author: walter erquinigo Date: 2023-08-28T17:47:30-04:00 New Revision: 47aca7562abe8de378fdb88160ece9e3fcac24f4 URL: https://github.com/llvm/llvm-project/commit/47aca7562abe8de378fdb88160ece9e3fcac24f4 DIFF: https://github.com/llvm/llvm-project/commit/47aca7562abe8de378fdb88160ece9e3fcac24f4.di

[Lldb-commits] [lldb] bc0b569 - [LLDB] Fix tab size settings tests

Author: walter erquinigo Date: 2023-08-28T17:55:15-04:00 New Revision: bc0b5699063ef4a678e663b8aee738b4906f8719 URL: https://github.com/llvm/llvm-project/commit/bc0b5699063ef4a678e663b8aee738b4906f8719 DIFF: https://github.com/llvm/llvm-project/commit/bc0b5699063ef4a678e663b8aee738b4906f8719.di

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace created this revision. wallace added reviewers: bulbazord, aprantl, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method was working as expected if `LLDB_ENABLE_LIBEDIT` is f

[Lldb-commits] [PATCH] D157063: [CodeGen] Make the MachineFunctionSplitter pass testable via MIR

dhoekwater updated this revision to Diff 554091. dhoekwater added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Try to replace with main to get this to work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157063/new

[Lldb-commits] [PATCH] D157063: [CodeGen] Make the MachineFunctionSplitter pass testable via MIR

dhoekwater updated this revision to Diff 554092. dhoekwater added a comment. Herald added a subscriber: JDevlieghere. Try to replace with a different branch to get this to work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157063/new/ https://revie

[Lldb-commits] [PATCH] D157063: [CodeGen] Make the MachineFunctionSplitter pass testable via MIR

dhoekwater updated this revision to Diff 554093. dhoekwater added a comment. Try to replace with yet another Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157063/new/ https://reviews.llvm.org/D157063 Files: llvm/lib/Target/AArch64/AArch64InstrIn

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

mib updated this revision to Diff 554102. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159017/new/ https://reviews.llvm.org/D159017 Files: lldb/bindings/interface/SBAddressExtensions.i lldb/bindings/interface/SBAttachInfoExtensions.i lldb/bindings/interface/SBBlockExtensions.i l

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Overall this LGTM. It's really unfortunate we have to define things like `__hex__` for every class. Is there a way to either (1) silence this warning on (2) have SWIG generate this