[Lldb-commits] [lldb] 7b0e548 - [lldb] Fix enumeration value 'RvvInt32m1x2' not handled in switch (NFC)

Author: Jie Fu Date: 2023-05-22T16:28:40+08:00 New Revision: 7b0e5485762b9fbbf81419aa67575c38e922e0a5 URL: https://github.com/llvm/llvm-project/commit/7b0e5485762b9fbbf81419aa67575c38e922e0a5 DIFF: https://github.com/llvm/llvm-project/commit/7b0e5485762b9fbbf81419aa67575c38e922e0a5.diff LOG: [

[Lldb-commits] [lldb] 5dfec67 - [LLDB] Skip TestInterruptBacktrace.py on Arm/Linux

Author: Muhammad Omair Javaid Date: 2023-05-22T14:53:35+04:00 New Revision: 5dfec676c3ab4fa2b7ea95d203f97faf7768b77f URL: https://github.com/llvm/llvm-project/commit/5dfec676c3ab4fa2b7ea95d203f97faf7768b77f DIFF: https://github.com/llvm/llvm-project/commit/5dfec676c3ab4fa2b7ea95d203f97faf7768b7

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. >>> Do you have a suggestion how we can move this patch forward? >> >> IIRC, D150688 + the diff in >> https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + >> upgrading the pre-merge linux bot should take care of all

[Lldb-commits] [lldb] a7c7c61 - [LLDB] Fix missing import in TestInterruptBacktrace.py

Author: Muhammad Omair Javaid Date: 2023-05-22T15:47:05+04:00 New Revision: a7c7c61af63188a66bd1ad67f9f25b48e5722b58 URL: https://github.com/llvm/llvm-project/commit/a7c7c61af63188a66bd1ad67f9f25b48e5722b58 DIFF: https://github.com/llvm/llvm-project/commit/a7c7c61af63188a66bd1ad67f9f25b48e5722b

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1165-1168 +if os.path.isdir(obj_dir.name): +for file in os.listdir(obj_dir.name): +os.unlink(os.path.join(obj_dir.name, file)) +os.rmdir(obj_dir.name)

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Are there other stop reasons that are currently not supported by scripted threads that we should consider supporting? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere. Herald added a subscriber: tschuett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These functions do the exact

[Lldb-commits] [lldb] ef73ea6 - [lldb][NFCI] Change return type of Language::GetInstanceVariableName

Author: Alex Langford Date: 2023-05-22T10:16:20-07:00 New Revision: ef73ea6cf691f08459dd33116ace45c946d05b54 URL: https://github.com/llvm/llvm-project/commit/ef73ea6cf691f08459dd33116ace45c946d05b54 DIFF: https://github.com/llvm/llvm-project/commit/ef73ea6cf691f08459dd33116ace45c946d05b54.diff

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

This revision was automatically updated to reflect the committed changes. Closed by commit rGef73ea6cf691: [lldb][NFCI] Change return type of Language::GetInstanceVariableName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470 __

[Lldb-commits] [PATCH] D145183: [libc++] Implement `stop_token`

huixie90 updated this revision to Diff 524387. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, lldb-commits, Sanitizers, TinaAMD, hoy, bviyer, wlei, jplehr, mgehre-amd, luke, hanchung, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, Enna1, bzcheeseman, mattd,

[Lldb-commits] [PATCH] D145183: [libc++] Implement `stop_token`

clementval added a comment. Herald added a subscriber: JDevlieghere. Something seems wrong with this patch. It contains multiple unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145183/new/ https://reviews.llvm.org/D145183

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

mib added a comment. In D151043#4360968 , @JDevlieghere wrote: > LGTM. Are there other stop reasons that are currently not supported by > scripted threads that we should consider supporting? Scripted Threads still don't support `eStopReasonWatchpoint`

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd25fb4e90c96: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] d25fb4e - [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

Author: Jorge Gorbe Moya Date: 2023-05-22T10:41:11-07:00 New Revision: d25fb4e90c96f8fcb22fbed9009295026f1d20cf URL: https://github.com/llvm/llvm-project/commit/d25fb4e90c96f8fcb22fbed9009295026f1d20cf DIFF: https://github.com/llvm/llvm-project/commit/d25fb4e90c96f8fcb22fbed9009295026f1d20cf.di

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4355229 , @paperchalice wrote: > In D141907#4355228 , @tstellar > wrote: > >> @paperchalice Do you need someone to commit this for you? > > Sure, I don't have the commit acce

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524398. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

bzcheeseman added inline comments. Comment at: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h:30 - LLVMCastKind getKind() const { return m_kind; } - - ExpressionTypeSystemHelper(LLVMCastKind kind) : m_kind(kind) {} - - ~ExpressionTypeSystemHelper() = default; - -p

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace added a comment. Sure, I can use it. I just didn't know it exists :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524448. wallace added a comment. Use RTTIExtends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524449. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h lldb/include

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:1165-1168 +if os.path.isdir(obj_dir.name): +for file in os.listdir(obj_dir.name): +os.unlink(os.path.join(obj_dir.name, file)) +os.rmdir(obj_dir.name) ---

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks like you're mostly moving things around which is fine. The bug that you're fixing is with thread handling in `MultiplexerScriptedProcess` right? That looks fine to me too. Reposi

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 _

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

mib added a comment. In D151044#4362084 , @bulbazord wrote: > The bug that you're fixing is with thread handling in > `MultiplexerScriptedProcess` right? That looks fine to me too. Yep! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord added a comment. Ok, this is a pretty big patch so we probably don't want to leave it in review for a long time or it just gets harder to land correctly. I've looked over most of this patch and it looks fine to me. A lot of is rather mechanical: Changing things like `GetIntegerValue`

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

mib updated this revision to Diff 524476. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ https://reviews.llvm.org/D150485 Files: lldb/include/lldb/API/SBStructuredData.h lldb/include/

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Alright, looks good to me. Let's see what the bots think! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ https://reviews.llvm.org/D150485 ___

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

mib updated this revision to Diff 524502. mib added a reviewer: bulbazord. mib added a comment. Address @JDevlieghere & @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 Files: lldb/examples/python/crashlog.py lldb/examp

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. I spent some time trying to see if there was a clear reason for the duplicated code; it was added in `llvm-svn: 193380` in 2013 and they were very clearly i

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

mib updated this revision to Diff 524521. mib added a comment. More refactoring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_process.py ll

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG1370a1cb5b97: [lldb] Add support for negative integer to {SB,}StructuredData (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ ht

[Lldb-commits] [lldb] ac09a0e - [lldb] Fix process LLDB_LOG typo (nfci)

Author: Med Ismail Bennani Date: 2023-05-22T16:14:00-07:00 New Revision: ac09a0e192e357a37d183f26f1063d18d6babf72 URL: https://github.com/llvm/llvm-project/commit/ac09a0e192e357a37d183f26f1063d18d6babf72 DIFF: https://github.com/llvm/llvm-project/commit/ac09a0e192e357a37d183f26f1063d18d6babf72.

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f407b8e6329: [lldb] Add "Trace" stop reason in Scripted Thread (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151043/new/ https://reviews

[Lldb-commits] [lldb] 1370a1c - [lldb] Add support for negative integer to {SB, }StructuredData

Author: Med Ismail Bennani Date: 2023-05-22T16:14:00-07:00 New Revision: 1370a1cb5b97ecfc4fd2cb550159db9c9ebd3a68 URL: https://github.com/llvm/llvm-project/commit/1370a1cb5b97ecfc4fd2cb550159db9c9ebd3a68 DIFF: https://github.com/llvm/llvm-project/commit/1370a1cb5b97ecfc4fd2cb550159db9c9ebd3a68.

[Lldb-commits] [lldb] 8f407b8 - [lldb] Add "Trace" stop reason in Scripted Thread

Author: Med Ismail Bennani Date: 2023-05-22T16:14:00-07:00 New Revision: 8f407b8e632956816e49d1ac0ffd6ff5245252a6 URL: https://github.com/llvm/llvm-project/commit/8f407b8e632956816e49d1ac0ffd6ff5245252a6 DIFF: https://github.com/llvm/llvm-project/commit/8f407b8e632956816e49d1ac0ffd6ff5245252a6.

[Lldb-commits] [lldb] 273a2d3 - [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

Author: Med Ismail Bennani Date: 2023-05-22T16:14:00-07:00 New Revision: 273a2d337f675f3ee050f281b1fecc3e806b9a3c URL: https://github.com/llvm/llvm-project/commit/273a2d337f675f3ee050f281b1fecc3e806b9a3c DIFF: https://github.com/llvm/llvm-project/commit/273a2d337f675f3ee050f281b1fecc3e806b9a3c.

[Lldb-commits] [lldb] abba5de - [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

Author: Med Ismail Bennani Date: 2023-05-22T16:14:00-07:00 New Revision: abba5de724665362db707d4cfab598cfbf5a475e URL: https://github.com/llvm/llvm-project/commit/abba5de724665362db707d4cfab598cfbf5a475e DIFF: https://github.com/llvm/llvm-project/commit/abba5de724665362db707d4cfab598cfbf5a475e.

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

This revision was automatically updated to reflect the committed changes. Closed by commit rG273a2d337f67: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15104

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

This revision was automatically updated to reflect the committed changes. Closed by commit rGabba5de72466: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

jingham added a comment. If a Scripted process is able to provide private events and enough info to lldb's lower level calls (read memory, registers) to work the thread-plan machinery then it won't need to generate the inferred stop reasons like PlanComplete and Instrumentation. But the script

[Lldb-commits] [lldb] f6938ff - [lldb][test] Fix -Wsign-compare in GDBRemoteCommunicationClientTest.cpp (NFC)

Author: Jie Fu Date: 2023-05-23T09:09:07+08:00 New Revision: f6938ffd4c56d270af62296e405a6b8bddf7955f URL: https://github.com/llvm/llvm-project/commit/f6938ffd4c56d270af62296e405a6b8bddf7955f DIFF: https://github.com/llvm/llvm-project/commit/f6938ffd4c56d270af62296e405a6b8bddf7955f.diff LOG: [

[Lldb-commits] [lldb] bed4d71 - [lldb] Fix racing issue when loading inlined symbols from crash report

Author: Med Ismail Bennani Date: 2023-05-22T22:18:35-07:00 New Revision: bed4d7155b81619d403b1f85ece56f33275b30ac URL: https://github.com/llvm/llvm-project/commit/bed4d7155b81619d403b1f85ece56f33275b30ac DIFF: https://github.com/llvm/llvm-project/commit/bed4d7155b81619d403b1f85ece56f33275b30ac.