Author: Jie Fu Date: 2023-05-23T09:09:07+08:00 New Revision: f6938ffd4c56d270af62296e405a6b8bddf7955f
URL: https://github.com/llvm/llvm-project/commit/f6938ffd4c56d270af62296e405a6b8bddf7955f DIFF: https://github.com/llvm/llvm-project/commit/f6938ffd4c56d270af62296e405a6b8bddf7955f.diff LOG: [lldb][test] Fix -Wsign-compare in GDBRemoteCommunicationClientTest.cpp (NFC) /data/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1526:11: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ /data/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1553:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ /data/llvm-project/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:303:3: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned long, nullptr>' requested here ASSERT_EQ(10, num_packets); ^ /data/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2056:32: note: expanded from macro 'ASSERT_EQ' ^ /data/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2040:54: note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ 1 error generated. Added: Modified: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp Removed: ################################################################################ diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp index eec494f6759ff..f93cf8ce679c5 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp @@ -300,7 +300,7 @@ TEST_F(GDBRemoteCommunicationClientTest, TestPacketSpeedJSON) { size_t num_packets; ASSERT_TRUE(dict_sp->GetValueForKeyAsInteger("num_packets", num_packets)) << ss.GetString(); - ASSERT_EQ(10, num_packets); + ASSERT_EQ(10, (int)num_packets); } TEST_F(GDBRemoteCommunicationClientTest, SendSignalsToIgnore) { _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
