[Lldb-commits] [lldb] 16c2872 - Reland "[lldb][DWARFExpression] Fix DW_OP_div to use signed division"

Author: LU Hongyi Date: 2023-05-05T06:45:07-04:00 New Revision: 16c2872d7b09eee67dd0c7ef6b5dd3c3724d3cfc URL: https://github.com/llvm/llvm-project/commit/16c2872d7b09eee67dd0c7ef6b5dd3c3724d3cfc DIFF: https://github.com/llvm/llvm-project/commit/16c2872d7b09eee67dd0c7ef6b5dd3c3724d3cfc.diff LOG

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. Thanks for fixing Just checked and it works on my M1 with assertions. I relanded the latest version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 _

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `TypeSystemMap::m_mutex` guards against concurrent modifications of

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 updated this revision to Diff 519803. Michael137 added a comment. Herald added a subscriber: JDevlieghere. - Add back change dropped in cherry-pick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149949/new/ https://reviews.llvm.org/D14994

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > paperchalic

[Lldb-commits] [lldb] 6bca093 - SymbolFile: invert condition, remove unnecessary `else` (NFC)

Author: Saleem Abdulrasool Date: 2023-05-05T07:31:19-07:00 New Revision: 6bca093976ef40f36a396b11a61a44dc0f4dcd13 URL: https://github.com/llvm/llvm-project/commit/6bca093976ef40f36a396b11a61a44dc0f4dcd13 DIFF: https://github.com/llvm/llvm-project/commit/6bca093976ef40f36a396b11a61a44dc0f4dcd13.

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

aprantl added a comment. Do we have other ForEach methods that contain a similar footgun? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149949/new/ https://reviews.llvm.org/D149949 ___ lldb-commits maili

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

This revision was automatically updated to reflect the committed changes. Closed by commit rGe74f03dde5d8: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] e74f03d - [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Author: Michael Buch Date: 2023-05-05T11:40:23-04:00 New Revision: e74f03dde5d8973e7ca3f99ea0d8d14c048d168d URL: https://github.com/llvm/llvm-project/commit/e74f03dde5d8973e7ca3f99ea0d8d14c048d168d DIFF: https://github.com/llvm/llvm-project/commit/e74f03dde5d8973e7ca3f99ea0d8d14c048d168d.diff

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 added a comment. In D149949#431 , @aprantl wrote: > Do we have other ForEach methods that contain a similar footgun? Not that I can tell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149949/

[Lldb-commits] [lldb] a136148 - [lldb] Use Haswell instead of arm64 in TestUniversal64

Author: Jonas Devlieghere Date: 2023-05-05T09:01:23-07:00 New Revision: a136148d8faa89d88820238d69855daeedbd8681 URL: https://github.com/llvm/llvm-project/commit/a136148d8faa89d88820238d69855daeedbd8681 DIFF: https://github.com/llvm/llvm-project/commit/a136148d8faa89d88820238d69855daeedbd8681.d

[Lldb-commits] [lldb] 039fc57 - ObjectFile: remove extraneous shadowed variable (NFCI)

Author: Saleem Abdulrasool Date: 2023-05-05T10:55:29-07:00 New Revision: 039fc57191980847afb6e674cac8bcbb6c1efa13 URL: https://github.com/llvm/llvm-project/commit/039fc57191980847afb6e674cac8bcbb6c1efa13 DIFF: https://github.com/llvm/llvm-project/commit/039fc57191980847afb6e674cac8bcbb6c1efa13.

[Lldb-commits] [lldb] e9eaf7b - Re-land "[lldb] Expose a const iterator for SymbolContextList"

Author: Alex Langford Date: 2023-05-05T11:19:21-07:00 New Revision: e9eaf7b430ee69e8ef145884cbc8fa3ef8bd3237 URL: https://github.com/llvm/llvm-project/commit/e9eaf7b430ee69e8ef145884cbc8fa3ef8bd3237 DIFF: https://github.com/llvm/llvm-project/commit/e9eaf7b430ee69e8ef145884cbc8fa3ef8bd3237.diff

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

compnerd created this revision. compnerd added reviewers: aprantl, kastiglione. compnerd added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. compnerd requested review of this revision. Windows uses COFF as an object file format and PE/COFF as an executable

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

aprantl added a comment. Could you build this into a yaml2obj obj2yaml plugin, so we could test this? Alternatively, you could check in a minimal binary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987 __

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

aprantl added a comment. Is there a way to compile something with clang and then load the object file into lldb-test so we could add a shell test for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987 _

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added a comment. We're definitely going to want a test for this, either a shell test or a unit test. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

compnerd added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +length); +} bulbazord wrote: > Reading the i

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +length); +} compnerd wrote: > bulbazord wro

[Lldb-commits] [lldb] 0f9c08f - [lldb] Migrate to GetPropertyAtIndexAs for LanguageType (NFC)

Author: Jonas Devlieghere Date: 2023-05-05T14:43:58-07:00 New Revision: 0f9c08f1b2ba23d6c4a4e542d3d2c5adf479d31f URL: https://github.com/llvm/llvm-project/commit/0f9c08f1b2ba23d6c4a4e542d3d2c5adf479d31f DIFF: https://github.com/llvm/llvm-project/commit/0f9c08f1b2ba23d6c4a4e542d3d2c5adf479d31f.d

[Lldb-commits] [lldb] 81f9c43 - [lldb] Migrate to GetPropertyAtIndexAs for ArchSpec (NFC)

Author: Jonas Devlieghere Date: 2023-05-05T14:43:59-07:00 New Revision: 81f9c4323bb5828d21ba5c5f3d593e94b00fb744 URL: https://github.com/llvm/llvm-project/commit/81f9c4323bb5828d21ba5c5f3d593e94b00fb744 DIFF: https://github.com/llvm/llvm-project/commit/81f9c4323bb5828d21ba5c5f3d593e94b00fb744.d

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

compnerd added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104 + + return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset, +length); +} bulbazord wrote: > compnerd wrot

[Lldb-commits] [lldb] dc91a55 - [lldb] Fix fallout from e9eaf7b430ee

Author: Alex Langford Date: 2023-05-05T14:56:49-07:00 New Revision: dc91a55b2c8fe71077b3131e93afe46a532bcc93 URL: https://github.com/llvm/llvm-project/commit/dc91a55b2c8fe71077b3131e93afe46a532bcc93 DIFF: https://github.com/llvm/llvm-project/commit/dc91a55b2c8fe71077b3131e93afe46a532bcc93.diff

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

compnerd updated this revision to Diff 519984. compnerd added a comment. Address feedback, add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987 Files: lldb/source/Plugins/ObjectFile/CMakeLists.txt

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149987/new/ https://reviews.llvm.org/D149987 _

[Lldb-commits] [PATCH] D149702: [LLDB] Add minimal support for the new Mojo language

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Don't forget to come back and update it when you get an official designation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ ht

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:203 +.Case(".debug_pubnames", eSectionTypeDWARFDebugPubNames) +.Case(".debug_pubtypes", eSectionTypeDWARFDebugPubTypes) +.Case(".debug_str", eSect

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > tstella

[Lldb-commits] [PATCH] D149702: [LLDB] Add minimal support for the new Mojo language

rriddle accepted this revision. rriddle added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] 9f5ef42 - [LLDB] Add minimal support for the new Mojo language

Author: walter erquinigo Date: 2023-05-05T20:35:19-05:00 New Revision: 9f5ef42cbd355fcdbda5ced9ccd21cb65dd67d0f URL: https://github.com/llvm/llvm-project/commit/9f5ef42cbd355fcdbda5ced9ccd21cb65dd67d0f DIFF: https://github.com/llvm/llvm-project/commit/9f5ef42cbd355fcdbda5ced9ccd21cb65dd67d0f.di

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've tested this and it works for my build configuration. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907

[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

tschuett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:26 +namespace { +bool IsCOFFObjectFile(const DataBufferSP &data) { + return identify_magic(toStringRef(data->GetData())) == Could you turn this into a static inste